00:00:01 The build has errored. (cursor-region-sanity - db58ac7 #13713 : advil): https://travis-ci.org/crawl/crawl/builds/704176570 00:04:31 something is weirdly variable about the ignition drawing bug 00:06:58 it comes and goes, I was seeing it consistently so tried to bisect, but now I'm seeing the explosions consistently at a version where I didn't see them a few minutes ago 00:09:17 I've noticed it runs a lot faster when it skips them, so I kind of suspect it's skipping a bunch of code rather than just drawing invisible explosions or something 00:13:14 and just got an instance where only some of the explosions rendered? 00:14:19 but that means it's not the "Fix clouds being invisible" commit 00:31:06 Branch master updated to be equal with bandit: 13https://github.com/crawl/crawl/tree/master 00:31:18 Branch pull/1465 updated to be equal with bandit: 13https://github.com/crawl/crawl/pull/1465 00:37:34 The build has errored. (bandit - 66bac3c #13715 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/704189488 00:37:43 The build is still failing. (cursor-region-sanity - 0466488 #13714 : advil): https://travis-ci.org/crawl/crawl/builds/704181323 01:01:32 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-158-g66bac3cce0 (34) 01:19:39 try with infestation, should be the same code path and it has a longer animation 01:22:07 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-3371-g11b60bd51a 01:22:48 %git cdd0e27 01:22:48 07Aidan Holm02 * 0.26-a0-131-gcdd0e27: Render dungeon zaps onto vbuf 10(5 days ago, 14 files, 101+ 126-) 13https://github.com/crawl/crawl/commit/cdd0e279bb9e 01:22:55 the likely suspect 01:23:19 it's also slower because it now does a full viewwindow cycle 01:24:16 (although I did test that commit manually before merging...) 03:23:08 Unstable branch on crawl.beRotato.org updated to: 0.26-a0-158-g66bac3c (34) 03:31:32 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3371-g11b60bd51a 05:36:10 -!- amalloy is now known as amalloy_ 08:35:54 Death Knight Monster Description References Haunt (Shywoof) 13https://crawl.develz.org/mantis/view.php?id=12299 by gressup 10:14:21 is ignition supposed to do much in the way of animation? 10:14:31 I have a vague memory that it used to, but maybe this is false 10:17:53 also, did someone say that infestation is broken too? I can't replicate this one 10:20:13 03advil02 07* 0.26-a0-159-gf7aefb7: Fix ignition rendering 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f7aefb7b055f 10:21:26 re ignition, my instinct is to add a tiny bit more animation than it currently has (i.e. render like 4 explosions at a time, instead of all), but maybe this would be too annoying? 10:22:34 I guess another alternative would be to do something like 3 or 4 rendering passes regardless of the number of explosions 10:31:59 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-159-gf7aefb7b05 (34) 10:34:44 03PleasingFungus02 07* 0.26-a0-160-g246d278: Fix Death Knight description (ShyWoof) 10(51 seconds ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/246d2780dcde 10:45:00 aidanh next report (from Goratrix): "hm, is it intended that rays now appear under items on the ground? searing ray for example" 10:46:46 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-160-g246d2780dc (34) 10:47:53 local tiles btw, in case it matters 10:48:32 the searing ray, when cast over tiles that have stuff on them, is rendered under the stuff 10:48:50 I think magic dart too, not sure, it's too fast 10:58:18 that is not intended and I could swear I manually checked for that 11:00:38 lol searing ray secretely turns you into a battlesphere to fire? am I reading this right? 11:09:09 this one may be tiles-specific, it's a bit fast but I think the *s are rendering on console 11:15:04 you can set view_delay = 1000 to slow things down 11:33:25 hm, should zaps maybe render under clouds instead of on top of them? 11:34:03 where zaps == flashes from searing rays, infestation, ignition, etc 11:45:14 probably not if you can't see them at all 11:47:30 they're visible, but of course not *as* visible 11:47:55 i do think items on top of clouds looks weird though 11:47:59 that's probably fine then 11:50:55 hm, for items I wonder if there's some way to do a cutaway effect 11:51:23 sounds hard, but could be cool 11:52:26 cutaway? 11:53:28 as in https://en.wikipedia.org/wiki/Cutaway_drawing 11:54:01 as an alternative to just alpha 11:54:08 having difficulty visualizing this applied to crawl 11:54:39 as in, like how the player in water is drawn with their bottom half covered with semitransparent water? 11:54:41 I am assuming what you have in mind with items and clouds is that when under clouds with alpha, items are hard to see, but over clouds, they look unnatural 11:55:16 03PleasingFungus02 07* 0.26-a0-161-g80609ef: Enact the 13th Amendment 10(6 minutes ago, 13 files, 76+ 89-) 13https://github.com/crawl/crawl/commit/80609ef61d39 11:55:39 so what I vaguely have in mind is rendering part of the cloud with a more cartoony cutway for the part of the tile where items are 11:55:46 i think that would be difficult to pull off; there's only 32x32 px 11:56:48 how does console handle this problem? 11:57:14 just draws the cloud 11:57:21 there's a mode where you can hide clouds 11:57:33 if you press | 11:58:21 ah, right 11:58:50 03Aidan Holm02 07* 0.26-a0-162-g02840ea: Fix zaps being rendered under items/clouds on local tiles (Goratrix) 10(13 minutes ago, 1 file, 8+ 2-) 13https://github.com/crawl/crawl/commit/02840eae70a5 11:59:22 showing the item on top when the mouse cursor is on top could help 12:00:13 or perhaps in the direction chooser 12:01:51 a more realistic solution is just to have a fixed render order and then fiddle with tile opacities until everything looks nice 12:03:12 Goratrix: bug's fixed, thanks for reporting! 12:03:44 yeah, could work, also one variant of the cutaway effect is to have gradient alpha across parts of the tile (e.g. more alpha in the middle), could work with small tiles better than a cutaway per se 12:11:46 04Build failed for 08master @ 80609ef6 06https://github.com/crawl/crawl/actions/runs/155564673 12:17:55 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-162-g02840eae70 (34) 12:21:42 it's a balancing act between too much transparency for clouds against dungeon floor 12:21:53 and too little for items 12:24:51 04Build failed for 08master @ 02840eae 06https://github.com/crawl/crawl/actions/runs/155567766 12:41:14 03gammafunk02 07* 0.26-a0-163-g6c8a0bf: Fix a broken vault 10(12 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/6c8a0bf6953f 12:43:12 aidanh: seems vaguely scary, so I didn't just mess around with fixing myself, but a gcc warning I've been having for a while since some recent refactorings you made: http://dpaste.com/0DXF48Z 12:45:29 huh, i was pretty sure that case would just use return-value optimization 12:45:52 what compiler is that? 12:46:28 it should be benign though 12:47:08 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-163-g6c8a0bf695 (34) 12:47:45 aidanh: gcc 9.3.0 12:48:07 i think that pikel overhaul will require save-compat code btw (don't have time to do it myself just now) 12:48:31 ...oh 12:48:51 did he not do save compat in his commit? 12:49:25 nope 12:49:58 hrm, isn't it handled by AXED_MONS etc? 12:50:15 like those existing slaves will just load as removed monsters or whatnot 12:51:12 yeah, but shouldn't they load as minions? 12:51:43 well as long as they don't cause a crash, it's fine 12:52:38 pikel would be a bit easier, not that big a deal 12:52:51 The build was broken. (master - 80609ef #13720 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/704375720 12:53:15 oh yeah, not a huge issue or anything 12:53:26 I'll test transfer a save just to check 13:03:39 -!- toblu1 is now known as toblu 13:13:49 yeah, just get a bunch of generic "ghost" monsters after transfer 13:16:41 The build was broken. (master - 02840ea #13721 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/704376853 13:21:27 is there a technical reason to even have those? wouldn't removing bad monsters be preferable? 13:30:10 Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-163-g6c8a0bf (34) 14:46:45 <|amethyst> aidanh: removing a monster in the middle of loading is kind of tricky because they're cross-referenced from all sorts of places, not all of which are necessary loaded yet 14:47:06 <|amethyst> aidanh: it should be possible to remove the ghosts in a final pass though 17:01:57 -!- amalloy_ is now known as amalloy 17:16:22 -!- Tiobot is now known as Guest81037 18:17:24 Branch pull/1425 updated to be equal with master: 13https://github.com/crawl/crawl/pull/1425 18:23:24 Unstable branch on underhound.eu updated to: 0.26-a0-163-g6c8a0bf695 (34) 21:08:36 03kate-02 07* 0.26-a0-164-gda07880: Fix demon pronouns 10(16 minutes ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/da07880ab8ed 21:10:26 -!- amalloy is now known as amalloy_ 21:17:03 Unstable branch on crawl.kelbi.org updated to: 0.26-a0-164-gda07880ab8 (34) 22:10:57 -!- kate-- is now known as kate- 22:41:03 -!- misha is now known as werekitten 22:55:34 -!- werekitten is now known as misha 23:41:46 !tell aidanh yes, i was fine with having slaves load in as removed monsters after the pikel change; i was vaguely under the impression that we were still running low on minor tags? 23:41:47 PleasingFungus: OK, I'll let aidanh know. 23:42:12 !tell floraline WDYT about hosting an experimental branch for https://github.com/crawl/crawl/pull/1468 ? 23:42:13 PleasingFungus: OK, I'll let floraline know. 23:43:22 PleasingFungus: ahh makes sense 23:43:22 aidanh: You have 3 messages. Use !messages to read them. 23:43:22 I merged a change to use 32 bit minor tags a while back 23:43:32 oh, that's great 23:43:35 weight off my back 23:43:44 i am, however, going to have to figure out how we handle removed species for centaurs 23:43:48 are djinn still around 23:44:03 ahh, species-data-deprecated-species.txt 23:46:00 there's also a pr for removing support for old minor tags, first in first out, with a rolling support window 23:46:36 ooh 23:46:49 but we never reached a conclusion about how best to change versioning 23:46:57 i should merge some of these 23:57:51 03Byrel Mitchell02 {PleasingFungus} 07* 0.26-a0-165-gf02c06f: Rename Spiny Frogs to Cane Toads 10(4 weeks ago, 25 files, 47+ 46-) 13https://github.com/crawl/crawl/commit/f02c06f1080f 23:58:15 |amethyst: I suspected as much, thanks