00:37:26 <Cheibriados> New branch created: pull/1449 (1 commit) 13https://github.com/crawl/crawl/pull/1449
00:37:26 <Cheibriados> 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1449 * 0.26-a0-62-gca4328b: Document python-is-python3 for Ubuntu 10(16 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/ca4328b316c4
01:27:09 <ebering> alexjurkiewicz: re the combo scoreboard design details, I defer to you
01:27:09 <ebering> I'm just plumbing the database
01:28:31 <alexjurkiewicz> this is the first and last time anyone will defer to my visual sensibility
03:04:43 <alexjurkiewicz> the "all players" and "all clans" pages should look nicer following 97637e2fcb
03:06:06 <alexjurkiewicz> ebering: the task "combo-scoreboard.mako: restore the combo scoreboard template and modernize. add to top link" can be emulated by searching the combo categories page
03:06:06 <alexjurkiewicz> eg you can search for "MiFi" or "Mi high score" or "Fi high score"
03:33:39 <Kelbell> Stable (0.25) branch on crawl.kelbi.org updated to: 0.25-b1-46-gb8a1ec05df
06:16:50 -!- amalloy is now known as amalloy_
06:23:27 <alexjurkiewicz> i'm so glad the tournament is a small dataset. I just looked at a couple of queries hahahaha. The query to get clan exploration category rank creates three temporary tables on disk, sorts three tables, and scans five
06:25:25 <alexjurkiewicz> not rubbishing the queries btw. It's just so surprising to see this EXPLAIN output and realise it's fine
06:50:41 -!- amalloy_ is now known as amalloy
06:53:34 -!- amalloy is now known as amalloy_
08:22:47 <alexjurkiewicz> ok, I've pushed some more refactoring to how clan pages are written. Changes: 1) url format has changed (0d340ab) -- probably want to rm -rf the web root to clean the old pages out 2) stopped s/ /_/ in the database for clan names (b40bf34) 3) Changed all clan links to use the team name (adb8bef). Lemme know if you see any problems
08:23:12 <alexjurkiewicz> oh yeah, this also makes changes to the DB structure
08:23:40 <alexjurkiewicz> !tell gammafunk some clan changes I've made require a full DB rebuild and rm -rf the web root (or at least clan pages subdirectory) to clear up old files
08:23:46 <alexjurkiewicz> rip
08:25:48 <alexjurkiewicz> advil: I messed with your datatables implementation. Code-wise it uses HTML classes rather than ID. I've added a few variants (see script.js to see all the available class names) and tweaked the padding to make tables more compact. Also most of the search/filter/sort UI is left enabled for large tables. Lemme know what you think
08:28:59 -!- aidanh_ is now known as aidanh
08:36:23 <ebering> alexjurkiewicz: re the queries, somewhere there's a comment "my kingdom for an outer join"
08:36:23 <ebering> an indexed outer join would be better than those triple union
09:19:11 <ebering> alexjurkiewicz: the search combo order approach is ok, but the old tournament's combo scoreboard page was nice
10:00:39 <elliotd123> aidanh: for the monster_habitat stuff, I'm not sure what you mean by not using the correct article for some monsters
10:01:01 <aidanh> elliotd123: sorry, I meant pronoun
10:01:16 <aidanh> e.g. ?/m Cerebov should be They, not It
10:02:21 <elliotd123> Yeah so let's see, should I check for M_GENDER_NEUTRAL and use They in that case?
10:03:46 <elliotd123> same with M_MALE or M_FEMALE?
10:04:41 <elliotd123> or better yet, get it from mons_class_gender?
10:04:51 <aidanh> i would guess that you want uppercase_first(mi.pronoun(PRONOUN_SUBJECTIVE))
10:12:14 <elliotd123> something like this? string pronoun = string(uppercase_first(mi.pronoun(PRONOUN_SUBJECTIVE)));
10:12:25 <elliotd123> Just trying to avoid mixing strings and char *
10:12:36 <elliotd123> where possible
10:27:12 <aidanh> elliotd123: probably use make_stringf("%s can walk through water.", uppercase_first(...))
10:27:36 <aidanh> if you write 'string foo = ...' then you don't need to explicitly cast to a string on the rhs
10:28:16 <elliotd123> got it, didn't realize it was implicitly casted
10:28:26 <elliotd123> but I'll use make_stringf
10:33:07 <elliotd123> still weird casting issues, because uppercase_first wants a string, but mi.pronoun returns a char *
10:33:23 <elliotd123> the compiler warns about that
10:34:23 <aidanh> huh, i copy-pasted that from elsewhere
10:34:27 <aidanh> what compiler are you using?
10:34:30 <elliotd123> gcc
10:34:52 <elliotd123> I don't get warnings for anything else though, so did they use it differently somehow?
10:35:39 <elliotd123> don't know why I'm getting that because I do see that used in other places, too. Likely I'm doing something wrong
10:37:27 <advil> monster::pronoun returns a string, monster_info::pronoun returns a const char *
10:39:05 <elliotd123> yeah it's just the uppercase_first function only takes a string. So I could explicitly cast to a string right there I guess
10:39:49 <advil> any word on the bot lately?
10:39:53 <elliotd123> not a cast, just a string constructed with the char *
10:40:22 <advil> why not just wrap the make_stringf with uppercase_first?
10:40:30 <advil> it's more resiliant to someone changing the string, too
10:42:09 <elliotd123> yeah that works too
10:44:20 <advil> alexjurkiewicz still not sure that paging generally does what we want, it makes it nearly impossible to view yourself in a ranking if you are not in the first few pages
10:44:43 <advil> you can find yourself with search, but that doesn't let you get to the page with you on it (as far as I have been able to manage at least)
10:45:07 <elliotd123> Thanks advil and aidanh! pushed those changes
10:46:15 <advil> alexjurkiewicz for the overview page individual categories things, I would be inclined to not enable datatables, though it's possible those are just glitching for me
10:46:54 <advil> also more generally getting some weirdnesses at high widths
10:47:26 <advil> maybe a default of 100 entries works better for paging
10:47:44 <advil> would be nice if there was an "all" in that dropdown, but I didn't yet find that option (only looked a little bit)
10:48:14 <Cheibriados> 03Elliot Dronebarger02 07https://github.com/crawl/crawl/pull/1427 * 0.26-a0-47-gd684532: Fix for pronouns 10(4 minutes ago, 2 files, 14+ 3-) 13https://github.com/crawl/crawl/commit/d6845321ab5d
10:50:56 <advil> alexjurkiewicz I think this is a bootstrap question: there's kind of a big mismatch between the biggest the content column can get, and browser window sizes on my (fairly large) monitor. Is there another step up in sizing we can use?
10:51:32 <advil> it's especially frustrating with the all-players and teams pages because I would easily be able to handle that table at full width at browser window sizes I normally use, but instead I get a ton of dead space + scrolling
10:51:56 <advil> (I suspect this is one thing some of the grar comments we've been getting are related to)
10:53:05 <advil> "Tournament Win Order", "Tournament All Rune Win Order" => "Win Order", "All Rune Win Order"?
10:54:51 <advil> re browser width, here is what all-players looks like at a normal browser size on this monitor at paging 10: https://www.dropbox.com/s/a53sus3ltlc90w3/Screenshot%202020-06-09%2010.54.38.png?dl=0
10:55:37 <advil> the vertical dead space would be fixed with a higher default paging (wonder if the default can be set responsively?)
10:59:14 <Cheibriados> 03Elliot Dronebarger02 07https://github.com/crawl/crawl/pull/1427 * 0.26-a0-48-ga7a7801: small cleanup 10(2 minutes ago, 2 files, 1+ 3-) 13https://github.com/crawl/crawl/commit/a7a7801dcf35
11:04:06 <elliotd123> advil: I have some bootstrap code somewhere that I think plays with table widths to get it right, I can see if I can find it
11:12:37 <elliotd123> nope I don't know where I put it. I always have trouble with bootstraps column formatting though
11:24:05 <advil> from my googling it seems like that screenshot is already using what bootstrap considers "large"
11:24:28 <advil> actually maybe even "extra large"
11:38:14 <advil> although maybe something isn't going right, the css that is winning is `.container, .container-lg, .container-md, .container-sm, .container-xl { max-width: 1140px; }`, where container-xl I *think* is actually supposed to be applying min-width: 1200px
11:43:41 <elliotd123> IIRC There's some meta data you have to add that allows for resizing on different devices better, like mobile devices and I would assume high resolution devices as well
11:44:30 <elliotd123> maybe this one here: <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
11:44:36 <elliotd123> (If you don't already have that)
11:48:25 <advil> right now we have <meta name="viewport" content="width=device-width, initial-scale=1">
11:50:32 <elliotd123> container-fluid?
11:51:03 <elliotd123> looks like that's the one you want?
11:52:05 <advil> not sure
11:52:25 <advil> alexjurkiewicz is the one who actually knows anything about bootstrap
12:34:33 <aidanh> advil: see https://getbootstrap.com/docs/4.4/layout/overview/; container-xl is 100% width up to a max of 1140px
12:35:42 <advil> ah, thanks
12:35:48 <advil> well, that's not very wide
12:37:16 <aidanh> i, too, measure my monitor sizes in football fields
12:37:57 <advil> :D
12:38:28 <aidanh> this table is pretty wide in any case; probably some form of horizontal scrolling will be needed
12:38:28 <aidanh> although container-fluid will always use 100% of the available width
12:38:59 <advil> that screenshot was with the navbar at around 2200px wide
12:39:40 <advil> which is pretty normal on a 4k or ultrawide display
12:40:12 <advil> no idea how common they are really
12:42:36 <aidanh> even at work i only have double qhd monitors
12:42:56 <Pinkbeast> My monitors are bigger than yours. (In the third dimension :-)
12:43:59 <aidanh> i think that humongous table might work better if the table itself scrolled vertically as well as horizontally, instead of the body scrolling vertically
12:44:06 <aidanh> that way the horz scrollbar is visible at all times (if it's present at all)
12:46:54 <advil> not immediately sure what you mean
12:47:22 <advil> the cdo version scrolls horizontally and vertically (though in the repo alexjurkiewicz switched paging back on so there's  no vertical scrolling)
12:48:29 <advil> maybe something os specific, on mac there's no way to have scrollbars always showing
12:49:42 <aidanh> https://0x0.st/iVfu.png
12:53:21 <advil> is that as compared to paging?
12:57:15 <aidanh> as compared to https://0x0.st/iVf_.png
12:57:25 <aidanh> haven't seen the paging version
12:58:21 <advil> right now I think cdo has something like what you're suggesting (though the column headers are buggy)
12:58:38 <advil> https://crawl.develz.org/tournament/0.25/all-players-ranks.html
13:00:56 <aidanh> ah interesting
13:01:10 <aidanh> unfortunately i see no scrollbars and my arrow keys don't scroll it either
13:01:33 <aidanh> oh, nvm, disregard that
13:09:35 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.26-a0-61-g6c07f0e (34)
13:22:46 -!- amalloy_ is now known as amalloy
15:21:09 <Cheibriados> 03advil02 07* 0.26-a0-62-g1937b06: Sanity check for pregen: is the generated level what was requested? 10(26 minutes ago, 1 file, 13+ 3-) 13https://github.com/crawl/crawl/commit/1937b064fbca
15:21:09 <Cheibriados> 03advil02 07* 0.26-a0-63-g18c3a0d: Fix pregeneration for upgrades where branch size changes 10(2 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/18c3a0dd01f8
15:31:30 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-63-g18c3a0dd01 (34)
16:08:09 <travis-ci> The build was broken. (master - 18c3a0d #13594 : advil): https://travis-ci.org/crawl/crawl/builds/696591641
16:29:50 <Kelbell> RoGGa (L8 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:5)
16:45:28 <Cheibriados> 03advil02 07* 0.26-a0-64-g059e62f: Don't crash on level excursion in the abyss 10(33 seconds ago, 1 file, 9+ 6-) 13https://github.com/crawl/crawl/commit/059e62fbdb0e
16:45:50 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:46:02 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:8)
16:46:18 <advil> hm
16:46:33 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:6)
16:47:06 <advil> probably the same fix will work
16:48:22 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:48:38 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:48:45 <advil> yes yes I'm doing the rebuild rogga
16:48:51 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:49:08 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:49:28 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
16:51:20 <ebering> ok, I've gone over all of the banner logic
16:51:39 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.26-a0-64-g059e62fbdb (34)
16:53:05 <Kelbell> RoGGa (L10 GnAs) ASSERT(you.on_current_level) in 'files.cc' at line 1923 failed. (D:9)
17:09:39 <ebering> we are on the home stretch team
17:11:54 <ebering> I went with what gammafunk and alexjurkiewicz were discussing for a new banner
17:12:09 <ebering> I put it under Usk and gave Wu Usk's turncount banners
17:12:41 <ebering> the new Usk banner is get a lair rune in 810 turns from branch end, get the silver rune in 540 turns ffrom branch end, and get the orb of zot in 270 turns from zot 5
17:21:57 <advil> sounds good enough
17:22:05 <advil> ultra tier, abyss rune in 1 turn
17:43:20 <gammafunk> ebering: nice
17:43:51 <gammafunk> my speedzot5 crushes all of yours btw
17:44:05 <gammafunk> except for kate who manage to get it in some ridiculous number of turns!
17:48:38 <kate-> oh nice, i bet that's my nemelex shaft zot:5
17:48:44 <kate-> very sad that the ttyrec for that died
17:54:33 <alexjurkiewicz> ebering: I saw that "my kingdom for an outer join" comment, and also another one where you had a beautiful query that was too slow, so you had to optimise it to something ugly
17:57:24 <alexjurkiewicz> advil: about page width. <body> contains a div with class container. Please try replacing that with container-fluid and let me know what it looks like
17:58:09 <alexjurkiewicz> it's a good point you have about search not letting you see your neighbours in the table. It would be nice if search was 'jump to' instead
17:58:33 <advil> yeah I think a jump to may be possible (would also be nice to have as a link from player pages)
18:00:17 <alexjurkiewicz> paging makes the page much more responsive for me btw, so I'm inclined to keep it. But yes the default size of 10 is too small. And it is possible to add an 'all' option
18:01:05 <alexjurkiewicz> (as in, with the full table, I could scroll faster than the rendering could keep up)
18:02:55 <alexjurkiewicz> you mentioned some rendering errors on overpage due to datatables as well. can you screenshot / elaborate? Is it that the tables are wider than they used to be?
18:10:02 <ebering> ok, I think I'm on track to finish the things under critical to do tonight
18:11:08 <ebering> alexjurkiewicz: for the recent/won games tables can those get even-odd highlighting even for wins
18:12:34 <advil> alexjurkiewicz I think it was just that I had scripts off for file:// at the time
18:14:10 <advil> not really sure why it was glitching only in minor ways (would have expected nothing to work), but it seems to be gone now
18:15:14 -!- jfcaron_ is now known as jfcaron
18:23:31 <Lantell> Unstable branch on underhound.eu updated to: 0.26-a0-64-g059e62fbdb (34)
19:00:40 <alexjurkiewicz> ebering: hm, the even/odd highlighting is tough because for dark rows you want the highlighting to lighten even rows, but for light rows you want to darken them
19:01:52 <alexjurkiewicz> i'll see what I can do. Might involve changing how we call out winning rows
19:05:19 <advil> floraline: when you have a second, I have another save to replace, username Raoeoiku, trunk, fixed save is at: https://www.dropbox.com/s/unpsj9uq1cow19g/Raoeoiku.cs?dl=0
19:05:26 <advil> sorry, hopefully there won't be many more
19:06:00 <advil> if I get too many more of these requests I may just do some one-off save compat + revert commits
19:15:20 <floraline> advil: done
19:22:58 <advil> thanks!
19:24:45 <advil> floraline can you check permissions on that file?
19:25:24 <advil> they are getting "can't open save file (/crawl-master/crawl-git-059e62fbdb/saves/Raoeoiku.cs): Permission denied"
19:57:17 <floraline> advil: sorry! should be good now
19:57:26 <floraline> bad permisssions
20:01:24 <advil> floraline thanks! sounds like that worked
20:15:51 <ebering> alexjurkiewicz: I re-enabled the combo scoreboard but the tables need some work
20:15:56 <ebering> format wise
21:18:03 <alexjurkiewicz> i'll take a look
21:21:11 <alexjurkiewicz> v.cool, i like it
23:43:41 <Cheibriados> New branch created: pull/1450 (1 commit) 13https://github.com/crawl/crawl/pull/1450
23:43:41 <Cheibriados> 03aegolden02 07https://github.com/crawl/crawl/pull/1450 * 0.26-a0-65-g6e59be9: Get rid of MSG_NO_ENERGY canned message. 10(29 minutes ago, 3 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/6e59be9b2150