00:50:07 I like that they didn't even bother 1) testing their assumption or 2) reading the function they reference in that report 01:10:25 New branch created: amu-cloak-scarf-shuffle (9 commits) 13https://github.com/crawl/crawl/tree/amu-cloak-scarf-shuffle 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1005-g5f7af93: Remove scarves of cloud immunity 10(5 hours ago, 10 files, 22+ 34-) 13https://github.com/crawl/crawl/commit/5f7af936bd63 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1006-g04eca1e: Move invisibility from cloaks to scarves 10(5 hours ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/04eca1e7fde5 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1007-g5c331ab: Add preservation (rCorr) and stealth to cloaks 10(5 hours ago, 8 files, 15+ 14-) 13https://github.com/crawl/crawl/commit/5c331ab60af5 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1008-g236f960: Remove scarves of spirit shield 10(5 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/236f96050184 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1009-gb011c15: Add Harm to scarves 10(2 hours ago, 8 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/b011c15d9d9e 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1010-g8afae82: Remove amulets of harm 10(2 hours ago, 13 files, 10+ 39-) 13https://github.com/crawl/crawl/commit/8afae826ec56 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1011-ge7209af: Allow Harm on randart armour 10(2 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/e7209af0d7ef 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1012-g6f40a43: Remove amulets of the gourmand 10(46 minutes ago, 20 files, 24+ 106-) 13https://github.com/crawl/crawl/commit/6f40a43bca6b 01:10:25 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1013-g67f7252: Remove amulets of reflection 10(7 minutes ago, 21 files, 24+ 57-) 13https://github.com/crawl/crawl/commit/67f7252223b0 01:19:06 did you consider merging them? Is 1 AC a big difference? 01:19:24 nuuuu my amulets of reflection :( 01:19:34 what is the referent of them 01:19:41 cloaks and scarves? 01:20:53 yes 01:21:44 cloaks give base ac and enchant 01:21:44 or making them more different, maybe some species could only have access to scarves 01:23:20 ebering: btw for xp_evoker_data, can that be an unordered_map? would be preferable if so 01:23:56 aidanh: yes, it's small and the only operation on it is lookup 01:28:23 for amu-cloak-scarf-shuffle @ 67f72522 https://github.com/crawl/crawl/actions/runs/101108566 01:33:45 dcss-ci...rip travis 01:33:50 ??travis[2 01:33:51 travis[2/2]: Travis can't be bargained with. Travis can't be reasoned with. Travis doesn't feel pity, or remorse, or fear. And Travis absolutely will not stop, ever, until your project is dead. 01:33:54 the good old days 01:35:43 I put that branch into a PR for discussion, the PR topic has 4 more things I'd like to look at before merging 01:36:07 !pr 1397 01:36:07 https://github.com/crawl/crawl/pull/1397 01:37:54 New branch created: pull/1397 (9 commits) 13https://github.com/crawl/crawl/pull/1397 01:37:54 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 01:38:55 Unstable branch on crawl.develz.org updated to: 0.25-a0-1007-g10a8c3caa8 (34) 01:39:28 ebering: are you hopeing to merge this before freeze? 01:39:39 *hoping 01:40:43 oh, I see the little check thingie 01:40:57 wow I can clikc it 01:45:15 I am hoping to get this in before the freeze but understand if someone else says hangon 01:46:32 yeah seems reasonable 01:47:15 also looking for input re: rage (remove vs scarfify) and regen-merging 01:49:07 yea I've always liked the idea of merging those effects to some degree; the only awkward part is that they're sort of fundamentally different effects 01:49:36 if you are not using many spells, I guess that just means it's no better an amulet than it used to be, which is perhaps not terrible 01:49:58 but since the way regen works is a bit mysterious to players, they frequently think hp regen from +Regen is way stronger than it is 01:50:16 I guess we've despoilered it as much as we can by now though 01:52:47 I have a PR to fix those build failure messages 01:53:22 https://github.com/crawl/crawl/pull/1392 01:55:22 03Alex Jurkiewicz02 {ebering} 07* 0.25-a0-1008-gf0b061a: Remove BUILD_ALL CI config 10(30 hours ago, 1 file, 1+ 15-) 13https://github.com/crawl/crawl/commit/f0b061a3c0ba 01:55:22 03Alex Jurkiewicz02 {ebering} 07* 0.25-a0-1009-gac5e0fa: Clean up notification logic 10(30 hours ago, 1 file, 3+ 5-) 13https://github.com/crawl/crawl/commit/ac5e0fa7056d 01:56:42 encoding bash in yaml, just what the founders envisioned 02:01:39 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1009-gac5e0fa705 (34) 02:07:23 The build failed. (amu-cloak-scarf-shuffle - 67f7252 #13278 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685506145 02:07:48 truly 02:11:20 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-1007-g10a8c3caa8 03:30:46 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3054-g1a545eca1e 04:15:53 -!- TooLmaN_ is now known as TooLmaN 05:22:28 Sif and Kiku will not give book gifts if an aquatic player is standing in deep water 13https://crawl.develz.org/mantis/view.php?id=12258 by bcadren 06:05:47 -!- amalloy is now known as amalloy_ 06:07:40 -!- amalloy_ is now known as amalloy 06:11:20 -!- amalloy is now known as amalloy_ 06:43:48 03Aidan Holm02 07* 0.25-a0-1010-g27f2bdb: Replace map<> with unordered_map<> 10(2 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/27f2bdb7b06b 06:46:45 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1010-g27f2bdb7b0 (34) 06:47:11 03Aidan Holm02 07[wide-minor-tag] * 0.25-a0-1011-g5e0136c: Allow phasing out support for old minor versions 10(2 weeks ago, 3 files, 39+ 3-) 13https://github.com/crawl/crawl/commit/5e0136c46a3e 06:47:16 Branch pull/1375 updated to be equal with wide-minor-tag: 13https://github.com/crawl/crawl/pull/1375 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1011-g8b8a381: Refactor startup code 10(8 months ago, 5 files, 36+ 32-) 13https://github.com/crawl/crawl/commit/8b8a381e250f 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1012-gb56ecc4: Add UIMainGame widget 10(4 months ago, 21 files, 305+ 268-) 13https://github.com/crawl/crawl/commit/b56ecc48519c 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1013-g3168152: Fix black screen on death 10(4 months ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/316815202029 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1014-g79009f9: Pull input through UIMainWidget on console 10(4 months ago, 12 files, 35+ 10-) 13https://github.com/crawl/crawl/commit/79009f9e0523 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1015-gf13c7fa: WIP: Add keymapper class 10(3 months ago, 3 files, 85+ 0-) 13https://github.com/crawl/crawl/commit/f13c7fa9dd6a 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1016-g5fd83e2: Use ui::getch() 10(3 months ago, 9 files, 19+ 19-) 13https://github.com/crawl/crawl/commit/5fd83e212bc3 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1017-g6020989: Add UI event is_synthetic property 10(2 days ago, 3 files, 5+ 1-) 13https://github.com/crawl/crawl/commit/60209895fe28 07:06:13 03Aidan Holm02 07[ui-main-game] * 0.25-a0-1018-g9e86ccc: WIP: add UIMapView widget 10(2 days ago, 1 file, 162+ 0-) 13https://github.com/crawl/crawl/commit/9e86ccc61378 07:09:29 Build failed for master @ 27f2bdb7 https://github.com/crawl/crawl/actions/runs/101345756 (failed: MacOS Build) 07:14:34 Build failed for wide-minor-tag @ 5e0136c4 https://github.com/crawl/crawl/actions/runs/101347778 (failed: MacOS Build) 07:19:03 doh 07:20:36 Build failed for ui-main-game @ 9e86ccc6 https://github.com/crawl/crawl/actions/runs/101366815 (failed: Linux Build,MacOS Build,Linux MingW Build,Catch2/codecov) 07:22:22 03Aidan Holm02 07* 0.25-a0-1011-g31286d2: Fix unordered_map<> on Mac OS 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/31286d223f32 07:26:37 is that "(failed: ...)" bit useful? 07:27:39 damn, it's MinGW not MingW 07:28:23 i don't know that it's all that useful, i'm still going to click in anyway to see the logs, but I like it anyway 07:31:40 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1011-g31286d223f (34) 08:16:48 prompt_for_quantity() does not handle initial backspace correctly 13https://crawl.develz.org/mantis/view.php?id=12259 by aidanholm 10:23:20 03Aidan Holm02 07[ui-refactor] * 0.25-a0-1012-g16744be: Move union/intersect methods to ui::Region class 10(23 minutes ago, 4 files, 107+ 19-) 13https://github.com/crawl/crawl/commit/16744bea8d55 10:25:37 03Aidan Holm02 07[ui-refactor] * 0.25-a0-1013-g305b0d5: Extract ScissorStack to its own class 10(37 seconds ago, 3 files, 92+ 44-) 13https://github.com/crawl/crawl/commit/305b0d50f314 10:36:48 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 10:54:28 Build failed for ui-refactor @ 305b0d50 https://github.com/crawl/crawl/actions/runs/101529081 (failed: Linux Build,MacOS Build,Linux MingW Build,Catch2/codecov) 11:01:58 03advil02 07* 0.25-a0-1012-g6ca9d89: Fix a usk grand finale crash (12248) 10(5 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/6ca9d89ac5d5 11:02:36 I wonder if it is really a good idea for usk grand finale flying chunks to do damage? The chunks themselves are flavorful and all but I would guess that the damage itself is negligible beyond annoying allies 11:03:06 they do damage?! 11:03:13 haha yep 11:03:20 blood spray is fine in case you are worried 11:03:29 usk has its own custom thing in addition to blood spray 11:03:44 !source throw_monster_bits 11:03:44 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-util.cc#L5576 11:03:55 dang I thought it was just the cosmetic effect like ood 11:04:14 there's even a little custom thing there in case the monster is acidic 11:06:22 v simulationist 11:16:36 the final sequence of events in this crashlog is amazing: http://crawl.berotato.org/crawl/morgue/ardl/crash-ardl-20191231-234514.txt 11:16:53 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1012-g6ca9d89ac5 (34) 11:17:30 wow 11:47:46 The build was broken. (ui-refactor - 305b0d5 #13287 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/685688896 12:47:52 %git ea32a606ab6609 12:47:52 07Josh Braden02 {ebering} * 0.24-a0-331-gea32a60: Don't place a wall if a monster is in the way (11967) 10(1 year ago, 1 file, 8+ 2-) 13https://github.com/crawl/crawl/commit/ea32a606ab66 12:48:08 does anyone know why this applies location effects in order to check if there is a monster at the pos? 12:48:46 as far as I can tell it should just directly check for a monster 12:49:17 (and *definitely* shouldn't apply location effects unconditionally, that's what's leading to the weird nymph situation above) 12:50:13 oh hm 12:50:31 yeah, I think this is wrong...the previous version applied location effects *after* changing the feature... 12:58:26 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1014-gce059bf: fixup! Remove scarves of cloud immunity 10(55 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ce059bf13950 12:58:26 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1015-g504e213: fixup! Remove amulets of harm 10(55 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/504e2130307f 12:58:26 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1016-g4dfdcb1: fixup! Remove amulets of reflection 10(19 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4dfdcb1830ab 12:58:40 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 13:08:40 03advil02 07* 0.25-a0-1013-g3a3e078: Apply location effects *after* temp changing a feature 10(10 minutes ago, 1 file, 3+ 7-) 13https://github.com/crawl/crawl/commit/3a3e078c5996 13:11:51 I think that commit probably also fixes an infinite loop with elemental wellsprings 13:12:17 if there are any of those left 13:16:53 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1013-g3a3e078c59 (34) 13:18:17 for amu-cloak-scarf-shuffle @ 4dfdcb18 https://github.com/crawl/crawl/actions/runs/101657736 13:41:43 The build is still failing. (amu-cloak-scarf-shuffle - 4dfdcb1 #13289 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685750381 13:45:46 -!- weretaco_ is now known as Weretaco 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1005-g6f3e075: Remove scarves of cloud immunity 10(17 hours ago, 10 files, 21+ 33-) 13https://github.com/crawl/crawl/commit/6f3e07560da8 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1006-gb2a6d4e: Move invisibility from cloaks to scarves 10(17 hours ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/b2a6d4e0c35e 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1007-g2293da2: Add preservation (rCorr) and stealth to cloaks 10(17 hours ago, 8 files, 15+ 14-) 13https://github.com/crawl/crawl/commit/2293da2e96ec 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1008-g3edfc6e: Remove scarves of spirit shield 10(17 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/3edfc6ef06a4 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1009-gefce8eb: Add Harm to scarves 10(15 hours ago, 8 files, 14+ 2-) 13https://github.com/crawl/crawl/commit/efce8eb93443 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1010-gcd6689f: Remove amulets of harm 10(14 hours ago, 17 files, 13+ 46-) 13https://github.com/crawl/crawl/commit/cd6689f192f5 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1011-gb093e97: Allow Harm on randart armour 10(14 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/b093e977b740 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1012-gebdb352: Remove amulets of the gourmand 10(13 hours ago, 23 files, 24+ 123-) 13https://github.com/crawl/crawl/commit/ebdb3528492a 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1013-g52ecd10: Remove amulets of reflection 10(13 hours ago, 25 files, 27+ 62-) 13https://github.com/crawl/crawl/commit/52ecd104bd06 13:47:34 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1014-g72f7c32: Remove amulets of Rage 10(27 minutes ago, 33 files, 23+ 168-) 13https://github.com/crawl/crawl/commit/72f7c320a7a8 13:47:47 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1014-gf563c7d: Remove scarves of cloud immunity 10(18 hours ago, 10 files, 21+ 33-) 13https://github.com/crawl/crawl/commit/f563c7dde50a 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1015-gaf56b54: Move invisibility from cloaks to scarves 10(17 hours ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/af56b54e6c68 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1016-g3e3876c: Add preservation (rCorr) and stealth to cloaks 10(17 hours ago, 8 files, 15+ 14-) 13https://github.com/crawl/crawl/commit/3e3876c6fd9a 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1017-ga6949e5: Remove scarves of spirit shield 10(17 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/a6949e53c423 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1018-g35ad667: Add Harm to scarves 10(15 hours ago, 8 files, 14+ 2-) 13https://github.com/crawl/crawl/commit/35ad667070b0 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1019-gcb7d265: Remove amulets of harm 10(14 hours ago, 17 files, 13+ 46-) 13https://github.com/crawl/crawl/commit/cb7d26594a8c 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1020-g6193c88: Allow Harm on randart armour 10(14 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/6193c880b089 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1021-g8ea4625: Remove amulets of the gourmand 10(14 hours ago, 23 files, 24+ 123-) 13https://github.com/crawl/crawl/commit/8ea4625a0560 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1022-g05c3389: Remove amulets of reflection 10(13 hours ago, 26 files, 27+ 67-) 13https://github.com/crawl/crawl/commit/05c33892f91c 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1023-g6aba536: Remove amulets of Rage 10(36 minutes ago, 33 files, 23+ 168-) 13https://github.com/crawl/crawl/commit/6aba536f0813 13:56:38 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1024-g82db92a: Remove outdated amulet descriptions from translations 10(3 minutes ago, 13 files, 0+ 283-) 13https://github.com/crawl/crawl/commit/82db92af89ac 13:56:52 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 13:57:03 -!- weretaco_ is now known as Weretaco 13:57:14 sorry for the rebase spam 14:07:55 for amu-cloak-scarf-shuffle @ 72f7c320 https://github.com/crawl/crawl/actions/runs/101698780 14:16:55 -!- sedition_ is now known as sedition 14:24:05 New branch created: pull/1398 (1 commit) 13https://github.com/crawl/crawl/pull/1398 14:24:05 03Byrel Mitchell02 07https://github.com/crawl/crawl/pull/1398 * 0.25-a0-1014-ga456522: Change the comment on max_miscast_damage to match the new miscast damage calculation. 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a4565227646d 14:28:03 Build failed for amu-cloak-scarf-shuffle @ 82db92af https://github.com/crawl/crawl/actions/runs/101704613 (failed: Linux Build) 14:29:06 I know we're coming up on release here, and I was wondering if anyone knew what caused https://github.com/crawl/crawl/issues/1243 14:29:07 This is a regression in 0.25 which is pretty annoying when using webtiles chat. 14:29:51 Basically, clicking outside the chat window fails to revert reyboard focus to the game. Which makes you minimize and reopen the chat window every time you chat with someone. 14:30:35 I'm happy to spend some time looking into this myself if needed, but I'm not really sure where to start. Any idea where this problem would be located? 15:13:28 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1025-g78105d5: fixup! Remove scarves of cloud immunity 10(30 seconds ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/78105d58d899 15:13:41 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 15:32:18 pblur not sure but maybe something to do with b8371ea9? 15:32:21 %git b8371ea9 15:32:21 07Aidan Holm02 * 0.25-a0-196-gb8371ea: Fix webtiles chat stuck focus issue 10(5 months ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/b8371ea95657 15:32:39 there were a few related commits around that time 15:33:06 pblur fwiw hitting escape seems to still work 15:33:22 Build failed for amu-cloak-scarf-shuffle @ 78105d58 https://github.com/crawl/crawl/actions/runs/101769335 (failed: Linux Build) 15:33:49 Right, but escape also closes the chat window so you can't read it. 15:33:53 it's probably not that commit itself because I tried manually reverting just that change and it still has the same behavior 15:34:05 I'll look around in that area and see if I can find the issue 15:34:08 ah I see 15:37:33 I would guess that something needs to trigger the removal of the focus-trap class 15:39:05 %git 74bebdfa 15:39:05 07Aidan Holm02 * 0.25-a0-133-g74bebdf: Add widget focus cycling 10(7 months ago, 5 files, 825+ 21-) 13https://github.com/crawl/crawl/commit/74bebdfac374 15:39:09 which was added here 15:56:57 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1026-gab8a870: fixup! Remove amulets of the gourmand 10(3 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/ab8a8704d50f 15:57:10 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 16:08:16 ~/. 16:08:16 oops 16:12:03 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1027-gd3016ba: fixup! fixup! Remove amulets of the gourmand 10(13 seconds ago, 3 files, 1+ 8-) 13https://github.com/crawl/crawl/commit/d3016bae082f 16:12:16 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 16:23:22 The build is still failing. (amu-cloak-scarf-shuffle - 78105d5 #13297 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685805688 16:27:58 Build failed for amu-cloak-scarf-shuffle @ ab8a8704 https://github.com/crawl/crawl/actions/runs/101798923 (failed: Linux Build) 16:32:44 Build failed for amu-cloak-scarf-shuffle @ d3016bae https://github.com/crawl/crawl/actions/runs/101817184 (failed: Linux Build) 16:36:53 -!- turin is now known as thurin 16:41:11 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1028-gc4038fc: fixup! Remove amulets of Rage 10(12 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/c4038fc65249 16:41:24 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 16:47:03 I hope pblur hasn't spent too much time on that, I think I have a fix 16:55:07 03advil02 07* 0.25-a0-1014-gac5a30b: Allow clicking outside chat window to defocus 10(7 minutes ago, 2 files, 7+ 2-) 13https://github.com/crawl/crawl/commit/ac5a30bc78f0 16:59:50 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1029-g7649194: fixup! fixup! Remove amulets of Rage 10(12 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7649194f8a17 17:00:03 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 17:01:10 03Byrel Mitchell02 {ebering} 07* 0.25-a0-1015-g4819203: Change the comment on max_miscast_damage to match the new miscast damage calculation. 10(3 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4819203062c5 17:01:49 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1014-gac5a30bc78 (34) 17:16:49 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1015-g4819203062 (34) 17:20:05 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1030-gb5e9404: fixup! fixup! fixup! Remove amulets of the gourmand 10(16 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b5e94046766f 17:20:16 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 17:23:25 The build is still failing. (amu-cloak-scarf-shuffle - d3016ba #13301 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685827279 17:23:34 oh there's travis 17:24:02 I guess we could disable irc travis notifications 17:25:00 I wonder how much github is wrecking the other CI companies 17:33:20 doesn't github own travis? 17:34:02 ah, seems not 17:36:05 travis is owned by some private equity that will milk it till death 17:36:47 most developers are gone 17:39:52 The build is still failing. (amu-cloak-scarf-shuffle - c4038fc #13303 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685837461 17:42:15 Build failed for amu-cloak-scarf-shuffle @ c4038fc6 https://github.com/crawl/crawl/actions/runs/101836536 (failed: Linux Build) 17:48:54 ah sad 17:52:35 it doesn't really seem like the immediate owner is that huge or obviously evil, but on the other hand apparently they apparently fired most of the engineering team right after buying the company 17:53:09 and the next level up is evil 17:53:11 well, no need to feel bad for them, I guess 17:58:36 Build failed for amu-cloak-scarf-shuffle @ 7649194f https://github.com/crawl/crawl/actions/runs/101848423 (failed: Linux Build) 18:01:27 I finally get the tag-upgrade test passing and githubs action runner cluster starts having connectivity issues 18:01:30 what a day 18:04:48 -!- amalloy_ is now known as amalloy 18:23:30 Unstable branch on underhound.eu updated to: 0.25-a0-1015-g4819203062 (34) 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1016-g654cf0d: Remove scarves of cloud immunity 10(22 hours ago, 10 files, 21+ 35-) 13https://github.com/crawl/crawl/commit/654cf0d35caf 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1017-g487180c: Move invisibility from cloaks to scarves 10(22 hours ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/487180c636c8 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1018-g1104a10: Add preservation (rCorr) and stealth to cloaks 10(22 hours ago, 8 files, 15+ 14-) 13https://github.com/crawl/crawl/commit/1104a1091935 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1019-g6b33625: Remove scarves of spirit shield 10(22 hours ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/6b3362526c27 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1020-g80b870e: Add Harm to scarves 10(19 hours ago, 8 files, 14+ 2-) 13https://github.com/crawl/crawl/commit/80b870e8c8af 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1021-g3964617: Remove amulets of harm 10(19 hours ago, 17 files, 13+ 46-) 13https://github.com/crawl/crawl/commit/396461704cf1 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1022-gaa0a947: Allow Harm on randart armour 10(19 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/aa0a947b2b80 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1023-gfb12904: Remove amulets of the gourmand 10(18 hours ago, 28 files, 26+ 134-) 13https://github.com/crawl/crawl/commit/fb12904e3212 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1024-geb36b03: Remove amulets of reflection 10(17 hours ago, 26 files, 27+ 67-) 13https://github.com/crawl/crawl/commit/eb36b03e4312 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1025-g5fc27ab: Remove amulets of Rage 10(5 hours ago, 33 files, 27+ 169-) 13https://github.com/crawl/crawl/commit/5fc27abb5217 18:23:53 03ebering02 07[amu-cloak-scarf-shuffle] * 0.25-a0-1026-g2605fc6: Remove outdated amulet descriptions from translations 10(5 hours ago, 13 files, 0+ 283-) 13https://github.com/crawl/crawl/commit/2605fc6f73cd 18:24:06 Branch pull/1397 updated to be equal with amu-cloak-scarf-shuffle: 13https://github.com/crawl/crawl/pull/1397 18:24:18 Ok, I think that (modulo talking out some design decisions) the amu-scarf-cloak branch is ready to merge 18:24:53 -!- Amnesiac_ is now known as Amnesiac 18:31:01 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 18:32:32 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 18:36:46 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 19:06:49 about travis, my $work actually used travis quite extensively. Since the purchase development has essentially stopped. And in the past six months it's become increasingly unstable and buggy 19:07:55 nothing that would affect the basic CI dcss does, but yeah, it's on the way out 19:19:34 Where are the "fake" player ghosts? 19:20:06 -!- amalloy is now known as amalloy_ 19:40:38 The build is still failing. (amu-cloak-scarf-shuffle - 2605fc6 #13311 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/685873634 20:10:34 so this is weird: cko, cue, and cpo show the species selection menu with the hotkeys in the wrong order (on cko and cue the right-hand column starts with a, on cpo it's the middle column); but cao, cbro, and cxc are fine 20:11:10 I have no idea what on earth would cause that? 20:22:17 wow, some kind of locale setting? 20:23:28 it's possible that something like a locale setting would cause species-groups.h to be generated in a different order, but there's nothing very obvious in the python code that would do that 20:32:49 ah, I bet it's a python version issue, this code looks like it would only generate a stable order in py3.6+ 20:33:15 good bug 20:35:32 03advil02 07* 0.25-a0-1016-g8c1d203: Make species group order stable across python versions 10(2 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/8c1d203243d5 20:38:22 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1016-g8c1d203243 (34) 20:38:46 looks like that fixed it on cko 20:39:09 ??travis[2 20:39:09 travis[2/2]: Travis can't be bargained with. Travis can't be reasoned with. Travis doesn't feel pity, or remorse, or fear. And Travis absolutely will not stop, ever, until your project is dead. 20:39:18 alexjurkiewicz: looks like this line hasn't aged that well then 20:44:04 "what's effectively frail 2" if this is true I wonder if harm would be easier to understand if it literally used the frail mut mechanism? (setting aside the issue of where it should be) 20:48:07 ??harm 20:48:07 amulet of harm[1/1]: Increases damage done by the wearer by 30% and to the wearer by 20%. Applied after AC. It applies to damage from melee, ranged, spells, abilities, evocations, clouds, falling down stairs, etc. Drains you on removal. 20:48:51 it might be more like frail 1.5 with ac? 20:49:01 advil: better fix might be to replace SPECIES_GROUPS_TEMPLATE with an ordered dict 20:49:08 just referring to the fact that you take 20% more damage, akin to having 20% less HP in terms of what you need to survive a fight while wearing harm 20:49:21 rather than another variable 20:49:58 yeah, possibly 20:50:03 too late now! 20:50:37 ok one mo 20:50:46 another way to do it would have been to use the coordinates to generate the order in c++ 20:50:58 that might actually be the best? 20:51:11 but I wasn't even 100% sure if that was the issue, so didn't both to do it 20:51:35 of course, you could generate the coordinates from the order! 20:51:38 hm how do you mean? 20:51:42 the former 20:52:16 really the lettering should be determined by left-right order of the column positions 20:52:28 which is determined by the coordinates that are hard-coded into the group template 20:53:02 oh i see 20:53:12 so something like load the array into a vector and sort by position (well, that feels a bit brute force maybe) 20:53:50 does bloatcrawl have more than one row? 20:54:15 not immediately sure why this even uses 2d coordinates 20:54:17 you mean, multiple groups in one column? 20:54:23 yeah 20:54:28 I guess the jobs screen does that 20:54:30 not for species 20:54:33 yeah 20:54:58 so it should be sorted by column with row as a minor sort 20:56:29 pr in to DRY that 20:57:30 New branch created: pull/1399 (1 commit) 13https://github.com/crawl/crawl/pull/1399 20:57:30 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1399 * 0.25-a0-1017-g827618e: Simplify 8c1d20324 10(4 minutes ago, 1 file, 5+ 8-) 13https://github.com/crawl/crawl/commit/827618e31dcb 21:03:08 gammafunk re the frail thing, I've always found it very hard to get a sense for what harm does, so I was wondering based on that comparison if some kind of percentage hp reduction that is similar might be more comprehensible 21:03:36 could even imagine it blacking out some of your hp bar, or something like that 21:03:54 advil: ah, yeah I was going to comment that I wasn't sure how harms effect was unclear. You feel that even knowing the specific percentage of damage increase you'll have doesn't help? 21:04:02 We obviously don't tell the player that percentage in-game 21:04:29 there's not a lot of ui feedback beyond a general sense that you might be taking more damage 21:04:31 it's true that you just have to have a feel for that, but that is of course the case for basically all damage in the game, save for the max damage values we print for melee 21:04:43 and given how swingy crawl's damage is, even that is hard to read I think 21:04:47 yeah, there's no onscreen indicator of that 21:05:14 if meleebug taught us anything, it's that not even elliptic can tell if damage done by a thing to another thing is doubled! 21:05:38 I guess one way to put this, is that harm's effect is less than meleebug which was hard to spot 21:05:40 haha yeah 21:06:04 started writing that at the same time probably 21:06:23 I guess there's the same issue with the damage increase 21:06:42 yeah 21:07:42 I guess I have no strong objection to making harm simply give some form of frail; maybe frail 1 only and slightly reducing the damage increase would be a good in-between! 21:07:49 03Alex Jurkiewicz02 {advil} 07* 0.25-a0-1017-g8a05a4c: Simplify 8c1d20324 10(14 minutes ago, 1 file, 5+ 8-) 13https://github.com/crawl/crawl/commit/8a05a4ca56ae 21:08:19 my big concern was how it's sort of not loved and also similar in practice to things that are more well-loved (archmagi/+int, slaying/+str) 21:08:39 right 21:09:06 remove harm, making slaying scarf-only 21:09:12 dang 21:09:14 dont @ me 21:09:42 I've seen alexjurkiewicz's scarf in his github profile, and I could believe it grants him a lot of slaying irl 21:09:48 how much would players hate that 21:10:03 people might wear scarves though finally! 21:10:47 hm, what actually is the math on how slaying relates to a percentage bonus like harm? 21:11:54 ty gammafunk it does 21:16:51 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1017-g8a05a4ca56 (34) 21:17:31 advil: it's tricky for slaying, because this depends on the target's evasion and AC, unfortunately 21:17:58 yeah, was thinking it would need fsim for some special cases 21:30:59 harm is more noticible for lower variance attacks than melee 21:35:25 nitpick: 20% more damage is 16.666% less HP 21:38:01 harm is more noticible for lower variance attacks than melee 21:38:04 I think my problem with harm is: you don't really want percentage damage boosts unless you have high damage already, and then I would rather have more defense 21:38:08 oops 21:38:16 +damage like slaying much better 21:38:19 in general 21:39:57 harm is win-more to use card game terms 21:40:55 I do like moving slaying only to scarves but it will increase the requests to let felids wear them! 21:41:45 "In Magic: the Gathering and other popular card games, advanced players have developed the notion of a "win-more" card. A "win-more" card is one that works very well, but only if you're already winning. In other words, it never helps turn a loss into a win, but it is very good at turning a win into a blowout. This type of card seems strong at first, but since these games usually do not use margin of victory scoring in tournaments, they end 21:41:45 up being a trap-- instead of using cards that convert wins into blowouts, you want to use cards that convert losses into wins." 21:41:53 this concept^ 21:47:45 I doubt that you take the protection ego over the speed ego, and most players choose to take even freeze/flaming/vorpal over that one 21:48:43 I don't think the card analogy is too helpful here because pretty much any form of damage you could get has already converted the game into a win, effectively 21:50:05 it is true that having a slot compete with more damage compared to other effects like faith/gspirit can make balance tricky 21:50:36 but the scarf slot doesn't have as may of those (especially in ebering's branch) 21:52:18 s/may/many/ 21:52:33 of course the numbers have to come into it at some point, weapon damage brands are a much bigger boost to damage than protection is to defense in general 21:53:28 well point of fact, harm is a 30% increase to damage, and those weapon damage brands that aren't speed are only 20% 21:53:46 it does depend on what the final set of egos on cloaks are 21:54:03 harm is also -16% to hp though 21:54:04 cloaks+scarves, I guess 21:55:02 yeah the current branch state is: cloaks (rPois, MR+, rCorr, Stealth), scarves (RMsl, Harm, Invis, Resistance) 21:55:05 what would you choose, vorpal/freeze/flaming or protection brand that also gives robust 2 permanently 21:56:10 I would choose +30% damage if I could do attacks from relatively safety 22:09:28 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 22:09:40 curse you, ziggurnaut! 22:56:14 -!- amalloy_ is now known as amalloy 23:02:14 another screen write out of bounds 13https://crawl.develz.org/mantis/view.php?id=12260 by aaron 23:35:35 03advil02 07* 0.25-a0-1018-g5cf8ac0: Try to fix the build on CBRO/CAO 10(47 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/5cf8ac06c505 23:35:56 -!- misha is now known as werekitten 23:36:12 broken for 2 weeks(!) 23:41:48 03advil02 07* 0.25-a0-1019-g7cce4bb: Second try to fix the build on CAO/CBRO 10(81 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7cce4bb545c0 23:43:06 ok seriously, wth 23:46:47 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1019-g7cce4bb545 (34) 23:49:35 -!- werekitten is now known as misha 23:57:29 03advil02 07* 0.25-a0-1020-ga314768: Third try to fix the build on CAO/CBRO 10(34 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/a314768f3c2e 23:58:06 hopefully we fit a revert in there too 23:58:17 man, that didn't work either 23:58:28 I'm just going to have to #define the goddamn thing