01:09:32 Stable branch on crawl.develz.org updated to: 0.24.1-11-gbbbb2193e6 (34) 01:33:33 -!- amalloy is now known as amalloy_ 01:38:38 Unstable branch on crawl.develz.org updated to: 0.25-a0-992-gca090100c3 (34) 02:11:13 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-992-gca090100c3 03:41:47 Spectators see time instead of turns (show_game_time). 13https://crawl.develz.org/mantis/view.php?id=12256 by Yermak 03:42:21 !blame aidanh 03:42:21 I pronounce aidanh... Guilty! 03:55:13 Stable (0.24) branch on crawl.kelbi.org updated to: 0.24.1-11-gbbbb2193e6 04:18:43 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-3054-g1a545eca1e 04:48:12 %git 1efe4d44ae 04:48:13 07Medar02 * 0.14-a0-1432-g1efe4d4: Update display when getting new WebTiles options 10(6 years ago, 3 files, 18+ 4-) 13https://github.com/crawl/crawl/commit/1efe4d44ae08 04:48:22 Yermak: ^ 04:49:34 oh, wow 04:49:46 !unblame aidanh 04:53:05 Although, it doesn't look like this feature is documented anywhere 08:11:42 -!- Amnesiac_ is now known as Amnesiac 08:36:31 -!- Amnesiac_ is now known as Amnesiac 08:47:40 %git 8c392e79 08:47:40 07Medar02 * 0.14-a0-1429-g8c392e7: Send some rc file options to the WebTiles client 10(6 years ago, 7 files, 145+ 7-) 13https://github.com/crawl/crawl/commit/8c392e7901cc 09:09:13 !source game_options::write_webtiles_options 09:09:13 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/initfile.cc#L4513 09:09:52 Yermak: it's anything in this function 09:09:54 %git 31eb1322e61 09:09:55 07Medar02 * 0.14-a0-1484-g31eb132: Support show_game_turns in WebTiles 10(6 years ago, 5 files, 20+ 4-) 13https://github.com/crawl/crawl/commit/31eb1322e61a 09:14:50 I think it might be dependent on webtiles server settings 09:14:58 so not all servers might have the same behavior 09:16:41 im 09:22:06 is lugonu corrupt supposed to have a 1% chance to affect any square out of los? 09:22:27 it seems unexpected to me 09:23:41 I guess it's sort of flavorful? 09:27:45 although I think if I wanted level-wide flavor I wouldn't implement it this way 09:27:50 I'm guessing this is just an accident 09:47:27 advil: blame dive time? 09:47:45 I already did that, it's from the original commit for this version of corrupt 09:47:45 I think it's supposed to be level-wide flavour 09:48:03 like, you let the abyss in but that's not very controlled 09:48:26 maybe...the comment indirectly implies that it should drop off out of los I think 09:49:11 %git 2f88dcd080dc 09:49:11 07greensnark02 * 0.6.0-a1-1940-g2f88dcd: Corruption changes (dpeg). Corruption is now usable only once-per-level, but produces only neutrals, no hostiles, and applies all corruption effects close to the player instead of using random seed points scattered over the level. 10(10 years ago, 2 files, 47+ 28-) 13https://github.com/crawl/crawl/commit/2f88dcd080dc 10:06:52 so i have a somewhat revolutionary suggestion: adding cyclomatic complexity and function/class size limits to ci 10:09:47 with a whitelist for existing code that would otherwise cause an error, so we're not forced to fix everything first 10:12:43 as long as you whitelist everything ;-) 10:13:39 why not just generate a report instead of hooking it up to fail/pass? 10:15:12 because it's no good tracking things if it's not going to influence your behaviour, and if you might forget to have your behaviour influenced, well, ci can help out 10:16:19 the only case in which this should kick in is if you're adding some new functionality to a function/class which is already kinda long 10:16:33 have it generate a report and then open an issue with the report? 10:16:59 this doesn't seem like a good fit for our increasingly spammy ci 10:17:27 I think you're the only one getting ci spam because you've got your e-mail notifications turned up to 11 10:17:30 that's more complicated from an implementation point of view, and it's easier to disregard 10:17:40 there are only two email settings that I know of, on or off 10:17:44 I only get the report if a push of mine fails, then I get the e-mail which is helpful 10:18:05 I guess I should check if actions came with any new settings 10:21:21 tbh I already think our ci does a bunch of stuff that is not a great fit, linting should be pre-commit hooks etc 10:21:36 but I already said that at the time and got sort of overridden 10:21:44 (or at least, wasn't willing to revert the commit) 10:21:53 communnity contributors have a long history of not setting up pre-commit hooks 10:22:08 yes, I remember the points made 10:22:29 but I think CI is most useful only if it identifies stuff that needs immediate fixing 10:23:00 now there are a ton of misc CI failures that aren't really urgent 10:23:50 (or if it gives some ranking between fail and pass) 10:24:10 hm. Github actions are much more granular than travis 10:24:12 originally I had suggested putting the linting stuff in a different CI so it would be easier to separate out crucial stuff 10:24:42 ahha 10:24:48 i think if you do that, what happens is the lint gets ignored, and your codebase slowly deteriorates 10:24:49 maybe "a ton" is too strong 10:24:58 that didn't really happen before :-) 10:25:28 we could move the linting into a separate action workflow and enable it only for PRs 10:25:28 it just ended up with devs enforcing the linting, and occasionally it lagged for a few days 10:25:58 does anyone have pre-commit hooks for that? 10:26:18 what is the referent for that 10:26:28 I think many contributors used to run checkwhite and unbrace as pre-commit hooks 10:27:09 anyways, I've given up on the linting thing, it's probably fine 10:27:12 well, if they run as presubmit hooks, then there's no problem, since that CI check will always pass :) 10:27:28 it's just that we're really being overtaken by CI creep IMO 10:27:40 also, it's always an option to run CI on your own fork 10:27:41 DCCI 10:28:00 I've definitely done that at times when I was iterating on stuff that triggered CI a lot 10:28:32 advil: are you getting e-mails for every CI run, not just fails for your own pushes? 10:28:50 I think you might be right with actions that it's my own pushes? 10:28:58 or at least, my own pushes after there is a failure 10:29:19 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-993-g26bcaaf: Fix CI ccache caching 10(15 hours ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/26bcaaf2163d 10:29:40 Yeah, that's the default 10:29:53 re: linting specifically, long-time contributors and devs definitely have a pre-commit hook set up, but first time PRs often miss the linting 10:30:15 GHA is not like travis and we can have separate workflows for "build", "build test", "lint" &c. 10:30:57 I would be fine with moving the linting to a separate action that's only run on PRs 10:33:05 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-993-g26bcaaf216 (34) 10:39:56 RBrandon (L23 VpIE) ASSERT(!invalid_monster(&mons)) in 'mon-death.cc' at line 1710 failed. (Vaults:5) 10:40:07 !crashlog 10:41:37 90s limit exceeded: killed !crashlog 12:05:39 03Aidan Holm02 07* 0.25-a0-994-gbaf2e0d: Remove duplication 10(28 hours ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/baf2e0d10d25 12:05:39 03Aidan Holm02 07* 0.25-a0-995-g5a1f090: Fix ugly code 10(27 hours ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/5a1f09014c08 12:17:05 03Aidan Holm02 07* 0.25-a0-996-gbd17af9: Add test for map view cursor clamping 10(58 seconds ago, 2 files, 18+ 7-) 13https://github.com/crawl/crawl/commit/bd17af971682 12:17:58 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-995-g5a1f09014c (34) 12:18:57 /win n3 12:32:55 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-996-gbd17af9716 (34) 13:29:29 Stable (0.24) branch on crawl.akrasiac.org updated to: 0.24.1-11-gbbbb219 15:04:36 I thought I'd ask this since I noticed it in tags. "// Save versions 30-32.26 are readable but don't store the names." ...so version 29 was the last time save compat was permanently broken. How long ago was that? 15:10:57 tbh; I was mostly surprised there was stuff from before 34 still reference at all...seems like it's always been 34. 15:18:33 03advil02 07* 0.25-a0-997-g211953e: Fix a theoretical terrain change crash 10(6 hours ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/211953ec74b5 15:18:33 03advil02 07* 0.25-a0-998-gabcb65d: Adjust lugonu corrupt flavor 10(4 hours ago, 1 file, 37+ 20-) 13https://github.com/crawl/crawl/commit/abcb65df2b6a 15:18:33 03advil02 07* 0.25-a0-999-g64580d5: Fix a local tiles crash with removed wands 10(3 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/64580d555afb 15:18:33 03advil02 07* 0.25-a0-1000-g7e57843: Remove an old debug dprf 10(2 hours ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/7e5784328aaf 15:18:33 03advil02 07* 0.25-a0-1001-g3a27ba4: More lugonu corrupt flavor tweaks 10(25 minutes ago, 3 files, 82+ 9-) 13https://github.com/crawl/crawl/commit/3a27ba4f8a65 15:24:42 -!- amalloy_ is now known as amalloy 15:37:29 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1001-g3a27ba4f8a (34) 16:50:30 ziggurnaut (L13 GrFi) Crash caused by signal #15: Terminated (Lair:5) 17:43:59 -!- amalloy is now known as amalloy_ 17:46:42 03ebering02 07* 0.25-a0-1002-gbcf8c60: Find a lost unary minus (#1395) 10(39 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/bcf8c60d551b 18:03:25 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1002-gbcf8c60d55 (34) 18:22:13 Unstable branch on underhound.eu updated to: 0.25-a0-1002-gbcf8c60d55 (34) 18:35:35 +advil | now there are a ton of misc CI failures <-- there should be none now, if you see any random failure please let me know 19:15:28 03ebering02 07* 0.25-a0-1003-g6a45855: Extract XP Evoker properties to data 10(15 minutes ago, 5 files, 38+ 24-) 13https://github.com/crawl/crawl/commit/6a458556268c 19:15:28 03ebering02 07* 0.25-a0-1004-g47ef49a: Further revise tremorstones 10(3 minutes ago, 2 files, 10+ 1-) 13https://github.com/crawl/crawl/commit/47ef49afec30 19:21:34 probably xp_evoker_data should not be in a header file 19:21:38 is a thing I have recently learned 19:23:03 tin_debt 19:31:43 needs a flavour message when an elemental moves into your tin 19:32:28 Letting small people move into your accomodation so you can later evict them for personal gain. Late capitalism crawl 19:49:58 advil: why? 19:50:22 a const in a header has internal linkage and an identical object shows up in every translation unit the header is included in 19:50:54 I'm going to do a pass over all of these since the PVS-studio static report found a whole bunch 19:51:07 in c++17 a constexpr in a header is ok 19:52:10 well, anything inline, but constexpr implies inline after c++17 19:53:24 so I've been planning on converting constants that can do it to constexpr (if they aren't already, some are) and just leaving them 19:54:28 ugh, I see 19:54:36 this is what I get for play-acting programmer 19:54:46 I wouldn't worry about that case as it's only included twice and I can deal with it in my pass 19:55:09 well I literally read up on this the other day while looking over those static analyzer results so it was news to me as well 19:55:42 here's a summary: https://www.learncpp.com/cpp-tutorial/global-constants-and-inline-variables/ 19:55:49 (it's surprisingly hard to find clear statements of all of this) 19:59:26 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1004-g47ef49afec (34) 20:03:49 I can read language lawyer but thanks! 20:22:19 wow, does this change mean changing certain header file values won't result in recompiling every cc file? 20:55:29 ebering: misc acquirement should probably be tweaked for new tremorstones, currently it gives them out in stacks of two under the assumption they're consumable 20:55:58 and i think it falls back to tremorstones if everything else has been seen/is useless, but it's now possible for all misc items to be seen/useless 20:57:17 although i guess currently it's only relevant for like, troves that try to acquire misc maybe? (also i saw your message about the charms stuff, will try to have a proper look at it when i get a chance!) 21:07:26 nonce (L9 KoHu) Crash caused by signal #15: Terminated (D:6) 21:16:19 kate-: hm yeah, that's only relevant for troves but I'll tweak it 21:26:26 New branch created: pull/1396 (1 commit) 13https://github.com/crawl/crawl/pull/1396 21:26:26 03Quipyowert202 07https://github.com/crawl/crawl/pull/1396 * 0.25-a0-950-gd4c0f36: Fix signed/unsigned int format mismatch (%d vs %u) 10(53 minutes ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/d4c0f361605d 21:33:00 03Quipyowert202 {advil} 07* 0.25-a0-1005-gedaaef9: Fix signed/unsigned int format mismatch (%d vs %u) 10(60 minutes ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/edaaef979a0b 21:38:48 -!- amalloy_ is now known as amalloy 21:41:39 03advil02 07* 0.25-a0-1006-gd106ae6: Fix spelling of @pronoun_possessive@ (u/bobloblawblogger) 10(14 minutes ago, 3 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/d106ae698dec 21:41:39 03advil02 07* 0.25-a0-1007-g10a8c3c: Normalize @pronoun_possessive@ to @possessive@ 10(57 seconds ago, 2 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/10a8c3caa8b2 21:48:09 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-1007-g10a8c3caa8 (34) 21:56:28 hrm, setting webserver log level to debug doesn't get me webtiles output 21:59:28 what do you mean by webtiles output? 22:00:18 on modern tornado some tornado-specific stuff is in its own log channel 22:00:45 well, I'm trying to see what messages are being sent to the client so I can see how cells are being composed 22:01:56 specifically TilesFramework::_send_map doesn't see the relevant cell as dirty so it doesn't call draw_cell() 22:02:12 despite this cell being changed due to a spell, so I need to see what code path is being called 22:03:04 if you are adding logging on the crawl side it might honestly be simplest just to use fprintf(stderr 22:03:06 if it's not _send_map sending out an update, I need to figure out what is, so was hoping to see that from webtiles output 22:03:18 maybe, yeah 22:03:48 the server will log anything on stderr under default settings 22:03:54 but it's a bit hard to know where to insert this statement, that's sort of the whole problem 22:04:17 maybe I can add my own in the code that sends webtiles messages out 22:04:39 yeah probably just ::send_message 22:04:43 that's usually what I would do I think 22:05:03 sounds good, thanks 22:05:16 the DEBUG_WEBSOCKETS code might be worth looking at, though it's possibly too low-level 22:05:32 yeah I saw that, and it does add a bunch of message-level bits of info 22:05:39 but not one that just gives message content 22:07:30 is this something that is happening on load? 22:07:53 or soon after load? 22:08:00 also, if a spectator connects, does it fix the problem? 22:09:45 I wonder if it is similar to the bug I just fixed with syncing the player, where there was never an initial full sync so the dirty values were wrong 22:09:50 %git 0adbbaad2 22:09:51 07advil02 * 0.25-a0-990-g0adbbaa: Fully sync player on webtiles load (12117) 10(30 hours ago, 2 files, 12+ 0-) 13https://github.com/crawl/crawl/commit/0adbbaad2a99 22:10:03 advil, Hey advil. I tested crawl-tiles on a fresh virtualbox freebsd install. .25 is giving me the same core dump. Something is up. Then I installed v.24 and it worked like a charm. 22:10:09 I definitely don't see _send_map(true) anywhere except _send_everything 22:10:28 not on load; it's tile data I want to update when frozen ramparts is cast, such that the drawn cell properly has a modified floor tile 22:10:29 michael2 thanks for the update, were you able to figure out anything about the core dump? 22:11:13 yeah it's probably not setting force_full, but I don't know how its determined that the tile isn't dirty 22:11:32 that sounds eerily reminiscent of the 3 hours I spent today trying to get lugonu to be able to reflavor metal walls 22:11:42 well, to be more clear, the floor tile for a cell adjacent to an icy wall is seeing its floor tile change 22:12:11 but my modifications to change the floor tile flavor, which is packed into the background of the cell, that change is not being seen 22:12:30 yet in _draw_map I can see that even said properly updating floor tile is marked as not dirty 22:12:36 and is getting skipped by _draw_map 22:12:41 I assume local tiles is ok? 22:12:51 I haven't tested but yes 100% my assumption as well 22:13:02 something is being sent to update that floor tile, just want to know what 22:13:06 it's not _draw_map, apparently 22:13:16 or what's sent by _draw_map 22:13:42 may be worth testing actually, there's a nightmare of special casing for tile flavor stuff in tileview.cc 22:13:44 and whatever's not sending that update isn't seeing my change to draw_cell, so I'm not sure what's updating there 22:13:51 heh 22:14:42 @advil, I havent. But I'm going to look into it tomorrow. I might need a little guidance :/. 22:15:22 advil, the unistd.h works. The game honestly installs itself. There isn't much to do to get it working on freebsd now aside from getting the deps installed. 22:16:16 I do wonder if the crash may be related to some bad interaction with a dep 22:16:48 I'll try to figure it out. Good practice. 22:17:06 but I'm stepping into unknown territory....:/ 22:17:40 yeah, unfortunately I don't think there's been a lot of experience with freebsd around here 22:17:52 though we have a bunch of developers who use mac 22:18:20 advil, I'm now passing the port to the maintainer...but I have a feeling I'm going to end up adopting that port because it is more than dead aside from cli v.23 22:21:35 advil, I honestly don't know how similar mac and freebsd are now a days. Mac is pulling away with each update. 22:21:55 possibly not very 22:22:24 I wouldn't think so. Not anymore, aside from their apple tv and stuff like that. 22:22:26 it does mean that clang is well tested thoughu 22:22:40 clang is good, and lldb 22:23:50 but I had to make the game with gmake and have some gnu stuff going on to make it work...so I don't know. 22:24:26 maybe when we switch to cmake, thinks will be better 22:26:43 alright. I'm going to bed. 9:30 over here. I'll talk to you guys tomorrow. 22:27:03 advil: just tested my changes in tiles, and the floor tile flv is working ok 22:27:23 but I will look to add that debugging statement 22:41:59 the reason I mentioned spectators is that if it is an issue with the dirty flag, a spectator joining should fix it, since that force-sends the whole map 22:44:53 level_id generic_shaft_dest(level_id place); has that param for a level id; but it's only ever called with level_id::current(), would it be reasonable to remove the param and just always return for level_id::current() or is there some reason to keep it for analytics, etc. ? 23:52:26 Sif and Kiku will not give book gifts if the player is standing in shallow water. 13https://crawl.develz.org/mantis/view.php?id=12257 by bcadren 23:58:32 I straight up put which line to change in that report. Just noticed it in the source and thought it was bizarre.