00:02:01 thought of an interesting failure case for rolling compat (both windowed and non-windowed) 00:06:14 a player might not visit a particular level for long enough, leading to a save with chunks too old to load 00:06:46 oh yeah 00:07:10 i think that's solvable though 00:07:16 does each level then get its own version? 00:07:23 yes, unfortunately 00:07:24 in terms of how we handle that now 00:07:36 guess it has to just due to transfers 00:08:34 it's mostly harmless though 00:09:19 and it should be possible to quickly check all versions of all chunks and e.g. force an upgrade if they're older than the midpoint between the current version and oldest supported version 00:12:13 another thing is that although dropping support for old minors would let us remove a lot of code, we don't know which bits we can remove, because it's all #ifdef'd on the major version 00:12:59 probably need a bit of hacky git scripting to figure that out 00:13:03 I would prefer we bite the bullet and go to tag major 35 before changing to a rolling compat system 00:13:46 gammafunk there's something I'm considering doing in my fork, specifically to make users more apt to do your vaults when that might not be the most survivable idea. a daction that has a chance of removing either all untouched floor items or untouched floor items that are given a vault loot flag on reloading the floor. (Bringing it up in case you 00:13:47 liked that idea for main). 00:15:20 conversely, I'd prefer not biting the bullet if possible 00:16:39 uncharacteristically at odds with my instinct for deleting whole swaths of tech debt, I know 00:17:50 03ebering02 07* 0.25-a0-873-g799ed12: Make allies annoyed by translocations other than Recall 10(76 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/799ed1240d53 00:17:50 03ebering02 07* 0.25-a0-874-g6492fb5: Permit inner flame on summons 10(29 minutes ago, 2 files, 2+ 11-) 13https://github.com/crawl/crawl/commit/6492fb5f8eb4 00:18:29 kate-: you might want to weigh in on this most recent inner flame change as my crawl-archaeology shows the summon restriction goes back a very long time but isn't mentioned in any commit log matching "[Ii]nner.*[Ff]lame" 00:18:40 alexjurkiewicz: here's a fresh run of the ci 00:18:49 (sorry I didn't restart things, I was a bit distracted) 00:18:56 now it's not a teleport other conspiracy....it's a teleport trap conspiracy! 00:19:06 oh wait maybe they won't step on those 00:22:29 aidanh I've def been tempted to clear out some old tags stuff and straighten up enums on my fork (since I don't have to worry about loading saves older than when the fork branched off); that said, I said it once before and I'll say it again, if you want to clean all that stuff up without worrying about losing old save files...next time y'all do a 00:22:30 stable version, make all savefiles older than that version go to the stable release...therefore only saves from that stable on be allowed on git...clean cut... 00:24:24 trouble is, that's going to throw a roadblock in players' trunk games 00:26:52 how so? I mean if existing trunk games became 0.25 stable games...instead of continuing forward any farther, the game wouldn't go into any newer versions, but it should still run? (as long as you can set the server up to transfer the saves like that correctly). 00:29:57 oh, I see 00:30:15 I think the fatal flaw with that plan is that it requires server modification 00:32:42 Too much effort to expect from server owners? 00:33:00 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-874-g6492fb5f8e (34) 00:39:58 they're pretty busy, yeah 00:41:16 those save transfer scripts are not well understood or tested (at all) and the servers are generally running other things as well, making modifications risky 00:42:20 yea; my fork was down on alexjurkiewicz's server for a bit, because his compiler was different than CKO's. 01:11:44 ebering: that fresh run of CI is green tick :| 01:12:02 i think the errors are from before 2ff81177622749c34a6f26a46d94dcb048760643 merged 01:12:09 somehow 01:12:39 god, when even was february 01:17:06 was there ever a february 01:17:32 %git 2ff81177622 01:17:32 07Alex Jurkiewicz02 {ebering} * 0.25-a0-818-g2ff8117: ci: Install PyYAML for Python 3 on macOS 10(2 months ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/2ff811776227 01:18:05 they're on commits I merged.. hours ago? 01:18:05 I guess if time no longer makes sense anything goes 01:18:07 maybe a gh caching issue 01:18:09 oh well 01:18:18 so much for repeatable builds :P 01:29:10 03ebering02 07* 0.25-a0-875-geaba134: Prevent attitude change for ancestors and demonic guardians 10(5 minutes ago, 2 files, 13+ 0-) 13https://github.com/crawl/crawl/commit/eaba134f4620 01:33:13 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-875-geaba134f46 (34) 01:36:05 heh. it looks like beckoning was changed to work on allies per yermak's input 4 years ago 01:38:15 I see no harm for it to continue working this way with immolation changed. 01:38:49 Unstable branch on crawl.develz.org updated to: 0.25-a0-874-g6492fb5f8e (34) 01:54:57 hm. the commit message doesn't elaborate and I can't find a message in the logs explaining the reasoning 01:55:23 other than Yermak asking why beckoning angers allies 01:57:05 Well, what harm is there in allowing to beckon allies? On the other hand you can use it to position them if you happen to find it useful. 02:03:22 the harm is that in my opinion it cleaves too close to individual ally micromanagement, which is something we would like to minimize 02:10:18 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-875-geaba134f46 02:15:21 +ebering | they're on commits I merged.. hours ago? <-- but they are from PRs. If the PR was branched before this commit was on master 02:15:49 the PR head would have tested without it, and failed. Then somehow the build result was cached when you merged into master... even though the sha change 02:15:55 i dunno, but I'm also out of ideas 02:29:36 03ebering02 07* 0.25-a0-876-gadf69d5: Update the credits 10(44 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/adf69d5009bb 02:32:38 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-876-gadf69d5009 (34) 03:09:41 ebering, situations where you'd want to use Beckoning on allies aren't very often plus it costs 3 mp unlike various commands (shouts), therefore it's not tedious. Plus I wouldn't rob the player of "Wow, I'm so smart!" moments they could experience with blocking OoD with an ally. 03:23:09 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-876-gadf69d5 (34) 03:31:35 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-2646-gabeecb8179 04:50:17 03Aidan Holm02 07* 0.25-a0-877-g3f1e787: Fix map not panning with cursor 10(3 months ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/3f1e787b38e5 06:02:30 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-877-g3f1e787b38 (34) 06:43:34 aidanh: just out of curiosity, do you know why TVARY_CYCLE doesn't work with wielded weapons? I am looking at the deep elf elementalist tiles added back in 2018 in 9b14fc1, and as gammfunk mentioned, the weapon shows only on the first variant 06:44:17 not offhand 06:44:20 %git 9b14fc1 06:44:20 07gammafunk02 * 0.22-a0-18-g9b14fc1: A batch of updated elven monster tiles (roctavian, #11340) 10(2 years, 4 months ago, 22 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/9b14fc1fdf4c 06:44:57 if I understand it correctly, the composition happens in mcache_monster? 06:45:05 which calls tileidx_monster and tilep_equ_weapon 06:45:50 I tried to play with it in a local build, and the base tile cycles nicely, but the weapon only shows on the first variant, the disappears for the other ones, then reappears again 06:55:30 03Aidan Holm02 07* 0.25-a0-878-gfe5977e: Fix map cell corruption on unmarshalling (#12218) 10(5 minutes ago, 2 files, 70+ 8-) 13https://github.com/crawl/crawl/commit/fe5977ef6f1c 06:55:51 !source mcache_monster 06:55:51 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilemcache.cc#L35 07:00:17 Goratrix: lemme take a look 07:02:44 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-878-gfe5977ef6f (34) 07:03:12 thanks :) that code is way over my head 07:03:38 maybe it's some refresh issue, as the tiles as such are picked correctly 07:12:11 it's not you, that code is just insane 07:12:57 haha 07:13:18 there's some kind of refresh/update happening in tile_fg_store 07:15:26 they're not showing up because they don't have weapon coords listed in tilemcache.cc 07:15:40 %source tilemcache.cc:480 07:15:40 http://s-z.org/neil/git/?p=cheibriados.git https://github.com/crawl/monster/ https://github.com/crawl/crawl/ 07:15:45 !source tilemcache.cc:480 07:15:46 https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilemcache.cc#L480 07:16:00 ooh 07:16:54 just adding TILEP_MONS_ELF_ELEMENTALIST in the list is enough? 07:17:02 yeah... i'm tempted to make crawl abort if that happens, but then there are loads of tiles where it's expected, e.g. dowan and duvessa 07:17:38 I'll test that and if it works I'll do a PR 07:17:38 it's already there; you need TILEP_MONS_DEEP_ELF_ELEMENTALIST_1 and _2 07:17:38 oh the variants 07:17:38 ok 07:17:46 there's actually one more in the original submission, I've added it locally 07:18:19 oh right 07:37:04 03Aidan Holm02 07* 0.25-a0-879-g6bf7129: Fix Leda's showing muddy lava (#11115) 10(44 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6bf7129739b2 07:47:22 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-879-g6bf7129739 (34) 07:59:01 New branch created: pull/1379 (1 commit) 13https://github.com/crawl/crawl/pull/1379 07:59:01 03Goratrix02 07https://github.com/crawl/crawl/pull/1379 * 0.25-a0-879-gbd15b1c: Enable deep elf elementalist tile animation 10(8 minutes ago, 7 files, 5+ 1-) 13https://github.com/crawl/crawl/commit/bd15b1c62bc6 08:33:15 Goratrix: looks like your PR deleted some of the tiles? 08:34:50 hmm that's weird 08:34:56 should have been replaced 08:35:39 ok, I'll close and re-do it 08:36:03 the local build compiled ok with all 4 tiles correct 08:36:22 wait no 08:36:27 they are not deleted 08:36:41 the red highlight is because the new ones are smaller 08:37:59 all 4 are there in the PR, number 1-3 are replaced (because of the sequencing), number 4 is new 08:38:47 oh, i'm an idiot 08:38:52 :D 08:39:12 the red github highlight confused me too for a second 08:39:46 merged! thanks! 08:39:55 03Goratrix02 {Aidan Holm} 07* 0.25-a0-880-g497542d: Enable deep elf elementalist tile animation 10(49 minutes ago, 7 files, 5+ 1-) 13https://github.com/crawl/crawl/commit/497542d149fb 08:40:37 thank you! 09:02:49 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-880-g497542d149 (34) 09:13:17 Since its now May 1 I'm going to put out the concrete suggestion that we: feature freeze May 14 (could be earlier but I kind of want to tweak scarf/cloak/amulet ego space before release, and tremorstones have some todo) with a May 27 release and May 29 tournament 09:13:29 Possibly also furious tournament score writing from May 1 - May 14 09:13:49 ef 09:13:58 er until May 27 tbf 09:16:15 also I haven't been involved in it closely because I don't understand webtiles that well, but I think it would be nice to land webtiles-improvements 09:16:25 before we end up with webtiles-changes 2.0 09:28:35 well, I do agree that it would be nice to merge it, but I'm not willing to do that without testing it in a dgl setup and I just haven't had time to get to it myself 09:29:26 what needs to be tested is whether (as intended) if it is merged in an existing server that the upgrade is transparent 09:31:23 I guess regardless of the outcome in a clean dgl setup I'm also expecting to need to spend a bunch of nerve-wracking hours in the middle of the night chivvying it into working on CAO, at least based on the last time I merged something that affected webtiles this much 09:35:13 yikers 09:35:25 I guess I should have expected as much 09:38:05 I guess regardless of whether this is merged, we may want to aim to give server owners advance notice given that many may not have restarted webtiles since the merge of the py2019 branch 09:38:37 which is also supposed to be transparent at this point (after the late night work at least) but who knows 09:40:08 Guys, is old versions removal (from servers) still planned? 09:40:31 Yermak I think for CAO I will try to give some advance notice...the only thing on CAO that urgently needs a decision is 0.10 (I got the security fixes working in other versions) 09:40:56 other servers don't go back so far 09:41:52 that is, for maintainability I still sort of do want to remove some older versions from CAO but because I got the security fixes mostly working I don't have any immediate plans to do it 09:42:03 also need to consult with r.ax probably 09:42:43 I think if/when aidanh's chroot build thing is merged, CAO will become unable to build older versions, maybe most of them, so that's another thing to deal with 09:43:18 thanks 09:43:40 (at least, in my modern linux containers I currently can't even build stuff like 0.15 or 0.16 as-is...I'm sure it's possible somehow but it would need some tweaking) 09:57:46 i didn't try that, but there's nothing too radical about building inside a chroot that should prevent old versions from building 09:58:16 it's not anything about building in a chroot but newer compilers don't build these versions 09:58:27 at least in my testing 09:58:34 it's going to depend on exact versions etc 09:58:55 I think it's possible they could build them with the right compiler flags 09:59:01 ah gotcha 09:59:07 it's not something worth spending time on imo 09:59:14 so this isn't a request to fix it :-) 09:59:35 just something I noticed along the way while trying to get the old versions buildling again 09:59:44 one possibility is just to not build them in the chroot 09:59:45 phew! back to my regularly scheduled crawl refactoring drudgery 10:02:12 03Aidan Holm02 07* 0.25-a0-881-g9575aa3: Revert "Fix map not panning with cursor" 10(2 hours ago, 1 file, 0+ 13-) 13https://github.com/crawl/crawl/commit/9575aa3b0e4a 10:02:12 03Aidan Holm02 07* 0.25-a0-882-ge549c88: Remove unused show_map() allow_esc parameter 10(2 hours ago, 6 files, 9+ 13-) 13https://github.com/crawl/crawl/commit/e549c8864652 10:02:12 03Aidan Holm02 07* 0.25-a0-883-gff86aee: Extract search path generation from map code 10(86 minutes ago, 3 files, 33+ 37-) 13https://github.com/crawl/crawl/commit/ff86aee0ceae 10:02:12 03Aidan Holm02 07* 0.25-a0-884-g76b13fe: Add coord_def ostream operator 10(7 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/76b13fe6462a 10:10:44 03ebering02 07* 0.25-a0-885-gac04306: Update the changelog 10(17 seconds ago, 1 file, 62+ 6-) 13https://github.com/crawl/crawl/commit/ac0430677b62 10:42:02 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-885-gac0430677b (34) 12:07:02 New branch created: refactor-show-map (3 commits) 13https://github.com/crawl/crawl/tree/refactor-show-map 12:07:02 03Aidan Holm02 07[refactor-show-map] * 0.25-a0-885-g7166e27: Move shop_struct to shopping.h 10(2 hours ago, 4 files, 27+ 23-) 13https://github.com/crawl/crawl/commit/7166e278e1eb 12:07:02 03Aidan Holm02 07[refactor-show-map] * 0.25-a0-886-g9ab75b0: Move map_markers struct to mapmark.h 10(2 hours ago, 3 files, 47+ 48-) 13https://github.com/crawl/crawl/commit/9ab75b035933 12:07:02 03Aidan Holm02 07[refactor-show-map] * 0.25-a0-887-g1e719e7: Split command processing out of show_map() 10(30 minutes ago, 3 files, 599+ 548-) 13https://github.com/crawl/crawl/commit/1e719e74d482 12:34:23 New branch created: pull/1381 (1 commit) 13https://github.com/crawl/crawl/pull/1381 12:34:23 03Goratrix02 07https://github.com/crawl/crawl/pull/1381 * 0.25-a0-886-g4bd0d00: Tweak phial of floods description (Flugkiller) 10(5 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/4bd0d005b67f 13:07:04 New branch created: pull/1382 (1 commit) 13https://github.com/crawl/crawl/pull/1382 13:07:04 03Goratrix02 07https://github.com/crawl/crawl/pull/1382 * 0.25-a0-886-gfb625ef: Tweak phial of floods description (Flugkiller) 10(5 minutes ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/fb625ef3c906 13:28:24 03ebering02 07* 0.25-a0-886-gd7461d2: Fix typos in changelog (pblur, Goratrix, Flugkiller) 10(18 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/d7461d2276fd 13:30:32 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-885-gac04306 (34) 13:32:54 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-886-gd7461d2276 (34) 14:31:42 Pestilence (L18 GnFi) ASSERT(mgrd(mons->pos()) == s) in 'show.cc' at line 275 failed. (Snake:4) 15:03:13 I made a trunk updates post, since its been about a month 15:03:21 I held off on tournament/release details though 18:01:45 -!- jfcaron_ is now known as jfcaron 18:25:08 Unstable branch on underhound.eu updated to: 0.25-a0-886-gd7461d2276 (34) 21:12:00 03ebering02 07* 0.25-a0-887-g568ea92: Display !lignification AC in the description (12224) 10(3 minutes ago, 2 files, 30+ 8-) 13https://github.com/crawl/crawl/commit/568ea92cc336 21:12:00 03ebering02 07* 0.25-a0-888-g084fcd9: Remove a testing comment (gammafunk) 10(61 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/084fcd9360b0 21:33:43 03ebering02 07* 0.25-a0-889-g237153e: Reveal frenzy immunity in the datura targeter (12197) 10(7 minutes ago, 3 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/237153e6255f 21:33:43 03ebering02 07* 0.25-a0-890-g62861fb: Expose "can_go_frenzy" to clua 10(54 seconds ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/62861fb195bf 21:38:32 this bug report has a patch fixing it attachedd 21:38:33 https://crawl.develz.org/mantis/view.php?id=12237 21:38:38 get Rogo a medal 21:41:54 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-888-g084fcd9360 (34) 22:10:06 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-890-g62861fb195 (34) 22:31:45 alexjurkiewicz: ci is still failing 22:31:53 for the same pyyaml reason 22:31:59 https://github.com/crawl/crawl/runs/638028629 22:35:26 alexjurkiewicz: hm. I think it is github's fault 22:35:40 from a green check subunit of the action: 22:35:41 Virtual Environment 22:35:41 7 Environment: ubuntu-18.04 22:35:41 8 Version: 20200406.2 22:35:55 from the fail: 22:35:55 Environment: ubuntu-18.04 22:35:55 8 22:35:56 Version: 20200426.1 22:36:53 well, github changed something 4 days ago 22:39:31 yes 22:39:31 this is the issue 22:39:37 the list of installed software has the same python versions