03:24:03 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-829-g4e6a552 (34) 05:26:18 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1368 * 0.25-a0-830-gb28a33f: Standardise text file TAG_MAJOR_VERSION comments 10(2 minutes ago, 47 files, 235+ 72-) 13https://github.com/crawl/crawl/commit/b28a33faff66 05:26:18 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1368 * 0.25-a0-831-g3a7cda8: Add util/tag-35-upgrade.py 10(2 minutes ago, 1 file, 100+ 0-) 13https://github.com/crawl/crawl/commit/3a7cda86bf59 05:26:18 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1368 * 0.25-a0-832-g01b6885: Fix compilation with TAG_MAJOR_VERSION 35 10(2 minutes ago, 21 files, 85+ 39-) 13https://github.com/crawl/crawl/commit/01b6885e7229 05:26:18 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1368 * 0.25-a0-833-g828a3d7: Add CI jobs to test TAG_MAJOR_VERSION 35 10(2 minutes ago, 1 file, 32+ 4-) 13https://github.com/crawl/crawl/commit/828a3d77bd8d 09:00:25 -!- Amnesiac_ is now known as Amnesiac 11:57:21 Arvaldir (L27 GrEE) ERROR in 'mon-util.cc' at line 671: bogus mc (no monster data): invalid monster_type 1000 (1000) (Zig:14) 12:13:35 !crashlog 12:13:59 21890. nxtlvl, XL27 KoFi, T:50823 (milestone): https://crawl.kelbi.org/crawl/morgue/nxtlvl/crash-nxtlvl-20200419-181221.txt 12:20:52 anyone have any strong opinions like me on the UNUSED folder? 12:20:52 there's a fix for that but it doesn't apply cleanly for some reason 12:21:46 I've long thought we should just not have this folder and be moving files to https://github.com/crawl/tiles 12:22:21 which would be helpful in both cleanup up unecessary stuff from the repo and keeping that project up to date for people who want to use the art 12:22:59 %git 79084b9aa608 12:22:59 07advil02 * 0.25-a0-572-g79084b9: Add a pointer check to actor::collide 10(7 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/79084b9aa608 12:24:25 oh, I guess the fedhas collision damage stuff is just not in 0.24 12:24:35 i agree that having the folder is a little weird; that's what git history is for 12:24:50 but there's no really accessible way of looking at old versions of tiles 12:25:28 well, if we moved them to the tiles project, we could certainly put old versions as distinct filenames 12:25:37 it's a bit more work when replacing a tile, of course 12:26:10 but old versions of stil-existing tiles seems less important than removed tiles, right? 12:26:17 unless you mean all kinds of tile changes 12:26:44 I guess I'm asking if anyone would object to my moving all UNUSED stuff out of the repo into the tiles repo 12:26:58 not sure how to best structure releases over in that repo, or if we even need to do that 12:27:36 i meant that having the folder is odd, for both types 12:28:18 i guess probably have a batch job that transfers commits from crawl/crawl to that repo 12:28:28 right, I was wondering about something like that 12:29:36 maybe just appending .0 .1 etc suffixes for different versions is simple enough 12:29:54 then the directory structure can directly mirror crawl/crawl's 12:30:07 (i say this without even having looked at what it's like currently) 12:31:05 i'm about to merge alex's TAG_MAJOR_VERSION CI stuff btw, no objections I hope 12:34:21 hm, maybe this is a different collision crash 12:48:08 03Alex Jurkiewicz02 07* 0.25-a0-830-gb28a33f: Standardise text file TAG_MAJOR_VERSION comments 10(7 hours ago, 47 files, 235+ 72-) 13https://github.com/crawl/crawl/commit/b28a33faff66 12:48:08 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-831-g239cf25: Add util/tag-35-upgrade.py 10(7 hours ago, 1 file, 100+ 0-) 13https://github.com/crawl/crawl/commit/239cf252b259 12:48:08 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-832-g00990ba: Fix compilation with TAG_MAJOR_VERSION 35 10(7 hours ago, 21 files, 85+ 39-) 13https://github.com/crawl/crawl/commit/00990ba76454 12:48:08 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-833-ge42328e: Add CI jobs to test TAG_MAJOR_VERSION 35 10(7 hours ago, 1 file, 32+ 4-) 13https://github.com/crawl/crawl/commit/e42328e28c13 12:51:21 re save compat, is most of this ifdef-bracketed code that checks e.g. removed item types really removed? 12:51:39 for some reason I was under the impression that if you loaded a save, removed items were, well.. removed 12:54:27 I don't quite understnd your question 12:54:48 !source item-name:2699 12:54:49 Can't find item-name. 12:54:54 !source item-name.cc:2699 12:54:54 https://github.com/crawl/crawl/blob/master/crawl-ref/source/item-name.cc#L2699 12:55:08 for removed items, if the item is on the ground or in inventory, it will remain at those places unless we have a tags.cc cleanup to delete them upon unmarshalling 12:55:57 so they'll exist even if they don't have function, and will often have weird catch-all names like "wand of removedness" or something like that 12:55:57 e.g. the POT_BENEFICIAL_MUTATION logic on line 2707 12:56:13 that seems non-ideal 12:56:39 these tags.cc cleanups are keyed by minor bump, right? 12:56:40 yes, a lot of TAG_MAJORED code like that could be outright removed because the default case handles things correctly 12:57:47 cause if none of these enums are changing value, there's no point in keying by minor bump... 12:58:04 right, they'd need to have a minor version to handle something like deletion of a removed item or turning one item into another, potentially 12:59:21 i'm not clear on why that'd be required 12:59:21 apart from loading newer saves on older versions, and properly reporting that the save is too new 13:00:11 right, I guess if you were removing an item like that, you'd not need a minor version actually 13:00:31 even replacing it shouldn't need one 13:01:11 but your example above is an example of code that doesn't need to exist at all 13:01:23 i guess minor version bumps could be useful to patch up saves between two minors where the save conversion code was broken :) 13:01:27 bleargh 13:01:28 doesn't even need a TAG_MAJOR since the default case is sufficient 13:01:47 well, that is true, but pretend that it isn't for a minute :) 13:02:30 it probably makes sense to #define CASE_REMOVED_POTIONS as case POT_...: die("!!") 13:03:09 you mean if you delete said potions via tags.cc? 13:03:16 yes 13:03:19 we don't even both deleting the useless items in most cases 13:03:24 s/both/bother/ 13:03:33 !source tags.cc:4776 13:03:34 https://github.com/crawl/crawl/blob/master/crawl-ref/source/tags.cc#L4776 13:03:54 looks like they're already unconditionally converted to !mut 13:03:58 sure, in that case 13:04:20 sure, but if you do remove them, you get to clear out all of this ifdef crap 13:04:48 and we may not even need to break compatibility 13:04:51 -13,000 lines would be a huge win 13:05:22 well, I think the big issue with that is going through all 13,000 lines or whatever to see what code does and does not have to stick around 13:05:37 easy to do incrementally though 13:06:02 yeah, if you incrementally add tags.cc removals pair with removal of said items handling code 13:06:12 s/pair/paired/ 13:06:13 e.g. I see 8 mentions of !curemut, and I know that's already got a converter 13:06:47 not sure if it causes problems for e.g. stash tracking 13:06:54 if the stash knows about a now-removed item 13:07:05 but presumably that's already handled properly or could be 13:07:49 shops that could suddenly become empty...gozag offerings? 13:08:06 could just turn whatever it is into a rock or something 13:08:27 or better yet, a fabulous +27 piece of unwearable armour 13:09:04 there is definitely a bunch of outright unecessary TAG_MAJOR code can be removed without needing anything in tags.cc, since it's involving stuff that's never marshalled 13:09:11 I try to remove it when I see it 13:20:32 you probably saw, but in the same vein, i suggested marshalling an enum-string <-> enum value, and using that to dodge the marshalled-enum issue 13:30:00 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-833-ge42328e28c (34) 13:30:15 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-833-ge42328e (34) 13:30:45 -!- oberste1n is now known as oberstein 13:36:23 DeForestationKelley (L12 MiAK) ERROR in 'describe.cc' at line 2155: Bad item class (Lair:4) 13:46:43 aidanh: I'm not a save structure guru; wouldn't that increase the size of our save file a lot? 13:48:39 03advil02 07[stone_soup-0.24] * 0.24.1-5-g77f818b: Fix a crash in monster collisions 10(61 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/77f818bfca1f 13:48:56 maybe by a kilobyte or two? 13:50:49 !crashlog DeForestationKelley 13:50:50 1. DeForestationKelley, XL13 VpVM, T:11687 (milestone): http://crawl.akrasiac.org/rawdata/DeForestationKelley/crash-DeForestationKelley-20191207-233815.txt 13:52:41 !crashlog DeForestationKelley miak 13:52:41 No milestones for DeForestationKelley (miak crash). 13:52:49 !crashlog 13:52:50 21890. nxtlvl, XL27 KoFi, T:50823 (milestone): https://crawl.kelbi.org/crawl/morgue/nxtlvl/crash-nxtlvl-20200419-181221.txt 13:52:56 !crashlog * cao 13:52:57 5220. Thrustazar, XL18 DrAE, T:37011 (milestone): http://crawl.akrasiac.org/rawdata/Thrustazar/crash-Thrustazar-20200419-165225.txt 13:53:17 !lm DeForestationKelley -sprint miak 13:53:18 Unknown option: sprint 13:53:21 !lm DeForestationKelley sprint miak 13:53:22 No milestones for DeForestationKelley (sprint miak). 13:54:23 automation has failed me 13:54:23 I wonder if this is the ongoing sequell issue 13:54:23 http://crawl.akrasiac.org/rawdata/DeForestationKelley/crash-DeForestationKelley-20200421-173623.txt 13:57:34 -!- raskol_ is now known as raskol 14:07:06 New branch created: ifdefs-begone (3 commits) 13https://github.com/crawl/crawl/tree/ifdefs-begone 14:07:06 03Aidan Holm02 07[ifdefs-begone] * 0.25-a0-834-g813c090: Remove code for old potion types 10(39 minutes ago, 5 files, 82+ 533-) 13https://github.com/crawl/crawl/commit/813c090031e4 14:07:06 03Aidan Holm02 07[ifdefs-begone] * 0.25-a0-835-gbd93cec: Remove is_blood_potion() 10(3 minutes ago, 6 files, 4+ 61-) 13https://github.com/crawl/crawl/commit/bd93cec957a9 14:07:06 03Aidan Holm02 07[ifdefs-begone] * 0.25-a0-836-ge0d8c9a: Remove more old potion code 10(12 minutes ago, 7 files, 8+ 228-) 13https://github.com/crawl/crawl/commit/e0d8c9a9c829 14:08:52 well, that's potions done 14:19:31 advil: yeah, no word back from greensnark yet 14:25:01 03Aidan Holm02 07[ifdefs-begone] * 0.25-a0-837-g58eafd5: fixup! Remove is_blood_potion() 10(67 seconds ago, 1 file, 0+ 17-) 13https://github.com/crawl/crawl/commit/58eafd5f3dcb 14:25:01 03Aidan Holm02 07[ifdefs-begone] * 0.25-a0-838-gf7fedaf: Remove an unused parameter 10(40 seconds ago, 3 files, 9+ 12-) 13https://github.com/crawl/crawl/commit/f7fedafbede9 14:25:41 oh, I think I understand why your proposal wouldn't increase the save file size that much, aidanh 14:25:56 I thought you meant marshalling strings for the enum names 14:28:23 sorry, it was a little unclear 14:29:01 i do, but marshalling them once only per enum name, not once per instance 14:29:04 sCylight (L2 FoFi) ERROR in 'describe.cc' at line 2155: Bad item class (D:1) 14:29:34 although what with the compression step, even that might be fine 14:29:48 sCylight (L2 FoFi) ERROR in 'describe.cc' at line 2155: Bad item class (D:1) 14:33:07 !crashlog 14:33:08 21890. nxtlvl, XL27 KoFi, T:50823 (milestone): https://crawl.kelbi.org/crawl/morgue/nxtlvl/crash-nxtlvl-20200419-181221.txt 14:33:24 !crashlog sCylight 14:33:24 8. sCylight, XL22 FoFi, T:45894 (milestone): http://crawl.akrasiac.org/rawdata/sCylight/crash-sCylight-20141127-184205.txt 14:34:19 jymna (L8 HuFi) ERROR in 'describe.cc' at line 2155: Bad item class (D:5) 14:35:01 this seems like something recent 14:35:14 it wasn't super obvious when I looked at the first crashlog 14:35:22 http://crawl.akrasiac.org/rawdata/sCylight/crash-sCylight-20200421-182947.txt is another 14:35:48 something triggered by changing item letters though 14:44:09 -!- Tiobot is now known as Guest71227 14:45:31 robotcentaur (L15 GnGl) ERROR in 'describe.cc' at line 2155: Bad item class (Bailey) 14:47:07 fallout330 (L3 MiBe) ERROR in 'describe.cc' at line 2155: Bad item class (D:1) 14:49:35 robotcentaur (L15 GnGl) ERROR in 'describe.cc' at line 2155: Bad item class (Bailey) 14:50:19 TyGuy6 (L13 OgWn) ERROR in 'describe.cc' at line 2155: Bad item class (Lair:6) 14:51:30 robotcentaur (L15 GnGl) ERROR in 'describe.cc' at line 2155: Bad item class (Bailey) 14:57:59 looks like 00990ba7645445 removed a case that it shouldn't have 14:57:59 %git 00990ba76 14:57:59 07Alex Jurkiewicz02 {Aidan Holm} * 0.25-a0-832-g00990ba: Fix compilation with TAG_MAJOR_VERSION 35 10(10 hours ago, 21 files, 85+ 39-) 13https://github.com/crawl/crawl/commit/00990ba76454 14:58:20 03kate-02 07* 0.25-a0-834-g55863b0: Don't crash when trying to describe potions 10(66 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/55863b0b92b1 14:58:40 uh oh did something accidentally get removed? 14:58:40 robotcentaur (L15 GnGl) ERROR in 'describe.cc' at line 2155: Bad item class (D:12) 14:59:01 big oof 14:59:01 oh haha I see 14:59:21 yeah, just slightly overzealous removal of the ifdef'd bit i guess 14:59:52 robotcentaur (L15 GnGl) ERROR in 'describe.cc' at line 2155: Bad item class (D:12) 15:00:29 guess we need to rebuild cao 15:00:43 ??rebuild[2 15:00:43 rebuild[2/2]: Trunk update start times in UTC (second number during summer time): CAO: 1700; CDO: 0600/0500; CUE: 2300/2200; CBRO: 0800/0700; CXC: 0500/0400; CPO: every 15 minutes; CKO: trunk every 15 minutes, other versions 0830/0730. 15:00:47 ??rebuild[ 15:00:47 I don't have a page labeled rebuild[ in my learndb. 15:00:49 ??rebuild 15:00:49 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely. 15:01:48 doing cao rebuild now 15:03:26 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-834-g55863b0b92 (34) 15:05:11 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-834-g55863b0 (34) 15:14:59 Draggles (L4 TeWz) ERROR in 'describe.cc' at line 2155: Bad item class (Sewer) 15:53:13 OcticalTactics (L11 OpFi) ERROR in 'describe.cc' at line 2155: Bad item class (D:10) 16:09:32 Iliotor (L16 GnWn) ERROR in 'describe.cc' at line 2155: Bad item class (D:15) 16:21:57 bentocg (L11 OpIE) ERROR in 'describe.cc' at line 2155: Bad item class (Gauntlet) 16:51:21 oof 16:51:28 thanks kate-- 17:27:12 -!- jfcaron_ is now known as jfcaron 18:11:22 i'm glad my secret balance patch to chuck made it through unscathed 18:23:10 Unstable branch on underhound.eu updated to: 0.25-a0-834-g55863b0b92 (34) 19:21:53 Stable (0.24) branch on underhound.eu updated to: 0.24.1-5-g77f818bfca 19:30:56 -!- Tux[Qyou] is now known as werecarpet