01:38:38 03gammafunk02 07* 0.25-a0-706-ga8a4922: Update loot in a vault 10(3 hours ago, 1 file, 18+ 17-) 13https://github.com/crawl/crawl/commit/a8a4922b4fa9 01:38:38 03gammafunk02 07* 0.25-a0-707-g603da07: Fix some issues in a vault 10(2 hours ago, 1 file, 37+ 32-) 13https://github.com/crawl/crawl/commit/603da076d2ba 01:47:41 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-707-g603da076d2 (34) 02:09:47 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-707-g603da076d2 02:45:03 Monster database of master branch on crawl.develz.org updated to: 0.25-a0-651-g8c222c7a2b 02:52:44 I've noticed an uptick in peanut gallery commit commenting on our github 03:12:11 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-707-g603da07 (34) 03:22:16 I've gotten a few positive comments 03:22:19 no negative ones so far 03:22:26 can you see a list of them all somewhere? 03:30:51 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2999-g24818c1c7b 03:56:25 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-2562-g2c1b0ff932 04:33:49 I don't think so 10:12:52 it seems to be 1. impossible to turn off on its own, and 2. impossible to see a list of all of them 10:35:24 I haven't noticed much of a difference, it's a bit unfortunate that we have to get emailed every time though 10:37:09 New branch created: pull/1340 (1 commit) 13https://github.com/crawl/crawl/pull/1340 10:37:09 03Goratrix02 07https://github.com/crawl/crawl/pull/1340 * 0.25-a0-708-ga1bb027: Adjust Vehumet gift range 10(6 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a1bb02713605 10:43:14 I guess it feels like I'm getting more than one e-mail in a blue moon 10:43:24 it comes and goes in my experience 10:44:31 so it might be true that there have been a few more lately but I doubt the average has budged 10:45:16 also correlates with how controversial some changes are perceived by some segment of the community ime 10:45:52 man, I can't help but feel that something like discourse shouldn't need the kinds of resources that it apparently does 10:56:58 maybe that's just because i'm Old 13:07:19 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-707-g603da07 (34) 13:58:52 03Aidan Holm02 07* 0.25-a0-708-g3249295: Fix spurious lint failure 10(4 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/32492954b1d2 13:58:52 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-709-gccf301f: Add CI for webserver 10(33 hours ago, 1 file, 34+ 0-) 13https://github.com/crawl/crawl/commit/ccf301f2a316 13:58:52 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-710-g19a9338: Fix isort arguments 10(31 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/19a9338ac185 13:58:52 03Alex Jurkiewicz02 {Aidan Holm} 07* 0.25-a0-711-g2667425: Fix import sorting 10(31 hours ago, 10 files, 92+ 55-) 13https://github.com/crawl/crawl/commit/2667425cccb6 14:02:59 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-711-g2667425ccc (34) 14:07:23 03Goratrix02 {Aidan Holm} 07* 0.25-a0-712-g6fb8d1b: Correct meliai and hornet spectral and simulacrum 10(13 days ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/6fb8d1b6dd7c 14:11:39 03Nikolai Lavsky02 {Aidan Holm} 07* 0.25-a0-713-g4845790: Fix stash search menu not showing tiles for some dungeon features 10(2 days ago, 1 file, 1+ 4-) 13https://github.com/crawl/crawl/commit/4845790874ce 14:15:44 -!- Raichvent_ is now known as Raichvent 14:18:04 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-713-g4845790874 (34) 14:18:35 ok I appreciate improving stuff like CI but why are there no commit messages telling me what any of this stuff does? 14:18:46 nor PR description? 14:19:15 sorry, yeah, pushed without realizing 14:20:31 well, not the first time I've given this feedback to alexjurkiewicz :-) 14:21:07 I take it there is something I could do when modifying webtiles code that would now cause CI to fail? 14:23:28 there are some test cases for the auth cookie code now 14:23:42 !source auth_test.py 14:23:42 ah ok...there is some linting now too? 14:23:42 https://github.com/crawl/crawl/blob/master/crawl-ref/source/webserver/auth_test.py 14:23:54 yes, but it's disabled for most files for now 14:24:11 that includes type checking 14:24:36 ok yeah I think I did look at those commits at some point so I know roughly what that's doing 14:24:38 what is isort? 14:24:41 hmm, type checking is probably something that should be run on all files, separate to style linting 14:24:51 isort enforces consistent import ordering 14:26:55 am I understanding it right that CI will fail if isort hasn't run? (because it actually looks pretty hard to manually get the import ordering that isort enforces) 14:27:13 probably, yes 14:28:18 might be better to keep that as something that someone runs every once in a while rather than a code formatting requirement 14:28:23 if that's too strict, disabling the import order lint check is always an option 14:30:39 i tend to err on the side of making such things requirements, since running `make format` is not any more difficult than running `make lint` 14:30:50 I'm not sure of any real consequences for having a messy import ordering (and import * from whatever is like 1000x worse on the scale of bad python imo) 14:31:11 well, I guess I do tend towards not really liking linting in CI as has come up in the past :-) 14:31:54 if it's a requirement we should document it somehow in https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/coding_conventions.txt (which right now does not really touch python at all) but with 5 minutes of thinking about it I'm not sure of this one being all that useful as a requirement 14:32:41 type checking is good imo 14:33:08 -!- Raichvent_ is now known as Raichvent 14:35:58 (sorry, it would have been better for me to provide this feedback on the PR but my time to look at crawl things has been fairly stretched for a while) 14:54:28 yeah, we should document it, although another benefit of enforcing it is that it's self-documenting, in a way 14:55:33 re mess, I agree that it's less important than other things, although one notable exception is the use of *-imports 14:56:01 oh, oops, somehow missed you mentioning that 14:56:31 yeah I would actually be ok with a lint check for that one :-) 14:56:40 of course it'd fail right now 14:56:43 i am pretty sure that's a separate lint check 14:57:40 it'd be very nice if we had per-file check toggling, rather than a single list of files to ignore 14:57:51 not sure if flake8 can do that 15:02:13 oh, looks like it can, nice 15:02:34 so it should be quite easy to ignore all lint errors, and then fix one at a time, per-file if need be 15:08:13 i took a brief look at getting cpplint up and running as well, but the number of warnings it spewed out was... daunting :) 15:58:48 I decided to click the "Watch" button on the repo to see all converations 15:58:55 Sure does generate some emails! 16:00:53 heh yeah I have watch on 17:30:28 advil: thanks for the pr reviews. I honestly thought the CI addition was self-explanatory (in that it runs the checks from the makefile) 17:59:52 i think some of those smaller commits can probably be cherry-picked directly 18:06:04 aidanh: while we are talking ci checks, i would prefer using black for formatting rather than flake8. For example, this construction triggers flake8 for being too long: 18:06:04 logging.warning( 18:06:04 "Found extra top-level keys '%s' in %s, ignoring them (only 'games' key will be parsed).", 18:06:05 extra_keys, file_name) 18:06:32 to fix it, I'll have to break the string into multiple strings separated by newlines, which imo is worse 18:09:21 i'm not sure that black would think differently about that line 18:09:53 personally I think a judicious line break would be better, probably after 'ignoring' 18:10:25 er, after 'them', rather 18:13:39 alright 18:14:13 i don't think black changes the formatting of strings -- eg if you give is a 100 char string it will just whack it on a line alone as best it can 18:24:24 Unstable branch on underhound.eu updated to: 0.25-a0-713-g4845790874 (34) 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-714-gc1decc1: Fix returning user auto-login 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c1decc14dd22 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-715-g167b7eb: Simplfy 10(2 days ago, 1 file, 3+ 6-) 13https://github.com/crawl/crawl/commit/167b7ebfca09 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-716-g5b9b1c8: Improve test coverage of auth.py 10(2 days ago, 1 file, 20+ 1-) 13https://github.com/crawl/crawl/commit/5b9b1c88f1b3 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-717-g217f267: Add option to disable webtiles access logs 10(2 days ago, 2 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/217f267dcc49 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-718-g1447d36: Enhancements to webtiles game definitions 10(2 days ago, 6 files, 365+ 53-) 13https://github.com/crawl/crawl/commit/1447d36084cf 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-719-g4706367: Reduce log spam 10(2 days ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/4706367d75ea 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-720-g31e7f7e: Convert README to markdown and update 10(2 days ago, 2 files, 85+ 49-) 13https://github.com/crawl/crawl/commit/31e7f7e2d7de 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-721-gd24de6e: Allow overriding HTML templates 10(2 days ago, 11 files, 336+ 336-) 13https://github.com/crawl/crawl/commit/d24de6e60ccc 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-722-g8596415: Remove version pin from Tornado dependency (advil) 10(2 days ago, 5 files, 21+ 18-) 13https://github.com/crawl/crawl/commit/859641586a3f 18:33:07 03Alex Jurkiewicz02 07https://github.com/crawl/crawl/pull/1253 * 0.25-a0-723-g7082207: Improve some webtiles log messages 10(2 days ago, 3 files, 16+ 3-) 13https://github.com/crawl/crawl/commit/7082207ec3eb 18:33:07 ... and 11 more commits 18:53:51 rebased + addressing review