00:04:06 -!- amalloy_ is now known as amalloy 00:22:26 03gammafunk02 07* 0.25-a0-415-gda09f83: Refactor conducts for Zin's sanctuary 10(3 hours ago, 9 files, 36+ 56-) 13https://github.com/crawl/crawl/commit/da09f83f66b6 00:22:26 03gammafunk02 07* 0.25-a0-416-gd5a9e69: Apply god conducts when placing clouds 10(3 days ago, 1 file, 32+ 13-) 13https://github.com/crawl/crawl/commit/d5a9e69a944c 00:22:26 03gammafunk02 07* 0.25-a0-417-g4be4e3a: Document some cloud functions 10(3 days ago, 2 files, 48+ 0-) 13https://github.com/crawl/crawl/commit/4be4e3ae422b 00:22:26 03gammafunk02 07* 0.25-a0-418-g9db6740: Remove an unnecessary scope 10(3 days ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/9db6740682ab 00:22:26 03gammafunk02 07* 0.25-a0-419-g7650d0d: Add attack prompts for Ring of Flames and Tornado 10(9 hours ago, 2 files, 16+ 18-) 13https://github.com/crawl/crawl/commit/7650d0de7575 00:22:49 I know how a small inkling of how advil felt after tracking down all those seed bugs 00:23:36 truthfully I've been down rabbit holes like these a lot in the past; just have to go through the pain all over again with each round of bugfixing 00:38:24 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-419-g7650d0de75 (34) 01:21:50 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-2893-g14d70eb493 02:09:43 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-419-g7650d0d 02:48:30 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:17:53 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-419-g7650d0d (34) 03:31:05 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2893-g14d70eb493 04:59:18 -!- amalloy is now known as amalloy_ 07:57:55 -!- Tiobot is now known as Guest27419 09:23:00 Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3 11:23:07 Stable (0.23) branch on underhound.eu updated to: 0.23.1-91-gf373564dc4 12:40:24 Trismagistus (L9 DDFi) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1023 failed. (Sewer) 12:43:09 Skivuli (L27 GhIE) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1023 failed. (Slime:5) 12:45:52 Skivuli (L27 GhIE) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1023 failed. (Slime:5) 14:02:35 -!- amalloy_ is now known as amalloy 14:02:56 !crashlog 14:03:19 21567. Skivuli, XL27 GhIE, T:91203 (milestone): http://crawl.akrasiac.org/rawdata/Skivuli/crash-Skivuli-20200117-174550.txt 14:04:41 I got a similar one that wasn't reported here: https://crawl.xtahua.com/crawl/morgue/jt/crash-jt-20200117-140107.txt 14:06:05 plausibly related to d5a9e69a944c41b8e84ee784fb0a222127780098, but i'm not sure 14:06:54 yeah, must be. i'm not sure if it's enough to just revert that, or if the stuff after it also needs reversion 14:12:07 03amalloy02 07* 0.25-a0-420-g1cc7eeb: Revert cloud/conduct changes 10(2 minutes ago, 5 files, 35+ 99-) 13https://github.com/crawl/crawl/commit/1cc7eeb0d1c9 14:12:24 ??rebuild 14:12:24 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.kelbi.org/rebuild/ Bug gammafunk, advil, |amethyst, or Nap.Kin for CDO. Use your powers wisely. 14:13:48 !tell gammafunk i committed 1cc7eeb rather than try to fix-forward the changes. the crash is easy to repro: just read ?immo with two adjacent goblins and kill one of them 14:13:49 amalloy: OK, I'll let gammafunk know. 14:14:03 %versions 14:14:18 is that not a thing? i always forget how to see what versions the servers are running 14:15:55 it (with some prefix) used to be a thing but it does it with a !lm search which times out these days 14:16:06 er, !lg search 14:19:14 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-420-g1cc7eeb0d1 (34) 14:30:57 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-420-g1cc7eeb (34) 14:31:48 Skivuli (L27 GhIE) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1023 failed. (Zig:19) 14:36:23 TheAlmightyOne (L14 DgSk) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1023 failed. (D:14) 14:42:56 brae (L18 OgWz) ASSERT(attacker) in 'attack.cc' at line 353 failed. (Shoals:4) 14:44:41 well, that's exciting 14:44:53 !crashlog Skivuli 14:44:59 3. Skivuli, XL27 GhIE, T:103714 (milestone): http://crawl.akrasiac.org/rawdata/Skivuli/crash-Skivuli-20200117-193146.txt 14:45:52 hm, it wasn't deployed to CAO even though i ran the rebuild and it looked successful 14:46:22 wait, yes it was. this person just didn't update their save 14:48:32 !crashlog brae 14:48:41 1. brae, XL18 OgWz, T:48624 (milestone): http://crawl.berotato.org/crawl/morgue/brae/crash-brae-20200117-194244.txt 14:53:56 dunno about that one 18:22:55 Unstable branch on underhound.eu updated to: 0.25-a0-420-g1cc7eeb0d1 (34) 20:21:46 will have to fix that immolation issue 20:21:55 I tested a lot of spells but not immolation 20:22:11 immolation might just be in a weird spot conduct-wise with its new behavior 20:22:33 although I supposed fundamentally it's not a major difference 20:23:22 it seems to me that the sensible thing with immolation and god conducts is to penalize upon enchant 20:23:23 either that or we sort of just have to not apply conducts to it 20:23:33 ebering: since you changed immolation, what do you think? 20:23:56 before new immolation I'm not sure any conducts were ever applied 20:24:12 now with new immolation, the first time a monster takes a hit, a cloud is placed 20:24:38 assuming the agent is set to the player each time (which I think it is), this would give conduct upon each hit the monster takes 20:24:54 -!- amalloy is now known as amalloy_ 20:25:15 before I guess you could argue that no conduct was necessary aside from upon explosion, which only happens once per monster, at least 20:25:50 not sure if immolatable sticks to snakes turn hostile the first time they take damage 20:49:29 -!- amalloy_ is now known as amalloy 20:55:10 <|amethyst> exploding needs to be a fineff I think 21:54:01 !crash 21:54:02 21572. LostGamesStreakFreak, XL8 MfGl, T:5474 (milestone): https://crawl.xtahua.com/crawl/morgue/LostGamesStreakFreak/crash-LostGamesStreakFreak-20200117-204146.txt 22:26:11 actually seems to not be directly related to explosion; happens even if you kill a single immolated monster 22:26:38 it's just that if the monster has died and leaves a cloud upon death, tracking the conduct causes a crash 22:27:01 I think the best fix might just be to condition application on the monster being alive 22:27:41 if the monster is already dead then it doesn't make sense to apply a conduct for placing flames on their corpse 22:30:28 not sure that this shouldn't just be checked for and aborted in set_attack_conduct() 22:30:54 right now it's an assert 22:58:47 -!- amalloy is now known as amalloy_