00:03:44 -!- amalloy_ is now known as amalloy 01:16:29 !messages 01:16:29 (1/6) advil said (8h 42m 15s ago): aha thanks! Syncing from webtiles only when there's user action makes a lot of sense, and I didn't realize was the intended behavior. So the bug then is that for some reason the textbox sends state on creation (?), which is a bit different than what I thought. 01:17:41 !tell advil yes, that would be the bug, although IIRC input actions can trigger spuriously from things you wouldn't expect like focus switches 01:17:41 aidanh: OK, I'll let advil know. 01:18:28 !tell advil s/actions/events; so the best fix might be to compare the current and previous value in the input event callback and only sync to the server if they differ 01:18:28 aidanh: OK, I'll let advil know. 01:18:32 !messages 01:18:32 (1/5) alexjurkiewicz said (6h 38m 47s ago): something about ui code changed with your updates a couple of weeks ago so that the bloatcrawl game modifier code receives two events every time you press a key 01:18:35 !messages 01:18:36 (1/4) alexjurkiewicz said (6h 38m 35s ago): specifically the on_keydown_event 01:18:37 !messages 01:18:38 (1/3) alexjurkiewicz said (6h 34m 39s ago): Changing to on_hotkey_event seems to fix the issue, but you mentioned this works differently so it might not be a good fix...? 01:18:41 !messages 01:18:42 (1/2) reaverb said (4h 19m 35s ago): Sorry I haven't uploaded the catch2 stuff yet. I had to deal with a tricky compilation error, were compilation didn't work on clean install but it worked on my machine. (Some object files weren't being cleared by make clean). 01:18:53 !messages 01:18:54 (1/1) reaverb said (4h 19m 36s ago): I strongly believe I can upload a version ready to go to master by the 21st, but if you ask me to I'll immediately upload a working but hacky version. 01:21:24 !tell alexjurkiewicz the main difference is that on_hotkey runs first, before the currently focused widget (e.g. a checkbox or input widget) can handle the event; if you're implementing hotkeys (keys that always do some action), it's what you should use 01:21:25 aidanh: OK, I'll let alexjurkiewicz know. 01:21:55 !tell reaverb no worries, take your time; I'm taking a short break from crawl dev in any case due to work 01:21:56 aidanh: OK, I'll let reaverb know. 01:25:12 !tell alexjurkiewicz that event doubling behaviour is probably because you return false (event not handled) from your event handler, instead of true (event handled) 01:25:13 aidanh: OK, I'll let alexjurkiewicz know. 01:38:04 Unstable branch on crawl.develz.org updated to: 0.25-a0-292-gaa31f04 (34) 02:10:00 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-292-gaa31f04 02:57:36 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:18:53 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-292-gaa31f04 (34) 03:31:20 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2824-g6a88ae04c9 04:01:42 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-1803-g47d6a72b85 08:42:07 -!- amalloy is now known as amalloy_ 11:23:39 Stable (0.23) branch on underhound.eu updated to: 0.23.1-91-gf373564dc4 13:37:56 advil: the rddit thread is > 2 weeks old 13:37:56 alexjurkiewicz: You have 2 messages. Use !messages to read them. 13:49:41 !tell aidanh returning false was it, thanks 13:49:42 alexjurkiewicz: OK, I'll let aidanh know. 13:50:26 Where's the log for this channel stored again? I always forget 13:58:59 | Logs: http://s-z.org/crawl-dev/ | 13:59:10 in the /topic 14:42:41 alexjurkiewicz it says 2-3 weeks 14:42:42 advil: You have 2 messages. Use !messages to read them. 14:46:43 03advil02 07* 0.25-a0-293-ge69d3d4: Focus arena text input widget automatically 10(44 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e69d3d42356f 15:03:21 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-293-ge69d3d4235 (34) 15:04:50 !source cast_irradiate 15:04:50 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/spl-damage.cc#L1288 15:04:57 is `vulnerable` there correct? 15:05:05 it seems like it should be !act->is_player() 15:07:07 vulnerable appears to be that and a few other things? 15:08:44 hm, think that wants a || instead of a && since they shouldn't both be true at the same time 15:09:49 so vulnerabe would be player OR god not fedhas OR (implicit god fedhas and) mon protected by fedhas 15:10:38 I think it's !is_player, that function is used to determine whether the "really irradiate near your ..." message is printed, and it isn't working right atm 15:11:51 right, but that condition looks messed up 15:13:44 I may have its use backwards but still something seems off with the condition to begin with 15:13:54 03advil02 07* 0.25-a0-294-gea9b1ad: Fix ally warning prompt for irradiate 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ea9b1ad378ae 15:14:17 it's supposed to just find monsters that are protected by fedhas 15:14:33 er, that aren't protected by fed 15:15:32 ok, I misunderstood what you were asking, but we were seeing pretty much the same issue 15:15:46 yeah, the two conjuncts couldn't both be true 15:18:10 03advil02 07[stone_soup-0.24] * 0.24.0-42-gbb69407: Clean up some heavy-handed artefact code 10(4 weeks ago, 6 files, 71+ 66-) 13https://github.com/crawl/crawl/commit/bb69407d3799 15:18:10 03advil02 07[stone_soup-0.24] * 0.24.0-43-g08225f2: Refactor habitability checks around monster flight 10(4 weeks ago, 2 files, 12+ 12-) 13https://github.com/crawl/crawl/commit/08225f2451ea 15:18:10 03advil02 07[stone_soup-0.24] * 0.24.0-44-gfded827: Fix a wizmode / test crash on randbooks 10(4 weeks ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/fded827bd886 15:18:10 03advil02 07[stone_soup-0.24] * 0.24.0-45-g8b03bf2: Various refactoring to make expensive calls less likely 10(4 weeks ago, 5 files, 58+ 47-) 13https://github.com/crawl/crawl/commit/8b03bf275c2a 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-46-g8f3fa87: Add support for formatted_string += string 10(3 months ago, 11 files, 24+ 16-) 13https://github.com/crawl/crawl/commit/8f3fa87f57b3 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-47-g573b442: Add support for formatted_string + string 10(4 weeks ago, 2 files, 30+ 2-) 13https://github.com/crawl/crawl/commit/573b442d14fe 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-48-gd133872: Set initially focused widget from run_layout() 10(4 weeks ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/d133872a1675 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-49-geea39dc: Fix string_wrap removing trailing empty segments 10(4 weeks ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/eea39dc89d89 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-50-ge1b011c: Fix run_layout() clearing default focus 10(4 weeks ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/e1b011c67567 15:18:10 03Aidan Holm02 {advil} 07[stone_soup-0.24] * 0.24.0-51-gf19f330: Remove/mark unused parameters 10(7 weeks ago, 173 files, 762+ 821-) 13https://github.com/crawl/crawl/commit/f19f3306e9e7 15:18:10 ... and 72 more commits 15:18:26 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-294-gea9b1ad378 (34) 15:20:05 (that is fairly extensive because I backported enough UI stuff to 0.24 so that the new seed input dialog could be used) 15:28:30 commits I wasn't sure about: 379fad0a3, da8bd6cf831 15:28:34 %git 379fad0a3 15:28:34 07ebering02 * 0.25-a0-176-g379fad0: Extend Fedhas protection to collisions (12082) 10(3 weeks ago, 2 files, 59+ 14-) 13https://github.com/crawl/crawl/commit/379fad0a35f2 15:28:40 %git da8bd6cf831 15:28:40 07AdamPG02 {ebering} * 0.25-a0-108-gda8bd6c: Make the Warlock's Mirror's reflection chance scale as intended 10(5 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/da8bd6cf8310 15:29:20 Coo, that's a corker 15:30:04 it looks from the timing like both of these got skipped on a previous cherry-picking pass, but they're both bugfix-ish enough that I would have been inclined to include them I think 15:30:42 I also did include the wand AI fix that also appears to have been skipped 16:37:25 https://www.reddit.com/r/dcss/comments/eawmyb/release_automatic_pillar_dance_script/ 16:39:21 gmarks: is this yours? 16:39:28 removing clua should fix crawl's luring problems 16:49:01 gmarks (L5 DrWn) Crash caused by signal #15: Terminated (D:4) 17:03:15 -!- amalloy_ is now known as amalloy 17:28:09 While I was doing my ranged reform stuff for my fork; I noticed there are a lot of vaults that use stones just for decoration. I'd like to suggest something along those lines. A "Decor" item class that has no practical purpose but can be used to vary the terrain a bit and/or spice up some vaults. "You see some rubble here." "You see some broken 17:28:10 manacles." etc. non-useful stuff on the floor that's just there to make the dungeon feel more full. Fountains kind of already are like this... 18:05:50 alexjurkiewicz, yeah that's my script 18:06:04 !crashlog gmarks 18:06:10 1. gmarks, XL5 DrWn, T:4874 (milestone): https://crawl.kelbi.org/crawl/morgue/gmarks/crash-gmarks-20191215-214846.txt 18:08:17 Interesting 18:08:41 Maybe i should use a queue instead of recursion for floodfill, I have a feeling thats causing problems 18:11:29 player lua has both time and memory limitations 18:16:43 It should be pretty low in terms of time cost, on local a pillar search takes worst case ~3 seconds 18:16:59 I could probably optimize for memory more by not recursing so much thoufh 18:22:50 Unstable branch on underhound.eu updated to: 0.25-a0-294-gea9b1ad378 (34) 19:23:20 Stable (0.24) branch on underhound.eu updated to: 0.24.0-123-gd5b16e6ec5 20:37:22 *confused and annoyed* how does the bridge between the webserver-unique javascript and the core game's C++ work? 21:59:49 gmarks uh 3s of solid lua computation is *extremely* cpu heavy 22:00:11 that's actually comparable or worse to the clouds in desolation that everyone used to complain about 22:00:43 I wouldn't run something like that on someone else's server without explicit permission... 22:53:27 advil, message received; I'll optimize it.