00:52:12 -!- amalloy_ is now known as amalloy 01:37:44 Unstable branch on crawl.develz.org updated to: 0.25-a0-167-g836c352 (34) 02:08:20 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-167-g836c352 02:58:41 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:16:16 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-167-g836c352 (34) 03:30:57 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2777-g6b872f2bae 04:25:05 New branch created: pull/1212 (1 commit) 13https://github.com/crawl/crawl/pull/1212 04:25:05 03sdynet02 07https://github.com/crawl/crawl/pull/1212 * 0.25-a0-167-ge4edfe3: Ely's Divine Protection always protects at 120 piety. 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e4edfe322532 04:50:12 !tell floraline my fork seems to be a few days behind; is it failing to compile for webtiles or something? 04:50:13 Bcadren: OK, I'll let floraline know. 04:51:22 I'm about to head to sleep for a bit here; but anyone with CKO permissions can try to kick it off and !tell me if there's an error to let me know what is it...or just !tell me so I know there isn't an error or something. 07:32:16 Gozag's bribe information is not displayed. 13https://crawl.develz.org/mantis/view.php?id=12137 by sdynet 08:30:02 03Aidan Holm02 07* 0.25-a0-168-gf1674c6: Fix webtiles chat not responding to mouseclicks (12136) 10(22 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/f1674c61360c 08:32:42 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-168-gf1674c6136 (34) 08:37:23 Hey, I'm working on that poison status icons PR. Aidan pointed out that I hadn't implemented the webtiles side yet. I think I have that done now, but I'm not sure how to build/run webtiles to test it. 08:38:01 I'm on a windows computer doing the MSYS build instructions, which is successfully building local tiles at least. 08:38:45 Is there instructions somewhere I'm missing on how to run webtiles? Or could one of you give me some pointers? 08:39:24 pblur: There was a pretty extensive discussion of this not too long ago in #dcss-variants on Discord. 08:39:36 Ah, I'll look there. Thx! 08:40:29 IIRC there was a recommendation for an X server to use and a suggestion that you might be able to run local webtiles under WSL. 08:48:49 pblur to run webtiles on windows you will need to use WSL or linux in a VM, it does not work under MSYS2 08:51:52 Maybe it's time for me to start playing with Linux again then; do any of you have VMs that you currently use and would recommend? 08:55:26 I'm on mac so it's different, but I use virtualbox to run windows and docker to run linux 08:55:31 I have heard that WSL is pretty good 08:55:50 and doesn't need a VM 08:58:11 pblur: if you can use WSL, that's probably easiest, since you can install a recent ubuntu from the windows store 08:58:35 OK, thx. That sounds more straightforward 09:12:43 pblur: btw, apart from needing to build crawl for webtiles, you'll need to install tornado and run the `webserver/server.py` script 09:13:10 OK. I'll keep that in mind. 09:13:46 Currently updating my ubuntu packages; WSL installation was far, far smoother than I expected. 09:13:49 you might want to create a virtualenv, and there's no requirements.txt, but the only package you should need is tornado; i have version 3.2.2 09:15:48 the two files you'll need to modify are enums.js and cell_renderer.js 09:18:33 Ah, good. Those are the two I modified. 09:19:14 I noticed also that the most recent addition to the foreground tiles (possessable) was also only added to local tiles (with no mention of why in the commit message.) 09:19:31 Should I remedy that and make a second PR for it? 09:20:03 man why are ttyrecs just named with a timestamp, who did this 09:23:50 pblur: that would be great, yes, looks like I forgot it at the time... 09:23:51 kk 09:24:04 !blame aidanh 09:24:05 I pronounce aidanh... Guilty! 09:26:15 hm, that pr to add monster difficulty tiles is still waiting for webtiles versions too 09:27:57 I could probably figure out how to pull that and make a separate PR crediting GnarledBeach if you want. 09:28:27 I'm not sure what the right way to handle that is, but it's pretty simple to actually do. 09:31:25 if you're interested, go for it 09:32:22 kk 09:32:54 First to get this webtiles testing working. 09:41:54 03Aidan Holm02 07* 0.25-a0-169-g5296520: Show sprint help for sprint menu help button (GH #1203) 10(2 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/529652008a4a 09:42:43 So, when making local tiles I have to specify the make flag TILES=y. Is there an equivalent for webtiles? 09:42:50 WEBTILES=y 09:43:04 OK. That's nice and consistent. 09:43:12 pblur: check out webtiles/README 09:43:21 Oh THNX! 09:43:55 I had no idea where the docs were on this. 09:44:17 it's not a very long doc but it should give you the basics to get a local testing webtiles server running 09:44:27 you need some specific (old) tornado versions too, that that specifies 09:45:11 webserver/README if you'll forgive me saying so 09:45:22 ah true 09:45:45 you also might want to set no_cache = True and autologin = "some-username" in config.py 09:47:58 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-169-g529652008a (34) 09:50:06 03Aidan Holm02 07* 0.25-a0-170-g0adb1ba: Add webtiles dev option note to readme 10(37 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/0adb1bad81c4 10:00:19 "byrel@S05-L:/mnt/c/play/myCrawl/crawl/crawl-ref/source$ sudo make WEBTILES=y 10:00:19 unexpected (expecting "then")" 10:01:04 Is that an error any of you are familiar with right off? 10:01:21 configure is a shellscript with nothing on line 2. 10:02:45 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-170-g0adb1bad81 (34) 10:03:06 Why "sudo" make? But let's have a pastebin of the whole thing. 10:03:43 That is the whole thing. And sudo because I was lazy and trusting and didn't look up the chmod options to make the source directory user writable 10:05:16 https://pastebin.com/wid3itDm 10:05:21 That's after a make clean 10:05:24 Well, try with make -d (and without sudo) 10:05:29 OK 10:05:47 OK, that wasn't even _remotely_ the whole of the output 10:06:26 The pastebin was after a make clean. The copy paste here was not 10:06:57 How did you know to look in "configure" if the output was only "unexpected (expecting "then")" ? 10:07:42 Maybe somethings not showing up the same for you. I see 6 lines of output that I pasted into this chat. 10:08:11 "byrel@S05-L:/mnt/c/play/myCrawl/crawl/crawl-ref/source$ sudo make 10:08:11 WEBTILES=y 10:08:11 unexpected (expecting "then")" 10:08:32 Yeah, I see like 4 more lines in here 10:08:41 Not sure what the difference is. 10:09:42 https://pastebin.com/47CMr6sR 10:09:50 This pastebin still looks mangled. Could you build it with TILES=y ? Without tiles? 10:10:00 <|amethyst> carriage returns 10:10:01 |amethyst: You have 2 messages. Use !messages to read them. 10:10:23 <|amethyst> you update the cheibriados you are running with 10:10:27 <|amethyst> doh 10:10:27 |amethyst: You have 1 message. Use !messages to read it. 10:10:54 No, it's the same issue regardless of tiles/no tiles/webtiles 10:11:10 <|amethyst> !tell advil saw your message about Chei, but no time at the moment, sorry :( 10:11:11 |amethyst: You have 1 message. Use !messages to read it. 10:11:11 |amethyst: OK, I'll let advil know. 10:11:25 Probably right about carriage returns, though - was the tarfile extracted under WSL? 10:12:02 <|amethyst> is this a tarball or a git checkout? 10:12:11 No, this is the same checkout I was developing on in windows previously. 10:12:14 git checkout. 10:12:27 |amethyst it's in the copy of chei under the crawl git org 10:12:27 in /mnt/c/... 10:12:27 advil: You have 2 messages. Use !messages to read them. 10:13:23 I can do a fresh checkout in WSL if anyone thinks that's likely to affect the problem. 10:13:35 |amethyst it's not very important, just trying to cut down on commit spam :-) 10:13:49 I think that's very likely and |amethyst has hit on it 10:14:00 OK. 10:14:44 <|amethyst> I forget the option to change that 10:14:52 <|amethyst> maybe this: https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings 10:15:10 <|amethyst> advil: I think my password on that machine expired? It might be a while :) 10:15:22 <|amethyst> advil: or I'm trying to log into the wrong machine maybe :) 10:15:45 haha ok...the logs show up on s-z.org? 10:16:01 <|amethyst> advil: thanks for the work on CAO disk space and scoring btw 10:17:08 <|amethyst> advil: found it, I was logging into the wrong machine :) 10:17:16 no problem, glad to be able to get some improvements there 10:23:12 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to a pastebin service, please. 10:23:16 <|amethyst> there we go 10:23:26 -!- The topic of ##crawl is: Play Dungeon Crawl Stone Soup online now! Type ??servers for instructions. | http://crawl.develz.org | FooTV: http://termcast.develz.org - ??footv for instructions | See also ##crawl-offtopic 10:23:30 <|amethyst> my branch was literally just the one commit to change the config, so rebased easily 10:23:49 <|amethyst> also, I have apparently gotten rusty with git 10:25:29 now we just need someone to push to their giant PR branch to see if I tested that adequately 10:25:35 my perl is really incompetent 10:28:45 I guess there are no current PR/repo branches that meet the conditions 10:28:45 push a bunch to a PR branch you say? 10:28:45 haha...I think because it's a draft that branch hasn't created a full PR branch 10:28:48 it has 10:28:54 it doubles in the logs 10:29:01 ah ok 10:29:06 well, maybe not any more! 10:30:48 OK, that git configuration article and a refetch fixed that issue. Thanks, I'd have been a long time figuring that one out. 10:30:52 ah yes I do see the ref 10:31:11 pblur while you've refetched, you should do whatever it takes to not do "sudo make" 10:31:19 I did already 10:31:22 Thx 10:31:22 because that will inevitably wreck permissions even further 10:32:41 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-171-g9513415ccb (34) 11:12:40 |amethyst augh I messed up the repo uri config for chei (changed how it worked, but forgot to change the default value), could you pull again 11:13:36 https://github.com/crawl/cheibriados/commit/38ebbae6a9687243aa05dab5bfb4b8da7bc203f9 11:14:41 I was testing on a different repo :-/ 11:16:49 The build was broken. (master - 9513415 #12291 : advil): https://travis-ci.org/crawl/crawl/builds/616734175 11:18:32 i've not had enough time to flesh this out as much as i'd like to, but the initial mod design writeup is here: https://github.com/crawl/crawl/wiki/DCSS-Mods 11:18:41 should showcase the general idea 11:19:14 alexjurkiewicz, Pinkbeast, you might be interested ^ 11:19:31 Mmm, taking a peek 11:19:50 We were just having a chat about 0.23 features, this'll make a change 11:22:45 Stable (0.23) branch on underhound.eu updated to: 0.23.1-91-gf373564dc4 11:24:54 aidanh: we'll have to put you on trial in the Court of DCSS, the charge is deviation from trunk, with a penalty of 27,000 years in the abyss 11:25:13 but don't worry, I'll be your court-appointed defense lawyer, and I think we can beat the case 11:26:12 aidanh: On a quick glance, I suspect some of the more complex changes aren't going to fit into this framework (eg by the time it can do our permabuffs you've basically reimplemented the whole thing to give us hooks to call) _but_ nevertheless it seems like a good idea, there are plenty of things that would fit into that format just fine 11:28:02 I think that's related to non-goal 1 11:28:47 aidanh: not sure this would prevent "splintering", but I also don't think splintering is a big worry any time soon 11:29:06 Oh, indeed, but permabuffs are one of the examples below. (I think Hellcrawl-style ones might be doable) 11:30:50 bcrawl might be splintering things a bit 11:31:07 !tell |amethyst augh I messed up the repo uri config for chei (changed how it worked, but forgot to change the default value after testing on a different repo), could you update again? 11:31:08 advil: OK, I'll let |amethyst know. 11:32:07 I also don't think splitering is any particular concern, not one that's necessarilly well-defined 11:32:51 but the project seems a good idea if aidanh wants to put the work into it 11:32:51 s/not one/nor one/ 11:33:30 for scoring we should probably be clear that we're not proposing to score fork games on the same official servers that we use presently (CAO and Sequell) 11:33:58 the code those servers run certainly can be modified to better support forks, though, as could the logfile/milestone formats, within reason 11:34:12 gammafunk: ruh roh 11:34:24 :) 11:34:36 gammafunk: yeah I figured others would have a better idea about the scoring situation, but that seemed like a likely solution 11:35:10 I'm guessing that "scoring" section is written partially with reference to just the regular score files that crawl generates (since seeded games aren't yet scored online either) 11:35:37 Being able to add a new kind of milestone in a mod would be useful (albeit we have only done that for the ghosts which I suspect are beyond the scope of these mods) 11:38:11 ah, I was under the impression that they were scored separately; shows how much I know heh 11:38:11 they are scored separately in that a separate logfile / high score file is written 11:38:28 I do plan on adding some form of online scoring for seeded games to cao 11:38:42 but I've ended up in too many other cao-related rabbit holes lately to get to that yet 11:40:14 right, fair enough 11:40:39 Pinkbeast: in what way do hellcrawl's permabuffs differ? 11:41:31 aidanh: They're kind of "one size fits all" - take maximum MP (a quantity dependent on spell failure rate), last forever, no ongoing MP regeneration cost (or hunger, since there's no food) 11:42:43 ah, right, and stoat soup's are more finely tuned with per-buff effects 11:42:47 Each of ours has a bit of spell-specific code so we're back to "for us to make this a mod, you'd have to implement a bunch of hooks", but Hellcrawl's aren't. 11:43:10 right 11:43:32 Finely tuned is a nice way of saying pointlessly overcomplicated :-) 11:43:44 well hopefully it'll be possible to implement hooks that are broadly useful for a wide range of mods 11:44:16 e.g. the proposed traverse-level-before and -after hooks 11:44:49 !tell bcadren i'll take a look tonight if i have time. fwiw a production server is not the right place to test if your code compiles, it's much easier to debug the errors if you build it yourself 11:44:49 floraline: You have 1 message. Use !messages to read it. 11:44:50 floraline: OK, I'll let bcadren know. 11:44:58 I'd be looking at doing FD, HE, MD, Og apts, non-boring food, our re-added unrands, the stuff you list other than permabuffs, just off the top of my head 11:45:36 floraline: I've been trying to persuade bcadren to set up to build local webtiles for ages :-/ 11:48:21 Speaking of... local webtiles testing is now running! It was less painful than I expected. 11:48:43 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1209 * 0.25-a0-112-g22e5af3: Added webtiles support for poison stack display 10(4 minutes ago, 3 files, 11+ 1-) 13https://github.com/crawl/crawl.git/commit/22e5af3e8169 11:48:53 Thanks for the help 11:49:22 pblur: Glad to hear it's working 11:55:21 advil: looks like chei has some broken links 11:56:00 Oh, and vaults being in there's good, we've got some vault stuff planned if C ever gets off her arse and does it 11:56:02 yeah, that's the !tell I just sent |amethyst 11:56:21 ah alright 11:56:37 is the PR spam reduction in place otherwise? 11:57:04 yeah, I'm not entirely sure if chei will be fetching with the bug I introduced 11:57:07 Pinkbeast: yeah, Og apts and FD are my initial milestones 11:57:23 I guess if that commit came through then it must be 11:57:30 not sure about the vault stuff yet, mostly because I don't work with that part of crawl at all 11:57:47 aidanh the links just have a spurious ".git", if you need to fix one 11:58:13 advil: right, thanks 11:58:33 perl strikes back huh 11:58:44 not sure how neil would feel about it, but if he doesn't have a lot of time for maintenance stuff, we could certainly host chei on another server like cdo or cao 11:59:42 that would let us support monster lookup for some more recent old version, but introduces the problem of getting binaries back to 0.9, which Cheibriados's server (is it s-z.org?) currently does have 11:59:49 %?-version 11:59:49 Monster stats Crawl version: 0.18.1-8-gdd0e5ea 11:59:53 %??-version 11:59:53 Monster stats Crawl version: 0.20-a0-733-gf92fd71 12:16:56 pblur: minor problem; seems like I always see at least two pips of poison 12:17:44 Odd. I was seeing all three states here. I'll try rechecking out that branch and rebuilding. 12:20:56 !source attack.cc:1415 12:20:56 https://github.com/crawl/crawl/blob/master/crawl-ref/source/attack.cc#L1415 12:21:38 that almost always rolls a number >= 7 12:21:43 !source monster::poison 12:21:44 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/monster.cc#L4162 12:22:16 which would then get rounded up to 2 here 12:27:10 Oh, so you were actually getting 2 stacks I see 12:27:15 I was testing with OTR 12:27:42 Which generally applies one stack at a time (for 10 aut actions.) 12:28:37 ah, right, I see that 12:29:01 this is from a dagger of venom 12:29:41 Right, a venom brand almost always does a couple stacks if it does any. Part of why random daggers of venom are so strong early game 12:31:47 yeah, makes sense 12:32:50 this looks pretty good; I'll give it a closer look tomorrow and merge it then 12:33:33 (y) 12:38:03 03Aidan Holm02 07* 0.25-a0-172-g4f669b7: Simplify some local tiles code 10(3 months ago, 6 files, 9+ 15-) 13https://github.com/crawl/crawl.git/commit/4f669b765a44 12:38:03 03Aidan Holm02 07* 0.25-a0-173-g1a393a3: Tidy up tilesdl.cc a bit 10(3 months ago, 1 file, 14+ 20-) 13https://github.com/crawl/crawl.git/commit/1a393a3f0527 12:41:21 aidanh: hearing reports that items are not getting colored until you x-v them; e.g. if you can't wear a helmet, it won't be darkgrey until you cursor over it 12:43:09 apparently this started shortly after tournament ended 12:45:07 gammafunk: i'll take a look 12:47:39 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-173-g1a393a3f05 (34) 12:52:46 yeah, moving chei might make sense; one issue about moving chei is that I suspect the log viewer is actually pretty bandwidth intensive 12:53:16 as far as I understand it the way that search works is that it downloads all logfiles and runs the search in javascript 12:53:35 in your browser 12:53:39 (that's why it's kind of slow) 12:54:45 oh 12:55:14 yeah, didn't even think about the dev log viewer 12:59:16 gammafunk: I can't seem to reproduce that, got any screenshots or more info? 13:00:04 there might be things out there that aren't hand-rolled irc log viewers from 2005 that don't work like that 13:03:12 though some quick google searches are not actually turning up much that looks like it would be a good idea to use 13:03:34 aidanh: I had that issue when testing the positional spells branch a few days ago. I was on an Op, and whenever I found an aux slot that I couldn't wear it the 'a helmet comes into view' message wouldn't mark the 'helmet' as dark gray. 13:03:55 I went to try to pick up the helmet a couple of times without thinking because of that 13:05:12 oh, I wonder if that explains why I kept trying to pick up armour on my dr in that branch 13:06:26 aidanh: compare https://cdn.discordapp.com/attachments/205316046230388737/648585007237038100/unknown.png to https://cdn.discordapp.com/attachments/205316046230388737/648585163676057650/unknown.png 13:06:38 the found message doesn't respect highlight like the x-v look does 13:06:48 this seems to be happening for any kind of item highlight 13:09:15 aidanh uh does the seed selection menu actually work on local console? 13:09:19 I like the design though :-) 13:09:28 oh duh 13:09:35 maybe start with the text box focused 13:11:01 gammafunk: you mean the "Found a scroll labelled foo" should be highlighted, or greyed out if it's useless, but it's not? 13:11:13 advil: :) yeah, that's a good idea 13:12:50 yeah, I can replicate this highlighting bug too, I see the bug on 0.24 locally so it probably wasn't after tournament that it started 13:13:18 advil: well a bunch of commits were cherry-picked after tournament 13:13:29 this is 0.24.0 13:13:32 ah ok 13:16:52 aidanh for another example of what changed see the way armour is shown to a felid in trunk https://www.dropbox.com/s/mkno5hl2r78s0ge/Screenshot%202019-11-25%2013.13.56.png?dl=0 vs 0.23.2 https://www.dropbox.com/s/aby44esac5gyrmj/Screenshot%202019-11-25%2013.15.45.png?dl=0 13:17:31 aidanh to replicate you can use a felid with seed 1 in current trunk and dismiss all monsters, there's a ring mail right away on the autoexplore path 13:17:57 ah I see 13:18:21 I swapped the version #s there 13:18:50 the second is trunk, the first is 0.23.2, and it's a leather armour that's easy to get to in seed 1 trunk 13:19:03 yep, found it 13:19:15 thanks, should be straight-forward enough to find now 13:31:38 New branch created: pull/1213 (1 commit) 13https://github.com/crawl/crawl.git/pull/1213 13:31:38 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1213 * 0.25-a0-172-g2d3d2c0: Added webtiles support for Possessable icon (Yred enslave soul status) 10(3 minutes ago, 2 files, 6+ 0-) 13https://github.com/crawl/crawl.git/commit/2d3d2c0b4ae2 13:39:42 The build is still failing. (master - 1a393a3 #12293 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/616800404 13:42:38 03ebering02 07* 0.25-a0-174-gbad95dd: Convert summon damage dismissal into a fineff (12082) 10(3 minutes ago, 3 files, 39+ 1-) 13https://github.com/crawl/crawl.git/commit/bad95dda2c2c 13:43:37 03ebering02 07* 0.25-a0-175-g3835771: Checkwhite 10(15 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl.git/commit/3835771c0716 13:50:13 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-175-g3835771c07 (34) 13:54:52 final stats on the db reload: Done processing 5.880GB from 11203808 lines; 43 lines/s in 2 days, 22:43:53 13:55:08 2 days isn't that bad 13:55:24 this is with no milestone reading 13:55:36 which I imagine added a huge overhead 13:56:21 should my player page be updated by now, or is that part still happening? 13:57:09 still happening 13:57:14 it takes forever 13:59:03 I have no idea what order it's going in either 14:00:19 Is it important to keep the flag values in tile_flags (tile-flags.h) the same for save compatibility? Or is that strictly a display enum? 14:02:34 I'm swapping the poison to use only 2 bits, and I can either use the existing bit 0x0000000000800000 and one new one 0x1000000000000000, keeping all existing flag values the same (but having a disjointed 'poison' sub-string), or renumber the existing ones down to put the poison bits adjacent to each other.. 14:02:54 In either case, I'll update the webtiles enums.js to match. 14:10:13 it looks sorta like they're not saved, but it's hard to say for sure 14:10:34 man that bitfield is a mess 14:10:34 I also suspect they aren't saved, but it's just a suspicion 14:11:10 incredibly there is only one reference to tile_flags in the entire codebase. all the other flags are just looked up by name and treated as integers 14:11:53 I can only find commits that add to the end, but that doesn't mean much 14:15:54 Yeah... that was about what I found too. 14:16:06 Guess I'll just play it safe and go with non-contiguous bit field 14:16:17 It's only slightly less readable 14:24:09 advil: some bad news, I still have duplicate games listed: http://crawl.akrasiac.org/scoring/players/gammafunk 14:24:20 unless that will be ongoing as it processes entries? 14:24:43 see games #58 and #59 14:35:42 !lg :gammafunk won 14:35:43 115. gammafunk the Slayer (L27 DsWn of Trog), escaped with the Orb and 3 runes on 2019-03-17 00:12:43, with 1532621 points after 89086 turns and 5:19:28. 14:36:13 lol how did this do anything at all 14:36:36 for reasons I haven't yet discerned it worked on the streak calculations, but yeah, there are still duplicate games galore 14:36:56 interestingly it's listed game count is only off by one 14:37:17 but it shows many duplicates 14:37:17 I think this state I can fix without rebuilding the db again 14:37:17 unless the streaks do turn out to be wrong 14:38:42 !lg . nawn won 14:38:44 1. gammafunk the Slayer (L27 NaWn of Makhleb), escaped with the Orb and 3 runes on 2016-09-21 05:31:11, with 1615498 points after 82724 turns and 8:18:14. 14:40:58 ohhh 14:41:06 crap, forgot how it doesn't count experimental wins 14:41:20 well the numbers make sense to me now, at least 14:41:31 !lg . won experimental 14:41:32 5. gammafunk the Slayer (L27 BaNe of Ashenzari), escaped with the Orb and 3 runes on 2016-10-09 05:59:51, with 1397009 points after 113149 turns and 10:30:07. 14:45:18 03ebering02 07* 0.25-a0-176-g379fad0: Extend Fedhas protection to collisions (12082) 10(4 minutes ago, 2 files, 59+ 14-) 13https://github.com/crawl/crawl.git/commit/379fad0a35f2 14:45:46 I seriously do not understand how this even worked 14:45:55 but the streak leaderboard seems ok? 14:46:16 what happened was that I accidentally applied the unique constraint to only one table 14:46:47 it seems ok from what I can remember 14:49:07 unfortunately I don't think I can safely stop the daemon until the player page generation is done 14:53:31 The build was fixed. (master - 3835771 #12296 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/616827320 15:03:20 I guess this is a testament to how weird the scoring streak calculation is 15:03:21 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-176-g379fad0a35 (34) 15:03:47 that it somehow was affected by a basically unrelated table 15:07:37 hm, I guess part of what is going is that at some point in the history of the old db, the cjr logfiles were read again under different names (and not in sync with contemporary games), so there were quadrupled games 15:07:49 so the db reload would fix that no matter what 15:08:39 and the way streak_breaks works would naturally prevent duplicates 15:08:56 *streak_breakers 15:11:05 ah, and I bet streak calculation uses strict time comparison so that games with exactly the same times will be excluded, so that's why streak length came out ok 15:22:47 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1209 * 0.25-a0-113-gfce72ca: Consolidated poison flags to 2 bits. 10(2 minutes ago, 4 files, 32+ 21-) 13https://github.com/crawl/crawl.git/commit/fce72ca40521 15:43:52 The build passed. (master - 379fad0 #12297 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/616852064 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-161-g5cc7f03: Generalize and rename targeter_los 10(60 minutes ago, 10 files, 26+ 26-) 13https://github.com/crawl/crawl.git/commit/5cc7f03332af 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-162-gb29767a: Use targeter_radius hitfuncs for friendly fire checks 10(10 minutes ago, 1 file, 9+ 29-) 13https://github.com/crawl/crawl.git/commit/b29767a9db8c 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-163-ga4ce3cf: fixup! Positional magic ⭐️: Rename and revise Dazzling Spray 10(6 minutes ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl.git/commit/a4ce3cf38b62 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-164-g982aae8: fixup! Positional magic 🔥: New Fire spell: Starburst 10(5 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl.git/commit/982aae81ccfd 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-165-ga23d01d: fixup! fixup! fixup! fixup! Positional magic ❄️: New Ice spell: Hailstorm 10(5 minutes ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl.git/commit/a23d01d914ee 16:04:49 03ebering02 07[positional-magic] * 0.25-a0-166-ge751876: fixup! fixup! Positional magic ⭐️: New Iskenderun's Mystic Blast 10(4 minutes ago, 1 file, 7+ 2-) 13https://github.com/crawl/crawl.git/commit/e751876f7769 16:04:53 Branch pull/1200 updated to be equal with positional-magic: 13https://github.com/crawl/crawl.git/pull/1200 16:10:14 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1209 * 0.25-a0-177-g8e04bb2: Add tiles and plumbing to display monster poison level as a debuff icon. 10(3 days ago, 9 files, 31+ 1-) 13https://github.com/crawl/crawl.git/commit/8e04bb25e9e8 16:10:14 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1209 * 0.25-a0-178-ga70c81e: Added webtiles support for poison stack display 10(4 hours ago, 3 files, 11+ 1-) 13https://github.com/crawl/crawl.git/commit/a70c81e3ef5b 16:10:14 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1209 * 0.25-a0-179-gb4d48b3: Consolidated poison flags to 2 bits. 10(4 minutes ago, 4 files, 32+ 21-) 13https://github.com/crawl/crawl.git/commit/b4d48b394c1e 16:11:21 advil: it worked! 16:14:59 nice 16:15:04 now if only the links weren't broken 16:26:49 Experimental (positional-magic) branch on crawl.kelbi.org updated to: 0.25-a0-166-ge751876f77 16:29:44 aidanh: sounds really cool. I am a big fan! Would the goal be to slowly move all game logic into Lua? So eventually there is an empty game engine and a 'base' mod? 16:33:06 it sounds like a good project to be prototyped with some corner of the codebase. Like, implementing it for backgrounds, then see if fork authors pick it up 16:33:26 One problem socially could be that you have to wait for the next generation of forks to arrive, since only bloatcrawl2 tracks master AFAIK 16:50:43 other use cases: the bloatcrawl game modifier screen, dcss-ca level 27 cap removal 16:56:26 03gammafunk02 07* 0.25-a0-177-gd145f35: Fix spell colors for Divine Exegesis 10(24 minutes ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl.git/commit/d145f35b4e07 17:00:23 did Cheibriados change recently? these recent messages point to crawl/crawl.git instead of crawl/crawl, and the links don't work for me 17:00:33 amalloy yes, I broke it 17:02:02 on the plus side it doesn't duplicate PRs made on main repo branches any more! 17:02:07 the fix is in the chei repository, just need neil to be available to update it again 17:03:25 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-177-gd145f35b4e (34) 17:07:24 oh, that's nice 17:27:31 03ebering02 07[positional-magic] * 0.25-a0-167-g39bbbe4: fixup! fixup! Positional magic 🔥: New Fire spell: Starburst 10(23 minutes ago, 3 files, 29+ 6-) 13https://github.com/crawl/crawl.git/commit/39bbbe4accf6 17:27:31 03ebering02 07[positional-magic] * 0.25-a0-168-g97cf186: fixup! fixup! fixup! fixup! fixup! Positional magic ❄️: New Ice spell: Hailstorm 10(22 seconds ago, 3 files, 24+ 2-) 13https://github.com/crawl/crawl.git/commit/97cf18668a9a 17:27:36 Branch pull/1200 updated to be equal with positional-magic: 13https://github.com/crawl/crawl.git/pull/1200 17:34:58 Experimental (positional-magic) branch on crawl.kelbi.org updated to: 0.25-a0-168-g97cf18668a 17:56:15 03ebering02 07[positional-magic] * 0.25-a0-169-gfc8e710: Positional magic 💀: Revise Corpse Rot (CanOfWorms) 10(4 minutes ago, 3 files, 17+ 19-) 13https://github.com/crawl/crawl.git/commit/fc8e71051a4a 17:56:20 Branch pull/1200 updated to be equal with positional-magic: 13https://github.com/crawl/crawl.git/pull/1200 18:00:59 Experimental (positional-magic) branch on crawl.kelbi.org updated to: 0.25-a0-169-gfc8e71051a 18:22:15 Unstable branch on underhound.eu updated to: 0.25-a0-177-gd145f35b4e (34) 18:23:02 New branch created: pull/1214 (1 commit) 13https://github.com/crawl/crawl.git/pull/1214 18:23:03 03Byrel Mitchell02 07https://github.com/crawl/crawl.git/pull/1214 * 0.25-a0-172-g7b30f65: Add threat level indicators for monsters 10(3 minutes ago, 13 files, 88+ 0-) 13https://github.com/crawl/crawl.git/commit/7b30f65882ff 18:25:46 Now with webtiles support 18:26:25 I picked enum values that won't collide with either the possessable or poison webtiles PRs I have open 18:26:48 All three of them put together do use up the rest of the enum slots. 18:27:06 Until save compat is broken 18:27:22 (Or someone refactors it into multiple enums.) 18:33:32 03gammafunk02 07* 0.25-a0-178-gc9f82b1: Allow Divine Exegesis without a memorized spell (12129) 10(7 minutes ago, 3 files, 16+ 5-) 13https://github.com/crawl/crawl.git/commit/c9f82b128835 18:37:40 nice! 19:07:31 aidanh: i'm trying to merge your UI event handling refactor into bloatcrawl and seeing errors like: 19:07:34 newgame.cc:779:16: error: no member named 'on' in 'ui::Text' 19:07:35 prompt_ui->on(Widget::slots.event, [&](wm_event ev) { 19:07:38 newgame.cc:779:27: error: 'slots' is a private member of 'ui::Widget' 19:07:40 prompt_ui->on(Widget::slots.event, [&](wm_event ev) { 19:07:43 newgame.cc:779:44: error: unknown type name 'wm_event' 19:07:44 prompt_ui->on(Widget::slots.event, [&](wm_event ev) { 19:08:07 we're merging from e29c8f235819f37de9bcaac210d7de67c75c1ce5 to HEAD 19:09:57 can you help understand how to use the new event handling system? I guess it's related to changes in 65a924605436f0f80ad29b65c3f7d9c230610638 and b87a47e8d26d4386b92e23caad741a5c8bc2a6d1 ? 19:14:25 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-178-gc9f82b1288 (34) 19:26:27 -!- cjm_ is now known as cjm 19:57:04 -!- bh_ is now known as bh 20:02:02 I've installed Debian via WSL to get local webtiles builds and ran into this. I know the error isn't in anything I've edited fork-wise so...any idea what's wrong before I just try codediving in to look? https://hastebin.com/asipobicew.txt 20:07:46 Bcadren: the error message says "If you experience any problems building Crawl, please take a second look at INSTALL.txt: the solution to your problem just might be in there!". that would be the first place to start; i've certainly forgotten steps in the past when building for the first time on a new computer 20:08:42 Wise Wolf thinks it's an issue caused by cloning the repo on windows and trying to build with linux (windows-style line endings issue) so I'm going to try a fresh clone in a second. 20:09:34 that sounds plausible. i'd suggest installing git under WSL and cloning with that. you don't want any windows stuff "infecting" your repo 20:13:56 floraline: I've got a big get ready to merge rebase of positional magic put together, could you wipe the experimental of old saves? they will be broken by the rebase probably 20:14:05 alexjurkiewicz: ^ 20:14:35 If not it's probably ok, I'm getting close enough to merge ready 20:16:25 guess put aside my *huge* *flavor* *rewrite* of the fedhas ghoul vault in order to make bvc 2.0 20:17:57 s/guess put/guess I have to put/ 20:27:45 floraline: alexjurkiewicz: actually, it won't crash immediately so I guess there's no need to wipe saves 20:27:59 gammafunk: have you started working yet, or can I push this in the next 20min 20:28:49 ebering: I just started; if you just want to push something else to the branch, please feel free 20:29:00 Yep. That worked. Line endings issue. Given that WSL worked with Ubuntu for Wise Wolf and Debian for me; perhaps the MSYS instructions in INSTALL.txt should be deprecated with WSL as the preferred method for Windows installs. Afterall the MSYS instructions literally ONLY work for Windows local, not distrib, webtiles, etc. Have to add some 20:29:22 "how to use linux" stuff in there to do that though since WSL/Debian is a little more technical than MSYS bash. 20:29:39 gammafunk: no it's a big rebase 20:29:51 well I'll wait and put your commit on top, since the necro changes are at the end 20:30:42 ebering: no problem either way for me; my changes won't be hard to rebase onto your rebased branch 20:39:38 Bcadren, the trouble with that is that A) only windows 10 pro users can use wsl and B) it's building a linux executable, not a windows one 20:40:31 Though I do agree that it was easier to set up than MSYS 20:42:15 pblur I suppose that's fair. I got the linux stuff to check on webtiles unique stuff since my fork is primarily webtiles deployment and it's been having issues that my local windows tiles builds don't have. 20:42:30 Also, most people just want to play it - the WSL stuff, I think, is only best if you want to develop it 20:42:53 pblur: how do you know WSL requires Pro? AFAICS from google searches it is fine on Home 20:42:57 ... actually I guess players don't build it at all so ignore me 20:43:13 ebering: you want me to wipe saves now? 20:43:13 floraline: You have 2 messages. Use !messages to read them. 20:43:16 but of course it is 10-only 20:44:10 Bcadren: you will want to follow the instructions for linux even if you're on WSL 20:46:18 floraline: no need; there might be the occasional crash on some of the stale saves but they're basically playable 20:46:53 floraline Yea I just got it to work; my issue earlier was because Windows git had checked out and Linux was trying to build (Windows-Style line endings). Now how did I run webtiles locally? (It compiled, but I forgot the correct command to test run webtiles) 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-177-gd20f57b: Generalize and rename targeter_los 10(6 hours ago, 10 files, 26+ 26-) 13https://github.com/crawl/crawl.git/commit/d20f57b79572 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-178-ge0c723f: Use targeter_radius hitfuncs for friendly fire checks 10(5 hours ago, 1 file, 9+ 26-) 13https://github.com/crawl/crawl.git/commit/e0c723fc15c0 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-179-gefbae3a: Positional magic 🌪: Airstrike 10(7 weeks ago, 3 files, 21+ 3-) 13https://github.com/crawl/crawl.git/commit/efbae3a11d12 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-180-g2c96e2c: Positional magic 🔥: Fire removals 10(7 weeks ago, 2 files, 2+ 5-) 13https://github.com/crawl/crawl.git/commit/2c96e2c58ba2 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-181-gc0a513c: Positional magic 🔥: Nerf conjure flame (minmay, tealizard) 10(7 weeks ago, 8 files, 55+ 153-) 13https://github.com/crawl/crawl.git/commit/c0a513c3e86a 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-182-gb843cf3: Positional magic 🔥: New Fire spell: Starburst 10(7 weeks ago, 8 files, 87+ 0-) 13https://github.com/crawl/crawl.git/commit/b843cf370797 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-183-gee598e8: Positional magic 🔥: Modify inner flame 10(7 weeks ago, 2 files, 10+ 2-) 13https://github.com/crawl/crawl.git/commit/ee598e8537b9 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-184-ga18c6ef: Positional magic 🔥: New spell Foxfire 10(13 days ago, 24 files, 225+ 14-) 13https://github.com/crawl/crawl.git/commit/a18c6ef57eb5 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-185-gcfe61e2: drop! Placeholder tile for Foxfire 10(7 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl.git/commit/cfe61e279b11 20:47:51 03ebering02 07[positional-magic] * 0.25-a0-186-g79b4c34: Positional magic ❄️: Ice removals 10(7 weeks ago, 2 files, 3+ 6-) 13https://github.com/crawl/crawl.git/commit/79b4c3492823 20:47:51 ... and 17 more commits 20:47:55 Branch pull/1200 updated to be equal with positional-magic: 13https://github.com/crawl/crawl.git/pull/1200 20:48:04 there we are 20:49:22 Bcadren: Instructions in crawl-ref/source/webserver/README 20:50:15 yep ^ make sure you have the prereqs 20:51:11 floraline on a related note I've seen you using Wizmode on your server, is that some admin-privalege thing? 20:51:20 i would recommend that when testing your code, you should not only compile but run the webserver and start and quit a game 20:52:22 i think if you don't build with USE_DGAMELAUNCH=Y then wizmode is allowed for any user 20:52:50 It says as much; I was just curious as to how you'd done it. 20:53:25 i build with that flag enabled and i believe it requires that a user has the admin flag set in the dgl database 20:53:41 i think you press & or some similar key 20:54:35 i only used it once to test some very specific bug report, i don't know a lot about how it works 21:02:42 if you ever think of adding steam magic, consider this emoji 🧖‍♂️ 21:12:34 DGL admins can use wizmode, yeah 21:15:30 how do I stop? . . . also it seems to be stuck on loading. . . maybe because this computer is doing more than one thing at once, idk 21:17:04 use ctrl+c 21:18:38 perhaps the issue that makes it never stop loading is the default tiles interface is looking for normal trunk and it's not flagged that way? I'm not sure...I can show the pages of everything that happened in the linux console 21:21:45 I know it's not php, but it's decent syntax highlighting for readability: https://hastebin.com/ubuwazoqix.php 21:27:30 ebering: ok taking no action 21:28:36 Experimental (positional-magic) branch on crawl.kelbi.org updated to: 0.25-a0-203-g6cffc1b1f5 21:35:48 this looks normal to me besides the missing static files, it looks like it finished loading on line 6 21:45:24 -!- sage is now known as Basil 22:39:38 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-1688-gd9aadcbef2