02:37:39 Unstable branch on crawl.develz.org updated to: 0.25-a0-59-gf342c8b (34) 03:09:15 Windows builds of master branch on crawl.develz.org updated to: 0.25-a0-59-gf342c8b 03:11:53 Unstable branch on crawl.beRotato.org updated to: 0.25-a0-59-gf342c8b (34) 03:31:05 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2682-g87278707ce 03:48:11 -!- amalloy is now known as amalloy_ 03:53:04 Fork (gooncrawl) on crawl.kelbi.org updated to: 0.22-a0-892-g9f47413f05 03:58:46 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 04:16:57 Fork (stoatsoup) on crawl.kelbi.org updated to: 0.22-s0-19-g4b661dc923 05:56:33 -!- Yermak_ is now known as Yermak 06:53:45 Wands should display failure rate, like spells 13https://crawl.develz.org/mantis/view.php?id=12113 by john_science 08:05:46 03Aidan Holm02 07* 0.25-a0-60-g7a5f90e: Revert "Add rudimentary win32 console colour adjustment" (advil) 10(5 minutes ago, 1 file, 0+ 14-) 13https://github.com/crawl/crawl/commit/7a5f90e2b27b 08:06:54 03Aidan Holm02 07[stone_soup-0.24] * 0.24.0-2-g5b39ceb: Revert "Add rudimentary win32 console colour adjustment" (advil) 10(7 minutes ago, 1 file, 0+ 14-) 13https://github.com/crawl/crawl/commit/5b39cebb1c0d 08:17:36 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-60-g7a5f90e2b2 (34) 09:52:00 aidanh: I did see a report somewhere suggesting that unix might have also been affected under some circumstances, can't seem to track it down though 09:53:43 aidanh: this is maybe a kind of obvious question now that I see what you reverted, but did you reckon with the various issues that brighten foreground has across terminals? on default settings (best_effort_brighten_foreground = true) there are terminals it just doesn't work on 09:55:48 needs some arbitrary combination of blink_brightens_background, bold_brightens_foreground, allow_extended_colours, and TERM to work on any given terminal 09:59:50 (iirc this interacts with windows console somehow, can't remember the details) 10:04:49 advil: I did briefly check with a few combinations of those settings but couldn't get anything buggy to happen 10:05:23 unsurprisingly i'm not too eager to dive back into libunix.cc if I can avoid it :) 10:20:04 regarding upgrading to c++17, CAO, CBRO, and CDO all use gcc 4.7-4.9, which is much too old 10:21:32 lazy-life.ddo.jp and webzook are both on 5.5 ish 10:23:18 and CKO and CUE are on 6.3.0, which has some very minimal support 10:23:30 according to https://gcc.gnu.org/projects/cxx-status.html#cxx17 10:26:19 I understand john.stein has very little free time for server maintenance right now, so it looks like c++17 (and even the older c++14) will have to be shelved for now 12:25:50 Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001 12:56:12 advil: I can't quite figure out why you added an event handler to the progress_popup UI that eats all events, when nothing in the popup should react anyway 12:56:12 https://github.com/crawl/crawl/blob/master/crawl-ref/source/ui.cc#L2349 12:58:42 -!- amalloy_ is now known as amalloy 13:06:07 Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-60-g7a5f90e (34) 13:52:43 Hmm... Inner-flamed monsters exploding break Zin's sanctuary, Zin is offended; this doesn't seem right. 14:20:19 New branch created: wip-warnings (2 commits) 13https://github.com/crawl/crawl/tree/wip-warnings 14:20:19 03Aidan Holm02 07[wip-warnings] * 0.25-a0-61-g3c60548: Add UNUSED(...) macro 10(67 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/3c605482a05b 14:20:19 03Aidan Holm02 07[wip-warnings] * 0.25-a0-62-g49556f1: WIP: Remove/mark unused parameters 10(43 minutes ago, 168 files, 749+ 814-) 13https://github.com/crawl/crawl/commit/49556f16f210 14:25:40 -!- Tiobot is now known as Guest64312 14:53:41 03Aidan Holm02 07[wip-warnings] * 0.25-a0-62-g61e16b4: WIP: Remove/mark unused parameters 10(77 minutes ago, 169 files, 752+ 818-) 13https://github.com/crawl/crawl/commit/61e16b4759bb 15:13:16 %git 947863900 15:13:16 07advil02 {gammafunk} * 0.22-a0-486-g9478639: Add a permanent store for some fallback ghosts 10(1 year, 10 months ago, 3 files, 197+ 99-) 13https://github.com/crawl/crawl/commit/94786390060c 15:15:49 did that use_store parameter ever do anything? 15:21:03 03Aidan Holm02 07[wip-warnings] * 0.25-a0-62-g95582e1: WIP: Remove/mark unused parameters 10(2 hours ago, 171 files, 757+ 822-) 13https://github.com/crawl/crawl/commit/95582e1cbc9e 15:28:19 03Aidan Holm02 07[wip-warnings] * 0.25-a0-62-g362e17d: WIP: Remove/mark unused parameters 10(2 hours ago, 171 files, 757+ 826-) 13https://github.com/crawl/crawl/commit/362e17d72620 15:37:58 it's supposed to be 15:38:07 that's probably causing some weird behavior 15:39:19 aidanh: re the progress popup, iirc without that handler events would get queued after level load 15:39:32 which is actually very bad both in terms of ui and for scripting 15:40:05 that may or may not still happen 15:41:43 that does not sound good 15:41:54 well, maybe it would have been ok from a scripting perspective 15:42:44 console, presumably? do you remember what kind of events? i'm assuming keyboard events 15:43:50 yeah, I think it might have happened in tiles too? 15:43:58 yeah there was a lot of surprising stuff that just wasn't getting used; i remember incremental tide in shoals is is also completely unused 15:51:50 03advil02 07* 0.25-a0-61-g63109bb: Fix some odd permastore update conditions (aidanh) 10(89 seconds ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/63109bb16d34 16:02:51 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-61-g63109bb16d (34) 16:07:41 The build failed. (wip-warnings - 362e17d #12135 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/604083200 16:30:35 !kw nchoice 16:30:36 Keyword: nchoice => MfEn|BaEE|HaVM|HaFE|CeIE|CeWz|TeSk|OpAE|FoNe|GhCj 16:30:41 =nemelex BaAK 16:30:44 Defined keyword: nchoice => MfEn|BaEE|HaVM|HaFE|CeIE|CeWz|TeSk|OpAE|FoNe|GhCj|BaAK 16:30:48 =nemelex DDAM 16:30:51 Defined keyword: nchoice => MfEn|BaEE|HaVM|HaFE|CeIE|CeWz|TeSk|OpAE|FoNe|GhCj|BaAK|DDAM 16:34:13 03Aidan Holm02 07[wip-warnings] * 0.25-a0-62-g8d917b9: WIP: Remove/mark unused parameters 10(3 hours ago, 172 files, 760+ 826-) 13https://github.com/crawl/crawl/commit/8d917b92ddd8 17:10:47 The build is still failing. (wip-warnings - 8d917b9 #12137 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/604116263 18:05:10 Gen-Apt.pl says "Generates aptitude table from skills.cc and the aptitude template file." where's the aptitude template file? 18:23:43 Bcadren: a `git grep gen-apt.pl` will show you the places where that file is called from, and from there it's reasonably easy to see what arguments it gets 18:28:33 gammafunk: do you remember how to update the version in https://crawl.develz.org/trunk/? It looks like CDO is already doing the builds 18:34:18 Oof. That's why I didn't find it. /Templates is outside of /Source and therefore wasn't included in what my IDE was searching through. 18:56:07 =nemelex HuTm 18:56:10 Defined keyword: nchoice => MfEn|BaEE|HaVM|HaFE|CeIE|CeWz|TeSk|OpAE|FoNe|GhCj|BaAK|DDAM|HuTm 18:56:30 advil: yeah, I saw that problem too, and I couldn't remember off the top of my head 18:56:39 advil: you could search dev logs though 18:56:45 if I have some time later I can take a look 19:25:28 Unstable branch on underhound.eu updated to: 0.25-a0-61-g63109bb16d (34) 20:07:17 gammafunk: I figured it out, need to edit and then run bin/update-trunk-indices.sh for future reference 20:07:27 got it 20:07:55 advil: we should probably make a little CDO readme and put it in the home dir somewhere 20:08:01 just documenting a few things like that 20:09:11 yeah, and maybe add to the release guide a list of all the random add-on stuff that we do after branching 20:09:32 right 20:10:35 I can think of offhand: that script, CAO scoring sources, Sequell sources, mantis versions (which I did the other day) 20:19:02 !lm Snack baak x=gid 20:19:03 57. [2019-10-29 00:14:46] [game_key=Snack:cbro:20190928235333S] Snack the Slinger (L10 BaAK of Lugonu) killed Harold on turn 7553. (D:9) 20:19:15 that game has a swastika on D:8 20:19:42 should be able to use the seed to replicate it once the game is over 20:21:54 Stable (0.24) branch on underhound.eu updated to: 0.24.0-2-g5b39cebb1c 20:26:12 one of the old vaults or something? 20:26:20 thought we had removed all of those 20:35:07 not sure, it was in a complex layout thing, maybe one of minmay's, so I suspect it might be an emergent swastika 20:35:41 snack posted a partial screenshot on discord (I spectated and saw the whole thing but it was too quick for my layout id skills) 20:36:11 https://cdn.discordapp.com/attachments/205316046230388737/638530048466485253/secretnazidev.png 20:36:58 it's funny and sad how easy it is to accidentally design swastikas 20:37:14 why couldn't the nazis have picked a more complex shape 20:37:29 nobody accidentally designs an eagle perched on a skull 20:38:22 relevant des comment: `# it took a while to figure out how to NOT draw a swastika with the V-pentomino` 20:39:23 heh 20:39:54 that does look like a relatively fixed piece of subvault 21:01:56 -!- james is now known as Sage1234 21:02:06 minmay identified it: https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/des/variable/the_grid.des#L2298 21:08:37 03advil02 07* 0.25-a0-62-g88673ef: Remove an accidental swastika (Snack, minmay) 10(4 minutes ago, 1 file, 0+ 16-) 13https://github.com/crawl/crawl/commit/88673ef09594 21:08:55 I just removed it for now per minmay's suggestion, but it might actually be better for seed stability if there were a modified version of it in its place 21:09:05 (definitely shouldn't cherry-pick that to 0.24 yet) 21:11:17 advil: will removing a vault or adding a new vault generally break seed stability? 21:11:31 in trunk this might happen pretty frequently 21:11:56 I guess that does have to be the case, doesn't it 21:11:56 yeah 21:12:21 changing the number of vaults with a particular tag can be especially bad 21:13:17 in trunk it's fine 21:13:39 at least, there's no way around it really so I have in the past declared that it's not usually worth worrying about 21:14:40 so I guess to that end we should not backport new vaults to point releases (or outright remove them) 21:15:15 yeah...though I think it's generally ok if there are changes in point releases, and players seem fine with that 21:15:24 there were seed changes in 0.23.2 21:15:34 eventually I do plan on having a version # as part of the seed 21:16:49 it's true that probably online seeded mode won't be that fine-grained if it becomes more available 21:17:43 Unstable branch on crawl.kelbi.org updated to: 0.25-a0-62-g88673ef095 (34) 21:21:32 -!- amalloy is now known as amalloy_ 22:31:37 -!- amalloy_ is now known as amalloy