00:11:08 <gammafunk> advil: oh nice, thanks for fixing that mummy death curse thing
00:11:08 <gammafunk> if that's safe to backport to 0.23, we should do so
00:12:16 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to a pastebin service, please.
00:12:30 -!- The topic of ##crawl is: Play Dungeon Crawl Stone Soup online now! Type ??servers for instructions. | http://crawl.develz.org | FooTV: http://termcast.develz.org - ??footv for instructions | See also ##crawl-offtopic
01:19:32 <Yermak> Since when durably summoned creatures can take stairs?
01:38:20 <Cheibriados> New branch created: pull/1193 (1 commit) 13https://github.com/crawl/crawl/pull/1193
01:38:20 <Cheibriados> 03Umer Shaikh02 07https://github.com/crawl/crawl/pull/1193 * 0.25-a0-50-gcb28425: Make the game check the floor when emergency eating 10(2 hours ago, 1 file, 23+ 8-) 13https://github.com/crawl/crawl/commit/cb2842561950
01:40:55 <alexjurkiewicz> ghost rework, perhaps?
01:48:19 <Xenobreeder> IIRC wrath mons always could follow you, guess that never got changed when these were made durable summons (to nerf Oka the pizza boy), because why?
02:05:53 -!- amalloy_ is now known as amalloy
02:49:51 <gammafunk> %git stone_soup-0.24
02:49:51 <Cheibriados> 07advil02 * 0.24-b1-49-g86bb956: Fix mummy death curses from ally kills (12104) 10(6 hours ago, 3 files, 19+ 9-) 13https://github.com/crawl/crawl/commit/86bb9569af75
03:27:05 <Kelbell> Stable (0.24) branch on crawl.kelbi.org updated to: 0.24-b1-49-g86bb9569af
03:27:54 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2634-gb4598b3726
03:48:11 -!- amalloy is now known as amalloy_
04:10:31 <Xenobreeder> Yermak, temporary summons were prevented from using stairs by http://s-z.org/neil/git/?p=crawl.git;a=commit;h=cf90cb503b9ebf22f65c3ea555b2d53e66e11613 — nothing affected durable summons. So looks like these were always like that.
04:11:55 <Xenobreeder> Also this: http://s-z.org/neil/git/?p=crawl.git;a=commit;h=7e50c859fae87336ea760c65409bad1a3daf4dad
08:12:10 <Henzell> artmatt (L27 GnVM) ERROR in 'tags.cc' at line 4476: Invalid item: (quantity: 0) quick blade (antimagic) (Depths:4)
08:35:46 <advil> !crashlog
08:36:04 <Sequell> 21275. artmatt, XL27 GnVM, T:144800 (milestone): http://crawl.akrasiac.org/rawdata/artmatt/crash-artmatt-20191024-121209.txt
08:38:02 <advil> hepl crash...though we'd sorted that out
08:41:28 <advil> well, the mantis bug is still open so I guess not
08:46:54 <advil> should I tag 0.24.0?
08:47:25 <advil> I guess I would need to know the release name for that ;-)
08:57:04 <advil> plants vs vampires
09:04:08 <advil> (I wonder if we would get sued)
09:04:08 <aidanh> bookish ballistomycetes
09:08:12 <aidanh> the abstruse arboretum
09:15:19 <Cheibriados> 03advil02 07* 0.25-a0-52-g9c56bcb: Add vaults to stable version morgues 10(2 minutes ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/9c56bcba7025
09:15:57 <Cheibriados> 03advil02 07[stone_soup-0.24] * 0.24-b1-50-g03419eb: Add vaults to stable version morgues 10(2 minutes ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/03419ebf5fb5
09:32:12 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-52-g9c56bcba70 (34)
10:41:59 <johnstein_> I forgot something related to rcfiles and cbro webtiles isn't creating rc files for new accounts.
10:42:08 <johnstein_> I can't remember what causes this and how to fix it.
10:42:17 <johnstein_> getting emails that people can't edit rc files for tourney
10:43:14 <advil> is it only with new accounts? I was able to edit a 0.24 rc
10:43:30 <johnstein_> were you able to do it before 5 minutes ago?
10:43:52 <johnstein_> there were 0 rcfiles in the crawl-0.24 folder since I forgot to copy over the old ones
10:44:11 <advil> didn't try
10:44:19 <johnstein_> and I had a typo in dgamelaunch-config/chroot/bin/init-webtiles.sh that I just fixed that I thought was the issue
10:44:36 <advil> I also just succeeded in creating a new account and editing rcs for both trunk and 0.24
10:44:41 <johnstein_> but when I delete the rc file for my test account and make a new game, I don't get a new config file
10:44:50 <johnstein_> so I can't edit it
10:46:02 <johnstein_> looks like it creates the account on login
10:46:21 <johnstein_> so if I log out, then log back in, it makes it. so I guess that's why I couldn't test it properly
10:46:53 <johnstein_> so my change 5 min ago seems to have worked. ping me if others report any issues, but looks like it should work. thanks for the double-check
10:59:59 <Cheibriados> 03advil02 07* 0.25-a0-53-g72b0ba0: Fix a gcc warning 10(28 seconds ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/72b0ba0336dc
11:00:43 <Cheibriados> 03advil02 07[stone_soup-0.24] * 0.24-b1-51-g3365646: Fix a gcc warning 10(72 seconds ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/33656463dde0
11:04:01 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-53-g72b0ba0336 (34)
11:24:20 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001
13:07:02 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-53-g72b0ba0 (34)
13:28:59 <advil> "untitled dcss release"
13:29:03 <advil> we need a title here
13:31:58 <advil> so far some of the ideas I've seen are (probably missing some stuff): "the poison garden", "plants vs vampires", "the abstruse arboretum", "bookish ballistomycetes"
13:32:55 <advil> "the atropa garden"
13:33:08 <gammafunk> yes
13:33:18 <gammafunk> heh, Plants vs Vampires
13:33:22 <gammafunk> that's pretty funny
13:33:36 <advil> :-) that one was mine
13:33:46 <advil> hopefully not trademark-infringing
13:33:55 <gammafunk> bookish ballistomycetes is cute due to alliteration, but book gifts really didn't change this release
13:33:59 <gammafunk> just the other sif stuff did
13:34:11 <gammafunk> yeah I like Plants vs Vampires the most so far
13:34:19 <advil> yeah, I like the abstruse one better of those two
13:34:50 <advil> those two = bookish vs abstruse
13:35:30 <advil> I think I also like "plants vs vampires" best so far but I'm biased
13:36:18 <aidanh> another one was "oklob-tipped darts" from ebering
13:36:23 <gammafunk> The Abstruse Arboretum isn't bad either
13:36:28 <gammafunk> what's the Abstruse part a reference to?
13:36:45 <advil> I think it's obliquely sif?
13:36:59 <gammafunk> hrm, maybe a bit too....abstruse
13:37:02 <aidanh> sif, although there are a few other words one could substitute
13:37:06 <aidanh> heh
13:37:22 <advil> the atropa arboretum
13:37:38 <gammafunk> kind of a neat tie-in between the two changes
13:37:41 <gammafunk> both plant references
13:38:26 <gammafunk> I guess Plants vs Vampires is my no. 1 pick, followed by The Atropa Arboretum
13:38:34 <advil> btw thanks for setting up the tournament scripts gammafunk
13:38:47 <gammafunk> no problem
13:38:59 <aidanh> the arcane arborescence?
13:39:39 <aidanh> although I don't think 'arborescence' finds much use outside of its graph theory definition
13:40:06 <gammafunk> I was going to ask what that meant
13:40:51 <aidanh> i always thought it meant "a profusion of plant stuff" more or less, until I actually double checked
13:40:52 <advil> and a 90s prog rock album by ozric tentacles (who I literally haven't thought about in like 20 years)
13:42:13 <aidanh> huh.. it's not impossible that that's where I saw it actually
13:43:23 <aidanh> there was also "The Magical Midnight Garden", though I'm not sure where the midnight comes from
13:43:32 <gammafunk> vampires?
13:43:48 <gammafunk> pretty abstruse as well as a reference, I guess
13:44:00 <aidanh> oh, i guess that makes sense, but it's a bit of a stretch
13:44:23 <gammafunk> I'm just happy we have four people who've thought about the release name!
13:44:35 <gammafunk> last time it was just me until neil stepped in
13:44:40 <gammafunk> actually maybe ebering helped some
13:45:00 <gammafunk> but it wouldn't be a proper release name if we didn't think of it at the last minute
13:50:56 <gammafunk> advil: oh, will you have time to update ghost files again? if not, we can always do that in the point release
13:51:09 <advil> ugh, forgot about that
13:51:31 <gammafunk> yeah, nbd
13:51:59 <gammafunk> if you ever have time to do a little writeup of what you do for that, would also be helpful
13:52:08 -!- amalloy_ is now known as amalloy
13:52:19 <advil> ok this time I will fully commit to actually doing that for a 0.24.1 release with ghosts from the tournament
13:52:32 <gammafunk> sounds great
13:52:43 <gammafunk> I guess it's even better to wait until after tourney anyhow
13:54:12 <gammafunk> wish we had some better way of coordinating getting those ghost files for servers like cwz lld etc
13:54:34 <gammafunk> need to add those webtiles admin commands that alex and I cooked up for webtiles-changes
13:56:52 <advil> what were those?
13:56:52 <advil> %git 05433c6f1a0
13:56:52 <Cheibriados> 07advil02 * 0.23.2: Update debian changelog for 0.23.2 release 10(7 months ago, 1 file, 10+ 0-) 13https://github.com/crawl/crawl/commit/05433c6f1a00
13:57:14 <gammafunk> I'll find you a link to a relevant commit
13:57:25 <advil> what does UNRELEASED mean in a debian changelog?
13:57:44 <advil> also, do we update that in master or in the branch?
13:59:12 <advil> both I guess?
13:59:37 <gammafunk> both, yeah, and we always leave it as UNRELEASED in the debian changelog
13:59:49 <gammafunk> but the debian changelog must be updated in branch
13:59:53 <gammafunk> since that's what I'll build
14:00:33 <gammafunk> I think we should probably not use UNRELEASED ideally but I forget if changing it would interact with our repo setup
14:00:51 <gammafunk> we make a new top-level entry (forget what those are called) for each version
14:00:57 <gammafunk> so that people can install old version from the repo
14:01:22 <gammafunk> arguably we shouldn't do that, since that's not how debian distros generally handle old versions
14:01:51 <gammafunk> components I think they're called
14:02:58 <advil> ah are you going to do debian? guess we should coordinate (I was just looking up how to do it)
14:03:26 <advil> (I'm happy not to do it, it's not a very familiar thing for me)
14:08:47 <gammafunk> advil: yeah, I can make the windows and debian packages both
14:08:52 <gammafunk> if you tag soon
14:09:08 <gammafunk> if you need me to make the debian changelog update, I can do as well
14:09:29 <gammafunk> things we need: final changelog update to say the release date...uh...guess I should also look at release guide
14:09:34 <advil> I can do that, IIRC it happens before the tag?
14:09:47 <gammafunk> yep
14:09:51 <advil> oh yeah changelog finalization
14:09:57 <advil> I guess "plants vs vampires"?
14:10:30 <gammafunk> that's my first pick, and I'll be sure to tell everyone on discord who doesn't like it that advil demanded this release name!
14:10:33 <aidanh> works for me
14:10:43 <Yermak> Is 'vs' that necessary? Maybe 'and'?
14:10:55 <advil> Yermak: it's a reference to another game
14:11:00 <gammafunk> Yermak: it's a reference to the video game Plants versus Zombies
14:11:06 <gammafunk> I guess we should get that reference exact though
14:11:21 <gammafunk> Plants vs. Zombies
14:11:23 <gammafunk> it seems
14:11:30 <gammafunk> so "Plants vs. Vampires"
14:11:47 <gammafunk> oddly fitting too, since the plants are stationary turrets in our game as well
14:12:24 <gammafunk> maybe some inspiration for future fedhas development: have "tracks of dirt" upon which monsters are forced to walk
14:13:10 <Yermak> Yeah, I understand. I mean it'll still be a reference if you change a word; there is no confrontation going in dcss.
14:14:37 <Yermak> But yeah, I guess the reference will be too shallow.
14:14:39 <gammafunk> Yermak: well, I think the point is to be a sort of 'cute' reference that directly evokes that game
14:14:50 <gammafunk> so the point is to make it remind people of that game as much as possible
14:15:00 <gammafunk> it's not intended to imply a real comparison
14:15:05 <gammafunk> our release names are basically just jokes
14:15:33 <advil> gammafunk: if you're going to do the debian build, should I put you in the changelog?
14:15:49 <advil> no idea if it really matters
14:15:50 <gammafunk> advil: sure
14:16:00 <gammafunk> and I don't think it does, but I guess that makes the most sense
14:16:09 <gammafunk> just gammafunk <gammafunk@gmail.com>
14:20:41 <gammafunk> advil: debian changelog looks good
14:21:07 <gammafunk> so I can do the windows and debian packages and update the website after you've tagged
14:21:40 <gammafunk> hrm, I guess git fetch is still broken on cdo, so I'll have to manually copy the website files, but that's easy enough
14:22:06 <advil> I've tagged, but I guess chei is being a bit slow
14:22:11 <gammafunk> great, thanks
14:22:26 <gammafunk> one thing I might not get to until much later in the evening is the release post itself
14:22:45 <gammafunk> depends on how fast these builds are, but I can do that much later in the evening at least
14:25:11 <Cheibriados> 03advil02 07[stone_soup-0.24] * 0.24-b1-52-g54606e7: Finalize changelog for 0.24 release 10(11 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/54606e7572d3
14:25:11 <Cheibriados> 03advil02 07[stone_soup-0.24] * 0.24.0: Update debian changelog for release 10(8 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/a7d21def0a8b
14:25:26 <advil> oh weird, somehow pushing with --tags pushed the 0.24.0 tag, and the commits, but not actually the stone_soup-0.24 branch
14:25:38 <advil> that's why chei didn't announce
14:25:45 <advil> so if you've pulled you may want to pull again
14:27:30 <gammafunk> yeah, I got those changes after another pull
14:27:42 <gammafunk> hrm, we probably need to make some manual updates, but we can do for 0.24.1
14:28:22 <Cheibriados> 03advil02 07* 0.25-a0-54-g45a4e74: Finalize changelog for 0.24 release 10(15 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/45a4e74662ef
14:28:22 <Cheibriados> 03advil02 07* 0.25-a0-55-g0753fd1: Update debian changelog for release 10(12 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/0753fd1ad2af
14:29:03 <advil> is there something release-specific? or just missing stuff
14:29:31 <advil> fwiw the seed changes should be up to date in the manual at least
14:31:04 <gammafunk> advil: probably some release-specific updates re: sif, fedhas, maybe other things?
14:31:12 <gammafunk> just not sure we've gotten all those changes into the manual
14:31:35 <advil> gods are, it seems, not discussed in the manual?
14:31:48 <gammafunk> oh that's interesting
14:31:56 <advil> vp looks like it is up to date, I think
14:32:16 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-55-g0753fd1ad2 (34)
14:32:33 <gammafunk> throwing changes maybe? I'll give it a quick pass at some point either way
14:32:51 <gammafunk> if we managed to get it fully updated before release, that's great
14:32:52 <advil> yeah, there's some minor throwing-related issues, it talks about tomahawks etc
14:33:00 <gammafunk> rats
14:33:05 <advil> there's not a lot of detail about how throwing works so it's not very harmful
14:34:03 <gammafunk> how about the crawl man page???
14:34:48 <gammafunk> huh, there's an ssh guide
14:36:09 <advil> I wonder if mac builds work at all on catalina
14:36:27 <advil> all I know is that I'm not installing it myself any time soon
14:41:28 <advil> gammafunk: do you do the source package as part of building debian?
14:51:31 <gammafunk> advil: yes, I think that happens automatically
14:51:56 <gammafunk> the source packages being made, I mean, and they get installed along with the rest
14:52:23 <advil> hm, I think I have manually uploaded it to cdo before?
14:52:33 <gammafunk> oh
14:52:36 <advil> mac builds are in the 0.24 dir on cdo
14:52:38 <gammafunk> you mean the source zip packages
14:52:53 <gammafunk> not the debian source packages?
14:53:03 <advil> yeah, sorry
14:53:05 <gammafunk> the source zip packages are done seperately outside of anything debian related
14:53:12 <gammafunk> as per the release guide
14:53:13 <advil> ah ok
14:53:23 <gammafunk> and yeah I'm doing those too
14:54:43 <gammafunk> advil: thanks re: the os x packages
14:54:52 <gammafunk> for the first time, os x packages ready before all the other ones!
14:55:19 <advil> heh
14:55:19 <advil> I guess if anyone else wants to test the osx packages, that's useful: https://crawl.develz.org/release/0.24/
15:16:39 <travis-ci> The build passed. (0.24.0 - a7d21de #12122 : advil): https://travis-ci.org/crawl/crawl/builds/602456882
16:32:15 <gammafunk> advil: Just so you know, download page at http://crawl.develz.org/download.htm is updated with all the main release packages, save debians
16:32:28 <gammafunk> I'll finish up debs tonight and make a release post
16:32:44 <gammafunk> although if someone wants to write that post now, they can feel free, using past release posts as a guide
16:32:50 <gammafunk> if not, no worries, I can do tonight
16:38:10 <advil> great, thanks
16:38:29 <advil> maybe I can do the release post in a bit
16:43:20 <gammafunk> advil: yeah, I often just copy the html in wordpress (from html view) over to a new post from a previous release post and edit
16:43:34 <gammafunk> just for basic formatting, but of course you don't have to use the same format
16:44:01 <gammafunk> if you try to copy over in the rich text editing mode it doesn't work so hot, but copying the html code from the html mode works fine
18:22:48 <Lantell> Unstable branch on underhound.eu updated to: 0.25-a0-55-g0753fd1ad2 (34)
18:38:19 <alexjurkiewicz> congrats on the release!
19:22:14 <Lantell> Stable (0.24) branch on underhound.eu updated to: 0.24.0-0-ga7d21def0a
19:30:17 <advil> ebering: how did you produce the list of 0.23 contributors? is there an easy way to see that all at once?
19:32:17 <advil> I guess I can find new contributos by a diff on credits, is that reliable?
19:38:15 <amalloy> advil: i'd start with something like: git log --pretty="%aN <%aE>" 0.23.0..0.24.0 |sort|uniq
19:38:24 <amalloy> i guess without the aE if it's getting published somewhere
19:39:16 <amalloy> ah, you're looking for just first-time. hm
19:42:44 <advil> both
19:43:00 <advil> following the template from last time...so that command is exactly the sort of thing I was looking for
19:45:21 <advil> "EC2 Default User"
19:46:29 <amalloy> for new contributors, diffing CREDITS is the best i can come up with too, unless you want to compute the set of all authors ever and diff the two lists
19:46:57 <amalloy> git diff 0.23.0 -- CREDITS.txt | grep -P '^\+\s+'| perl -p -e 's/^\+\s+//g;'
19:48:28 <amalloy> highly hacky and only actually works with gnu grep. probably there are arguments you could pass to git-diff that would be better than this
19:53:19 <advil> hm, also in some cases it's unclear whether to use real name or username
19:54:15 <advil> oh that one is in credits so it's ok
20:11:19 <advil> I notice that CXC doesn't have a credit??
20:13:43 <advil> I guess medar should be by name, since that's how he is in the devteam list?
20:14:49 <advil> ok there's a draft release post in wordpress but it would be helpful if somehow who has actually been merging patches could quickly squint at the name list
20:15:10 <advil> I also found a few missing from credits, at least as far as I could resolve the names
20:17:11 <Cheibriados> 03advil02 07* 0.25-a0-56-g68f8618: Add some missing credits 10(50 seconds ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/68f861856ed0
20:17:29 <alexjurkiewicz> git sohrtlog -e 0.23.0..0.24.0
20:18:02 <advil> oops, I never actually did swap in Medar's name
20:32:15 -!- amalloy is now known as amalloy_
20:32:31 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-56-g68f861856e (34)
20:54:49 -!- amalloy_ is now known as amalloy
22:26:04 <shmup> where can i see properties of the arg passed to `pickup_equipment`. the subtype method and `is_useless` etc
22:26:12 <shmup> curious if it is in a doc or elsewhere
22:28:02 <amalloy> !source pickup_equipment
22:28:03 <Sequell> Can't find pickup_equipment.
22:29:11 <amalloy> what function are you talking about?
22:29:26 <shmup> ah, right
22:29:30 <shmup> !source add_autopickup_func
22:29:31 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/dlua/userbase.lua#L186
22:29:54 <shmup> curious about the properties of items.Item
22:31:43 <shmup> mostly curious about the docs for any of the inline lua you can do. dont know anything about the api
22:31:48 <shmup> like i know, from seeing others, you can do:       local cur = items.equipped_at("armour")
22:31:55 <shmup> items must be globally available
22:34:13 <amalloy> probably https://github.com/crawl/crawl/blob/master/crawl-ref/source/l-item.cc
22:34:17 <shmup> i guess afaict from grepn it jsut comes from ^
22:34:18 <shmup> yeah
22:35:15 <shmup> mostly i wanted to see if i can get a count for a thing in my inventory
22:38:12 <advil> hm https://www.reddit.com/r/dcss/comments/dmqtkw/windows_installer_being_flagged/
22:38:18 <advil> I assume that's just a false positive
22:40:05 -!- amalloy is now known as amalloy_
22:43:46 <johnstein_> ^status
22:52:28 <advil> gammafunk: I drafted the release post but didn't finalize it, I'll let you look it over