00:07:46 -!- Amnesiac_ is now known as Amnesiac
02:41:33 <aidanh> alexjurkiewicz: what sort of changes are you trying to make to those screens?
02:43:06 <aidanh> glad to hear it :)
03:12:20 <alexjurkiewicz> adding the species/backgrounds stat line
03:12:49 <alexjurkiewicz> the "right" way to do it seems to be to copy the implementation of OuterMenu::descriptions
03:18:24 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.25-a0-10-g2fe12d4 (34)
03:23:14 <aidanh> i don't think descriptions even belong in that class
03:25:25 <aidanh> I guess I only added them there because it was convenient, since all menus have them
03:32:51 <aidanh> so I think the best thing to do is to move the description handling out to the outer_menu->add_button call sites, with a focus-in event handler on the button
03:49:43 -!- amalloy is now known as amalloy_
07:16:40 <Cheibriados> 03theJollySin02 07https://github.com/crawl/crawl/pull/1180 * 0.24-b1-1-gba27cd4: Misleading text when renouncing religion (8887) 10(3 days ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/ba27cd430db2
07:37:33 <Cheibriados> 03theJollySin02 {ebering} 07* 0.25-a0-11-gb8d28a4: Misleading text when renouncing religion (8887) 10(3 days ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/b8d28a4aeb7e
07:47:53 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-11-gb8d28a4aeb (34)
07:48:09 <Cheibriados> 03ebering02 07* 0.25-a0-12-g1381ef2: Update CREDITS 10(52 seconds ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/1381ef2bc469
08:02:29 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-12-g1381ef2bc4 (34)
08:11:10 <shalmezad> If I'm reading this right, travis CI does build tiles and webtiles, but not android, right?
08:12:43 <aidanh> shalmezad: there is no official android build
08:13:42 <aidanh> (so that's a yes, you're correct, no, it doesn not build it)
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-11-g94a4266: Fix off-by-one error 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/94a426642890
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-12-geac6ed6: Add ui::Switcher::current_widget() 10(2 days ago, 2 files, 9+ 0-) 13https://github.com/crawl/crawl/commit/eac6ed6c820a
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-13-gb91b22b: Fix some event forwarding bugs 10(2 days ago, 4 files, 11+ 13-) 13https://github.com/crawl/crawl/commit/b91b22b36588
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-14-gf3c9ec5: Fix segfault when delivering mousebutton events 10(3 days ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/f3c9ec5a1a71
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-15-g1d9ec65: Don't allow showing messages on arena team choice UI 10(41 minutes ago, 1 file, 1+ 7-) 13https://github.com/crawl/crawl/commit/1d9ec6570cd6
09:54:42 <Cheibriados> 03Aidan Holm02 07[ui-fixes] * 0.25-a0-16-g195debd: Factor out Region::contains_point() 10(25 hours ago, 2 files, 12+ 25-) 13https://github.com/crawl/crawl/commit/195debd732b5
10:21:36 <advil> alexjurkiewicz it was broken in trunk for probably a couple weeks, is fixed now. Given that seeds change on trunk it wouldn't surprise me if even online most players using that mode on CPO are just playing 0.23
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-13-g8ab17b4: Fix off-by-one error 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8ab17b4d2b7d
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-14-gbc5b4a9: Add ui::Switcher::current_widget() 10(2 days ago, 2 files, 9+ 0-) 13https://github.com/crawl/crawl/commit/bc5b4a908130
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-15-gc27d5b8: Fix some event forwarding bugs 10(2 days ago, 4 files, 11+ 13-) 13https://github.com/crawl/crawl/commit/c27d5b89ad21
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-16-g2533fd6: Fix segfault when delivering mousebutton events 10(3 days ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/2533fd6716c4
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-17-gb94451d: Don't allow showing messages on arena team choice UI 10(2 hours ago, 1 file, 1+ 7-) 13https://github.com/crawl/crawl/commit/b94451d52d75
11:15:39 <Cheibriados> 03Aidan Holm02 07* 0.25-a0-18-gf4602a8: Factor out Region::contains_point() 10(26 hours ago, 2 files, 12+ 25-) 13https://github.com/crawl/crawl/commit/f4602a88a125
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-12-gff0f5c7: Fix off-by-one error 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ff0f5c72dbc8
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-13-gbd631bd: Add ui::Switcher::current_widget() 10(2 days ago, 2 files, 9+ 0-) 13https://github.com/crawl/crawl/commit/bd631bd1fb96
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-14-g4467201: Fix some event forwarding bugs 10(2 days ago, 4 files, 11+ 13-) 13https://github.com/crawl/crawl/commit/44672012a7f7
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-15-g65f01f3: Fix segfault when delivering mousebutton events 10(3 days ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/65f01f3a6f57
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-16-g1bb75ce: Don't allow showing messages on arena team choice UI 10(2 hours ago, 1 file, 1+ 7-) 13https://github.com/crawl/crawl/commit/1bb75cea03d5
11:17:32 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.24] * 0.24-b1-17-g333a2cb: Factor out Region::contains_point() 10(26 hours ago, 2 files, 12+ 25-) 13https://github.com/crawl/crawl/commit/333a2cbe936b
11:19:08 <geekosaur> …dammit. (just rebuilt)
11:21:29 <aidanh> rats
11:24:28 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001
11:42:06 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-18-gf4602a88a1 (34)
12:46:38 -!- amalloy_ is now known as amalloy
13:13:17 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.25-a0-18-gf4602a8 (34)
16:14:55 <Cheibriados> 03advil02 07* 0.25-a0-19-g74baf03: Add a webtiles seed selection popup 10(6 minutes ago, 5 files, 212+ 26-) 13https://github.com/crawl/crawl/commit/74baf033cde2
16:14:55 <Cheibriados> 03advil02 07* 0.25-a0-20-g8315797: Fix a js error in go_lobby 10(79 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/83157970ee14
16:18:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-20-g83157970ee (34)
16:20:54 <aidanh> advil: re seed ui, fear not, textbox widgets are on the way
16:21:08 <advil> sounds good
16:21:55 <aidanh> although I'm not sure how that'll work with webtiles, and honestly the UI stuff on webtiles is all pretty awful
16:23:58 <advil> doing it in a general way in webtiles is probably hard but adapting what exists to specific text input boxes shouldn't be too bad
16:24:19 <advil> the only trick would be that the assumption that they are modal is heavily exploited in the webtiles code
16:24:51 <advil> so if you make them selectable (which presumably we want someday) handling that might be tricky
16:25:56 <advil> but probably not impossible
16:26:28 <aidanh> not sure what you mean by them (textboxes?) being modal
16:27:19 <aidanh> I think giving textbox widgets an id and syncing the text content back and forth whenever it changes will work
16:28:54 <aidanh> the textbox widget is basically done, but the focus handling and event delivery model need some work
16:32:18 <advil> when a textbox is up that is the only ui element that's active, any keys that do anything first pass through and are filtered by the text input code
16:32:37 <advil> so it's not designed for e.g. a hypothetical configuration menu that has 30 textboxes or whatever
16:32:43 <advil> I'm sure it's fixable
16:35:10 <aidanh> ah I see, right
16:36:43 <advil> alexjurkiewicz: I'm considering moving seeded games into their own save directory, like sprint games. I think the way this will impact CPO is just that any ongoing seeded games in trunk will need to be loaded using the regular trunk button until they are done, does that sound correct (and ok) to you?
16:36:47 <advil> alexjurkiewicz: (would that mess with how your challenge saves are set up? Not sure how you did that)
16:37:13 <Cheibriados> 03gammafunk02 07* 0.25-a0-21-ga5a8db4: Update the changelog 10(58 seconds ago, 1 file, 125+ 0-) 13https://github.com/crawl/crawl/commit/a5a8db46c77b
16:47:52 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-21-ga5a8db46c7 (34)
16:54:54 <advil> alexjurkiewicz: another question -- is the seeded logfile available over html for CPO? (I realize nothing uses it yet.) I guessed https://crawl.project357.org/dcss-logfile-seeded-0.23 etc but that doesn't work
16:59:30 <advil> actually hm maybe it would be best to move the save file on upgrade
17:27:32 <advil> ugh this is a bit messy
17:28:01 <advil> wish I'd done this from the beginning, figuring out how to move a save safely is not very easy
18:01:47 <shmup> :(
18:02:36 <alexjurkiewicz> advil: sounds fine, people can deal with a migration. However I wish you would go in the opposite direction actually and unify the logfile/milestones
18:03:14 <alexjurkiewicz> advil: for seeded logfiles/milestones put -seeded at the end. Yes this is ugly and inconsistent
18:23:44 <Lantell> Unstable branch on underhound.eu updated to: 0.25-a0-21-ga5a8db46c7 (34)
18:33:14 <advil> alexjurkiewicz: unifying logfiles would be fine except one would have to first ensure sequell and cao scoring did the right thing. But do you think save files should stay this way?
18:33:35 <advil> I was figuring it would be kind of annoying for the player to have only one save slot to decide between a seeded and non-seeded game
18:39:36 <advil> yeah, milestone/logfile entries do not include game type
18:40:30 <alexjurkiewicz> advil: my rationale is that it is weird in combination with how crawl otherwise has one save slot per name
18:41:21 <alexjurkiewicz> it would be nice if you could have multiple saves for a single username in webtiles, but that's technically challenging and would require greater rework of scoring/tracking
18:41:21 <advil> well, except for sprint
18:41:33 <advil> which is the model I was using
18:41:46 <alexjurkiewicz> good point. I guess I'm looking at it from the other end
18:41:54 <alexjurkiewicz> now you mention it, unify sprint scoring and saving :)
18:42:57 <advil> for saving, I think people use sprint as a break from their long game, so that would definitely provoke some complaints
18:43:27 <alexjurkiewicz> i wonder if giann's work on json morgue could be expanded to a newer logfile/milestone format. It has a couple of warts
18:48:07 <advil> the other issue having separate slots would solve is that "starting" a non-seeded game in all the UIs when a seeded game exists just loads the existing game (and vice versa)
19:01:58 <advil> aidanh: I think I finally figured out what multi-char macros were for -- not macros, but keybinds triggered by terminal special codes. These may be terminal dependent but here's some exx: http://ascii-table.com/ansi-escape-sequences-vt-100.php
19:02:02 <advil> (scroll down to VT100 Special Key Codes)
19:02:53 <advil> I found this by looking at the keybinds in http://crawl.develz.org/configs/trunk/ldf.macro, which was reported in 12095
19:02:53 <advil> given this, we may actually want to revert that commit?
19:03:31 <advil> not sure how widely used these are going to be, given that console players are somewhat rare these days, but for someone who was using this heavily like that player, this change will break a lot of their keybinds
19:03:48 -!- amalloy is now known as amalloy_
19:04:49 <advil> (also, as a side-effect of the way that commit works, anyone who had these sorts of keybinds will now have a broken esc key -- since they are all escape codes, that's what it gets truncated to)
19:13:17 <Cheibriados> Cannot exit from aptitude screen from start species screen 13https://crawl.develz.org/mantis/view.php?id=12098 by vt
19:14:27 <Pinkbeast> Oh, is this 12095? Did I call it, re the commit?
19:14:32 <advil> aidanh summarized the situation here: https://crawl.develz.org/mantis/view.php?id=12095&nbn=2#bugnotes
19:14:36 <advil> Pinkbeast nope, sorry ;-)
19:14:43 <Pinkbeast> Curses :-(
19:15:36 <advil> well, I didn't check back further so it could have been broken before the commit I linked, I suppose
19:30:28 <advil> ah, yes I have no replicated this with trying to bind option+arrows on mac terminal with default settings, which is an obscure example but probably on some other terminals there will be much less obscure case
19:32:03 <advil> (where binding that key combo in 0.23.2 worked)
21:10:50 <Cheibriados> 03ebering02 07* 0.25-a0-22-gc5ee894: Further update the changelog 10(44 seconds ago, 1 file, 28+ 4-) 13https://github.com/crawl/crawl/commit/c5ee89407969
21:18:03 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-22-gc5ee894079 (34)
21:22:27 -!- amalloy_ is now known as amalloy
21:38:58 <Cheibriados> 03advil02 07* 0.25-a0-23-gdc1bd94: Fix Ru sacrifice delay with faith (12096 / @Wise Wolf) 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/dc1bd944b940
21:39:39 <advil> oops that apparently linked some random github user because of the space
21:48:05 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.25-a0-23-gdc1bd944b9 (34)
21:55:25 <ebering> maybe they'll come contribute!
23:32:48 <ebering> gammafunk: I added my changelog changes
23:33:05 <ebering> I started writing a cdo post and then got daunted by the length since I didn't do them incrementally this cycle
23:33:15 <ebering> The draft is there if you want to take it over