00:45:14 -!- amalloy_ is now known as amalloy
01:23:11 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-2461-g77d781cab4
02:48:28 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de
05:49:17 -!- amalloy is now known as amalloy_
05:53:53 -!- joemaro- is now known as joemaro
09:26:06 <Lantell> Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3
11:27:07 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001
14:24:49 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-770-gad1f87b: Fix empty high scores menu (Goratrix, 12080) 10(10 minutes ago, 1 file, 11+ 2-) 13https://github.com/crawl/crawl/commit/ad1f87bc8924
14:24:49 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-771-g643f6c6: Fix main menus not handling app quit (Goratrix, 12080) 10(51 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/643f6c6e1a8e
14:33:10 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-771-g643f6c6e1a (34)
15:37:38 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-772-gbb1ff42: Fix invalid read causing map-view crash (jackofblades, 12069) 10(37 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/bb1ff42f1e00
15:39:52 <advil> is that the X view crash that I couldn't replicate?
15:40:58 <advil> maybe not
15:47:55 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-772-gbb1ff42f1e (34)
15:51:42 <aidanh> quite possibly
15:59:40 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-773-g3be9bf8: Add keybind to clear player name (kitchen_ace, 12084) 10(7 minutes ago, 1 file, 13+ 10-) 13https://github.com/crawl/crawl/commit/3be9bf80fb2e
16:01:13 -!- amalloy_ is now known as amalloy
16:03:05 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-773-g3be9bf80fb (34)
17:05:47 <Cheibriados> 03Aidan Holm02 07* 0.24-a0-774-gf26d611: Fix dungeon feature quotes not visible (Vaamat, 12032) 10(18 seconds ago, 3 files, 26+ 8-) 13https://github.com/crawl/crawl/commit/f26d6114a74a
17:11:26 <advil> aidanh it's https://github.com/crawl/crawl/issues/1166 if you have a way of checking, there are a couple saves there
17:18:13 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-774-gf26d6114a7 (34)
17:18:35 <aidanh> yeah, that's the one
17:19:31 <advil> ah  yeah I added that check as an ASSERT and it definitely crashes when the water in those saves is in view in X
17:19:45 <advil> not sure why it didn't crash on mac otherwise
17:24:20 <advil> hm maybe `_is_seen_shallow` etc should return false immediately if _safe_feat returns DNGN_UNSEEN?
17:26:37 <aidanh> is there any significant difference between !seen() and DNGN_UNSEEN?
17:27:03 <advil> !seen in _safe_feat DNGN_UNSEEN is returned if the bounds check fails
17:27:03 <Sequell> Sorry advil, I haven't seen in.
17:27:08 <advil> heh
17:27:34 <advil> that !seen was a typo anyways
17:28:32 <advil> whereas I think that !seen thing will crash (just not on a mac apparently) if the bounds check fails
17:29:51 <aidanh> ah, I see what you mean
17:31:05 <aidanh> yeah, that might be a slight improvement
17:32:10 <aidanh> the whole _safe_feat() thing is kinda ugly, but it's not ugly enough to really motivate me to improve it
17:32:56 <advil> yeah not sure it is a big deal
17:34:20 <aidanh> the crash is maybe just windows being more strict with out-of-bounds reads?
17:37:46 <Cheibriados> 03advil02 07* 0.24-a0-775-gb0425b2: Remove an ifdef related to seed selection 10(3 days ago, 1 file, 0+ 8-) 13https://github.com/crawl/crawl/commit/b0425b2895e2
17:37:46 <Cheibriados> 03advil02 07* 0.24-a0-776-g8ac5403: Add an explicit bounds check to crawl_view_buffer () 10(3 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/8ac54030cd55
17:49:34 <Cheibriados> 03S. Mark02 {GitHub} 07* 0.24-a0-777-g30414c0: Fix typo. 10(11 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/30414c0b4592
17:51:11 <Cheibriados> 03wheals02 {GitHub} 07* 0.24-a0-778-g74da537: Update mailmap. 10(8 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/74da537585e1
18:05:41 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-776-g8ac54030cd (34)
18:18:20 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.24-a0-778-g74da537585 (34)
18:24:23 <Lantell> Unstable branch on underhound.eu updated to: 0.24-a0-778-g74da537585 (34)
22:24:56 <p0a> Hello, I'm reading the source code for _acquirement_armour_slot in acquire.cc
22:25:55 <p0a> It says Centaurs and Nagas get higher chances of obtaining the armour if they haven't seen it
22:25:58 <p0a> but I think the opposite happens
22:26:50 <p0a> nevermind im dumb
22:27:01 <p0a> no yeah
22:27:30 <p0a> so there's an extra roll that returns EQ_BOOTS sometimes; it's 1/4 if seen_armour[bard] is true; it's 1/2 if seen_armour[bard] is false
22:28:00 <p0a> after that extra roll, if it fails to return EQ_BOOTS, the normal armour slot roll occurs.
22:28:16 <p0a> (is the barding a boot? :S)
22:36:56 <p0a> I wrote an issue on github instead I'll see when it is replied to, thanks
22:39:39 <advil> barding is in the boots slot
22:39:55 <advil> that logic looks correct to me?
22:40:59 <advil> 50% chance if they haven't seen any, 25% chance if they have (plus an extra 1/6 for the regular roll)
23:24:24 <Cheibriados> alarm trap spawned on staircase 13https://crawl.develz.org/mantis/view.php?id=12087 by GrumpyCat