00:39:35 03argonaut02 {ebering} 07* 0.24-a0-726-g2f2aade: The unrand staff of Battle 10(6 months ago, 7 files, 53+ 1-) 13https://github.com/crawl/crawl/commit/2f2aade273a4 00:39:35 03ebering02 07* 0.24-a0-727-g0e0b679: Tiles for the staff of Battle (CanOfWorms) 10(6 minutes ago, 4 files, 3+ 2-) 13https://github.com/crawl/crawl/commit/0e0b6798f169 00:42:44 should it get an inscription to denote its enhancer property? 00:44:21 03Nikolai Lavsky02 {ebering} 07* 0.24-a0-728-gf61156f: Distinguish flammable and non-flammable trees 10(2 months ago, 4 files, 15+ 5-) 13https://github.com/crawl/crawl/commit/f61156fd2af9 00:44:21 03Nikolai Lavsky02 {ebering} 07* 0.24-a0-729-gac2e79e: Add descriptions for awoken autumnal and dead trees 10(4 days ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/ac2e79e1c788 00:51:42 alexjurkiewicz: maybe but enahncers produce a message with each cast so 00:59:52 03NormalPerson702 {ebering} 07* 0.24-a0-730-g011b83a: Let Trog and Okawaru gift regular boomerangs and javelins 10(7 weeks ago, 1 file, 10+ 6-) 13https://github.com/crawl/crawl/commit/011b83addebf 01:02:33 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-729-gac2e79e1c7 (34) 01:04:02 oh man giann's morgue improvements look super cool 01:04:10 but also a real burden on server operators 01:17:43 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-730-g011b83adde (34) 01:27:48 03Aidan Holm02 07[ui-fixes] * 0.24-a0-723-g93433d4: Fix difficult-to-read main menu labels on console (advil) 10(11 hours ago, 2 files, 43+ 30-) 13https://github.com/crawl/crawl/commit/93433d4062d2 01:27:48 03Aidan Holm02 07[ui-fixes] * 0.24-a0-724-g1ecdbc2: Tidy up some duplication and incorrect naming 10(8 minutes ago, 2 files, 10+ 11-) 13https://github.com/crawl/crawl/commit/1ecdbc2b4b7a 01:39:35 ebering: I don't think real burden, assuming there is an rc file option to disable them 01:39:52 I guess most server admins will disable them until JSON morgue readers exist 01:39:57 !seen giann 01:39:57 I last saw giann at Mon Mar 21 20:28:42 2016 UTC (about 3y 28w 9h 11m 14s ago) quitting, saying 'Client Quit'. 01:40:11 hm, did they have another name in here? 01:40:13 !seen giann__ 01:40:14 Sorry alexjurkiewicz, I haven't seen giann__. 01:40:15 !seen giann_ 01:40:16 I last saw giann_ at Thu Apr 2 19:08:06 2015 UTC (about 4y 26w 4d 10h 32m 9s ago) quitting, saying 'Client Quit'. 01:43:56 alexjurkiewicz: bgiannan 01:44:04 oops 01:44:29 i'm here 01:47:33 alexjurkiewicz, aidanh, i have a json morgue reader in the works. 01:48:13 Though i've not work on it in a while since it didn't seem that the json PR was that appealing 01:48:55 bgiannan: I've been somewhat inactive 01:49:18 machine readable morgues would be great imo 01:49:19 can't make landing timeline guarantees, I'm in the midst of a job search 01:49:23 but there is dev interest 01:50:21 good to know 01:53:09 ebering, note that the PR as it is it not finished. I think some discussion/debate are needed to flesh out what really needs to be in the json. 01:53:23 for sure; when I get some time I'll add my inputs 01:53:34 screenshots looks ready to go as is on a quick read 01:53:45 tho it would be cool if you could save the colors too 01:54:16 that's harder to do in a portable way but ANSI terminal escapes should be ok 01:54:40 ah yes did not think of that 01:55:30 hm. no I take that back; you should limit screenshots to one per turn 01:55:53 well 01:55:58 what are you taking back? 01:56:08 that screenshots looks ready to go 01:56:19 I'm worried about a server denial of service attack vector 01:56:44 the notes field already is, in that a malicious actor could spam in notes 01:57:27 ansi terminal escapes probably won't work for windows console 01:57:51 !blame3 windows 01:57:51 wiiiiindooooows 01:58:05 and most people view the morgue file in a browser i think 01:58:05 heh 02:00:46 that's true, but there's the hiscores in-game ui 02:02:08 is there any plan for auto-conversion of old morgues to new? 02:02:46 hm, I guess that'd be tough to do robustly 02:03:10 I think the json draft at present just adds json morgues side by side? 02:03:42 yeah; I was mostly thinking of how this could be used to spruce up the hiscores ui 02:04:12 one thing that would be great is if the player tile was saved 02:12:16 aidanh, i can imagine having a converter txt -> json but it would be limited 02:12:35 the whole point of the json branch is that the txt is not exploitable/parsable 02:12:47 the hiscore section could however be parsed pretty easily 02:13:03 ebering, if you want to take a look, here's my json morgue reader: https://github.com/giann/crawl-undertaker 02:15:14 yeah, makes sense 02:15:23 great project name 02:16:24 thx 02:20:25 yeah this looks great 02:21:32 I especially like the timeline-style notes section 02:24:55 the idea is that things like unique names, item names, etc. will be hoverable/clickable and show information from learndb 02:25:47 i also did https://github.com/giann/crawl/commit/d4a53bd443e83f2640e4678a64233a64b845ed50 02:25:51 nice 02:26:11 so that the monster-util can serve json as well 02:27:02 i think this open doors to a lot of things we could do 02:27:30 yeah definitely 02:28:36 ah, quick comment: the seed should be stored as text, not as a number, otherwise you can lose precision 02:29:04 can you make that comment on the PR so that i don't forget? 02:29:09 sure thing 02:37:25 New branch created: pull/1160 (1 commit) 13https://github.com/crawl/crawl/pull/1160 02:37:25 03AdamPG02 07https://github.com/crawl/crawl/pull/1160 * 0.24-a0-711-g464653c: Fix incorrectly displayed success chance for confusion gaze 10(8 minutes ago, 5 files, 53+ 16-) 13https://github.com/crawl/crawl/commit/464653c28418 02:44:15 ebering, right now screenshots are taken whenever a user makes a note. Should I: limit user notes to one a turn altogether? limit screenshots alone to one a turn? 02:44:43 The build was fixed. (ui-fixes - 1ecdbc2 #11961 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/591845117 02:44:44 or create a new commands that creates a screenshot notes 02:44:58 and left the current note command untouched 02:54:26 simplest approach would be to limit every game to 50 screenshots 02:55:00 well, it might be the simplest approach. And for non-webtiles build, the limit could be unlimited (since users can DOS themselves if they want :D) 02:59:58 what happens when the limit is reached? print a "Screenshot limit reached" warning? 03:01:54 how is this problem solved for ttyrecs? 03:04:39 good point. They have no protection and could generate far more traffic 04:34:52 03Aidan Holm02 07* 0.24-a0-731-g3ed16d2: Refactor curses colour and attr munging 10(15 hours ago, 1 file, 72+ 96-) 13https://github.com/crawl/crawl/commit/3ed16d2262f8 04:34:52 03Aidan Holm02 07* 0.24-a0-732-g6844edd: Fix difficult-to-read main menu labels on console (advil) 10(14 hours ago, 2 files, 43+ 30-) 13https://github.com/crawl/crawl/commit/6844edd79dc0 04:34:52 03Aidan Holm02 07* 0.24-a0-733-g940da44: Tidy up some duplication and incorrect naming 10(3 hours ago, 2 files, 10+ 11-) 13https://github.com/crawl/crawl/commit/940da4496633 04:43:58 03Aidan Holm02 07[ui-fixes] * 0.24-a0-734-gca5e8cfc: Use quads for line drawing (advil) 10(3 minutes ago, 3 files, 11+ 8-) 13https://github.com/crawl/crawl/commit/ca5e8cfc3fef 04:44:54 advil: when you get a chance, could you give that a spin on your VM? 04:45:34 hopefully that will resolve the off-by-one errors 06:03:14 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-733-g940da44966 (34) 06:38:41 -!- bh is now known as Guest27513 08:39:37 aidanh: thats why I said "one per tur" 08:39:48 that way the saave is at most doubling the ttyrec 08:40:14 the attack I worry about is just spamming a screenshot command without taking turns 08:40:24 ah, I see 08:40:44 but, that's still only 192 bytes per attack 08:41:03 so maybe it's not such a big deal 08:45:37 should i put that limit on user note or on the screenshot feature alone? 08:51:22 maybe just don't take a screenshot when taking more notes on the same turn, and refer to the one already taken 08:51:47 i mean, the content should be the same, right? 08:53:56 makes sense yeah 08:54:23 ebering: well, they might be larger if tiles info is screenshotted as well 09:16:28 aidanh: hmm yeah; I guess currently the PR in question uses the screenshot function used for writing morgues 09:16:33 which is text only 09:17:53 sure; I remember there being some discussion a while back about saving tiles screenshots as well, but that can always be worked in later 09:18:45 for now limiting it to one per note is fine; in the future we might want to add a screenshot cap for webtiles builds 09:18:51 er, one per turn 09:18:58 and re-using that turn's shot for all notes 09:25:28 format-wise, storing them as two independent maps (turn -> screenshot, turn -> note) would support that and be pretty flexible wrt future changes 09:46:59 -!- amalloy is now known as amalloy_ 11:15:10 The Mantis bug tracker has a LOT of stuff. Does anyone have opinions on which tickets would be good for someone new to the codebase? 11:18:20 All of mine aha 11:19:28 More seriously, there is a "newbie friendly" tag. I don't know how intensively it is used. 11:20:05 two issues, heh 11:20:20 Ah, well, that's something. 11:20:52 you could search for 'descript', which should yield mostly bugs related to unclear or outdated descriptions 11:20:55 I wouldn't rely on tags on mantis 11:21:47 aidanh: the quad-based menus look great in my virtualbox vm 11:22:34 from googling around, apparently drawing decent lines in opengl is just extremely hard? 11:22:57 I wouldn't necessarily rule out the line-drawing code entirely because it doesn't work for this one niche case though 11:25:23 Stable (0.23) branch on underhound.eu updated to: 0.23.1-89-g277498a001 11:26:06 Heliophobic: I would look mainly at recently mantis reports (~ the last year) and discard anything you can't easily reproduce from whatever's already in the report...unfortunately because of the complexity of crawl it's not extremely easy to predict how complicated a fix will be 11:26:46 Heliophobic: I am going to cheekily list some of mine; 12049 is a simple text tweak as are 11500 and 11692, 11940 is a one-line change suggested in the issue. 11:26:51 mantis reports from Yermak are often good starting points 11:29:05 advil: great, I'll go ahead and merge it 11:29:22 PS staff of Battle, you are a nuisance, vanilla devs :-) 11:29:42 how so 11:29:52 oh you made it a permabuff didn't you 11:30:06 Yeah. So that's going to be an interesting tangle at some point. :-/ 11:30:28 yeah, surprisingly so, but the opengl apis are extremely limited even discounting all the driver bugs 11:30:40 my kingdom for a proper rendering layer 11:31:05 Pinkbeast: re the barbs buck 11:31:12 03Aidan Holm02 07* 0.24-a0-734-gca5e8cfc: Use quads for line drawing (advil) 10(7 hours ago, 3 files, 11+ 8-) 13https://github.com/crawl/crawl/commit/ca5e8cfc3fef 11:31:28 bug 11:31:28 definitely gonna make it a text change for berserk 11:31:28 replacing "carefully remove" with "RIP AND TEAR" 11:31:52 I could live with a message change for berserk but it seems absurd you can do it while, say, petrified. (Yeah, I know, send you a patch to get it done my way) 11:33:06 you'll notice my commit count has been rather low of late 11:33:19 get me a good job and I'll do it your way ;) 11:37:53 ebering are you applying for http://www.mathjobs.org/jobs/jobs/14076 ? it looks relevant, insofar as I can decode math research area names 11:38:01 I have 0.0 pull in that dept though 11:43:49 alexjurkiewicz: btw if you're wondering why your menus aren't working, you need to focus them with ui::set_focused_widget() 11:47:41 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-734-gca5e8cfc3f (34) 11:48:20 advil: maybe but I am not an algebraic geometer or topologist in the modern sense of either of those words so I'm probably not going to make their list 11:53:12 ah, well, that's what I mean by decoding math research areas 11:53:23 ebering: 11:53:33 Whoops, typing error, sorry 11:53:44 yeah 11:53:53 the adjectives are all really overloaded 11:56:32 -!- amalloy_ is now known as amalloy 12:14:52 Quick Opinion Poll: In real life Komodo Dragons are quite poisonous, but not in Crawl. Also in real life, spiny toads aren't poisonous, but they are in Crawl. Would komodo dragons in, say, Lair be too powerful if they were poisonous? 12:16:40 ??realism 12:16:40 realism of crawl[1/10]: whacking KILLER FUCKING BEES with a halberd and throwing javelins at them 12:17:03 lol 12:17:17 ...Okay, right. Realism. I get that. 12:18:20 For some reason I'm always just a little disappointed komodo dragons aren't more dangerous. They're nightmares IRL. 12:19:13 They can swallow a whole goat. It's kind of amazing. 12:19:48 "Although previous studies proposed that Komodo dragon saliva contains a variety of highly septic bacteria that would help to bring down prey,[42][46] research in 2013 suggested that the bacteria in the mouths of Komodo dragons are ordinary and similar to those found in other carnivores. They actually have surprisingly good mouth hygiene." 12:20:14 ... also I think Crawl's komodo dragons are pretty damn dangerous but I think that's because of the way one is disproportionately scarred by any splat just before one's first win 12:20:17 komodo dragons hit like a truck in crawl anyway 12:20:28 for the level at which you encounter them 12:20:46 r??realism 12:20:47 realism_of_crawl[1/10]: whacking KILLER FUCKING BEES with a halberd and throwing javelins at them 12:20:58 the perils of randomness 12:21:20 hm, maybe not random. i thought r?? was how to look up a random entry 12:25:22 yeah, I would say a lair 1 komodo dragon is pretty rough, I will exclude them there if I catch them sleeping 12:26:02 1 can be a random number! 12:26:21 though I think you're right, in this case it is not 12:29:50 ah it needs an exact entry name 12:29:51 r??realism_of_crawl 12:29:52 realism_of_crawl[9/10]: case OBJ_GOLD: unit_mass = 0; 12:30:33 ah, right 12:56:20 would be great if someone found a way to fix this: https://crawl.develz.org/mantis/view.php?id=11924 12:56:29 it's sooo annoying 12:58:02 * Pinkbeast mutters "my preferred fix would be to remove peekaboo vaults", yes I know that's not going to happen. 12:59:26 That has happened to me lots. Not just with wolf spiders. 12:59:36 But I don't know if it's a bug. I mean, wouldn 13:00:08 wouldn't players get angry if autoexplore never notified them of peekaboo vaults? They would just pass by them and never know they were on the level, right? 13:00:40 it happens with any clinging monsters 13:00:53 here's another on the same issue: https://crawl.develz.org/mantis/view.php?id=11867 13:01:35 AH, what you don't like is it stops your Next autoexplore. You're not upset that autoexplore is stopped once. I see. 13:01:42 yes 13:02:03 the game thinks the clinging monster can get to you 13:08:27 it's a bug 13:09:01 a clingy bug 13:14:16 Fairly new to the code base, but could it be a quick check in mon-pathfind.cc, in mons_traversable for the second bit that deals with mons->can_cling_to_walls (check to see if pos is a runed door, though probably other cases I don't know about) 13:18:41 New branch created: pull/1161 (13 commits) 13https://github.com/crawl/crawl/pull/1161 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-585-gddfcd3f: #984 making text more clear for mutation 10(4 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ddfcd3f28af4 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-586-ga1d924b: #984 make it seem more positive 10(3 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a1d924bc89e8 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-587-g4a44c8d: first pass, adding flavour text 10(2 weeks ago, 1 file, 48+ 11-) 13https://github.com/crawl/crawl/commit/4a44c8d3bb5b 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-588-g7bfc43f: cleaning up and adding options 10(2 weeks ago, 1 file, 50+ 10-) 13https://github.com/crawl/crawl/commit/7bfc43f112ce 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-589-g277e9bb: obviously the funniest monster 10(2 weeks ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/277e9bb9bcb3 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-590-gf224aed: adding some humour, retrieving some original lines 10(13 days ago, 1 file, 24+ 8-) 13https://github.com/crawl/crawl/commit/f224aed09ad6 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-591-g887685b: I found a few really good quotes that fit. 10(12 days ago, 1 file, 14+ 5-) 13https://github.com/crawl/crawl/commit/887685b1bc57 13:18:41 03theJollySin02 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-592-g33ee609: breaking these ideas into two branches 10(12 days ago, 1 file, 5+ 14-) 13https://github.com/crawl/crawl/commit/33ee609908a3 13:18:41 03John Stilley02 {GitHub} 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-593-ge26d63a: a couple new ideas 10(10 days ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/e26d63acc56c 13:18:41 03theJollySin02 07https://github.com/crawl/crawl/pull/1161 * 0.24-a0-594-g69a9cf8: adding some monsters 10(9 days ago, 1 file, 33+ 5-) 13https://github.com/crawl/crawl/commit/69a9cf87f678 13:18:41 ... and 3 more commits 13:18:55 `&& !cell_is_runed(pos)` perhaps? 13:19:31 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-734-gca5e8cfc (34) 13:20:09 !source mon-pathfind.cc 13:20:10 https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-pathfind.cc 13:21:49 The cell_is_runed idea comes from mons_can_traverse, which is in mon-util.cc if you want to check that as well (line 4183) 13:29:26 03AdamPG02 07https://github.com/crawl/crawl/pull/1160 * 0.24-a0-712-g3f6f6c4: Fix some typos 10(6 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/3f6f6c4144a5 13:30:12 hrm, even if it's not clinging, the spider still prevents autotravel 13:54:39 well, apparently that spider knows a path towards the player, which makes it unsafe, which stops autotravel 13:54:44 which explains why it hangs around the door 13:57:15 it has to have something to do with the clinging property, only happens with those monsters in runed vaults 13:58:18 gecko, spider, dart slug, cockroach 14:09:12 https://pastebin.com/cTmLmk41 I think this may fix it. That mons_traversable is used by the pathfind algorithm, and the part after the or seems to be rather hacky to get clinging monsters to traverse otherwise non-traversable terrian 14:32:22 that function does look pretty buggy 14:37:51 oh boy are we gonna fix this bug 14:37:53 I'm excited 14:38:02 shalmezad: great work! 14:38:51 i think cell_can_cling_to needs to check that the cell being clung to isn't solid 14:41:08 the rune check should definitely be added though, as well as the mon.is_habitable(p) check 14:41:18 I guess that's what cell_can_cling_to() should check 14:41:53 The odd thing is those checks are in mon_can_traverse. May want to consider moving the cling check there 14:42:00 *in mon-util.cc 14:42:31 *mons_can_traverse, with an s 14:47:44 it can't be, because cell_can_cling_to's correctness depends on the current monster position 14:48:13 well, current position in the context of pathfinding 14:48:27 mon_can_traverse doesn't have access to that info 14:49:31 Ah, overlooked that pos and p are different. Nevermind then 14:50:14 huh 14:51:21 it looks like that call to cell_is_clingable should be given p, not pos 14:55:10 03Aidan Holm02 07[ui-fixes] * 0.24-a0-735-gb75cad0: Refactor and improve UI widget iterators 10(79 minutes ago, 2 files, 73+ 112-) 13https://github.com/crawl/crawl/commit/b75cad06ff4e 14:57:42 when are we going to get more commits that unleash the power of Current Scissors? 14:57:57 fr: an unrand pair of scissors 15:00:33 dropped by a new unique named edward 15:02:39 Hey aidanh, unless you have an urge to fix it now, mind if I take a look at the clinging issue tonight and see if I can come up with a good PR for it? 15:03:04 I already have a fix almost ready to roll 15:03:12 thanks for your help though, you were instrumental 15:04:53 03Aidan Holm02 07* 0.24-a0-735-g323ad4e: Fix clinging monsters breaking autoexplore (shalmezad, 11924) 10(9 minutes ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/323ad4e9fb1d 15:05:28 thank god 15:05:46 I did try to fix that bug briefly when I added clear runed doors/clear doors 15:05:51 but it was a pita to track down 15:07:20 yeah for sure, the monster code is definitely a little bewildering 15:08:59 woooooooooooo 15:12:37 03Aidan Holm02 07[ui-fixes] * 0.24-a0-736-geb779c0: Refactor and improve UI widget iterators 10(2 hours ago, 2 files, 75+ 112-) 13https://github.com/crawl/crawl/commit/eb779c0a957c 15:15:45 related to this is the sensing of invisible monsters in vaults 15:16:03 hrm, wonder if this was actually just clinging, let me test to see if I can trigger it 15:16:42 are there invisible monsters that cling? 15:16:52 invisible wolf spiders... *shudders* 15:17:05 not innately I don't think, obv you can make them invis, but I'm testing to see if it's a problem with invis monsters as well 15:17:23 ah, yes 15:18:00 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-735-g323ad4e9fb (34) 15:18:04 https://cdn.discordapp.com/attachments/325651923514556417/628671938826600500/unknown.png 15:18:13 I placed that ghost vault, put a ghost moth in there 15:18:24 and when I attempt to autoexplore it gives that message 15:18:48 the moth is at that { glyph 2 squares away 15:23:43 Mind if I were to try a fix for 12065 tonight? I believe it should just be a check status in player-reacts.cc before line 832. 15:24:05 !bug 12065 15:24:05 https://crawl.develz.org/mantis/view.php?id=12065 15:24:39 well I don't think anyone minds at all if you fix a bug, unless they've said they're about to push a fix, I guess :) 15:25:05 shalmezad: btw, if you want to work more on fun autoexplore issues, that invis monster behind runed doors bug I just outlined is still a problem 15:25:15 unless aidanh is on the trail and about to fix 15:25:50 it's perhaps less common than the clinging monster issue, but it's still fairly common and just as annoying 15:26:49 heh 15:26:51 !source nearby-danger.cc:303 15:26:52 https://github.com/crawl/crawl/blob/master/crawl-ref/source/nearby-danger.cc#L303 15:27:37 all the pathfinding checks only happen for visible monsters; this check is totally independent, and just looks for known disturbances 15:30:38 hrm 15:30:54 well extending the pathfinding check to include known disturbances could be a thing, no? 15:31:21 !source _exposed_monsters_nearby 15:31:21 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/nearby-danger.cc#L217 15:31:44 hrm 15:31:47 !source get_nearby_monsters 15:31:48 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/nearby-danger.cc#L181 15:32:09 i mean, the dang thing already has six bool parameters, what harm could one more do 15:32:29 shouldn't that just use LOS_NO_TRANS? or is that just too unsafe and we'd have to move this totally to pathfinding stuff 15:32:35 by that I mean the function I linked 15:32:49 yeah, wow, that's a lot of params 15:34:06 well, that'd also work, but afaik a single tile of glass between you and the monster would then allow autoexplore 15:35:09 aidanh: Good Design dictates you replace them all with a single bitwise int param. fewer parameters means more clarity! 15:35:58 !source mons_is_safe 15:35:59 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/nearby-danger.cc#L129 15:36:49 !source mons_can_hurt_player 15:36:49 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/nearby-danger.cc#L97 15:37:13 so I guess the problem with extending this to invis monsters might be information leak 15:37:44 but we could sort of assume some kind of worse case, I guess 15:38:37 seems like we'd ideally want to treat sensed invis monsters with this codepath and remove the independent check on invis sensed monsters 15:38:46 as that will never be able to be accurate without pathfinding of some kind 15:38:59 you jest, but I do think that would probably make it clearer 15:40:40 hm, is there some sort of mon->is_sensed() getter? that'd make this straightforward enough 15:43:00 aidanh: env.map_knowledge(mon->pos()).flags & MAP_INVISIBLE_MONSTER would be the check I think 15:43:14 thanks 15:45:11 hrm, although I suppose there's an issue with that, which is that a monster could leave a sensed disturbance and not actually be in los 15:45:17 I'm not sure if that can happen 15:45:50 it would be a sort of information leak maybe, but a pretty weird corner case 15:47:04 yeah, but that'd not matter if there's no path to the player, no? 15:47:45 oh, I see, you mean checking env.map_knowledge(mon->pos()) won't work 15:48:46 yeah, if the actual monster is not the target of this iteration but the sensed disturbance would be 15:49:12 specifically if the monster is no longer where the sensed disturbance is 15:49:18 i'm iterating over monsters here 15:49:35 although I don't see that that'd affect this corner case 15:50:13 right, so if we remove this independent sensed disturbance check that we currently have (that doesn't consider pathfinding, just the map knowledge and los) 15:50:13 and only do this check via iteration over actual monsters 15:50:24 imagine if a monster has left a sensed disturbance in los but is no longer in los and hence not the target of this iteration 15:50:36 so it's a sort of information leak is what I'm saying 15:51:00 what information is being leaked in this case? 15:51:09 as the sensed disturbance would not trigger the check ever regardless of pathfind (since there's no monster at the disturbance) 15:51:21 the info that the sense disturbance definitely has no monster there 15:51:39 hold on, I'll upload my wip 15:52:01 but yeah it's weird, since the way you'd try to get this leaked info is via autoexplore 15:53:40 New branch created: wip-autoexplore-bug (1 commit) 13https://github.com/crawl/crawl/tree/wip-autoexplore-bug 15:53:40 03Aidan Holm02 07[wip-autoexplore-bug] * 0.24-a0-736-g8b90856: WIP fix pesky bug 10(39 seconds ago, 1 file, 8+ 12-) 13https://github.com/crawl/crawl/commit/8b908569d6bc 15:55:11 is there a typo in that on line 286? 15:55:29 in that it should be sensed and not visible 15:55:47 for the target vector, I mean 15:56:01 oh, yeah 15:56:13 and the size check is wrong too ugh 15:56:15 thanks 15:57:22 03Aidan Holm02 07[wip-autoexplore-bug] * 0.24-a0-736-g91f9552: WIP fix pesky bug 10(4 minutes ago, 1 file, 8+ 12-) 13https://github.com/crawl/crawl/commit/91f955255332 15:57:30 the idea here is that the sensed vector will only ever contain monsters that can pathfind to you 15:57:50 monsters that can't are already filtered out by get_nearby_monsters() 16:00:03 that's right and that fix makes, but I was just pointing out a sort of leak where if the player sees sensed square and they see that their autoexplore didn't stop, they'd know that there's definitely no monster on that sensed square 16:00:13 s/fix makes/fix makes sense/ 16:01:24 like if the monster that originally caused that sensing had moved somewhere out of consideration (sensed squares last for some turns) 16:01:44 it's just a pretty minor issue though 16:02:57 ah I see what you mean 16:03:06 that wouldn't happen with this implementation though 16:15:34 03Aidan Holm02 07* 0.24-a0-736-g4e6fe30: Fix sealed-off sensed monsters stopping travel (gammafunk) 10(23 minutes ago, 1 file, 12+ 12-) 13https://github.com/crawl/crawl/commit/4e6fe308c7ef 16:15:50 The build was canceled. (wip-autoexplore-bug - 91f9552 #11972 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/592216489 16:18:01 cool, thanks 16:18:34 no worries 16:18:42 I've noticed that one as well 16:32:54 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-736-g4e6fe308c7 (34) 16:37:41 The build passed. (ui-fixes - eb779c0 #11970 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/592195327 16:53:45 -!- aidanh_ is now known as aidanh 18:23:57 Unstable branch on underhound.eu updated to: 0.24-a0-736-g4e6fe308c7 (34) 19:07:00 aidanh: hm which menus of mine aren't working? or do you just mean when I rewrite to use your new code 19:10:07 -!- amalloy is now known as amalloy_ 19:39:39 New branch created: pull/1162 (1 commit) 13https://github.com/crawl/crawl/pull/1162 19:39:39 03Richard Wardin02 07https://github.com/crawl/crawl/pull/1162 * 0.24-a0-737-g8353f7c: Fix being able to pick out barbs while incapacitated (12065) 10(9 minutes ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/8353f7cb1f47 19:42:24 shalmezad: disappointed you did not include RIP AND TEAR as a separate verb for berserk :< 19:45:15 Since you do squash commits, I'm sure nobody will notice if that verb changes :P 19:56:12 I like to press the github rebaase and merge command when I can :) 20:00:36 (and I could now but RIP AND TEAR is a dear old bit of crawlculture) 20:10:28 s/crawlculture/doomculture/ 20:38:26 03srvanmeter8702 {ebering} 07* 0.24-a0-737-g6aba940: Rephrase MP-powered wands player alert (#984) 10(7 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/6aba9404ae88 20:38:26 03theJollySin02 {ebering} 07* 0.24-a0-738-g26e8666: An assortment of item and location quotations 10(12 days ago, 1 file, 28+ 11-) 13https://github.com/crawl/crawl/commit/26e86663625b 20:38:26 03theJollySin02 {ebering} 07* 0.24-a0-739-g463e120: Clean up Paradise Lost quote citations 10(10 days ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/463e12031983 20:38:26 03theJollySin02 {ebering} 07* 0.24-a0-740-gebba34e: Add more random uselessness messages 10(16 minutes ago, 1 file, 67+ 3-) 13https://github.com/crawl/crawl/commit/ebba34edf6e2 20:38:26 03theJollySin02 {ebering} 07* 0.24-a0-741-g7e681d2: Vary orb descriptors in the welcome text 10(31 minutes ago, 1 file, 15+ 2-) 13https://github.com/crawl/crawl/commit/7e681d2d2359 20:38:26 03theJollySin02 {ebering} 07* 0.24-a0-742-g8abc067: Add more flavour to the Halloween welcome spam 10(31 minutes ago, 1 file, 26+ 2-) 13https://github.com/crawl/crawl/commit/8abc0672763f 20:38:47 if I can rebase and rewrite history there's no limit to my power 20:38:57 right on cue chei 20:39:55 :< github auto closing didn't get two of those 20:40:47 984? It did, it just took a second 20:40:54 No, 1133 and 1143 20:41:36 ah yeah. "To close multiple issues, preface each issue reference with one of the above keywords." 20:41:57 I want my smart features to be smarter 20:48:34 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-742-g8abc067276 (34) 20:48:51 03NormalPerson702 {ebering} 07* 0.24-a0-743-gf6d4cf8: Remove troves asking for scrolls of identify 10(8 months ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/f6d4cf813364 20:59:59 advil: by the way, did you ever hear back from r.ax about that access to CAO? 21:00:32 no, I will bug her again tmw, which is a week after the last email 21:01:00 that is, I did hear back and sent my ssh key, but I don't think she got to setting up the account 21:03:10 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-743-gf6d4cf8133 (34) 21:03:24 gotcha, I'll go ahead and send her an email again with mine then 21:03:53 well, not again, since I haven't emailed her at all yet 21:05:19 rax: hey, if you're around, advil and I are still interested in getting access to CAO for purposes of fixing up/maintaining scoring DB and the webtiles server. Not sure if it works for you to have two people with access or what kind of access you can even grant 21:05:39 rax: I will send you an email with my public ssh key regardless 21:08:00 can hardly bear to remove a function called _mushroom_prob() 21:21:05 03ebering02 07* 0.24-a0-744-g42da65f: De-randomize Golden Eye confusion spellpower 10(6 minutes ago, 5 files, 9+ 16-) 13https://github.com/crawl/crawl/commit/42da65fd27e7 21:27:26 -!- amalloy_ is now known as amalloy 21:36:47 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-744-g42da65fd27 (34) 21:43:42 03Richard Wardin02 {ebering} 07* 0.24-a0-745-g3348362: Fix being able to pick out barbs while incapacitated (12065) 10(2 hours ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/3348362083ca 21:44:04 !bug 12065 21:44:04 https://crawl.develz.org/mantis/view.php?id=12065 21:47:46 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-745-g3348362083 (34) 21:57:46 ebering: Thanks :-) 21:58:39 it begins 21:58:43 I've some contact with rax elsewhere, I'll see if I can bring this to their attention. 21:59:09 03gammafunk02 07* 0.24-a0-746-g0b10f19: Fedhas rework part 1: piety gain 10(3 weeks ago, 14 files, 11+ 444-) 13https://github.com/crawl/crawl/commit/0b10f196a578 21:59:09 03gammafunk02 07* 0.24-a0-747-g9563602: Fedhas rework part 2: Wall of Briars ability 10(3 weeks ago, 10 files, 72+ 0-) 13https://github.com/crawl/crawl/commit/95636025921a 21:59:09 03gammafunk02 07* 0.24-a0-748-g1d64b78: Fedhas rework part 3: remove Sunlight 10(3 weeks ago, 16 files, 12+ 202-) 13https://github.com/crawl/crawl/commit/1d64b78cf498 21:59:09 03gammafunk02 07* 0.24-a0-749-g6ba74d5: Fedhas rework part 4: remove Growth 10(3 weeks ago, 9 files, 0+ 163-) 13https://github.com/crawl/crawl/commit/6ba74d58385e 21:59:09 03gammafunk02 07* 0.24-a0-750-gdd8df34: Fedhas rework part 5: remove Evolution 10(3 weeks ago, 11 files, 1+ 295-) 13https://github.com/crawl/crawl/commit/dd8df34df510 21:59:09 03gammafunk02 07* 0.24-a0-751-g7da3b9e: Fedhas rework part 6: simplify ballistomycetes 10(3 weeks ago, 31 files, 57+ 474-) 13https://github.com/crawl/crawl/commit/7da3b9efa77d 21:59:09 03gammafunk02 07* 0.24-a0-752-g7ac76a7: Fedhas rework part 7: rework Reproduction 10(3 weeks ago, 14 files, 438+ 457-) 13https://github.com/crawl/crawl/commit/7ac76a7cd560 21:59:09 03gammafunk02 07* 0.24-a0-753-g8f1ea3d: Fedhas rework part 8: remove Rain 10(3 weeks ago, 8 files, 0+ 121-) 13https://github.com/crawl/crawl/commit/8f1ea3d74cbb 21:59:09 03gammafunk02 07* 0.24-a0-754-g286ebac: Fedhas rework part 9: Overgrow ability 10(3 weeks ago, 12 files, 162+ 0-) 13https://github.com/crawl/crawl/commit/286ebac72db5 21:59:09 03gammafunk02 07* 0.24-a0-755-gdacd3b1: Fedhas rework part 10: Grow Oklob ability 10(3 weeks ago, 9 files, 77+ 0-) 13https://github.com/crawl/crawl/commit/dacd3b15afd9 21:59:09 ... and 3 more commits 21:59:41 03EC2 Default User02 {ebering} 07* 0.24-a0-759-gbfa02ac: Fix wizdump loading when rotted or Gozag follower. 10(3 months ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/bfa02ace7b03 22:28:09 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-759-gbfa02ace7b (34) 22:44:31 03Nikolai Lavsky02 {ebering} 07* 0.24-a0-760-g74cc3ae: Fix display of detected gold on the minimap (11950) 10(4 months ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/74cc3aede520 22:44:47 !bug 11950 22:44:47 https://crawl.develz.org/mantis/view.php?id=11950 22:47:46 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-760-g74cc3aede5 (34) 22:50:26 hi. i can only get poison staff instead of other staff in dcss-git of webtile. http://crawl.akrasiac.org:8080/#watch-simcity