00:26:05 <Cheibriados> 03Psymania02 07https://github.com/crawl/crawl/pull/1120 * 0.24-a0-522-g2206fe9: Braces unneeded, and change ifs to else ifs 10(6 minutes ago, 1 file, 12+ 15-) 13https://github.com/crawl/crawl/commit/2206fe9571b7
01:38:16 <Gretell> Unstable branch on crawl.develz.org updated to: 0.24-a0-520-g8fd06ad (34)
01:42:18 -!- amalloy is now known as amalloy_
01:52:34 <bgiannan> alexjurkiewicz, thanks for the pointers. I had some idea for a morgue viewer/browser. Thought i could start there.
01:58:59 <alexjurkiewicz> hm. I started writing a morgue parser once. It was very annoying. I like your screenshot PR btw. Next step is tiles screenshots and a HTML morgue with embedded data: PNGs :)
02:00:00 <alexjurkiewicz> Psymania: the switch idea seems decent. I guess the alternative is a macro. Not sure if that's good or bad according to crawl convention these days
02:01:16 <Psymania> A macro? Howso?
02:01:54 <Psymania> Oh, to compress each pair of conditions into a single condition?
02:02:17 <bgiannan> alexjurkiewicz, my idea was to modify crawl to generate json morgue files. I also tried a while back to parse morgue files and I don't think it's a good approach.
02:03:04 <bgiannan> of course it would mean you could only view recent morgue files but that's the sacrifice to make i guess
02:09:33 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-520-g8fd06ad
02:11:47 <Psymania> alexjurkiewicz, Well, I'll submit the switch version
02:21:20 <alexjurkiewicz> bgiannan: nice
02:21:34 <alexjurkiewicz> yes please
02:24:19 <aidanh> might want to look into how most people view morgue files; I'd suspect it's via web browser, in which case you'd need some way to render morgues as HTML
02:25:27 <bgiannan> aidanh, my idea is to generate json so it can easily consumed by any app. I'll then make a Vue or React app on top of that.
02:32:28 <bgiannan> !source command.cc:1305
02:32:29 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/command.cc#L1305
02:32:43 <bgiannan> do we actually show the char dump in a scroller on current version?
02:33:29 <bgiannan> seems like it's bound to `#` but that command actually dumps the char in a file if i'm not mistaken
02:34:43 <aidanh> bgiannan: yup, ?# shows it in a popup
02:34:54 <bgiannan> TIL
02:35:47 <aidanh> perhaps the popup should be bound to #, and have a dump-to-file keybind
02:36:00 <aidanh> that'd get everyone up in arms
02:36:21 <bgiannan> how usefull is it to read a morgue file while you're ingame?
02:36:38 <bgiannan> whenever i dump a char, it's to share it outside the game
02:36:55 <aidanh> I usually do it only to check whether I've knocked off dangerous uniques
02:38:43 <aidanh> re json morgues, what I meant is that if crawl were to generate json morgues instead of textual morgues, webtiles would need some UI for displaying morgues at the very least
02:39:21 <Cheibriados> 03Psymania02 07https://github.com/crawl/crawl/pull/1120 * 0.24-a0-523-g29b80de: Change these conditionals for better compliance with crawl conventions 10(51 seconds ago, 1 file, 22+ 12-) 13https://github.com/crawl/crawl/commit/29b80de20620
02:39:34 <aidanh> might have to keep generating textual morgues even then, since there might be infra built around downloading morgues as txt files; other devs would know more
02:40:09 <bgiannan> aidanh, it would generate both format
02:40:39 <bgiannan> too much is relying on txt morgue files for me to replace it
02:48:01 <Psymania> alexjurkiewicz, Just realized that I'm not sure what the code I added in menu.cc does :P I put it there alongside the code which references the halos, as I figured if that is there then my stuff had better be there too...but I'm not sure what it does, and I forgot to check against the user options there
02:48:15 <Psymania> Maybe I'd better do that :)
02:55:31 <alexjurkiewicz> yeah. I'm sure you'd want to keep generating txt as well for a few versions. But a standalone app to view JSON morgues would be great. I don't think you'd want it as part of the main webtiles app either, since that's a crufty ball nobody can update. No harm if the viewer is a standalone thing with its own JS dependencies
02:56:14 <Pinkbeast> It seems extraordinary to suggest one might stop generating text morgues ever
02:56:15 <bgiannan> yes i agree
02:58:02 <aidanh> Psymania: that code is used when rendering monsters in menus, e.g. in the ?/m and ctrl-x popups
03:00:09 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de
03:47:25 <aidanh> alexjurkiewicz: the main problem with webtiles that really cements the cruft is the compatibility requirements, but if you added HTML morgues as a main-page feature, not in-game, it should be ok
03:52:52 <Kelbell> Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-2223-gf5476ef099
04:36:22 <bgiannan> why does stats label are different when rotted?
04:39:08 <bgiannan> oh i get it it's a space issue
04:39:26 <bgiannan> to make room for `(<real_value>)`
04:44:03 <Pinkbeast> I wonder how CKO knows bcrawl is 0.23 but still thinks we're 0.21
06:08:03 -!- amalloy_ is now known as amalloy
06:44:09 <alexjurkiewicz> Alexs-MacBook-Pro ~/personal/crawl/crawl-ref/source [stoatsoup ?] $ git describe
06:44:11 <alexjurkiewicz> 0.21.2-1016-g15a4c85d20
06:44:25 <alexjurkiewicz> your most recent tag is 0.21.2
06:50:15 <Pinkbeast> crawl-dev@poe:~/dgamelaunch-config/crawl-build/crawl-git-repository/crawl-ref/source $ git describe
06:50:18 <Pinkbeast> 0.22.2-65-g15a4c85d20
06:50:31 <Pinkbeast> ... my understanding of this stuff is a bit limited but surely that should be the same everywhere?
06:51:03 <aidanh> git push origin 0.22.2 ?
06:51:49 <Pinkbeast> I just ran that on the server, not on my development machine - so it's not a local tag hanging about there, the server got it from somewhere.
06:55:27 <Pinkbeast> ... but let me try that
06:59:46 <Pinkbeast> Still confused: https://github.com/damerell/crawl/tags shows 0.22.2
07:08:33 <alexjurkiewicz> are you checked out the stoatsoup/master branch there?
07:08:37 <alexjurkiewicz> not in detached head or something
07:09:54 <Pinkbeast> I get 0.22.2-<something> either way
11:16:42 <Cheibriados> 03Psymania02 07https://github.com/crawl/crawl/pull/1120 * 0.24-a0-524-gf0d7e20: Check player options before adding threat indicators in menu interface 10(5 minutes ago, 1 file, 21+ 8-) 13https://github.com/crawl/crawl/commit/f0d7e20bc3f7
11:16:42 <Cheibriados> 03Psymania02 07https://github.com/crawl/crawl/pull/1120 * 0.24-a0-525-g79ad2ef: Remove unnecessary braces and self-explanatory comment 10(87 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/79ad2effcf77
11:22:14 <Lantell> Stable (0.23) branch on underhound.eu updated to: 0.23.1-82-g5129a83184
12:29:02 <Pinkbeast> Aha. It's because CKO builds out of one repository for multiple forks. Ergo, vanilla's 0.22.x tags trump ours, so we don't appear to have any 0.22.x tags at all. I wonder what to do about that.
15:29:36 <bgiannan> I'm getting "Bad item name" errors when launching my crawl build. Any pointers as to what's happening?
15:32:47 <Pinkbeast> Recommend quoting the error verbatim
15:34:37 <bgiannan> /home/giann/crawl/crawl-ref/source/dat/des/altar/altar.des:344: Bad item name: 'short sword'
15:35:00 <bgiannan> if i remove the vault at that line, another pops up with the same error
16:29:48 <Pinkbeast> bgiannan: What's "git diff" show?
16:30:53 <Pinkbeast> (more generally, how did we get here, since presumably it wasn't a straight "git clone" and "make"?)
23:25:06 <bgiannan> Pinkbeast, quite a large diff but it *should* only concern dumping: https://github.com/giann/crawl/commit/6fd96633872809b9c5d6f59e830b8ba60c15a46f
23:40:26 <alexjurkiewicz> subscribed
23:40:57 <bgiannan> ?
23:43:56 <alexjurkiewicz> i'm interested in JSON morgues too
23:46:01 <bgiannan> oh
23:47:21 <bgiannan> i'll make a Json Schema of what I'm doing, because it'll be hard to find an example that hits all the possibilities
23:56:50 <Eksell> Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184