00:00:11 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-464-g6b2be6b8c7 (34) 00:01:42 Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-82-g5129a83184 01:37:41 Unstable branch on crawl.develz.org updated to: 0.24-a0-464-g6b2be6b (34) 02:10:04 Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-464-g6b2be6b 02:21:58 -!- tehgeek is now known as Psymania 02:59:12 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-443-g80245de 03:07:03 advil: one thing about the seed menu I don't understand is why there are three copies of newgame_def. `ng`, `choice` and `defaults`. I guess defaults has some default values. But why is stuff written to `choice`? Is it like a temporary holding struct you use for the menu, before copying the final values to `ng`? 03:11:54 Unstable branch on crawl.beRotato.org updated to: 0.24-a0-464-g6b2be6b (34) 03:53:30 Fork (stoatsoup) on crawl.kelbi.org updated to: 0.21.2-996-geeac58028f 08:56:59 alexjurkiewicz that signature is just copied from _choose_char (and choose_game), but I don't think the seed menu in particular needs all of those 08:59:43 iirc ng is the output, choice represents current menu choices + rc options, and defaults is from the sticky options file 09:12:45 hm trolls making a troll fork, I guess 09:13:05 by "making" I mean, "talking about", to be clear 09:13:43 trollcrawl 11:22:43 Stable (0.23) branch on underhound.eu updated to: 0.23.1-82-g5129a83184 12:13:24 Twin Ghosts! 13https://crawl.develz.org/mantis/view.php?id=12019 by zkyp 14:18:51 Anyone around? "grep engergy dat/descript/status.txt" 14:19:13 ... maybe this typo can be fixed without opening a Mantis issue &c 14:57:11 haha if you search for "engergy" you get all sorts of power companies 15:14:47 just searching DCSS also gets you some highly non-related results 15:15:00 well I suppose that depends on your perspective 15:16:06 thankfully wikipedia does have dungeon crawl stone soup in the DCSS disambiguation page 15:16:58 "The development team has also expressed a desire to maintain the current total length of the game, and so as new areas are added to the dungeon, old ones have been shortened or even removed to compensate." 15:17:04 which they got from 0.6 patch notes 16:59:22 %git 65f37dfae 16:59:22 07Aidan Holm02 * 0.23-a0-68-g65f37df: Fix webtiles level map message hiding (sort of) (Yermak, #11602) 10(11 months ago, 2 files, 6+ 4-) 13https://github.com/crawl/crawl/commit/65f37dfae7e9 16:59:35 aidanh: in case you're around, did you have any ideas about a more permanent fix to that? 17:09:35 hm, I don't know a general solution but it appears if I put a tiles_ui_control with UI_NORMAL in all of the right places in viewmap.cc it works 17:10:06 at least for the prompt cases 18:07:13 03advil02 07* 0.24-a0-465-g4402b9e: Improve zooming behavior (mainly for local tiles) 10(8 hours ago, 13 files, 98+ 17-) 13https://github.com/crawl/crawl/commit/4402b9e188df 18:07:13 03advil02 07* 0.24-a0-466-gf8f69c1: Start local tiles on the current display 10(7 hours ago, 1 file, 23+ 3-) 13https://github.com/crawl/crawl/commit/f8f69c1b1ce2 18:07:13 03advil02 07* 0.24-a0-467-ga9e2c0f: Let X be zoomed differently from main map, default to 60% 10(31 minutes ago, 11 files, 116+ 37-) 13https://github.com/crawl/crawl/commit/a9e2c0f7d088 18:07:13 03advil02 07* 0.24-a0-468-g378ef55: Add local tiles zoom to key reference 10(61 seconds ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/378ef55cfb79 18:19:43 advil: I have a general issue with the new sif exegesis where it's related to a larger issue of spells that use spellpower calculations after they've been cast (an issue for duration-based spells) 18:20:10 namely ddoor has this sanity check on hp where it resets mhp to the value calculated by spellpower each time player reacts 18:20:27 so initially the spellpower and hence the resulting ddoor hp is correct when casting under exegesis 18:21:03 but immediately when player reacts, the subsequent calculations don't see that you.divine_exegesis (a state variable tracking whether we're actively using the ability) is true 18:21:14 this is also an issue for spells like tornado and dragon's call 18:21:49 namely you cast with a given spellpower, and most players probably don't realize that subsequent checks to spellpower happen based on the spellpower on the current turn, not what it was at time of casting 18:22:13 so if you switch out of e.g. staff of air after casting tornado, your dps goes down 18:22:27 and your dragons get less spellpower (less an issue overall for that spell compared to tornado) 18:22:48 for ddoor+exegesis thing I was going to add a prop specifically to record ddoor hp 18:22:59 hmm so you want to do something like save the spellpower, specific to that spell? 18:23:23 but I noticed we have these player attribute things and it also feels like a more general issue to solve 18:23:23 yeah, that was essentially going to be my fix 18:23:28 but we'd have to code this for each relevant spell 18:23:41 there aren't many affected by this but it'd be nice to have a more general solution 18:23:58 does exegesis have any time limits? Or can you just cast it back to back as long as you have piety? 18:23:59 *many spells affected by this 18:24:20 yeah, exegesis isn't a duration and has not limits aside from piety; it's something that happens in a single turn 18:24:34 so the state tracking thing is just so e.g. spell descriptions under the ability UI can show the correct spellpower 18:24:44 well and to avoid argument passing to various spell functions 18:25:12 by state tracking I mean you.divine_exegesis, a boolean currently used 18:25:31 but this gets set to false after the ability is used (via unwind_var<>) 18:26:39 sorry, have to get to streaming, but figured I mention the issue to you since you were around; I'll be around later tonight or tomorrow and can maybe show you my (attempted) fix at that time 18:26:43 heh did you know that exegesis doesn't work if you haven't memorized anything at all? 18:26:56 yep, but that makes sense, right? 18:27:02 er 18:27:10 nothing memorized? that's a bug 18:27:16 it should only fail if you have no library spells 18:27:39 if you have none memorized yet do have library spells and it doesn't work, then yeah it's a bug 18:28:08 looks like it, probably doesn't come up for actual sif chars (as opposed to wizmode GrBe chars that convert to sif and set piety to 250) 18:38:14 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-468-g378ef55cfb (34) 18:45:05 I can't get ddoor hp to change much, I must be doing something wrong 18:45:10 or to change at all 18:54:15 oh is the change instant? 19:15:22 The build was broken. (master - 378ef55 #11656 : advil): https://travis-ci.org/crawl/crawl/builds/553975206 19:35:43 troll fork? you mean stoatsoup?? It's pretty good faith I think 19:55:30 I don't think it's us :-) 20:57:38 I'm annoyed that someone had the gall to fork crawl into a stupid beat'em up game and name it 'crawl' 21:16:25 -!- amalloy is now known as amalloy_ 21:25:42 huh...that error would seem to indicate that travis is linking with the wrong sdl version? 21:34:11 I do not mean stoat soup, to be clear 21:42:55 indeed, it's using 2.0.3 21:52:00 more specifically, something from "zoogie/sdl2-snapshots"?? 21:56:38 03advil02 07* 0.24-a0-469-g4a4e935: Remove old 3rd party sdl build from travis 10(48 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/4a4e93562d0d 22:02:20 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-469-g4a4e93562d (34) 22:13:49 03advil02 07* 0.24-a0-470-gc1e67f2: More travis tweaking for local tiles 10(28 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/c1e67f237a34 22:16:04 how should I marshall an enum class value so I can write it to the save file? 22:17:07 do I need to write a custom mapping of enum class values to integer and use that to serialise/deserialise? Or is there built in support to do this transparently 22:17:21 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-470-gc1e67f237a (34) 22:26:04 It's not just done with a marshallByte? It seems to be for eg item.base_type 22:28:57 (uh, that's a uint8_t, your enum might be bigger) 22:33:16 for enum classes, you will probably have to write your own serialization code 22:33:23 ugh, now it's installing libsdl2-2.0-0 22:38:59 oh version 2.0.2 22:41:00 ok, it's just because trusty is ancient 22:54:11 03advil02 07* 0.24-a0-471-g3302cd4: Try xenial (travis) 10(85 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/3302cd442e81 23:02:21 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-471-g3302cd442e (34) 23:29:49 damn. enum classes seem less good than enums 23:35:00 well enum classes are designed to not have that implicit conversion specifically for safety 23:35:12 so they're not less good if they require you to make explicit conversion 23:35:16 they're just doing their job 23:36:58 https://stackoverflow.com/questions/8357240/how-to-automatically-convert-strongly-typed-enum-into-int 23:36:58 has some nice answers 23:37:38 one of the answers also has a template you can use to do explicit conversion of any enum class without specifying the underlying type 23:38:09 but I'd leave it to someone with more C++ knowledge as to whether we'd want to use something like that for serializing that type of data 23:52:57 The build has errored. (master - 3302cd4 #11659 : advil): https://travis-ci.org/crawl/crawl/builds/554046640