00:01:56 -!- Krakhan|2 is now known as Krakhan 00:22:40 New branch created: pull/1071 (1 commit) 13https://github.com/crawl/crawl/pull/1071 00:22:40 03cut1less02 07https://github.com/crawl/crawl/pull/1071 * 0.24-a0-348-g5ebab06: Simplify missile description cases 10(38 minutes ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/5ebab06cfb35 00:28:50 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-350-g5b3daab8ba (34) 01:05:41 03cut1less02 07https://github.com/crawl/crawl/pull/1071 * 0.24-a0-349-g10389d3: Don't fully describe unthrowable missiles 10(5 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/10389d3c7d9b 01:55:07 -!- amalloy_ is now known as amalloy 04:49:06 -!- amalloy is now known as amalloy_ 07:48:13 In relation to this commit, https://github.com/crawl/crawl/pull/1066 07:48:27 I compared the previous version with the changed version. 07:49:34 Should I keep it this way, or should I make some modifications? 10:18:18 03cut1less02 {ebering} 07* 0.24-a0-351-g4011b8c: Simplify missile description cases 10(11 hours ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/4011b8c8abdb 10:18:18 03cut1less02 {ebering} 07* 0.24-a0-352-g1cdb867: Don't fully describe unthrowable missiles 10(9 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/1cdb867ce8f2 10:32:42 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-352-g1cdb867ce8 (34) 10:39:49 03advil02 07* 0.24-a0-353-gff863c2: Don't crash on gozag + gold in grunt_nemelex_the_gamble 10(9 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/ff863c23c4f2 10:47:28 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-353-gff863c23c4 (34) 11:21:32 Stable (0.23) branch on underhound.eu updated to: 0.23.1-50-ga50397a6bc 13:06:26 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-353-gff863c2 (34) 14:10:18 -!- amalloy_ is now known as amalloy 16:32:21 03advil02 07* 0.24-a0-354-g4488db6: Clean up and improve gozag gold detection 10(5 minutes ago, 6 files, 53+ 79-) 13https://github.com/crawl/crawl/commit/4488db6de095 16:33:00 I didn't replicate that abyss gozag crash, but I suspect it might be because some rare condition in abyss would allow gold to be generated in deep water (and that would have crashed gold detection before 4488db6) 16:45:02 advil: 0500&^A is an exciting slideshow to see if i can reproduce 16:46:39 heh 16:46:42 %git 1bbe59b729d032d3a7bddac4299d2f4e2c56efa1 16:46:42 07|amethyst02 * 0.15-a0-1343-g1bbe59b: Don't crash on Gozag-detected underwater gold. 10(5 years ago, 1 file, 3+ 4-) 13https://github.com/crawl/crawl/commit/1bbe59b729d0 16:47:03 that one fixed the dactions code but not the code called on entering a level, which were separate before that last commit 16:47:57 oh 16:48:05 amalloy: that probably won't actually work 16:48:19 since the gozag gold detection stuff wasn't called except on entering the level 16:48:45 well, it'll work after my commit, if there is still a crash to reproduce 16:48:45 but I removed the ASSERT 16:48:47 so you'd need to add it back in 16:50:54 hm, really? when i did it i still saw gold outside of LOS 16:52:25 it's possible that dactions were getting called? 16:52:30 which also didn't have the ASSERT 16:52:31 i did somehow get a different crash by repeating &u&d a bunch of times 16:53:10 but i think that might be because of earlier monkeying around i did in wizmode 16:56:19 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-354-g4488db6de0 (34) 16:56:20 hm, I can't get ctrl-a to show gold before my commit 16:56:51 I was actually wondering if dactions should be reset on abyss shift, since they aren't as far as I could tell 16:58:21 advil: just now i see a scroll generated inside a rock wall 16:58:43 so i imagine it is possible for gold to appear on deep water or lava 16:58:48 (this is before your change) 16:58:57 ah, rock wall would do it too if gold can appear there 16:59:06 I think 16:59:54 the only feature that's feat_destroys_items is laval 16:59:56 *lava 17:00:11 and feat_eliminates_items is water or lava 17:01:33 also hm what is wizard_set_abyss doing, it's not actually using any normal abyss shift code 17:01:48 !source set_abyss_state 17:01:49 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/abyss.cc#L1445 17:02:35 it calls that which is not otherwise used, and seems a bit idiosyncratic 17:03:19 was wondering because the levels it was spitting out looked qualitatively odd to me 17:03:43 wizard_set_abyss = &ctrl-a 17:13:03 I guess it's mimicking _initialize_abyss_state, but that is not really very useful? 17:13:07 %git d43997cb1d0d7 17:13:07 07bh02 * 0.12-a0-1534-gd43997c: Cleanup Abyssal State 10(6 years ago, 7 files, 45+ 20-) 13https://github.com/crawl/crawl/commit/d43997cb1d0d 17:14:28 was added there, I guess for the location setting stuff, but I can't figure out the use case; that command should probably just call abyss_teleport like it did before d43997c 17:14:46 or abyss_area_shift 17:15:40 oh, maybe it is in some cases 17:18:25 03advil02 07* 0.24-a0-355-gbe4061d: Fix another abyss gozag gold detection case 10(29 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/be4061de67c6 17:19:28 ok, many premises were wrong, but it was still the case that gold detection code wasn't called on &ctrl-a 17:32:32 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-355-gbe4061de67 (34) 18:22:27 Unstable branch on underhound.eu updated to: 0.24-a0-355-gbe4061de67 (34) 19:16:17 you seem to be an expert at tracking down weird levelgen crashes now 20:48:24 -!- amalloy is now known as amalloy_ 21:10:54 -!- amalloy_ is now known as amalloy