00:00:15 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-244-ga6a6ab7 (34) 00:01:45 Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-49-g05433c6 01:37:51 Unstable branch on crawl.develz.org updated to: 0.24-a0-244-ga6a6ab7 (34) 02:08:38 Windows builds of master branch on crawl.develz.org updated to: 0.24-a0-244-ga6a6ab7 02:59:35 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-244-ga6a6ab7 03:30:42 Stable (0.23) branch on crawl.kelbi.org updated to: 0.23.1-49-g05433c6f1a 04:58:34 -!- Euph0ria is now known as q[_]-Java- 05:29:37 -!- q[_]-Java- is now known as C[_] 05:29:54 -!- C[_] is now known as Euph0ria 05:33:41 -!- Euph0ria is now known as c[_] 05:43:25 -!- c[_] is now known as C[OuO]D 08:35:51 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-245-gcea1735: Generate job groups on the character selection screen from yaml files 10(4 minutes ago, 30 files, 139+ 158-) 13https://github.com/crawl/crawl/commit/cea1735af759 08:41:11 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-245-gbea19a2: Generate job groups on the character selection screen from yaml files 10(10 minutes ago, 30 files, 139+ 158-) 13https://github.com/crawl/crawl/commit/bea19a21a047 09:18:35 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-246-gf342357: Add documentation for background creation using yaml files 10(3 minutes ago, 3 files, 36+ 123-) 13https://github.com/crawl/crawl/commit/f3423572f8c5 09:23:55 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-246-gef857d6: Add documentation for background creation using yaml files 10(8 minutes ago, 3 files, 36+ 123-) 13https://github.com/crawl/crawl/commit/ef857d6c34bb 09:34:36 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-246-g0be4a65: Add documentation for background creation using yaml files 10(19 minutes ago, 3 files, 36+ 123-) 13https://github.com/crawl/crawl/commit/0be4a6517973 10:01:13 Traps trigger after action when using passwall 13https://crawl.develz.org/mantis/view.php?id=11952 by shummie 11:10:47 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-247-g89430ee: Move weapon_choice and job_def definitions out of job-data.h 10(7 minutes ago, 4 files, 35+ 24-) 13https://github.com/crawl/crawl/commit/89430eec88cc 11:23:04 Stable (0.23) branch on underhound.eu updated to: 0.23.1-49-g05433c6f1a 12:36:19 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-248-g61c33cf: Convert weapon_choice to an enum class and abstract the yaml field 10(29 minutes ago, 18 files, 41+ 41-) 13https://github.com/crawl/crawl/commit/61c33cfe9b8b 12:39:53 Hmm I'm getting "permission denied" errors on my PR with respect to the new file job-gen.py... does anyone know why? 12:41:56 you're on windows right? 12:42:27 windows does permissions differently, it will need to be marked as +x somehow but I'm not sure what the right way to do that on windows is 12:46:24 yep 12:47:14 I shall commence googling 12:47:48 you can probably also run it from the Makefile by prefacing it with `python` 12:47:54 that doesn't require +x 12:48:23 just to clarify, I mean that travis is reporting "permission denied", in case that wasn't clear :) 12:48:29 yeah, I saw the error 12:48:42 I'm pretty sure that is the result of it not being +x 12:50:16 hmm does this look right? http://blog.lesc.se/2011/11/how-to-change-file-premissions-in-git.html 12:51:06 that looks plausible 12:51:44 (on unix you do it directly with a chmod command, so I've never had to do it that way in git) 12:52:10 if you are using the git ui thing there may be some way to do it there too? 12:52:43 er the github ui thing 12:54:00 I'm using the command line 12:54:12 and that doesn't appear to have worked 12:54:24 it is from 2011 so there's a fair chance it's out of date 12:56:04 here's one from 2017 that looks similar though: https://medium.com/@akash1233/change-file-permissions-when-working-with-git-repos-on-windows-ea22e34d5cee 12:57:08 nvm it seems I messed up a command; that does work 13:01:55 Stable (0.23) branch on crawl.akrasiac.org updated to: 0.23.1-49-g05433c6 13:06:33 that's fixed now, thanks for the help 13:06:43 no problem 13:07:04 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-244-ga6a6ab7 (34) 13:08:23 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-249-ga1c0652: fixup! Generate job data from yaml files 10(3 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/a1c065234612 14:01:48 03NormalPerson702 07https://github.com/crawl/crawl/pull/1030 * 0.24-a0-250-g7fd0665: fixup! Generate job data from yaml files 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7fd0665bf51b 17:19:54 hm why does _get_monster_name for printing morgue output have its own custom determiner code, instead of using regular monster description code 17:29:33 oh, I see, it's because of the adjective part 17:45:25 man, this code is like a tangle of string 17:45:34 why does full_name add "the" to any proper name? 17:45:52 "the Mara" 17:46:31 this isn't German 17:46:48 oh hm that's not what it's doing 17:47:00 no idea why "the" is there for that one 18:01:41 find what's outputting that message, see if it passes a flag forcing it 18:01:50 there are a few places that do and which cause problems sometimes 18:02:04 that one was my mistake actually 18:14:25 advil: one possible explanation: the morgue file has a lot more room 18:15:03 if you're surrounded by 15 different monsters, the in-game monster list pane can't list them all, or even list all genuses. but the morgue can 18:15:55 yeah, it does read better in the morgue, when it works 18:16:08 for example: "You can see an orb of fire (dormant), a golden dragon (sleeping), 2 draconians, a purple draconian (sleeping) and a white draconian." but in-game "* orb of fire (dormant) D golden dragon (sleeping) dddd 4 draconians" 18:16:31 I suspect I'm going to end up pulling on this string and breaking something else that I didn't anticipate 18:16:42 good guess 18:17:15 but "the friendly Bogwald the orc knight" is just too annoying 18:19:08 gonna try to get Bogwald, the friendly orc knight? i can imagine that would be some work 18:19:12 yep 18:19:18 I have a hack that does it 18:19:35 Bogwald the orc knight (friendly) is good imo 18:19:55 having an important qualifier like "friendly" hidden in the middle makes me a bit sad 18:20:12 I just like the sound of "the friendly orc knight" 18:20:13 although some of why it works the way it does is because there (used to be?) a polish translation 18:20:18 which is … tricky 18:22:36 hm there is code to do the parenthetical version but it's also an ad-hoc wrapper in a static function, just in a different file 18:22:39 // FIXME: this duplicates _get_monster_desc(). Unite them. 18:33:58 wondering, why does all message coloring work - but not "message_colous += lightmagenta:disappears" ? 18:34:11 erm, ok, i see :D 18:34:13 well if that's a paste you have a typo 18:34:15 :-P 18:34:39 hehe 18:34:48 next try 18:34:58 thanks for your help ;-) 18:36:06 man this code, I'm actually going to give up, I didn't actually want to rewrite the description code right now 18:38:47 there's like 4 different major places where adjectives are compiled, and then a bunch of minor ways in which they are added in some code paths 18:40:12 hm plus it interacts with #979 anyways 18:40:26 description code secretly worse than beam.cc, monster AI, ... 18:40:52 not secret to everyone, I recall 1kb ranting about it at one point 18:41:17 ...in part because it's their fault, due to that translation I mentioned earlier :) 20:39:39 %git 9e5ec5d9ef1f 20:39:39 07advil02 * 0.18-a0-1681-g9e5ec5d: fix expose_to_element not being called properly (10293) 10(3 years ago, 9 files, 78+ 26-) 13https://github.com/crawl/crawl/commit/9e5ec5d9ef1f 20:39:57 just noticed my first commit (as a contributor) was about 3 years ago 20:40:00 wow 20:49:12 happy birthday! 20:54:45 GG 20:55:22 I need to make 400 commits to pass wheals 20:56:07 then another 400 to reach grunt and an eternity to reach PF 20:56:59 but of course the real metric is 20:57:02 ??millimarvin 20:57:02 millimarvin[1/1]: 22.669 lines of code removed (as of 2017-08-30) 20:57:05 advil is already less than 400 behind me though, so I guess I'll have to contend with him 20:57:10 hrm 20:57:20 about 12k removed for me 20:57:56 so I'm a bit more than half a marvin 20:58:02 oh, no 20:58:06 wait 20:58:11 30.6k 20:58:56 yeah, I've got a ways to go in the commit ranking 20:58:56 1.3 marvins 20:59:06 you got to top 10 really fast 20:59:52 I guess this is not a really fair top 10, since we can't see all commits imported from svn properly 21:00:19 true, plus there are different ways of counting 21:00:25 looking at the graphs, I've just never been able to do the apparent burst productivity of some of the top committers 21:00:49 yeah, some people have done 21:01:09 er, some people have done that for many months in a row 21:01:40 interestingly pf has more lines removed than mpa 21:02:24 I have a pretty bad remove ratio 21:03:41 I have tended to add a lot of comments, I blame that 21:03:51 heh, some people strongly embrace that 21:03:54 ??millisnark 21:03:54 millisnark[1/1]: <|amethyst> a millisnark is 191 lines of code added 21:04:17 grunt was a notable one 21:19:43 -!- quadsar_ is now known as quadsar 21:28:06 -!- amalloy is now known as amalloy_ 21:30:42 No warning for ally collisions 13https://crawl.develz.org/mantis/view.php?id=11953 by CanOfWorms 23:57:34 Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-49-g05433c6