01:14:21 gammafunk: yep, that'll cause a problem, as will pretty much every other you.unrands conditional in a vault 01:14:41 fun times 01:15:09 since I'm pretty sure the number of random numbers requested by "ITEM: glaive_of_the_guard no_pickup" is different from the number requested by "ITEM: bardiche randart no_pickup" 01:17:00 (or is that on a different PRNG than the one used by / ?) 01:21:44 that's all assuming that number of RNG draws varying depending on unrands actually causes a seed stability problem in the first place, of course - I'm actually having a hard time thinking of when it would? 01:38:27 -!- TAS-2012v is now known as TAS_2012v 02:02:39 minqmay: my understanding is: if you visit floors in a different order, you might have a different set of unrands available when you generate a floor. it that draws from the rng more, you get different choices in the floor generation, possibly up a veto causing the whole level to regenerate 02:17:09 what if two players play the same seed 02:17:17 one acquires weapon and gets an unrand, another doesn't 02:17:18 Monsters with the dig spell can cast spells out of LOS at the player 13https://crawl.develz.org/mantis/view.php?id=11945 by CanOfWorms 02:18:17 the seed is such that a monster was going to generate with said unrand 02:18:45 or I suppose even that the unrand was going to generate on the ground 02:37:04 ah yeah, those are both possibilities 02:47:10 Monster database of master branch on crawl.develz.org updated to: 0.24-a0-235-g3f03afc 03:00:20 !messages 03:00:20 No messages for floraline. 03:30:43 Stable (0.23) branch on crawl.kelbi.org updated to: 0.23.1-49-g05433c6f1a 03:31:33 Fork (gooncrawl) on crawl.kelbi.org updated to: 0.22-a0-824-g079cee711d 06:07:19 gammafunk: the real bug that I fixed was that the "variability" variable was global, and so if that function ever rolled variability, it tried to place variability every time after that 06:08:54 I see; normally that wouldn't matter, but if the vault was part of a veto, it could get called again if the vault ever tried to place again 06:09:13 yeah, also it wasn't ever using the correct weapons list again once variability placed 06:09:32 and that fn does get called by more than one vault I think 06:09:42 the xom weapon one? no 06:09:49 in the affected seed it was called two or three times in the whole levelgen sequence 06:09:50 well, yes, there is the vaults variant 06:10:07 so I guess that's true, there is the vaults variant of that vault, but that'd be the only other one 06:10:09 maybe just two then, yeah I think the 2nd one was in vaults 06:10:16 I guess I'm still confused as to whether those cases we were talking about create seed instability 06:11:06 that one didn't really create seed instability on a single run (just over multiple runs, which failed the tests) 06:11:27 if a player acquires weapon and gets e.g. an unrand, does that possibly effect level gen? or is the prng for acquirement not the same as the one for dungeon 06:11:37 yes, it can affect levelgen 06:11:50 this is something I need to sort out to get incremental pregen fully working 06:12:04 for complete pregen, it doesn't matter, because what's placed is placed 06:12:16 I see 06:12:40 right, so gotm is fine 06:12:40 yeah 06:12:40 ok, that makes sense 06:16:12 the code you linked looks fine right now but it will interact with acquirement in an incremental pregen setup (so I need to figure out a general solution of some kind) 06:17:08 I'd have to check how it's implemented but if it uses shuffle that *could* change the number of draws 06:18:27 once seeds seem a bit less like I'm putting out fires I have some plans to try to make that more controlled in general 06:18:29 since the two possible ITEM statements are such that one has a random choice and one is fix, isn't the random choice guaranteed to generate a single extra draw? 06:18:41 s/is fix/is fixed/ 06:18:49 oh, yeah 06:24:50 that launcher vault is probably a useful testcase 06:25:49 on incremental pregen, as long as the rng doesn't get off, it's probably ok if it swaps out between sniper/piercer/randart if the player has acquired one 06:26:08 so it's a matter of figuring out how to ensure that the rng is in sync for cases like that 06:32:20 -!- amalloy is now known as amalloy_ 07:09:36 I macroed a key to call this function: https://pastebin.com/KRsYX4BV 07:09:50 When I press the key, output messages alternate, but there is no other effect. How do I refer to rc options in lua functions? Thanks in advance. 07:17:17 Yermak: craw.setopt(STRING) 07:17:23 where STRING contains an rc line 07:17:37 but some things have lua interfaces you could call 07:17:58 huh, just found this simultaneously with your reply, thx 08:05:05 Hah, new summoner interface gives up the real Mara location. 08:09:51 New summoner highlighting shows the real Mara. 13https://crawl.develz.org/mantis/view.php?id=11946 by Yermak 09:22:19 Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3 10:18:07 Monster description for Drain Life is the same as player 13https://crawl.develz.org/mantis/view.php?id=11947 by Flugkiller 11:22:32 Stable (0.23) branch on underhound.eu updated to: 0.23.1-49-g05433c6f1a 13:01:52 Stable (0.23) branch on crawl.akrasiac.org updated to: 0.23.1-49-g05433c6 15:53:16 -!- TAS-2012v is now known as TAS_2012v 16:21:39 -!- amalloy_ is now known as amalloy 18:18:52 Game unstable 13https://crawl.develz.org/mantis/view.php?id=11948 by PissedPlayer1 18:36:31 Napkin: this guy https://crawl.develz.org/mantis/view.php?id=11948 has been trolling mantis for a few weeks now; aside from disabling his accounts and deleting the reports, is there anything else we should do? 18:48:10 you should bring back that arrival vault with an orb of zot mimic, but put it on lair:2 18:55:42 the tavern ip ban seems to have stuck, so if it's possible to ip ban from mantis that'd do the trick i guess? i don't have access to the admin end there though 18:59:52 yeah, wasn't sure if there's a way to do that in mantis 21:07:07 i'll check after sleep ;-) 21:30:38 thanks Napkin :) 21:57:24 -!- collin38 is now known as rofl 23:57:33 Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-49-g05433c6