00:02:19 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-205-g1d96822bd8 (34) 00:59:57 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-205-g1d96822 (34) 01:01:21 Stable (0.23) branch on CRAWL.XTAHUA.COM updated to: 0.23.1-38-g628c18f 01:03:02 Stable (0.22) branch on CRAWL.XTAHUA.COM updated to: 0.22.1-59-ge965b3a 01:46:40 anyone going to be working on PRs again soon? 02:03:42 New branch created: pull/1021 (1 commit) 13https://github.com/crawl/crawl/pull/1021 02:03:42 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/1021 * 0.24-a0-204-g6275b76: Two vaults (MisterPersonMan) 10(4 days ago, 1 file, 35+ 0-) 13https://github.com/crawl/crawl/commit/6275b7657e6a 02:08:07 Stable branch on crawl.develz.org updated to: 0.23.1-38-g628c18f (34) 02:17:46 Stable branch on crawl.develz.org updated to: 0.22.1-59-ge965b3a (34) 03:52:45 Stable (0.22) branch on crawl.kelbi.org updated to: 0.22.1-59-ge965b3aba3 04:01:23 Stable (0.23) branch on crawl.kelbi.org updated to: 0.23.1-38-g628c18f423 10:22:26 Stable (0.22) branch on underhound.eu updated to: 0.22.1-59-ge965b3aba3 11:04:25 !tell gammafunk I'm fine with that PR, the shafts in that vault were more cosmetic than useful; 11:04:26 ebering: OK, I'll let gammafunk know. 11:05:03 alexjurk1: life calls, crawl must wait. Last semester I had a much lighter teaching load and was stuck in my research 12:07:20 -!- amalloy is now known as amalloy_ 12:24:04 Stable (0.23) branch on underhound.eu updated to: 0.23.1-38-g628c18f423 12:38:15 -!- amalloy_ is now known as amalloy 12:55:50 03gammafunk02 {advil} 07[stone_soup-0.23] * 0.23.1-39-g12317a5: Remove a digging Trove 10(13 hours ago, 1 file, 0+ 40-) 13https://github.com/crawl/crawl/commit/12317a5773ee 12:58:37 03NormalPerson702 {advil} 07* 0.24-a0-206-g696e1f2: Don't place shafts in ebering_ghost_disaster_area (11926) 10(3 days ago, 2 files, 2+ 12-) 13https://github.com/crawl/crawl/commit/696e1f2bf7e3 13:00:24 03NormalPerson702 {advil} 07[stone_soup-0.23] * 0.23.1-40-g51ea08c: Don't place shafts in ebering_ghost_disaster_area (11926) 10(3 days ago, 2 files, 2+ 12-) 13https://github.com/crawl/crawl/commit/51ea08c4e431 13:02:20 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-206-g696e1f2bf7 (34) 13:02:30 Stable (0.23) branch on crawl.akrasiac.org updated to: 0.23.1-40-g51ea08c 13:04:42 Stable (0.22) branch on crawl.akrasiac.org updated to: 0.22.1-59-ge965b3a 13:09:50 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-206-g696e1f2 (34) 13:39:02 is there a general way of keeping certain kinds of markers from placing on certain kinds of terrain? 13:46:23 well, given the ordering of this case that wouldn't help, I would need to keep the terrain from placing on the marker 14:10:23 actually, why can this vault even place on top of another, neither is overwriteable 14:13:46 oh 14:13:54 well, abyss_entry does have overwrite_floor_cell 14:14:09 I guess because it's so fallbacky 14:36:56 03advil02 07* 0.24-a0-207-gc779bbd: Don't let overwrite_floor_cell place on transporter markers (11936) 10(8 minutes ago, 1 file, 11+ 2-) 13https://github.com/crawl/crawl/commit/c779bbd14b3b 14:47:32 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-207-gc779bbd14b (34) 15:33:07 The build was canceled. (master - 696e1f2 #11264 : NormalPerson7): https://travis-ci.org/crawl/crawl/builds/512609288 17:06:51 advil: not sure if you know anything about this, but mapstat had an iteration with a warning about multiple branch exits on tomb:1 17:06:51 er, that turned into a crash it seems 17:07:24 ah, the crash is unrelated 17:07:29 it's crashing due to labyrinths 17:10:32 that warning about multiple tomb:1 branch exits is weird though 17:18:47 it seems to happen with every mapstat iteration 17:30:09 ebering: so it goes 17:33:44 03gammafunk02 07* 0.24-a0-208-g17bec22: Don't try to generate Labyrinths in mapstat (vt) 10(13 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/17bec22d1706 17:33:58 %git stone_soup-0.23 17:33:58 07NormalPerson702 {advil} * 0.23.1-40-g51ea08c: Don't place shafts in ebering_ghost_disaster_area (11926) 10(3 days ago, 2 files, 2+ 12-) 13https://github.com/crawl/crawl/commit/51ea08c4e431 17:34:11 guess I should cherry-pick that 17:45:41 03gammafunk02 07[stone_soup-0.23] * 0.23.1-41-g7e51ed3: Don't try to generate Labyrinths in mapstat (vt) 10(25 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/7e51ed32d827 17:47:16 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-208-g17bec22d17 (34) 17:57:11 how are crawl's compile speeds? relative to whatever "normal" is I guess. this is my first nontrivial c++ project, so I don't have much of a point of reference 17:58:58 I noticed a merged pull request from a while ago focused on separating headers into smaller pieces. was that because we "had problems"? 17:59:31 I've never worked on anything of this size before so I really just don't know what's normal 18:03:25 The build was broken. (stone_soup-0.23 - 51ea08c #11265 : NormalPerson7): https://travis-ci.org/crawl/crawl/builds/512610092 18:04:21 The build was canceled. (master - c779bbd #11266 : advil): https://travis-ci.org/crawl/crawl/builds/512651691 18:16:22 fourba: hard to compare compile speed in absolute terms. The reason for that PR was because it reduced the "blast radius" of re-compiles after changing a single thing in the header file 18:16:58 the compilation process determines the source files required for every output file, eg fight.o is generated from fight.cc, fight.h, and all the other .h files that are #include'd 18:17:14 If any source file is updated, the output file has to be regenerated 18:17:45 yeah that part I'm familiar with, just the sheer number of headers is new to me 18:17:46 so if you have a file, say enum.h, which pretty much everything includes, any time to update it the entire codebase will have to be recompiled. Even though you just added a new fountain type or something 18:18:27 I guess I was wondering whether there's more room to keep doing that, and whether it is a potential "easy win" someone like me could do 18:18:53 the reason not to do that endlessly would presumably be the endless number of files generated 18:19:38 just as a subjective experience right now I am indeed finding myself recompiling a lot of .ccs I never touched because "invent.h" is included just about everywhere 18:19:58 yeah. The devs probably have strong opinions about where the balance is. Personally I think it's about right at the moment but I am biased from using the code base every day. I wish the code base tree had some hierarchy though 18:20:27 ah, like the actual directory structure? 18:21:07 right. there's 300+ *.cc files 18:22:03 about invent.h, yeah. Looking at that file I suspect just a lot of things use it. The file seems pretty focused. But I don't think anyone would object to you pulling out some particularly popular definition if it speeds up compilation and keeps the layout sane 18:23:25 if you were interested in a backend project may I suggest converting job/role/background definitions to YAML like species 18:24:06 oh? I'll take a look 18:24:29 that sounds like the kind of thing that has about a 50/50 chance of turning out to be script-friendly 18:25:16 I'm sure I'd get good ideas from whatever commits made it happen for species to begin with. thanks for the suggestion 18:36:38 just keep in mind that we have to keep any PR you make doing that around for like a year before we merge it 18:36:48 as is tradition :D 18:40:54 I look forward to it 18:45:03 what you guys need is more billionaires in the playebase 18:45:41 with a desire to casually unconditionally fund development for as much time/year as anyone feels like spending 18:45:47 i'll talk to my billionaires 18:54:44 Some items are colored with the tiles_horizon_col until save/reload 13https://crawl.develz.org/mantis/view.php?id=11938 by Aule 19:21:48 Unstable branch on underhound.eu updated to: 0.24-a0-208-g17bec22d17 (34) 19:31:13 -!- TAS-2012v is now known as TAS_2012v 19:38:23 The build passed. (master - 17bec22 #11267 : gammafunk): https://travis-ci.org/crawl/crawl/builds/512721978 20:37:29 The build passed. (stone_soup-0.23 - 7e51ed3 #11268 : gammafunk): https://travis-ci.org/crawl/crawl/builds/512726579 20:46:57 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/1021 * 0.24-a0-205-gb811608: Vaults for Orc (MisterPersonMan) 10(43 seconds ago, 1 file, 74+ 0-) 13https://github.com/crawl/crawl/commit/b81160858dfb 22:21:51 03NormalPerson702 {ebering} 07* 0.24-a0-209-g0fa666e: Let formicids dig statues (Yermak) 10(6 days ago, 1 file, 1+ 5-) 13https://github.com/crawl/crawl/commit/0fa666e6e4fd 22:26:00 🙌 22:26:36 03Andrew O'Neill02 {ebering} 07* 0.24-a0-210-gbac502f: Fix CMD_MAP_UNFORGET in colemak keybindings 10(8 days ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/bac502f846c4 22:27:10 03Joshua Gelbard02 {ebering} 07* 0.24-a0-211-g51c60a9: Don't ignore autopickup settings after autobutcher 10(3 days ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/51c60a924a40 22:27:40 03Joshua Gelbard02 {ebering} 07* 0.24-a0-212-g90687ab: Add new message for re-corroding a corroded foe 10(2 days ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/90687ab01aaf 22:30:11 gammafunk: I'm generally in favor of pr 995, but you might disagree 22:30:13 !pr 995 22:30:14 https://github.com/crawl/crawl/pull/995 22:31:33 ??piercer 22:31:34 piercer[1/1]: a +7 longbow of penetration with -2 EV. 22:31:38 ??stormbow 22:31:38 storm bow[1/1]: Unrandart +8 longbow of electrocution, sometimes creates rain clouds while wielded. 22:31:44 heh 22:32:45 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-212-g90687ab01a (34) 22:33:15 ebering: it seems ok as a basic idea to me, without looking at the commits in question 22:33:15 I don't know that the EV-2 thing is necessary 22:33:32 storm bow didn't pick up the EV-2 in this 22:33:40 yeah, looks like it 22:33:44 so that seems ok to me 22:34:16 I'm going to tweak the description before merge 22:34:30 I guess it doesn't really add anything terribly new gameplay-wise, but neither of the original two unrands did either 22:51:03 oh, they took my description suggestion 22:51:20 03kitchen-ace02 {ebering} 07* 0.24-a0-213-g3ca0c31: Merge Piercer into the storm bow 10(4 weeks ago, 3 files, 8+ 7-) 13https://github.com/crawl/crawl/commit/3ca0c319c68e 22:57:59 gammafunk: not sure what's up with that tomb error but it's been going on as long as I've had cause to be generating tomb maps 22:59:26 first mention in dev chat looks to be from 2017 23:02:24 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-213-g3ca0c319c6 (34) 23:08:22 interesting, I'd never seen that before 23:08:39 maybe it's just been so long since I'd run mapstat on tomb 23:09:02 I could hazard a guess it's from the tomb hatch changes 23:09:08 %git 0.20.0 23:09:09 07gammafunk02 * 0.20.0: Update the Debian changelog for 0.20 10(1 year, 10 months ago, 1 file, 25+ 0-) 13https://github.com/crawl/crawl/commit/35d994404934 23:09:33 yeah could be 23:20:59 it shows up in objstat and in the vault seed tests too 23:21:07 now that's weird 23:21:10 objstat I should have seen 23:21:28 well, I haven't tried objstat myself so maybe that's old info 23:21:56 yeah I don't recall seeing that when making my standard objstat data 23:22:13 but in any case maybe I can look into when I get more time for crawl dev stuff 23:32:01 03Umer Shaikh02 {ebering} 07* 0.24-a0-214-gcd7e529: Remove use of testbits in is_valid_shaft_effect_level 10(2 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cd7e529e91d7 23:32:01 03Umer Shaikh02 {ebering} 07* 0.24-a0-215-g494fbac: Use a function instead of duplicating logic 10(2 weeks ago, 1 file, 1+ 6-) 13https://github.com/crawl/crawl/commit/494fbaca61bf 23:32:01 03Umer Shaikh02 {ebering} 07* 0.24-a0-216-gb3ba8b5: Refer to function by name, not position, in comment 10(2 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b3ba8b5ca559 23:32:01 03Umer Shaikh02 {ebering} 07* 0.24-a0-217-g1152973: Check trap effects' validity before choosing effect 10(2 weeks ago, 1 file, 35+ 24-) 13https://github.com/crawl/crawl/commit/1152973720f3 23:47:25 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-217-g1152973720 (34)