01:05:59 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.24-a0-181-gd121a6d (34) 01:07:52 LRD doesn't work in Lines Sprint 13https://crawl.develz.org/mantis/view.php?id=11925 by airin 01:52:05 -!- amalloy_ is now known as amalloy 02:47:16 -!- ProzacElf_ is now known as ProzacElf 03:02:58 -!- amalloy is now known as amalloy_ 03:30:50 Fork (bcadrencrawl) on crawl.kelbi.org updated to: 0.22.1-96-g6014ea2896 04:11:27 I kept adding ##crawl at work office and failed to get into this chat :D then discovered it was ##crawl-dev instead, now it works. This is great, it means I can participate during working hours too ;) 04:15:02 what time zone do most of the people have here anyway? I often see heated discussions when I am about to go to sleep :P 07:08:19 most of the devs are USTZ 09:11:42 !crashlog SaintRoka 09:11:51 7. SaintRoka, XL27 MfWr, T:79619 (milestone): https://crawl.xtahua.com/crawl/morgue/SaintRoka/crash-SaintRoka-20190313-081628.txt 11:35:25 Historically evoking a deck is an action with an item, so it couldn't be silenced. But now this is not the case. So: nerf Nem by allowing all his abilities to be silenced. 12:29:50 well, nem may well need nerfing, no opinion about that one way or the other, but thematically it is still very much item-based, just using goldified items 13:09:52 Unstable branch on crawl.akrasiac.org updated to: 0.24-a0-181-gd121a6d (34) 13:18:45 -!- amalloy_ is now known as amalloy 14:22:05 i don't think there's really a good justification for the abilities working under silence now regardless of power level 14:22:43 so i'd definitely be in favour of making them be consistent 15:03:20 for the record, the justification I used was: My project was to take decks out of inventory with a minimum disruption to their mechanics. 15:03:41 But don't let my initial conservatism be a constraint moving forward 15:19:45 On the other nem topic: imo, hostile nem summons should go. I think most early nem deaths are from those. 15:24:43 03advil02 07* 0.24-a0-182-gc7eaa07: Improvements to the seed selection ui 10(4 minutes ago, 4 files, 18+ 9-) 13https://github.com/crawl/crawl/commit/c7eaa0789552 15:27:05 I think correct early nem play is following: don't use escape, don't use summoning. Don't use destructions if there are adjacent monsters. 15:32:32 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-182-gc7eaa07895 (34) 17:10:47 I just met curious thing in Swamp: Kirke was generated with her pigs miles way from her, in crab vault behind runed door. 17:10:53 Bug? 17:28:18 I've noticed her flock ranges fairly widely. Pikel's sometimes does as well, but less so 19:21:52 Unstable branch on underhound.eu updated to: 0.24-a0-182-gc7eaa07895 (34) 21:05:16 -!- amalloy is now known as amalloy_ 21:29:19 -!- amalloy_ is now known as amalloy 21:46:34 hello. in keeping with contribution-process.md's advice to 'chat about even small changes with some devteam members, especially if you are new to the dcss codebase' I am seeking input on the following idea: I want to add a drop-last-unequipped-item feature to the drop prompt/menu, sort of like what 'D' does. 21:48:00 so if you have been using a +1 slaying ring and upgrade to a +4, dropping the old one would be easier 21:48:11 I find myself doing that a lot 21:51:43 is there anything obviously terrible about that idea, like it's a commonly-rejected feature or something? 21:52:39 I can also just implement it and submit a pull request and see what happens 21:57:22 seems like a nice idea, if you can find a free key it's probably fine to allocate 22:00:45 yeah the 'find a free key' part is looking tough. I am learning a lot about menu keys I never knew existed 22:06:40 ctrl-d seems to be bound to the same thing as ~ right now, you might be able to justify replacing that 22:07:45 oh, I wasn't even thinking about making it a top-level key, actually. I was thinking it would be something you pressed after pressing 'd' to bring up the drop menu 22:08:39 that actually sounds much better, because then you can have some UI which describes this and it will be discoverable for players 22:10:05 cool, I'm glad it sounds reasonable! thanks for the reminder that I'll have to document it on the help screen 22:10:47 fwiw, i'm not a dev (they have + in their name). But I think an unobtrusive feature like this would almost certainly be accepted 22:12:15 got it. feedback very much appreciated either way. 22:14:50 fourba: i added a feature to wizmode that tells you what keys are available 22:14:58 i think it's &` 22:15:44 !source monster::holiness 22:15:45 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/monster.cc#L3530 22:16:02 oh so you did, that's awesome 22:16:04 advil: i see 22:16:22 yeah, that may affect some of the rest of your question too 22:16:46 yeah, in that the question suddenly went from easy to unanswerable 22:17:30 fourba: but making it a special command inside d is probably better 22:17:40 as you can see we don't have a lot of top-levek keys left 22:18:10 ok, cool, was about to ask. I like the subcommand idea better myself -- if someone wants to do it in one keypress, they can always macro it 22:18:18 yep 22:20:00 incidentally, d_ seems to lie now 22:20:23 it claims d, selects all items, but this does not appear to happen 22:21:28 fwiw that change does look right to me 22:21:38 also should impact soul eaters, if I'm understanding things right 22:22:56 the two lines at the bottom of d_ are supposed to clarify that I think 22:23:23 oh, it is. i looked at that text like ten times, and got bored before i got to the second line 22:24:11 03Josh Braden02 {amalloy} 07* 0.24-a0-183-g8902462: Use & instead of equal for holiness check (11909) (#1001) 10(9 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/890246250bbc 22:24:26 except maybe I'm not even sure why all those elses are there 22:24:41 advil: i think the idea is to not give you double-credit for killing a demonic+evil monster 22:24:51 yes 22:25:31 oh, I guess those are really for increasing piety 22:26:11 -!- CaptainFruitcake is now known as CanOfWorms 22:28:13 I'm having serious trouble convincing myself that any given key is really 100% unused in the d menu, so I think for now I'm going to pick some definitely-unused combo like CTRL-R and finish it enough to submit a pull request 22:28:30 I am sure there will be changes to make anyway regarding my actual code 22:29:13 and if the code seems acceptable, I can find and pick a less out-of-the-way key later 22:29:54 fourba: the 52 letters a-zA-Z plus the symbols described in the help screen _ aree what's used 22:30:14 oh, then I can use semicolon after all 22:30:28 semicolon would be good and consistent 22:30:42 I was about to do that and then I saw a case for it at the top of process_key and became convinced it was a pageup that just didn't work on my machine 22:30:43 since semicolon in the main view means "autopickup this cell" 22:31:05 hmm, it does seeem to currenetly process as page up 22:31:09 put isn't documented as such 22:31:16 alas... 22:31:28 we already have two page up keys 22:31:45 a keyboard without < would have a tough time with crawl 22:31:53 it really would 22:32:05 I'll steal it then? for now 22:32:10 since the ; behavior is undocumented you can change it, but be sure to change the help screen too 22:32:20 + is documented but doesn't seem to work for me? 22:32:25 Unstable branch on crawl.kelbi.org updated to: 0.24-a0-183-g890246250b (34) 22:32:46 excellent, will do. thanks for all the feedback everyone 22:33:25 oh right, it was + that didn't work for me. semicolon totally does 22:33:46 i think it's because + used to be an alternate glyph for books 22:34:11 oh, right. I actually used that instead of : all the time 22:35:56 yeah + doesn't seem to work 22:36:25 if you could fix that (make it a sepearate commit at least; a separate PR if your PR is very involved) 22:36:30 it would be very appreciateed 22:36:53 I will absolutely do that 22:37:54 I secretly already implemented this before asking whether it was a good idea, so I'm confident this is roughly 10 lines of code total 22:38:15 once I remove the 30 lines of print statements required to keep me oriented 22:38:41 I will submit some sort of pull request with both of those changes in two separate commits some time later. thanks everyone 22:39:14 there has been a real burst of new contributors in the past few months 22:39:34 be sure to check the style guide before you hit subit, util/unbrace and util/checkwhite can do most of the work for you 22:39:41 and welcome! 22:39:52 fourba: what got you interested in contributing? 22:39:56 glaas too 22:40:59 I am procrastinating on applying for jobs 22:41:19 and also finally know a tiny bit of c++ 22:47:12 -!- collin38 is now known as rofl 22:58:09 procrastination is also the reason i'm helping 23:02:17 oh and thanks ebering for the welcome, nearly missed it. off to dinner, thanks all for the guidance