00:00:51 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-814-g91b4073 (34)
00:14:44 <Cheibriados> 031Hyena02 {ebering} 07* 0.23-a0-815-g48644e5: Check and set conducts for holy word and torment (11821) 10(6 days ago, 4 files, 167+ 8-) 13https://github.com/crawl/crawl/commit/48644e56ec92
00:14:44 <Cheibriados> 03ebering02 07* 0.23-a0-816-g81dc5fd: Refactor scroll and sceptre of torment prompts 10(44 minutes ago, 2 files, 25+ 79-) 13https://github.com/crawl/crawl/commit/81dc5fd5f0a7
00:14:44 <Cheibriados> 03ebering02 07* 0.23-a0-817-g40270af: Better grammar for LOS spell attack prompts 10(23 minutes ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/40270af0197d
00:14:44 <Cheibriados> 03ebering02 07* 0.23-a0-818-g00444ac: Tormenting allies turns them hostile 10(10 minutes ago, 1 file, 10+ 0-) 13https://github.com/crawl/crawl/commit/00444ac475f2
00:17:04 <ebering> down to 13 open PRs!!
00:19:03 <ebering> !bug 11821
00:19:04 <Sequell> https://crawl.develz.org/mantis/view.php?id=11821
00:21:01 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.23-a0-818-g00444ac475 (34)
00:26:02 <switch__> wanna help me code mine? i broke my dev environment twice today
00:26:14 <switch__> :<
00:29:53 <switch__> https://i.imgur.com/UFGjLsZ.png this IDE doesn't let you copy-paste, sorry if you have to zoom in really hard/if it's unreadable.
00:30:31 <switch__> i tried to use https://github.com/crawl/crawl/blob/04f6012f58c171925684bdcddd1bb3b4e62cef64/crawl-ref/source/dat/dlua/lm_fog.lua#L207 on_trigger as an entry point for the chained fog machines, but the only way i could see how to do it was to pass slaves to that function
00:30:59 <switch__> which worked, but had unintended consequences that i haven't shored up yet (i.e. broke everything)
00:32:18 <alexjurkiewicz> how many things use chained fog machines?
00:32:27 <switch__> exactly one subvault
00:32:38 <alexjurkiewicz> maybe a silly idea, but wondering if it's worth supporting at all, or if you could just remove that functionality
00:32:51 <alexjurkiewicz> ??millimarvin
00:32:52 <Sequell> millimarvin[1/1]: 22.669 lines of code removed (as of 2017-08-30)
00:33:09 <switch__> well, i didn't post a full explanation of the problem i'm tackling with the hope someone would say "well, why not just not do it"
00:33:15 <switch__> because i totally considered not doing it
00:34:16 <switch__> but uhh, i dunno. the subvault isn't anything special. i've never actually seen it in the game, and i've played a few thousand games, so it isn't like anyone would even notice it gone
00:34:24 <switch__> but i like the functionality, it's neat
00:34:34 <ebering> you should always consider "why not just not do it"
00:35:03 <switch__> i did already, and you said "i wouldn't merge this right now because it breaks a vault"
00:35:20 <ebering> yeah; you can fix the vault instead :)
00:35:44 <switch__> but it's so cooooooool when they all light up at once
00:36:08 <switch__> it's 4 little fire things in a circle and they go poof all at the same time
00:36:29 <switch__> with a few seperate ones you could totally do rotating rings of fire and stuff
00:36:49 <switch__> maybe
01:01:48 <switch__> i fixed it by the way, problem was bad code
01:02:06 <switch__> not sure who sat down at my computer and wrote it
01:28:03 <Gretell> Unstable branch on crawl.develz.org updated to: 0.23-a0-818-g00444ac (34)
01:31:43 <Cheibriados> 03ebering02 07* 0.23-a0-819-g6debee6: Really remove High Elves 10(78 seconds ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/6debee6d2d96
01:47:05 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.23-a0-819-g6debee6d2d (34)
01:55:34 <ebering> !lg . BaIE won -tv:<14
01:55:36 <Sequell> 1. ebering, XL27 BaIE, T:100798 requested for FooTV: telnet://termcast.develz.org or http://termcast.develz.org.
01:55:38 <ebering> oops
01:59:27 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-819-g6debee6
02:23:48 <Kelbell> Webtiles server stopped.
02:23:50 <switch__> well
02:23:53 <Kelbell> Webtiles server started.
02:23:56 <switch__> i wrote a bunch of code
02:24:04 <switch__> they all fire synchronously
02:24:19 <switch__> the c++ equivalent of the fog machine markers, i mean
02:24:33 <switch__> but it doesn't actually work; they don't all fire at once for the player
02:25:07 <switch__> i don't actually know how to debug this
02:25:23 <switch__> i don't know why they're not in sync
02:29:16 <switch__> guess i'll push it and maybe someone can see what i'm missing
02:59:01 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.23-a0-819-g6debee6
03:39:00 -!- muffindrake1 is now known as muffindrake
05:58:35 -!- amalloy is now known as amalloy_
06:12:19 <Cheibriados> in long text box, lines a skipper with PgDn 13https://crawl.develz.org/mantis/view.php?id=11835 by RoGGa
08:40:38 <Cheibriados> No warning for Demonspawn when reading scroll of Holy Word 13https://crawl.develz.org/mantis/view.php?id=11836 by RoGGa
11:19:47 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-717-g61b839f: Fix chained fog machines 10(8 minutes ago, 6 files, 165+ 70-) 13https://github.com/crawl/crawl/commit/61b839f877b0
11:20:03 <switch__> the logic in my cloud.cc function is probably just wrong
11:20:31 <switch__> (the commit message for that ^ is "but it doesn't work")
11:21:11 <switch__> could someone please fix my cloud generator code? it shouldn't be too hard. test by creating hangedman_minor_magic with wizmode -> shift+p
11:21:29 <switch__> i'm not sure when i'll have time to fix it
11:22:15 <switch__> shouldn't need to touch anything but cloud.cc
11:22:57 <ebering> switch__: I marked it with the 0.24 milestone, I'm not sure anyone will have time to look at it before the feature freeze, since we're looking to freeze within the week
11:23:33 <ebering> it would help if you could annotate the PR with a review pointing out the specific places where you believe things aren't working, and if possible include links to the lua in the master tree your logic is intended to replace
11:23:33 <switch__> this is so easy though, probably
11:23:49 <switch__> i haven't done that part of the PR yet, i'll annotate everything
11:23:53 <switch__> i just want it to work first
11:24:27 <switch__> for some reason the clouds in the managed loop don't all fire at the same time and i'm not 100% sure why
11:25:24 <switch__> in theory nobody but the vault creator will notice the difference, since the 4 clouds show up as normal for everyone else
11:25:34 <switch__> so for what you wanted, this is feature complete, assuming i haven't left a memory leak somewhere
11:25:47 <ebering> switch__: "so easy, probably" does not inspire confidence
11:25:58 <switch__> lol
11:26:07 <switch__> but it has all this unnecessary code that i'd rather just get working
11:27:19 <switch__> i wouldn't be surprised if i didn't use the pointer logic properly
11:27:38 <ebering> anyhow, at least I personally am not of the opinion that merging a MVP that needs polish is a good idea, regardless of timeline; I'll try to take a look when I get a chance
11:28:09 <switch__> please do, it really just needs fresh eyes
11:28:14 <switch__> it isn't complicated or anything
11:31:52 <ebering> like I said, some annotations will really help when I do get to it
11:32:16 <switch__> i don't actually know how to do that
11:32:47 <ebering> if you go to the PR in the web ui, click on the changes tab, then click on any line in the diff and a comment box appears
11:32:50 <ebering> in the github web ui
11:32:58 <switch__> found it, thanks
12:10:16 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-819-g6debee6 (34)
12:41:59 <switch__> nevermind, today is MLK day, i do have time to work on this
12:42:27 <switch__> anyone good with the vault builder: is there any way you'd be able to pass synchronization information while defining clouds? e.g. if you wanted to fire them in order
13:35:18 -!- muffindrake1 is now known as muffindrake
14:09:19 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-716-g25e7b04: C++ Cloud Generators 10(5 days ago, 8 files, 299+ 88-) 13https://github.com/crawl/crawl/commit/25e7b04e854a
14:09:41 <switch__> that's a mergable PR ready for review
14:18:14 <switch__> may have slipped in an unnoticable but necessary MSVC change I forgot about :^)
14:19:54 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-716-g8f8acce: C++ Cloud Generators 10(5 days ago, 9 files, 300+ 89-) 13https://github.com/crawl/crawl/commit/8f8acce23d1e
14:23:25 <switch__> after this goes through i can finally do what i wanted to do like 6 months ago and remove the exclusions from clouds that were generated by a now-inaccessable generator (e.g. closing the door in sprint 2)
14:56:58 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-716-gcba1011: C++ Cloud Generators 10(5 days ago, 9 files, 302+ 89-) 13https://github.com/crawl/crawl/commit/cba101126bfc
14:57:06 <switch__> (done for real :3)
15:26:27 -!- amalloy_ is now known as amalloy
15:28:44 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-716-ga61bf4a: C++ Cloud Generators 10(5 days ago, 9 files, 307+ 94-) 13https://github.com/crawl/crawl/commit/a61bf4ac411c
15:29:02 <switch__> (checkwhite lul)
16:12:29 <advil> does anyone know what "deterministic magic mapping" refers to? how could it not be deterministic?
16:15:14 <ebering> where?
16:15:42 <advil> !source _tile_difficulties
16:15:43 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/view.cc#L539
16:16:25 <advil> oh hm maybe this is about passive mapping
16:16:25 <ebering> this looks like it's about passive mapping
16:17:25 <advil> oh, I suppose it's so you can't keep reloading your dd to reveal more map
16:26:21 <switch__> https://github.com/crawl/crawl/commit/d96b3e46e6442585a5b24e0017c9ff4c240b6f4e
16:27:38 <advil> the crucial commit is actually f844dbe31ff1
16:27:41 <advil> %git f844dbe31ff1
16:27:41 <Cheibriados> 07kilobyte02 * 0.14-a0-186-gf844dbe: Use a hash rather than the RNG for deterministic passive mapping.  Refactor. 10(5 years ago, 1 file, 13+ 13-) 13https://github.com/crawl/crawl/commit/f844dbe31ff1
16:28:37 <geekosaur> oh. that'd also be about making the RNG more deterministic
16:29:11 <geekosaur> i.e. you don't get different monsters later depending on how many times passive mapping has taken place
16:30:35 <switch__> dumb question: passive mapping is just the mutation effect that randomly reveals tiles, right?
16:31:48 <geekosaur> yes, including the DD intrinsic and the ash passive
16:33:11 <switch__> aren't monsters placed at level generation?
16:33:24 <geekosaur> but they can move
16:33:48 <geekosaur> many will be placed "asleep" but there's e.g. vaults that specify "patrolling" for monsters, etc.
16:34:14 <switch__> ah, i understand
16:34:35 <switch__> those monsters actually move, while you're on-level, even though you can't see them, right?
16:34:40 <geekosaur> yep
16:35:20 <geekosaur> I think some monsters may also place awake, e.g. seems to me like gnolls and orc bands move on their own?
16:35:34 <geekosaur> at least some of them. probably some percentage of some or all monsters place awake
16:35:39 <Pinkbeast> Since spawn removal some have been placed awake.
16:37:35 <switch__> oh, geekosaur, how well do you understand the level builder? i want to implement synchronized fog machines, for something like rings of fire, but I can't see any way to make that work with the markers that we currently have
16:38:23 <geekosaur> I'm not sure anyone understands the level builder, except possibly am*thyst
16:38:42 <geekosaur> (not sure if pinging is a good idea here...)
16:39:01 <switch__> e.g. i add support for a numerical parameter and a wrapping function, but even then, each marker would have to be unique, i think
16:39:27 <switch__> well, actually
16:39:29 <switch__> hm
16:40:55 <switch__> nevermind, i think i know how to do it
16:41:15 <switch__> but i think it'd be hard so i'll leave that on the to-do list, lol
16:41:42 <switch__> for now we can gaze at the beauty that is hangedman_minor_magic
17:05:13 <alexjurkiewicz> i tested bumping TAG_MAJOR_VERSION and removing all old code
17:05:20 <alexjurkiewicz> it almost compiles!!
17:05:33 <alexjurkiewicz> I made some errors when there was #else directives that are annoying to track down
18:08:46 -!- isha is now known as werekitten
18:16:50 -!- werekitten is now known as isha
20:03:53 <Cheibriados> Elec weapons (at least the one I'm using) repeat target name 13https://crawl.develz.org/mantis/view.php?id=11837 by Laret
20:09:25 <Cheibriados> New branch created: pull/954 (2 commits) 13https://github.com/crawl/crawl/pull/954
20:09:25 <Cheibriados> 03Umer Shaikh02 07https://github.com/crawl/crawl/pull/954 * 0.23-a0-820-ga0c7109: Let ESC clear/toggle layers in show_terrain view (amalloy) 10(3 hours ago, 1 file, 15+ 1-) 13https://github.com/crawl/crawl/commit/a0c710958802
20:09:25 <Cheibriados> 03Umer Shaikh02 07https://github.com/crawl/crawl/pull/954 * 0.23-a0-821-ge2be915: Unify exit paths from show_terrain view 10(2 hours ago, 1 file, 2+ 15-) 13https://github.com/crawl/crawl/commit/e2be9150ac2a
20:40:57 <Cheibriados> Reading notes with ?: starts at top of list 13https://crawl.develz.org/mantis/view.php?id=11838 by kitchen_ace
20:46:13 <floraline> ^ i noticed that as well with the ctrl+P message log. only on firefox
23:03:07 <alexjurkiewicz> in dungeon-feature-type.h, all new dungeon features are wrapped in TAG_MAJOR_VERSION == 34 at the bottom. Why is that?
23:03:22 <alexjurkiewicz> eg if you bump to major version 35, there will no longer be transporter features
23:05:02 <alexjurkiewicz> oh, actually most are elsewhere behind TAG_MAJOR_VERSION > 34
23:07:18 <geekosaur> == 34 is usually for features that have been removed but have save compat?
23:07:46 <geekosaur> there have been cases where people have gotten that backwards though
23:08:13 <ebering> alexjurkiewicz: saves assume an order to features, new ones go at the end
23:08:28 <ebering> when compat breaks (TAG_MAJOR > 34) they can be re-ordered to their proper place
23:23:40 <alexjurkiewicz> yeah. I got confused by DNGN_ALTAR_WU_JIAN which isn't in a TAG_MAJOR > 34 place (I'll submit a PR)
23:25:27 <ebering> alexjurkiewicz: I fixed your xxx
23:25:33 <ebering> you wanted dice_def, not calc_dice
23:26:13 <alexjurkiewicz> difference between giving beam the dice and rolling the dice for beam
23:26:28 <amalloy> alexjurkiewicz: why would WU_JIAN be in a >34 place?
23:27:04 <alexjurkiewicz> isn't WU_JIAN a god in the game who isn't going away?
23:27:07 <amalloy> well. reordering, obviously. but i mean, if it's currently in a reasonable place we don't ened an ==34 / >34 pair
23:27:30 <alexjurkiewicz> it's only in a ==34 place, and other gods are in a >34 place to be reordered so they are together
23:27:58 <amalloy> alexjurkiewicz: that would be wrong, indeed
23:28:34 <alexjurkiewicz> I have a branch I'm working on here to fix some similar errors: https://github.com/crawl/crawl/compare/master...alexjurkiewicz:patch-5?expand=1
23:28:41 <ebering> not quite; calc_dice(d, m) returns a dice_def(d,s) with sides calculated so that the max damage is m,
23:29:21 <ebering> so you were getting dice_def(4, 10/4) for your damage definition :P
23:30:08 <alexjurkiewicz> 4d2 oops
23:38:21 <amalloy> alexjurkiewicz: your fix to ARTP_FOG looks wrong - it looks to me like +Fog has been removed on purpose but kept for save compat, and you're putting it back for the next version
23:40:20 <alexjurkiewicz> it's still used by thief unrand
23:40:39 <amalloy> cool, seems good to me then
23:41:16 <alexjurkiewicz> heres a q. what about pakellas god passives. shoud they get tagged out?
23:42:13 <amalloy> i assume pakellas the god tagged is already out? i'd tag out the passives then
23:42:30 <alexjurkiewicz> correct. ok
23:42:59 <alexjurkiewicz> is the _t in passive_t hungarian notation? meaning what?
23:43:50 <amalloy> i expect it is a callback to stuff like size_t and ptrdiff_t
23:45:07 <amalloy> i wouldn't have called it passive_t so i assume it is some C++ idiom that |amethyst (who i think enum-ified passives) knows better than i do
23:48:18 <gammafunk> in mon-death.cc:2292 I would reorder that
23:48:51 <gammafunk> hrm
23:49:05 <alexjurkiewicz> put `random2(you.piety) >= piety_breakpoint(0))` first?
23:49:08 <gammafunk> I guess it does have to end if clause so it's a bit tricky
23:49:15 <gammafunk> yeah, but it has to close the statement
23:49:20 <gammafunk> so maybe it's not actually cleaner