00:00:20 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-726-g9fa1570 (34) 00:02:44 Stable (0.22) branch on CRAWL.XTAHUA.COM updated to: 0.22.1-6-g1668fe2 00:26:33 -!- amalloy is now known as amalloy_ 00:57:09 -!- muffindrake1 is now known as muffinddrake 00:57:13 -!- muffinddrake is now known as muffindrake 01:13:07 Stable branch on crawl.develz.org updated to: 0.22.1-6-g1668fe2 (34) 01:20:52 -!- ProzacElf_ is now known as ProzacElf 01:27:56 Unstable branch on crawl.develz.org updated to: 0.23-a0-726-g9fa1570 (34) 01:58:57 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-726-g9fa1570 03:00:20 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-726-g9fa1570 03:52:18 Stable (0.22) branch on crawl.kelbi.org updated to: 0.22.1-6-g1668fe2c40 04:13:15 Fork (bcrawl) on crawl.kelbi.org updated to: 0.23-a0-1461-g396401564d 08:38:58 -!- kevn57_ is now known as kevn57 09:23:41 Stable (0.22) branch on underhound.eu updated to: 0.22.1-6-g1668fe2c40 09:49:32 -!- bairyn is now known as ByronJohnson 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-727-gc10c12c: Convert `enum spflag_type` to `enum class spflag` 10(12 days ago, 19 files, 541+ 504-) 13https://github.com/crawl/crawl/commit/c10c12cd18d6 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-728-g6cc9815: Convert `enum spschool_flag_type` to `enum class spschool` 10(11 days ago, 35 files, 648+ 645-) 13https://github.com/crawl/crawl/commit/6cc9815d96e9 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-729-gcf51a5b: Convert `enum nothing_happens_when_type` to `enum class nothing_happens` 10(9 days ago, 7 files, 24+ 23-) 13https://github.com/crawl/crawl/commit/cf51a5b58e68 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-730-g6ae3f7c: Add a struct to use for MiscastEffect::special_source 10(23 hours ago, 15 files, 89+ 80-) 13https://github.com/crawl/crawl/commit/6ae3f7c33952 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-731-g340d99c: Convert `enum miscast_source` to an enum class 10(23 hours ago, 15 files, 102+ 90-) 13https://github.com/crawl/crawl/commit/340d99ca71cd 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-732-gf2062c9: Convert `enum recall_t` to an enum class 10(9 days ago, 3 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/f2062c9c22fd 11:19:54 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-733-gcd8e13e: Add a note to docs/obsolete/cut_spells.txt 10(4 days ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/cd8e13e48a2f 11:35:47 New branch created: pull/945 (1 commit) 13https://github.com/crawl/crawl/pull/945 11:35:48 03NormalPerson702 07https://github.com/crawl/crawl/pull/945 * 0.23-a0-727-gaafdf2d: Fix death channel duration leak when cast at max duration (11828) 10(4 minutes ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/aafdf2ddb46a 11:46:23 New branch created: pull/946 (1 commit) 13https://github.com/crawl/crawl/pull/946 11:46:23 03NormalPerson702 07https://github.com/crawl/crawl/pull/946 * 0.23-a0-727-g2fd5de5: Don't let battlespheres be blinded (11827) 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2fd5de5e711f 12:02:49 Stable (0.22) branch on crawl.akrasiac.org updated to: 0.22.1-6-g1668fe2 13:10:21 -!- amalloy_ is now known as amalloy 13:21:18 ebering re 944 it's a bit of work but not too crazy, are you hoping to have this done for release? 13:21:41 New branch created: pull/947 (1 commit) 13https://github.com/crawl/crawl/pull/947 13:21:41 03NormalPerson702 07https://github.com/crawl/crawl/pull/947 * 0.23-a0-727-gf099351: Fix monsters not being woken when hit by animated trees (11819) 10(12 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/f099351a3c24 13:36:39 advil: I think it's in the would be nice column 13:37:13 what do you think of in the long run, showing everyone all of their current followers, instead of tying it to a god display? 13:37:57 you'll run into overflow problems literally every beogh game i think 13:38:07 switch___: we have scrollers 13:38:19 also my immediate response :) 13:38:35 as long as you sort by xl or something 13:39:49 advil: the only real issue with that is what key to put such a menu on; it'd probably be a nice long-term goal 13:39:59 oh, i may have figured out clouds 13:40:19 will need help testing it once i'm done 13:40:27 03NormalPerson702 {ebering} 07* 0.23-a0-727-g19699f6: Fix death channel duration leak when cast at max duration (11828) 10(2 hours ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/19699f695db2 13:47:11 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-727-g19699f695d (34) 13:49:42 03NormalPerson702 {ebering} 07* 0.23-a0-728-g06a100f: Don't let battlespheres be blinded (11827) 10(2 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/06a100ffd6d2 14:02:18 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-728-g06a100ffd6 (34) 14:05:31 Crash running tiles version on Windows 10 13https://crawl.develz.org/mantis/view.php?id=11830 by ptommy 14:08:43 gonna need a windows expert to unpack that stack trace 14:09:13 oh god the lua 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-727-gf3ab628: Convert `enum spflag_type` to `enum class spflag` 10(12 days ago, 19 files, 542+ 505-) 13https://github.com/crawl/crawl/commit/f3ab628a2016 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-728-g2c9cd9b: Convert `enum spschool_flag_type` to `enum class spschool` 10(11 days ago, 35 files, 648+ 645-) 13https://github.com/crawl/crawl/commit/2c9cd9b53d02 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-729-g5da7fb0: Convert `enum nothing_happens_when_type` to `enum class nothing_happens` 10(9 days ago, 7 files, 24+ 23-) 13https://github.com/crawl/crawl/commit/5da7fb08f1b0 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-730-gb724be9: Add a struct to use for MiscastEffect::special_source 10(26 hours ago, 15 files, 89+ 80-) 13https://github.com/crawl/crawl/commit/b724be9be6cc 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-731-ge8f3988: Convert `enum miscast_source` to an enum class 10(26 hours ago, 15 files, 102+ 90-) 13https://github.com/crawl/crawl/commit/e8f39886c42e 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-732-g176d107: Convert `enum recall_t` to an enum class 10(9 days ago, 3 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/176d10725ccb 14:11:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-733-g05c31ba: Add a note to docs/obsolete/cut_spells.txt 10(4 days ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/05c31bae8686 14:16:20 03NormalPerson702 07https://github.com/crawl/crawl/pull/947 * 0.23-a0-727-g65bd4d0: Fix monsters not being woken when hit by animated trees (11819) 10(66 minutes ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/65bd4d03f379 14:19:51 not sure what's going on in that win10 crash but my first guess would be that that lua stack is the result of buggy stack reporting code more than anything else 14:21:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/947 * 0.23-a0-727-g640b738: Fix monsters not being woken when hit by animated trees (11819) 10(71 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/640b738662c3 14:32:49 i've been encountering non-fatal heap corruption during my testing 14:32:54 somewhere in the load code 14:33:05 it might be a symptom of the debugger i've attached but maybe not 14:36:11 https://i.imgur.com/ub2IqOO.png kinda just posting it here for later, if it doesn't end up being on my end 14:42:51 switch___: please use a pastebin instead of pictures of text 14:42:59 can't really pastebin that 14:43:30 i didn't forget, don't worry 14:52:54 when the delay is specified as 3 in the cloud generator, is that meant to be 3 auts or 300 auts? 14:53:03 or 30 o_O 14:53:26 does anyone know lol 14:53:46 oh, interesting, it's meant to be 3 auts. 14:54:04 i don't understand at all 14:54:40 all the clouds in dungeon sprint 2 are delay = 3 auts, but in my implementation that fills the entire map with clouds, understandably. 14:56:52 https://pastebin.com/raw/ekVnhB7n ebering; was wrong, it does let you copy-paste it 14:59:35 so, good news: i can run Sequell locally, and queries are still embarrassingly slow. bad news: i am not good at investigating postgres performance 15:02:44 like here is the EXPLAIN ANALYZE for `!lm *`: https://gist.github.com/amalloy/2b463fa92df50bf872f77edb2bd9937d - the parallel sequential scan on milestone obviously sucks but how else is it supposed to get a count 15:06:36 we could imagine disabling the result count for queries that don't ask for it explicitly, but still things like `!lg * recent / won` need a number 15:14:37 https://gist.github.com/amalloy/133029e0f8dda25eba23e3c55c2308a6 is the EXPLAIN ANALYZE for that query if anyone has an idea 15:39:07 it seems like query time scales linearly with number of games in database, even when you limit by version, because it seems to be scanning the whole table for wins before removing games with the wrong version number 15:44:47 ah, and i think it *can't* start by using its index on the logfile table's version field, because the internal id for a version number does not necessarily increase corrsponding to a higher version number 15:48:43 yes, interesting. we get a much better performance, and identical results, from `SELECT COUNT(*) FROM milestone where milestone.cv_id in (32, 39);` instead of `SELECT COUNT(*) FROM milestone INNER JOIN l_cversion ON milestone.cv_id = l_cversion.id WHERE (l_cversion.cvnum >= '2200099000000'::bigint);` 15:49:45 so either we should figure out how to convince psql's query planner of this, or teach Sequell to do version-based queries that way 16:14:40 03NormalPerson702 {ebering} 07* 0.23-a0-729-g94ec030: Fix monsters not being woken when hit by animated trees (11819) 10(3 hours ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/94ec0301e695 16:17:06 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-729-g94ec0301e6 (34) 16:26:05 amalloy: I don't have a lot of experience with postgres but the query plan you posted for !lm * would only count, it wouldn't return the most recent milestone, so there would be a second query too. But there's no more optimised way to get a row count. How big is the on-disk size of the data? 16:26:22 uhh 16:26:24 alexjurkiewicz: the most recent one is extremely fast and doesn't need to be optimised 16:26:31 how on earth do desolation clouds work 16:26:34 why is their delay 0 16:26:59 switch___: If you can fix that I'll be delighted 16:27:06 yeah I assumed there would be an index on the 'time' column 16:27:29 i'm working on it, but i can't replicate the fog effect of desolation clouds using these settings, i don't understand how this works 16:27:39 there's no buildup or anything 16:27:54 they just run at delay 0, which is an infinite loop in pleasingfungus' code 16:28:46 modifying it to something that isn't 0 (e.g. 1) doesn't come close to replicating current desolation 16:29:28 amalloy: how big is the postgres on disk database? 16:30:10 alexjurkiewicz: are you asking about the on-disk size of any particular table, or the whole db or what? it seems to be using 92GB in total, all of which is for Sequell (i had no psql installation before starting this project) 16:31:12 yeah was just wondering about the total working set. If it would be reasonable to just run sequell on something with enough RAM to keep everything on disk 17:16:08 well, i know why desolation lags, lol 17:16:19 each cloud generator runs around 9 times each tick 17:16:29 and you get over 1k clouds on the map in env 17:21:56 scratch that, there's something else here that i can't see yet. even running my cloud generators 20 times a tick doesn't match the fog machines in desolation. i can't get more than 800 clouds 17:34:23 is tile_display_mode = hybrid supposed to show tiles? i'm only seeing glyphs still 17:38:24 oh, nevermind. i get it 17:50:14 gammafunk, do you know how desolation clouds manage to fill the whole screen? 18:15:04 gammafunk: I'm thinking of replacing the monster silence effect from klown pie with mute because of the difference between how player and monster silence decay; when a klown pies a monster it creates full range silence for most of the time the monster is silenced (all but the last 3 turns), and reducing the player duration to 60 so that only the player is silenced 18:15:39 these two changes could be separated 18:16:47 what's the current duration? 6 turns is pretty short 18:17:08 switch___: I'm not sure what you're doing with clouds but do you know about https://github.com/crawl/crawl/commits/cloud_gen/crawl-ref? 18:17:24 the player effect does silence some other monsters but then again the player is still stuck with silence 18:17:25 yep, i used a lot of his code 18:17:30 ok 18:17:35 and many monsters are still just as dangerous when silenced, of course 18:17:49 but I'm not sure what the current (I think) 100 spellpower translates to duration-wise 18:18:14 i'm actually done for now, i'm gonna PR it. i broke one tiny room that uses the synchronized fog machine feature; it doens't look like there were any other features used (or more than 1 vault) 18:18:40 it seems to be about 120 I haven't read through the code. 18:18:56 there's a noticable performance benefit on my end, but i dunno how well that translates. also a decent amount of my changes (and my entry point) are hacky, but that's the point of other devs, right? 18:19:00 yeah, 12 turns is a fairly nice duration for the player effect 18:19:20 6 is like, paralysis length 18:19:31 yeah. I'm less certain about the player change 18:20:30 I'm not sure that the change is too necessary, since obviously klowns won't silence monsters too often, and I think the situation they create is more dangerous on-average 18:20:39 what's your main concern behind this change, weird exploits? 18:20:50 monster silence, because of how the radius behaves with the duration, seems less good, since it lasts for 12 turns but is affecting squares for all of those 18:20:59 weird exploits or incentives 18:21:25 I guess I could see the potential, but this seems pretty tough to pull off as an exploit 18:21:31 have some popcorn around to get free silence against an alich, probably not actually a good play 18:21:57 yeah, it's true if you have a lot of allies you can possibly get lucky that way 18:21:57 also if an ally gets silenced the player has far fewer options than their own silence 18:22:06 oh, well 18:22:12 Unstable branch on underhound.eu updated to: 0.23-a0-729-g94ec0301e6 (34) 18:22:20 a player with allies still has allies, one of the strongest things in the game :) 18:23:06 I don't feel super strongly against, but 6 duration silence just seems a bit too brief; the asymmetry of it muting monsters feels a bit weird, but I suppose there's nothing hugely wrong with that 18:23:20 there are certainly some effects that straight up do nothing 18:23:37 vs. monsters, I mean 18:23:48 that's another option, remove it from the list of possible monster effects 18:26:34 it's possible that 6 turns of silence will work similarly for people who let themselves get killed by silence 18:27:15 I think getting allies muted if they get pied is a good middle point between taking it out alltogether and the very long large silence field of monster silence 18:27:15 .klowned !ru s=status ckaux!~~pie 18:27:15 Killed by new Killer Klowns (!ru s=status ckaux!~...): about to teleport,marked,no potions,hasted,wreathed by umbra,drained, agile,silence,marked,very slightly contaminated,slowed,constricted,invisible, confused,mighty,brilliant,agile,silence,resistant,marked,berserk cooldown, mighty,about to teleport,bat-form,berserk cooldown,flying,regenerating,hasted and slowed,studying 2 skills, mighty,marked,... 18:28:19 it's sort of interesting that allies can get silenced 18:28:26 it's anti-ally tech in some ways 18:28:38 but it's sort of mixed since it might just be beneficial depending on what else is around 18:28:40 @?lightning spire 18:28:40 lightning spire (118) | Spd: 10 (07stationary) | HD: 3 | HP: 17-24 | AC/EV: 13/3 | 11non-living, unbreathing | Res: 13magic(immune), 05fire++, 02cold++, 11elec+++, 09poison+++, 12drown, 04rot+++, 13neg+++, 13torm | XP: 32 | Sp: b.electrical (3d6) [11!AM, 06!sil] | Sz: small | Int: brainless. 18:29:04 you can't control the silenced ally, so I could see concerns about not wanting allies around when fighting klowns 18:29:25 but if someone argued that this gameplay is undersireable, they'd probably also argue that monster mass confusion is just a bad spell 18:29:38 it has similar issues vs allies 18:30:16 s=status would need some strong regexp_replace to be at all useful 18:33:23 .klowned 18:33:24 17. Violenta the End of an Era (L26 DsAr of Qazlal), demolished by an Orb Guardian on Zot:5 (hall_of_Zot) on 2019-01-15 12:13:36, with 597579 points after 83797 turns and 2:35:13. 18:33:31 17 kills already! congrats 18:33:42 it's not 17 18:33:44 !cmd ./klowned 18:33:44 No command ./klowned 18:33:47 it's like 3 18:33:47 !cmd .klowned 18:33:47 Command: .klowned => !lg * newklowns (( cikiller=killer_klown || zot status~~bat-form|wisp|pig-form|fire_vuln|silence|vertigo|no_potions || zot collapse|brainless|clumsy )) title:"Killed by new Killer Klowns$(argst $*)" $* 18:33:57 just a lot of false positives and incidental ones 18:34:16 !lg * map~~chequers 18:34:18 6510. Dittersdorf the Fighter (L10 HOFi of Beogh), blasted by an electric eel (bolt of electricity) on D:9 (chequers_big_river) on 2019-01-16 20:50:06, with 5433 points after 7095 turns and 0:42:09. 18:34:42 dang. 6k. cool. 18:36:12 ebering: another problem with muting is that the player would have no way of knowing this would be an outcome, and we'd have to communicate that in the spell description to some extent 18:36:23 we're sort of adding more special cases 18:36:49 makes me wonder if maybe there's an alternative to silence 18:36:57 -Cast :P 18:37:30 part of why I picked 60 is that it's the duration with silence rdius 0 18:37:50 yeah that probably would work well with monster muting 18:37:50 so that the effect could be communicated as "prevents the target from speaking" 18:37:54 in a description 18:38:29 I guess as a compromise, probably 6 turn player silence and similarly shortish duration monster muting would be best 18:38:37 from a player perspective those would basically be the same 18:39:44 I don't think exploits are too big a concern, although I could be wrong about that, nor that problems for players with allies are too bad, but yeah if you feel like you want to make that change, the 0-radius silence + muting is probably the best option 18:40:48 it would throw a bone to people that think that silence is a *death sentence*!!!! 18:48:34 I think for them, even 6 turns is a *death sentence*~~~~ 18:49:01 the player could also be silenced at radius 1 if we want a longer player silence 18:49:13 I dunno how many turns that is, maybe 7 or 8? 18:50:09 hrm, it's not actually literally always 6 turns is it? 18:50:34 for silence radius zero? yes, the relation between radius and remaining dur is deterministic 18:50:48 well, are you going to fix it to a duration? 18:50:50 instead of spellpower 18:51:01 hrm I guess not 18:51:09 it shouldn't be an exact duration is what I'm saying 18:51:13 yeah I see 18:51:42 it would be fine to just lower the spellpower probably, yeah; maybe sometimes player would have a larger silence aura 18:51:51 was just typing that 18:51:52 but it wouldn't be more than one or two tiles I presume? 18:51:55 yes 18:52:55 well, rip what I said about mute being the same as the player effect; I suppose that difference is not too large a concern 18:53:44 the 100 spellpower I chose was certainly arbitrary 18:54:06 but it seemed ok duration-wise in testing; just did have a largish silence aura sometimes 18:58:58 New branch created: pull/948 (1 commit) 13https://github.com/crawl/crawl/pull/948 18:58:59 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-715-gaef92ca: C++ Cloud Generators 10(25 minutes ago, 7 files, 230+ 29-) 13https://github.com/crawl/crawl/commit/aef92ca26f28 18:59:02 -!- amalloy is now known as amalloy_ 19:02:02 that lua debugger totally has a memory leak, by the way 19:04:19 wow nice 19:05:16 server owners salute you 19:05:36 still needs to be tested, lol 19:08:45 in principle, it works, and should be easy to build off of/improve 19:10:22 just special case it for desolation only and I'd still be happy 19:10:51 nah, just need to rebuild the synchronicity in c++ 19:11:12 desolation's problem is that it just uses too many clouds in the first place 19:11:46 i have no idea how those cloud generators work, if we're being honest. do they just run 50 times a tick? 19:12:03 when i ran mine 50 times a tick it still didn't really match it perfectly 19:12:07 I found the cloud mage wizlab to be generally more fun 19:12:21 not as challenging as desolation, but I think it works a lot better 19:12:29 and I believe it's not as slow when resting either 19:12:44 well, the real problem is that each cloud generator in desolation was running the entire time 19:12:46 50 times a tick 19:12:53 or whatever it was 19:13:06 so if we redesign desolation to have more layout and with less clouds 19:13:07 my patch cuts them off if they're not visible to the player 19:13:28 not literally by los, but roughly by distance 19:13:39 and possibly just less popcorn spam so there's not quite so much luring of that away from the monsters that interact with them 19:13:44 it might be a better portal 19:41:20 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-715-g28360e1: C++ Cloud Generators 10(67 minutes ago, 7 files, 229+ 29-) 13https://github.com/crawl/crawl/commit/28360e1860e4 21:01:14 since when does checkwhite not fix all in one go 21:01:21 d'oh 21:06:03 03stenella02 07https://github.com/crawl/crawl/pull/948 * 0.23-a0-715-g5a0250d: C++ Cloud Generators 10(3 hours ago, 7 files, 229+ 29-) 13https://github.com/crawl/crawl/commit/5a0250d44c4c 21:13:30 spaces at eol: crawl-ref/source/spl-damage.cc 21:13:36 oh yeah, well, i didn't even edit that file, so 21:46:17 -!- TAS-2012v is now known as TAS_2012v 21:46:17 -!- masterinire is now known as inire 21:50:38 -!- bairyn is now known as ByronJohnson 21:53:40 03advil02 07https://github.com/crawl/crawl/pull/944 * 0.23-a0-720-g814426a: Add god extra pane to webtiles 10(9 minutes ago, 3 files, 76+ 12-) 13https://github.com/crawl/crawl/commit/814426aff402 21:58:58 03advil02 07https://github.com/crawl/crawl/pull/944 * 0.23-a0-721-g732b779: Code formatting, wording 10(2 minutes ago, 2 files, 6+ 5-) 13https://github.com/crawl/crawl/commit/732b7798d03c 22:04:16 03advil02 07https://github.com/crawl/crawl/pull/944 * 0.23-a0-722-g2c721a0: Remove commented code 10(46 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/2c721a01e788 22:25:26 03advil02 07https://github.com/crawl/crawl/pull/944 * 0.23-a0-723-gea4a607: Code formatting 10(4 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/ea4a607e6d99 22:41:34 did someone break travis 22:43:05 yep, sure did 22:43:46 the whitespace in 947 22:46:21 -!- Adeon_ is now known as Adeon 23:07:05 !blame NP7 23:07:05 I pronounce NP7... Guilty! 23:07:13 I share the blame for not wating for travis to checkwhite it 23:07:37 advil: nice commit :) 23:07:41 (S) 23:07:44 plural 23:08:01 !blame2 ebering 23:08:01 eeebbbeeerrriiinnnggg 23:09:36 03ebering02 07* 0.23-a0-730-g0b75920: checkwhite (Stenella) 10(20 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/0b759201fd16 23:17:07 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-730-g0b759201fd (34) 23:39:42 ebering: could you please tag 948 with "help wanted". a man can dream, right? 23:40:29 i feel kinda bad about breaking that vault :\ 23:42:43 switch__: done. two requests: in your PR message include a checklist indicating what needs to be done before you'd consider this ready 23:43:00 awesome, thanks. i'll do that now 23:43:25 and 2. if you've copied a majority of the code from PF's cloud_gen it would be nice if you could cherry pick those commits and then apply your edits so we have accurate attribution and blame in git; if that makes sense to do 23:43:55 though to be honest, if a server owner tests it and it can run as-is with desolation perfectly smooth, you could use this as-is, there's nothing horribly wrong with it, from what i can tell 23:44:22 if you can't make those cherry-pick cleanly then you can fake it using git commit --author= 23:45:19 switch__: it breaks an existing vault, and no one has taken a look at what you mean by "pretty close to the current effect" 23:45:30 so I wouldn't call this "ready to use as is" 23:46:24 if what i checked is accurate, it's literally one vault, and the vault is a 5x5 room, but yes, that's true 23:46:51 i was actually really surprised by that 23:46:51 so many unused fancy fog machine features 23:48:21 switch__: I wonder if other vaults have gone by the wayside - it might be worth looking at the corpus of vaults when they were first introduced. 23:48:50 i don't understand what you mean 23:49:12 Which bit? 23:49:54 are you saying that there may have been other vaults that used the fancy features, but were deleted? 23:50:13 Yes. 23:50:16 if so, i dunno why i would look for them, because the current implementation of my PR breaks them :P 23:50:31 Curiousity? 23:50:52 that's a good point 23:51:01 but would crawl devs ever really delete an interesting vault? 23:51:09 i refuse to believe it 23:55:04 ebering: https://github.com/crawl/crawl/commit/62eaa7fa39dbc4ef564fa2494ad2c08405597500 is there an easy way for me to import this specific commit into my branch? it's probably the only one worth keeping, though his wizmode commit should be tested/imported seperately 23:55:35 switch__: git cherry-pick 23:55:48 thanks