00:09:23 -!- thurin is now known as uprime 00:33:30 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-667-gc184e93 (34) 03:52:16 Experimental (bcrawl) branch on crawl.kelbi.org updated to: 0.23-a0-1377-gd4f69ff5c3 08:25:46 -!- Tiobot is now known as Guest39325 09:50:48 !tell johnstein can you message me when you get this? 09:50:48 mikee_: OK, I'll let johnstein know. 10:05:44 !tell mikee_ I got your message but I’m heading to work in a couple minutes. 10:05:45 johnstein: OK, I'll let mikee_ know. 10:19:23 mikee_: I have to go to work. irc isn’t convenient for me via my phone. I have a much better chance of seeing your message on discord. 10:38:21 jfc why does webtiles even work at all 12:05:30 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-667-gc184e93 (34) 12:19:44 03ebering02 07* 0.23-a0-668-g079dcdc: Adjust deck size and card dealing 10(31 minutes ago, 2 files, 11+ 6-) 13https://github.com/crawl/crawl/commit/079dcdc05b3c 12:19:44 03ebering02 07* 0.23-a0-669-geb4e2cb: Adjust Deal Four 10(5 minutes ago, 3 files, 3+ 6-) 13https://github.com/crawl/crawl/commit/eb4e2cb51d0b 12:33:50 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-669-geb4e2cb51d (34) 12:37:02 triple draw might become the minmay version of taking one from each deck; definitely thinking about switching to an ace-in-the-hole replacement for stack five 12:48:27 03advil02 07* 0.23-a0-670-gedc2041: Don't create a new TextDecoder for each message 10(3 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/edc204144ce3 12:48:27 03advil02 07* 0.23-a0-671-g42e8185: Use window hidden API properly 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/42e81859b23d 13:01:58 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-671-g42e81859b2 (34) 13:02:57 wonder what happened to the cbro bot here 13:03:02 it's still up on lunarnet 13:18:25 is there any execution flow documentation on the lua code? 13:19:41 my guess is advil: you're the person to ask 13:19:55 there's the docs that ebering put together, but otherwise not really 13:20:23 where are those? 13:20:33 http://doc.dcss.io/ 13:20:39 thanks 13:21:14 to the extent that discusses control flow it's probably in the Hooks section 14:46:09 03NormalPerson702 {ebering} 07* 0.23-a0-672-gfb80274: Convert spret_type to an enum class 10(9 days ago, 23 files, 460+ 455-) 13https://github.com/crawl/crawl/commit/fb802740aadb 14:46:09 03NormalPerson702 {ebering} 07* 0.23-a0-673-g3803c42: Rename spret_type to spret 10(9 days ago, 35 files, 654+ 654-) 13https://github.com/crawl/crawl/commit/3803c42f1661 15:17:00 question: shoals lags in a way that's similiar to desolation. is water spread handled in lua? are we sure that lua is the reason desolation is slow? 15:17:47 reading through logfiles has this question pop up a few times in various ways but the replies are never very conclusive 15:21:13 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-673-g3803c42f16 (34) 15:37:22 So no issues with spret yet 15:37:34 Fingers crossed it stays that way :) 15:40:04 -!- aidanh_ is now known as aidanh 16:42:38 New branch created: pull/938 (5 commits) 13https://github.com/crawl/crawl/pull/938 16:42:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-674-gf068b24: Convert `enum spflag_type` to `enum class spflag` 10(4 days ago, 19 files, 543+ 506-) 13https://github.com/crawl/crawl/commit/f068b24626b3 16:42:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-675-gd901bea: Convert `enum spschool_flag_type` to `enum class spschool` 10(3 days ago, 35 files, 648+ 645-) 13https://github.com/crawl/crawl/commit/d901beaab399 16:42:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-676-ge6f2485: Convert `enum nothing_happens_when_type` to `enum class nothing_happens` 10(26 hours ago, 7 files, 24+ 23-) 13https://github.com/crawl/crawl/commit/e6f24857869d 16:42:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-677-gaf2f6b8: Convert `enum miscast_source` to an enum class 10(25 hours ago, 15 files, 118+ 97-) 13https://github.com/crawl/crawl/commit/af2f6b8a1810 16:42:38 03NormalPerson702 07https://github.com/crawl/crawl/pull/938 * 0.23-a0-678-ge259bd8: Convert `enum recall_t` to an enum class 10(25 hours ago, 3 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/e259bd8ac6a8 16:48:53 The build has errored. (master - 3803c42 #10804 : NormalPerson7): https://travis-ci.org/crawl/crawl/builds/477007494 16:51:39 NP7: 16:52:22 hmm 16:52:30 just re-run the build 16:52:38 are you sure I can reset it? 16:52:55 i imagine if you force-push nothing it'll restart the build 16:53:31 uhm this is master we're talking about here 16:53:34 not my branch 16:54:16 right, if you force-push to your branch it'll restart the check on the PR, is my guess; i'm not sure how you did it, but it looks like it restarted 16:55:09 crawl's master branch just errored for no good reason 16:55:15 I can't change crawl's master branch 16:55:18 no it didn't 16:55:24 you just didn't read the build error 16:55:29 oh 16:55:31 suggest you do that before jumping to conclusions 16:55:49 well 16:55:50 Failed to connect to packagecloud-repositories.s3.dualstack.us-west-1.amazonaws.com port 443: Connection timed out 16:55:52 is a good reason 16:55:56 just not a relevant one 16:56:25 right 16:57:25 oh. i'm an idiot. sorry. the travis check for the current master branch errored, with your name on it, becuase your PR was the most recent pushed to master. you also very recently put up a new PR, which is what I thought errored out 16:57:35 everything is fine carry on 16:57:36 yes :) 16:59:48 by "good reason" I meant one I have to worry about, but nvm :D 17:18:47 in general if it says "errored" in here that's ignorable, "failed" is something to look at 17:20:52 oh that's probably a good rule of thumb 17:21:05 I remember the good old days when (I think) grunt first enabled travis 17:21:12 it was a constant stream of false positives 17:21:36 ??travis 17:21:37 travis[1/2]: travis runs automatic builds of Crawl and its branches, ensuring that they compile properly, and running Crawl's tests on the subsequent builds to look for errors or crashes. See: https://travis-ci.org/crawl/crawl/ 17:25:41 !learn add travis_error If you see "The build has errored", this is likely an ignorable error due to travis failing to fetch/install packages. If you see "The build has failed", that is likely a legitimate build problem. Click the https://travis-ci.org/crawl/... build link travis reports to see for sure. 17:25:42 travis error[1/1]: If you see "The build has errored", this is likely an ignorable error due to travis failing to fetch/install packages. If you see "The build has failed", that is likely a legitimate build problem. Click the https://travis-ci.org/crawl/... build link travis reports to see for sure. 17:25:52 ??travis 17:25:52 travis[1/2]: travis runs automatic builds of Crawl and its branches, ensuring that they compile properly, and running Crawl's tests on the subsequent builds to look for errors or crashes. See: https://travis-ci.org/crawl/crawl/ 17:26:12 !learn edit travis[1] s/$/ and {travis error}./ 17:26:13 travis[1/2]: travis runs automatic builds of Crawl and its branches, ensuring that they compile properly, and running Crawl's tests on the subsequent builds to look for errors or crashes. See: https://travis-ci.org/crawl/crawl/ and {travis error}. 17:26:27 ??travis[2 17:26:27 travis[2/2]: Travis can't be bargained with. Travis can't be reasoned with. Travis doesn't feel pity, or remorse, or fear. And Travis absolutely will not stop, ever, until your project is dead. 17:31:56 fosho 17:32:30 i've just noticed in the past that when i'd open a PR from like, months back, and wonder "what's going on? why is this still here?" sometimes it'd be "oh, the build errored out and nobody has touched it since, because that's the PR owner's problem 17:48:34 hm, speaking of travis, I think we need to do something to upgrade it or it will stop working at the end of the month 17:48:36 https://developer.github.com/changes/2018-04-25-github-services-deprecation/ 17:49:49 probably convert it to an app, https://github.com/marketplace/travis-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW43MA==#pricing-and-setup 17:50:53 sounds like you've volunteered :P 17:52:30 advil: when you were working with the cloud lua, how were you testing? 17:53:27 I haven't done very much with the cloud lua, but I was probably just making it print stuff? 17:53:42 hm, travis currently has no migration plan for oss currently using travis-ci.org 17:53:54 oh, really? 17:55:03 I just tried to upgrade my personal account, and it wouldn't do it 17:55:05 "However, open source repositories will be migrated to travis-ci.com gradually. The migration was planned to start at the end of Q2 2018, but has been pushed back. We will announce a new date as soon as we are able. You will receive an email when the migration for a repository is complete." 17:55:35 we could migrate immediately and have them delete the build history if we email 17:56:23 well, we can hope they will try to do something by the end of the month, there's still many weeks 17:57:00 I'm going to activate it for the org though 18:00:21 that way I suppose it should automatically update whenever they do it 18:22:31 Unstable branch on underhound.eu updated to: 0.23-a0-673-g3803c42f16 (34) 20:11:40 03ebering02 07* 0.23-a0-674-ge8b2c15: New axe and polearm statue tiles (CanOfWorms) 10(10 minutes ago, 4 files, 9+ 1-) 13https://github.com/crawl/crawl/commit/e8b2c155c3ee 20:11:40 03ebering02 07* 0.23-a0-675-g184aec9: Adjust the shape of a Bailey entry 10(35 seconds ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/184aec986fb2 20:12:51 03ebering02 07* 0.23-a0-676-g03697e9: Correct a feature description to match a tile 10(25 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/03697e99979b 20:19:44 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-676-g03697e9997 (34) 21:55:43 03gammafunk02 07* 0.23-a0-677-g07611c5: Allow Vertigo status to show up in status displays 10(44 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/07611c572365 22:02:02 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-677-g07611c5723 (34) 22:24:37 is it possible for a player to start a trunk game on a version which is not the latest? 22:26:10 i don't think so 22:26:14 not normally 22:26:27 suggests a misconfigured dgl setup 22:26:49 (or a tricky one that allowed that for some reason, but it'd take a fair amount of work I think) 22:27:38 it could happen if the server isn’t auto updating 22:28:04 but if you aren’t talking about that, I think it would be difficult for most servers. 22:28:34 i have a script which checks for and removes old trunk builds that have no players. i suspect a player started a game on a version which the script was trying to remove 22:28:42 maybe it's just my script is written poorly 22:29:00 the poor thing got stuck in a loop while dgl was saying you can't remove this version, there is an active game ongoing 22:29:29 probably means there’s a save file that exists 22:29:39 that hasn’t been transferred to the new version 22:30:07 I have a ton of those and I have a script process to batch auto update that I ran several months ago 22:30:13 if i run bin/dgl remove-trunks -v i get a line that looks suspicious 22:30:19 Jan 8 13:01 0 22:31:17 the script is supposed to only look at versions which report zero players on remove-trunks 22:34:15 floraline: I had one of those - in the end I found the hanging version and removed its files manually 22:41:18 Pinkbeast: thanks, i found it and removed the files. this was the version which my script failed to remove correctly 22:44:36 well, at the very least i've changed the call to remove-trunks to pass the -q parameter which should prevent it from looping like that. now it should just skip that version and prevent a half-baked removal 22:47:51 johnstein: do you just transfer saves when you need disk space, or is there some other limit to the number of installed trunk versions? 22:48:09 basically space 22:48:47 I’ve only done this once. for about 5-6 versions 22:48:47 i haven't transferred anyone yet and i'm wondering what is the best way to automate it 22:50:48 i was thinking a daily script could savegame-transfer all players on versions past the Xth installed 22:51:08 that would allow me to set an upper limit on the number of versions i keep around 22:52:22 you must have a huge number if you've only done it once 22:58:14 yea tons 22:58:25 trying to make sense of my notes.... 22:59:21 here's my rough notes and approach. https://gist.github.com/jmbjr/a6d95a6140fa0f0d29f4216cd1c346d5 22:59:31 basically, I use the %git command here to figure out what the latest stable version of each version is 23:00:04 %git 0.17-b1~1 23:00:04 07gammafunk02 * 0.17-a0-2234-g0da9ddf: In the release guide, use -a in the example git tag command 10(3 years, 2 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0da9ddf72ea6 23:00:20 so that means all v0.16 games need updated to that 0.17-a0 version 23:00:40 er maybe I have that wrong 23:04:42 yea that's wrong. that %git command figures out the commit just prior to the beta release verson of that version. so in this case, I would want to transfer all 0.17 games to 0.17-a0-2234 23:04:54 however, on my system, I didn't have that version. my latest was d80ca38 23:05:03 %git d80ca38 23:05:04 07MarvinPA02 * 0.17-a0-2231-gd80ca38: Remove some cases of vault-specified monster spellsets 10(3 years, 2 months ago, 3 files, 5+ 58-) 13https://github.com/crawl/crawl/commit/d80ca38ea2b9 23:06:25 i don't understand, when and why would you need to do this? 23:06:50 is this an alternative to dgl savegame-transfer? 23:07:03 I'll start from the beginning. I had about 1100 trunk versions installed on cbro 23:07:21 that had one or more save file, so clean-trunks didn't delete them 23:08:26 so they wouldn't get transferred unless the players logged in and then selected 'transfer game' manually 23:08:35 which likely wouldn't happen for most of them 23:09:37 why not just execute dgl savegame-transfer or savegame-transfer-all? 23:11:30 I wanted to update each game only to the most stable version for that version. i.e. I had 200+ version 0.17 versions installed. so I wanted to transfer them all to the same equivalent stable version of 0.17 (i.e. 2234 above) 23:12:13 which I did by manually moving the save files for those 0.17 games to the 2231 version folder (i.e. the most recent one I had installed on cbro) 23:12:25 I don't recall offhand exactly what those two dgl scripts do 23:12:40 oh, i see. that makes sense 23:13:18 i believe the dgl scripts just transfer you to the latest trunk 23:13:54 that sounds great until it comes to crossing into the next stable iteration 23:14:52 yea, I was trying not to force all old games (I was all the way back to 0.14) to transfer to the newest trunk 23:15:35 the issue is, git describe shows a shorter hash than the crawl install dir 23:15:35 0.22-a0-447-gee5f723 crawl-git-ee5f7238b3 23:16:29 actually, i think i am mistaken 23:16:58 POSSIBLE_GAME_HASH="$(echo "select hash from versions where major=${OUR_SGV_MAJOR} order by time desc limit 1;" | sqlite3 ${VERSIONS_DB})" 23:17:09 so I had to use shell scripts to create a correspondance table to figure out which crawl version corresponded with each crawl-git folder. 23:17:31 I can barely remember what I did and my notes are pretty bad. thought I documented it better 23:17:38 it looks like it will only transfer a save to the latest commit hash that has the same major version 23:18:06 what is actually the major version here? is it the entire 0.22? 23:19:35 if i'm not mistaken, dgl savegame-transfer-all will do exactly as you described 23:19:46 bring everyone forward to the latest hash without changing major versions 23:27:37 major version is defined here: https://github.com/crawl/crawl/blame/master/crawl-ref/source/tag-version.h#L18 23:27:44 it has not been updated in seven years 23:28:34 i think with just some small changes to the dgl scripts it could work the way you describe 23:46:08 are the git tags guaranteed to always follow their current structure? where the version 0.23 is the first item 23:46:57 i want to change the install-trunk script to grab the result from git describe --long HEAD and use that first item as the major version 23:47:55 then i can update my versions db and savegame-transfer will automatically begin limiting transfers to commits that have the same version (like 0.23) 23:50:20 -!- muffindrake1 is now known as muffindrake