00:00:20 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-644-gb60d84b (34)
01:22:38 -!- muffindrake1 is now known as muffindrake
01:37:35 <floraline> i've been informed that 0.18 games on cko are not being tracked in cao scoring. can someone please point me to the person i need to ask to get that added? or the repo where i can make a pull request
01:37:40 <floraline> also, happy new year!
01:48:48 <ebering> floraline: it's already been passed along
01:51:35 <|amethyst> just updated the config and restarted the scoring daemon
01:51:46 <|amethyst> it'll be a few hours before things update
01:53:25 <floraline> oh thank you very much! that was super quick :)
01:53:55 <floraline> it completely slipped my mind that that was an important step when i was installing 0.18
01:54:30 <|amethyst> well, I was first asked on Saturday, so not that quick :)
01:54:37 <|amethyst> I just happened to be here this time :)
01:54:51 <floraline> oh :P
01:54:56 <floraline> well it's the first time i noticed so it still counts
02:06:07 <ebering> %git :/Kung Fu
02:06:07 <Cheibriados> 07ebering02 {NormalPerson7} * 0.22-a0-687-g612cff6: Kung Fu with swordchucks (11402) 10(7 months ago, 1 file, 9+ 4-) 13https://github.com/crawl/crawl/commit/612cff60e4b3
02:06:17 <ebering> something's up with the commit attribution
02:06:25 <ebering> gammafunk: has it locally also, whereas I do not
02:06:33 <gammafunk> yeah we were talking about this; my local repo also has the wrong committer
02:06:38 <gammafunk> but ebering's does not
02:07:00 <gammafunk> oh, you said that, sorry
02:07:58 <gammafunk> a ton of commits just before that one have the same committer
02:08:22 <gammafunk> if I had to guess, it's what you'd see if you looked at the commit history of one of those forks
02:08:47 <gammafunk> where they merged a lot of our commits
02:09:07 <gammafunk> but no idea how that would be influencing the commit history in the crawl repo
02:09:26 <ebering> it can't be that; the sha1s match, and metadata is sha'd
02:11:05 <ebering> I got a fresh clone on a separate machine and get correct commit attributions
02:11:38 <ebering> %git HEAD
02:11:38 <Cheibriados> 07NormalPerson702 {ebering} * 0.23-a0-644-gb60d84b: Improve spell description of memorised uncastable spells (11808) 10(17 hours ago, 1 file, 18+ 16-) 13https://github.com/crawl/crawl/commit/b60d84b635cc
02:12:31 <gammafunk> ebering: actually, when I look at this commit history, it's that of the x-crawl fork
02:13:15 <gammafunk> %git 81da88e7226cb45ca46ba203d7cd78bc4121b7e2
02:13:15 <Cheibriados> 07Vajrapani02 * 0.22-a0-659-g81da88e: X-crawl Dev Philosophy Document 10(5 months ago, 1 file, 36+ 0-) 13https://github.com/crawl/crawl/commit/81da88e7226c
02:13:23 <gammafunk> that's in the git log
02:15:12 <ebering> %git 3327843f9c
02:15:12 <Cheibriados> 07ebering02 {advil} * 0.22-a0-887-g3327843: Kung Fu with swordchucks (11402) 10(7 months ago, 1 file, 9+ 4-) 13https://github.com/crawl/crawl/commit/3327843f9cc9
02:15:27 <ebering> you locally and Chei are (somehow) looking at x-crawl
02:16:23 <gammafunk> nope
02:16:35 <gammafunk> it's just that the ref you pulled up via that search
02:16:37 <gammafunk> is one in their repo
02:17:35 <ebering> yes, but why is a commit in their repo showing up in Chei search?
02:17:51 <ebering> does git clone --mirror fetch forks from github by default?
02:18:11 <gammafunk> not sure how we're seeing those refs, yeah
02:18:32 <gammafunk> if I do git log --grep swordchucks
02:18:32 <gammafunk> I get the right commit
02:18:49 <ebering> ebering@high-fructose-corn-syrup:~/new/crawl$ git show 612cff6 --
02:18:50 <ebering> fatal: bad revision '612cff6'
02:19:26 <gammafunk> it might have to do with pull requests
02:19:32 <gammafunk> I fetch the refs for those
02:19:39 <gammafunk> that might be pulling in refs from forks too
02:19:45 <gammafunk> that would explain things
02:20:18 <gammafunk> fetch = +refs/heads/*:refs/remotes/origin/*
02:20:18 <gammafunk> fetch = +refs/pull/*:refs/remotes/origin/pull/*
02:20:31 <gammafunk> in my git config
02:20:46 <ebering> ah yeah, I don't fetch those by default
02:20:49 <gammafunk> chei does likewise so it can report on pull requests
02:20:54 <gammafunk> so I think that's the answer, phew
02:21:16 <gammafunk> !gitgrep 1 swordchucks
02:21:16 <Sequell> %git HEAD^{/swordchucks}
02:21:16 <Cheibriados> 07ebering02 {advil} * 0.22-a0-887-g3327843: Kung Fu with swordchucks (11402) 10(7 months ago, 1 file, 9+ 4-) 13https://github.com/crawl/crawl/commit/3327843f9cc9
02:21:42 <gammafunk> that version of the search is better since it searches only parents of HEAD
02:21:47 <gammafunk> but it's longer to type
02:21:55 <ebering> yeah
02:25:50 <ebering> oh! I know why that's showing up, we've had some PRs sent to us and not a fork, so the fork commits end up in the tree fetched for that pull request
02:25:53 <ebering> mildly annoying
02:32:03 <gammafunk> right, makes sense
02:32:17 <gammafunk> but I guess the problem is also that form of search
02:32:34 <gammafunk> which searches all branches, and when you add those pull request refs, they're in your branches now
02:32:42 <ebering> yep
02:32:52 <gammafunk> so maybe it's how pull requests are represented as well in terms of a design problem
02:34:22 <gammafunk> best thing about the killer klown pie idea when I implement it
02:34:22 <gammafunk> is we already have a tile for pies
02:34:22 <gammafunk> from the jester implementation
08:07:20 -!- amalloy is now known as amalloy_
12:06:04 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-644-gb60d84b (34)
12:17:06 <advil> hm yeah github keeps around extra branches for closed PRs in the target repo so that even if the submitter deletes them you can get access
12:17:21 <advil> it's probably possible to delete those?
12:17:40 <advil> *even if the submitter deletes their branch
13:18:20 -!- thurin is now known as uprime
13:42:41 <Ozaq> hmm... an anyone help me debug web-tiles? I get stuck on the loading screen after starting a game on my local server. Log shows no errors :/
14:06:03 -!- aidanh_ is now known as aidanh
14:13:39 -!- Tiobot is now known as Guest11618
14:40:11 <Mattias> Ugh, I've not found the spells I want and I've cleared everything I can clear with the ones I have :( Orc L1 is overflown with bad enemies. Vault I probably can't even start on. The Depths... not a chance yet.
14:40:18 <Mattias> Oh wrong channel :/
17:27:38 -!- amalloy_ is now known as amalloy
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-645-g8ec7dd4: Fix a weapon specification function 10(27 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8ec7dd4a3df5
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-646-g4b96247: Update and comment a ghost vault loot function 10(2 hours ago, 1 file, 20+ 14-) 13https://github.com/crawl/crawl/commit/4b962473851d
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-647-g3f50ca7: Remove some ammo quantities from DES monster specs 10(16 hours ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/3f50ca7087f8
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-648-g2b9f6a0: Fix loot generation in a vault 10(16 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/2b9f6a0aa068
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-649-g5ee8fed: Update DES and monster data for a ghost vault 10(16 hours ago, 3 files, 40+ 28-) 13https://github.com/crawl/crawl/commit/5ee8fed46229
19:13:44 <Cheibriados> 03gammafunk02 07* 0.23-a0-650-ga4d50d4: A Trog-themed ghost vault with wrathtful warriors 10(16 hours ago, 1 file, 228+ 0-) 13https://github.com/crawl/crawl/commit/a4d50d4d25f0
19:17:10 <Kelbell> Unstable branch on crawl.kelbi.org updated to: 0.23-a0-650-ga4d50d4d25 (34)
20:22:23 <Cheibriados> FR: add info about God synergy for Race/combos 13https://crawl.develz.org/mantis/view.php?id=11811 by RoGGa
20:27:40 <Cheibriados> Ball Lightning has unusual stair behavior 13https://crawl.develz.org/mantis/view.php?id=11812 by CanOfWorms
20:38:36 <gammafunk> I have a recreatable crash that might be a real pain to fix, so I'm mentioning it here in case someone sees an easy way
20:38:48 <gammafunk> http://dpaste.com/26YN2JR
20:39:33 <gammafunk> You can cause this crash by making e.g. mf javelineer with javelins of penetration (`&m merfolk javelineer ; javelin ego:penetration q:20')
20:39:42 <gammafunk> then cast conjure ball lightning
20:40:05 <gammafunk> move one of the ball lightnings in the path between you and the javelin monster
20:40:12 <gammafunk> use ctrl-, to set the monsters hp to 1
20:40:25 <gammafunk> if it throws its javelin of piercing at you before the ball lightning blows up on its own
20:40:47 <gammafunk> the javelin will pierce it, causing it to explode, killing the throwing monster, but the javeling proceeds to hit you
20:41:00 <gammafunk> when it does hit, crash (all this happens on the same turn)
20:41:39 <gammafunk> this happens because the ranged_attack instance is instantiated only when the javelin hits you at beam.cc:3683
20:41:47 <gammafunk> well two lines below that
20:42:03 <gammafunk> in bolt::affect_player()
20:42:51 <gammafunk> since the throwing monster is dead and reset, when this code tries to get the actor pointer based on the mid stored in the bolt it gets null_ptr
20:43:09 <gammafunk> and tries to instantiate the ranged_attack with that null_ptr as the agent, which hits an ASSERT
20:43:27 <gammafunk> the ranged_attack won't have the data it needs from the (presumably) reset monster
20:43:48 <gammafunk> I'm not really sure how to fix this one
20:44:22 <gammafunk> also not fully sure what other things could trigger it, maybe a similar setup with a non-resistable explosion triggering the cbl to explode on a monster with damnation crossbow
20:46:56 <gammafunk> that actually might not be a problem since the beam of the explosion is the relevant thing there, and that has been set up already
20:47:09 <gammafunk> anyhow, if someone sees an easy way to fix that, let me know
20:47:47 <gammafunk> ah
20:47:51 <gammafunk> canofworms pointed out
20:48:03 <gammafunk> https://crawl.develz.org/mantis/view.php?id=9717
20:48:17 <gammafunk> so |amethyst already noticed this
23:10:49 -!- muffindrake1 is now known as muffindrake
23:59:57 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-650-ga4d50d4 (34)