00:05:01 advil: I know you were skeptical about 922; it's a bit of a hack but I'm warming to it 00:06:15 since keeping the EV displayed for non-actions seems like the best approach for communicating acrobat working to the player 00:06:32 and player_reacts() which decrements durations is called before monster handling in the turn loop 01:27:46 Unstable branch on crawl.develz.org updated to: 0.23-a0-625-g1d2cd9b (34) 01:58:29 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-625-g1d2cd9b 02:10:21 Incorrect flight expiry warning when Dragon Form is about to expire with Boots of Flying activated 13https://crawl.develz.org/mantis/view.php?id=11800 by CyrusL 02:59:23 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-625-g1d2cd9b 03:31:12 Experimental (bcrawl) branch on crawl.kelbi.org updated to: 0.23-a0-1216-gdf326a844d 05:24:49 -!- amalloy is now known as amalloy_ 07:53:34 Trying to cast drain life in wizmode crashes the game 13https://crawl.develz.org/mantis/view.php?id=11801 by NormalPerson7 10:04:06 New branch created: pull/925 (1 commit) 13https://github.com/crawl/crawl/pull/925 10:04:06 03NormalPerson702 {GitHub} 07https://github.com/crawl/crawl/pull/925 * 0.23-a0-555-g6007641: Fix a typo 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6007641b2add 11:18:09 New branch created: pull/926 (1 commit) 13https://github.com/crawl/crawl/pull/926 11:18:09 03NormalPerson702 07https://github.com/crawl/crawl/pull/926 * 0.23-a0-620-ga02578a: Fix surge of power message order when evoking enhanced wands (11753) 10(12 minutes ago, 3 files, 16+ 8-) 13https://github.com/crawl/crawl/commit/a02578ad37d7 11:22:27 03NormalPerson702 {ebering} 07* 0.23-a0-626-g6760373: Fix a typo 10(83 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6760373aa6f2 11:24:39 03gammafunk02 07* 0.23-a0-627-gf6ffe88: Fix a typo in the INSTALL instructions (enop) 10(57 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f6ffe88bf0b4 11:32:02 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-627-gf6ffe88bf0 (34) 11:35:22 03NormalPerson702 07https://github.com/crawl/crawl/pull/926 * 0.23-a0-621-gd07b88c: Improve wand_mp_cost 10(4 minutes ago, 2 files, 7+ 4-) 13https://github.com/crawl/crawl/commit/d07b88c93c9e 12:05:31 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-627-gf6ffe88 (34) 13:33:27 03NormalPerson702 {ebering} 07* 0.23-a0-628-g7e7a9de: Fix surge of power message order when evoking enhanced wands (11753) 10(2 hours ago, 3 files, 22+ 9-) 13https://github.com/crawl/crawl/commit/7e7a9de784ed 13:57:30 So, were there ever an ansible/docker crawl server finished? I saw I last touched the ansible script 3 years ago. Did things change in the installation procedure that might be needing an update? 13:58:48 No one used that project afaik 13:59:07 The thing is that we have an existing setup procedure and existing servers 13:59:33 new servers come online rarely; one came online just in last couple months, but the admin had already figured out their configuration 14:00:18 so you'd really have to convince and admin to move their setup over to ansible/docker and work with them to the extent necessary to successfully migrate 14:01:12 It's more for getting a server up and running quickly. So I guess there's no need to update so it'll work on the latest version of ansible 14:01:36 yeah 14:06:03 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-628-g7e7a9de784 (34) 14:06:17 gammafunk, I see an update was made during summer here: https://crawl.develz.org/wiki/doku.php?id=dcss:server:setting_up_dgamelaunch_and_webtiles is there a way to see exact lines changed? 14:16:32 -!- ProzacElf_ is now known as ProzacElf 14:18:05 -!- aidanh_ is now known as aidanh 14:23:27 Mattias: yep, from here https://crawl.develz.org/wiki/doku.php?do=revisions&id=dcss%3Aserver%3Asetting_up_dgamelaunch_and_webtiles 14:23:38 next to each change click the little 3-d glasses icon 14:23:43 it shows a div relative to the last version 14:24:26 so you'd have to start from the oldest change, look at the diff, then proceed from each subsequent one 14:31:32 Thanks! 14:33:33 s/div/diff/ 15:10:26 -!- glaas` is now known as glaas 15:13:36 03gammafunk02 07* 0.23-a0-629-gae4348f: Fix a typo in the gauntlet portal message (vt) 10(39 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ae4348f6cf45 15:17:00 Unstable branch on crawl.kelbi.org updated to: 0.23-a0-629-gae4348f6cf (34) 15:18:50 Recent minimap colour options undocumented 13https://crawl.develz.org/mantis/view.php?id=11802 by Tamsk 16:21:13 Is there any possible point to a function that is declared and never defined or used? I assume this is cruft and can be deleted? (crawl did compile successfully when I tried) It is one case of an overloaded function, but I don't think that should make any difference. 16:26:49 glaas: generally no, we'd remove that function (signature) if it's truly unused 16:27:23 possibly there was some code that was recently removed that was the last caller 16:27:31 ok. i'm fiddling with this file anyway so i'll submit a request 16:27:32 so you might to a git log to find the last instance 16:27:47 New branch created: pull/927 (2 commits) 13https://github.com/crawl/crawl/pull/927 16:27:47 03NormalPerson702 07https://github.com/crawl/crawl/pull/927 * 0.23-a0-629-geb781ee: Convert spret_type to an enum class 10(11 minutes ago, 22 files, 456+ 453-) 13https://github.com/crawl/crawl/commit/eb781ee215ce 16:27:47 03NormalPerson702 07https://github.com/crawl/crawl/pull/927 * 0.23-a0-630-g2553788: Change spret_type to spell_retval 10(10 minutes ago, 34 files, 652+ 652-) 13https://github.com/crawl/crawl/commit/2553788a999d 16:27:49 yeah that's what I figured 16:27:54 oh good idea, I'll try 17:04:48 03NormalPerson702 07https://github.com/crawl/crawl/pull/927 * 0.23-a0-631-gebd06f2: Wrap some lines 10(3 minutes ago, 9 files, 46+ 31-) 13https://github.com/crawl/crawl/commit/ebd06f2d33c6 17:38:36 other possibilities, depending on how you are determining it's unused: it's used only for some build targets, it's used by generated code (so the caller isn't visible in git grep) 17:39:00 that last one always gets me 18:15:41 advil: I used git grep. Is there some way I can tell if generated code calls it? 18:16:36 I'm looking at commit 27b4f7b9727d2a2a39f488ca2e4da9d0034a8a6a - surely while purple chunks are gone, Zot traps can still malmutate? 18:19:47 glaas: you can run non-git grep (i.e. normal grep) recursively 18:19:51 looking for the function call 18:20:05 I think util and rltiles might be the only dirs with relevant generated code 18:20:24 generated files wouldn't be checked into the repo, so just a normal grep would do 18:21:22 Pinkbeast: yeah, seems it was a bit of overzealous editing there 18:21:44 I'll look forward to a fixing commit not to cherry-pick either :-) 18:21:56 glaas: oh, and you'd have to do this after having built crawl so that said generated code is created 18:22:18 Unstable branch on underhound.eu updated to: 0.23-a0-629-gae4348f6cf (34) 18:22:37 I guess usually you'd find a match of your function in whatever code template generates the code 18:23:06 so in that case git grep would see it, but maybe some generated code is a bit tricky in how it assembles C++ code 18:40:55 gammafunk: thanks. grep doesn't see any use of the function with those arg types either. Will I have all the generated code present in the folder if I've built both console and tiles versions, or are there any other options I might have to try compiling with? 18:42:07 glaas: I think that would cover it; if there are other problems, travis will discover them 18:42:22 OK, sounds good. Thanks for the help. 18:42:26 I'd say the most important build to try is webtiles just because live servers use that, and we'd not want to break it 18:42:41 but yeah, travis will try a large number of builds and it does so for branches in PRs, too 18:44:50 Ok, I'll try webtiles locally too before I pr then. 18:57:35 glaas: I don't want you to think that you have to try every kind of build before submitting a PR; I would say that testing the webtiles build is probably best, since that's the one that we use online 18:57:56 if compilation is fast for you, you can also try tiles; definitely don't need to try more than those two 18:58:11 most of us devs just compile with e.g. webtiles and then let travis check the rest :) 18:58:23 Sure, I won't go crazy with it. 19:05:56 -!- amalloy_ is now known as amalloy 19:06:34 i don't think compilation is fast for anyone 19:07:36 switch__: a fresh compile takes a minute for me 19:07:46 wait really 19:08:00 different people have different computers?!?! 19:08:05 i have a good computer 19:08:11 multithreaded make on a linux system helps 19:08:13 it takes me 5 minutes 19:08:20 sounds like my settings are off 19:09:57 i use `nice make -sj16 debug-lite` 19:16:38 just timed it again for you, with 2 6-core CPUs according to /proc/cpuinfo, after make clean, and without ccache active. 1:12 of realtime, 11:52 of CPU time 19:21:52 thank you 23:35:55 while Starving, Berserk 1 mutation kicks in 13https://crawl.develz.org/mantis/view.php?id=11803 by RoGGa