00:09:01 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-416-g33f1def (34) 01:27:48 Unstable branch on crawl.develz.org updated to: 0.23-a0-416-g33f1def (34) 01:59:00 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-416-g33f1def 02:09:16 -!- ProzacElf_ is now known as ProzacElf 02:59:16 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-416-g33f1def 05:36:48 -!- amalloy is now known as amalloy_ 08:20:18 <|amethys1> advil: hm, that looks like the crash was in fgets, which sounds like maybe fopen_u failed 08:20:42 oh hm 08:21:17 yeah I missed the fgets there 08:21:49 <|amethys1> alexjurkiewicz: re that crash, are any of the manual files missing for that version: crawl_manual.txt aptitudes.txt quickstart.txt macros_guide.txt options_guide.txt ? 08:22:12 <|amethys1> alexjurkiewicz: or unreadable 08:26:11 they all load on current cpo trunk 08:26:49 that code probably shouldn't assum fp is safe though 08:32:09 or probably even that datafile_path is going to work, though I'm not going to debug that one now 08:32:54 <|amethys1> hm, I don't know how the CPO update process works, is it possible that trunk was in the process of being updated and this happened just when one of the files being upgraded was missing? 08:33:01 sounds plausible to me 08:33:40 I'm going to stick an assert in there, though possibly this one could also be handled without a crash 08:45:08 03advil02 07* 0.23-a0-417-gf02c810: Validate file pointer when loading help parts 10(3 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/f02c81043874 08:45:29 my repo is in that state where I've been stashing and stash popping random things without quite finishing them for a couple weeks now 08:45:40 I don't even remember doing some of this stuff 08:47:39 also, after testing, the player's description of the crash makes a bit more sense to me now in that all of those files are opened in order to construct the ? popup immediately, so the crash wouldn't have been on # per se, it happens right when you open ? 09:10:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-417-gf02c810438 (34) 12:05:43 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-417-gf02c810 (34) 14:29:48 -!- amalloy_ is now known as amalloy 15:04:11 greensna1k: 15:04:19 oops, sorry for the ping 17:08:17 yes he can 17:09:01 sorry wrong window 18:21:50 Unstable branch on underhound.eu updated to: 0.23-a0-417-gf02c810438 (34) 21:10:21 |amethys1: the files aren't overwritten for trunk, but yes it is possible 21:11:40 i think they mentioned after they restarted the game it upgraded their save. or maybe immediately before. Either way every trunk build is into its own directory, so not sure if it was literal overwrite, or just something similar happening around an update 22:05:33 -!- capablanca is now known as mikee_ 22:31:45 Inventory does not appear 13https://crawl.develz.org/mantis/view.php?id=11755 by CaptainKyles