00:03:43 03gammafunk02 07* 0.23-a0-379-g1903759: Properly apply god ally conducts for LOS damage spells 10(10 hours ago, 1 file, 14+ 3-) 13https://github.com/crawl/crawl/commit/190375989256 00:03:43 03gammafunk02 07* 0.23-a0-380-g7ed3b4c: Apply god ally conducts for Static Discharge, Irradiate, and Shatter 10(10 hours ago, 1 file, 18+ 12-) 13https://github.com/crawl/crawl/commit/7ed3b4cd4930 00:03:43 03gammafunk02 07* 0.23-a0-381-g8079fb2: Refactor melee attack prompts for some unrands 10(10 hours ago, 1 file, 16+ 14-) 13https://github.com/crawl/crawl/commit/8079fb2f1ca3 00:03:43 03gammafunk02 07* 0.23-a0-382-gdc5cae9: Remove an unnecessary scope block 10(10 hours ago, 1 file, 3+ 5-) 13https://github.com/crawl/crawl/commit/dc5cae9113cd 00:03:43 03gammafunk02 07* 0.23-a0-383-g752426d: Fixes, refactoring, and message cleanups for static discharge 10(9 hours ago, 5 files, 43+ 74-) 13https://github.com/crawl/crawl/commit/752426dcc1fe 00:03:43 03gammafunk02 07* 0.23-a0-384-g3a68796: Rework the Arc Blade (minmay) 10(9 hours ago, 6 files, 32+ 23-) 13https://github.com/crawl/crawl/commit/3a6879684958 00:09:49 sweet 00:12:12 There are more problems with static discharge, the attack prompt is pretty bad 00:12:32 warns you individually for each ally you would hit :( 00:12:52 so you have to answer y or Y each time if you want to attack anyways 00:13:07 which is fixable, but I might leave this until I move it over to the chain code 00:15:15 oof 00:16:09 it's fairly easy to fix that warning without moving it over to said chain spell code, so I might do that later 00:16:15 but that's enough fiddling with that stuff for now 00:34:06 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-378-gd7a6ca6 (34) 01:07:26 -!- isha is now known as werekitten 01:10:47 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-384-g3a68796849 (34) 01:28:32 Unstable branch on crawl.develz.org updated to: 0.23-a0-384-g3a68796 (34) 01:51:24 -!- neunon_ is now known as neunon 01:58:40 Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-384-g3a68796 02:59:52 Monster database of master branch on crawl.develz.org updated to: 0.23-a0-384-g3a68796 03:23:36 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-384-g3a68796 (34) 10:10:29 -!- neunon_ is now known as neunon 11:17:41 Mixedsea (L13 DsMo) ERROR in 'mon-util.cc' at line 664: bogus mc (no monster data): invalid monster_type 1000 (1000) (IceCv) 13:30:18 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-384-g3a68796 (34) 13:46:19 Minor bug I think. I have Qaz RMissiles, but the scarf isn't coloured as useless in the inventory. 13:47:10 Tiktacy (L19 HuMo) ASSERT(constricting->find(whom.mid) == constricting->end()) in 'actor.cc' at line 686 failed. (Swamp:4) 13:49:05 !crash tiktacy 13:49:07 1. Tiktacy, XL19 HuMo, T:55053 (milestone): http://crawl.berotato.org/crawl/morgue/Tiktacy/crash-Tiktacy-20181027-174701.txt 13:51:47 have to take a closer look at that later 13:51:50 grasping roots crash 14:25:14 03ebering02 07* 0.23-a0-385-gb2d5814: Update ploomutoo in CREDITS.txt 10(28 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b2d581486a90 15:04:58 -!- aidanh_ is now known as aidanh 15:10:41 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-385-gb2d581486a (34) 15:48:31 -!- babuloseo is now known as babuloseo_afk 16:00:55 -!- capablanca is now known as mikee_ 16:42:24 i'm running into a weird issue 16:42:34 the debug build doesn't work unless i build release first 16:42:56 i'm pretty sure i'm not re-using any files... 18:02:11 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-386-g5fa266a: MSVC2017 Compatability and relocation of project files 10(3 minutes ago, 49 files, 5055+ 466-) 13https://github.com/crawl/crawl/commit/5fa266aa2021 18:02:13 -!- babuloseo_afk is now known as babuloseo 18:03:33 ^ pull-able 18:04:10 tested it on individual sets of fresh pulls, builds win32/release, win32/debug, x64/release, x64/debug 18:09:17 is release a specific target? 18:09:32 or does that just mean no make target 18:10:00 the equivalent would be no make target 18:10:04 I see 18:10:05 but inside msvc it's a specific target 18:10:20 i guess because it's less ambiguous than having nothing there 18:10:43 all of my work was based on the project files that were originally included 18:13:02 oh boy, there are tabs in that zlib props file again 18:13:15 that entire 45 line file is literally a single variable and could be 3 lines .___. 18:13:40 but libpng wrote it, not me 18:18:06 gonna see if there are any optimizations i can use 18:18:12 build time is about 5 minutes from start to finish 18:20:52 (fixed the tabs in zlib.props) 18:22:30 Unstable branch on underhound.eu updated to: 0.23-a0-385-gb2d581486a (34) 18:23:19 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-386-g4df7b70: MSVC2017 Compatability and relocation of project files 10(24 minutes ago, 49 files, 5055+ 466-) 13https://github.com/crawl/crawl/commit/4df7b70b29dc 18:38:40 Mixedsea (L16 DsMo) ERROR in 'mon-util.cc' at line 664: bogus mc (no monster data): invalid monster_type 1000 (1000) (Snake:4) 18:39:10 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-386-g3283d84: MSVC2017 Compatability and relocation of project files 10(40 minutes ago, 49 files, 5060+ 466-) 13https://github.com/crawl/crawl/commit/3283d84d740f 18:47:59 https://i.imgur.com/OtwNIxC.png https://i.imgur.com/Vh3MYBX.png 18:48:13 this doesn't happen if you build release, then re-build everything debug 19:07:43 flyingllamaman (L20 GrFi) ERROR in 'mon-util.cc' at line 1568: bogus mc (no monster data): invalid monster_type 1000 (1000) (Depths:3) 19:08:35 !crashlog 19:08:51 20355. flyingllamaman, XL20 GrFi, T:38230 (milestone): http://crawl.berotato.org/crawl/morgue/flyingllamaman/crash-flyingllamaman-20181027-230734.txt 19:14:56 damn, whoever wrote this didn't write anything for non-tiles 19:15:07 i have to make it from scratch D: 20:12:25 -!- capablanca is now known as mikee_ 20:27:04 whew 20:27:08 console works 20:40:48 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-387-g961787b: Console support 10(2 minutes ago, 8 files, 330+ 64-) 13https://github.com/crawl/crawl/commit/961787b21bce 20:55:30 wait 20:55:55 ebering, you reverted the location of _remove_equipment 20:57:40 that should re-introduce the bug that necessitated this https://github.com/crawl/crawl/commit/305c090e76ea74b79c4db93514c580a99d33c0d5 20:57:56 my code handled the location safely 20:58:44 oh, you removed my checks 20:58:57 yeah, those transformation checks were important 21:03:01 sorry, i should have noticed this earlier. i didn't realize you modified the code before pushing the PR 21:06:18 yes, i can repro that bug in trunk 21:07:49 incidentally, i learned a funny fact: if you manage to worship zin as a vampire, he doesn't get upset that you go batform, unlike any other transformation 21:08:22 he accepts all of his quirky worshipers for who they are 21:08:23 i feel that 21:09:48 hm, if i revert this PR i will have committed the bug once and uncommitted it twice. that's like fixing a bug, right? 21:10:02 i'd say so 21:11:20 what bug? 21:11:28 i linked it 21:11:42 oh hm 21:12:34 so I don't like the solution that you have, because it creates a weird order dependency in calc_hp 21:12:44 in that calc_hp gets called twice during a transformation, once when equipment is removed and once when form hp is recalculated 21:12:44 how so? 21:12:52 if the equipment is hp modifying 21:13:17 it's handled correctly, is it not? 21:15:23 e.g. you have 75/115 hp, wearing a +15 chestpiece. You transform to dragon form (+50% hp flavor text). During transformation, your chestpiece is melded. Your HP changes to 75/100. Your HP is then modified by 50%, changing to 112/150 21:17:12 switch__: yes, that is handled correctly. in get_real_hp in your version you have 'trans && you.props...' to check that the player is really transformed 21:17:19 correct 21:17:51 which, I agree with you, is pretty ugly 21:18:06 this is a logically correct solution, but get_real_hp gets called (in the call path) of _remove_equipment, and so the effect of _remove_equipment (with your version of the check) will depend on where it's called during a transformation 21:18:08 but the way transform is written there's no other easy way to check it, other than introducing a variable, which is uglier 21:19:29 i don't understand what you mean 21:19:33 it's always called in the same spot, is it not? 21:24:24 for now. the point that I'm making is that doing it that way is a spaghetti solution 21:25:03 i don't see how that's the case 21:26:38 to someone who isn't deeply acquainted with every corner of the codebase it will be very strange to them why you're checking the prop and not you.form != none, or why the function form_hp_mod() doesn't just work correctly there 21:29:06 amalloy: the batform thing is independent from the HP thing 21:29:16 it's an issue with _remove_equipment and not the hp calculations 21:29:33 it's an issue with the placement of _remove_equipment before setting form 21:34:56 anyway, the check being based on the prop is due to the way transform is written. if you think transform needs to be rewritten, to make it easier and simpler to check whether or not someone is fully transformed, i completely agree with you 21:35:38 but that wasn't the point of the PR. the PR was meant to fix a bug and rewrite HP 21:36:49 switch__: welcome to crawlcode :) 21:37:02 transform has been worked over a few times before 21:37:28 having _remove_equipment take a "which form" parameter and not make assumptions about the state of you.form is appropriate for a function private to transform 21:42:26 i honestly don't see the problem 21:46:26 03ebering02 07* 0.23-a0-386-g9c9d49f: Prevent unwielding by transforming 10(7 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/9c9d49f62369 21:47:18 the problem is calling functions that expect the player to be in a fixed transform (and condition on that transform) from the function that changes the transform 21:51:24 gotcha 21:51:25 nice work 21:51:34 :D 21:55:39 that doesn't fix the hp bug, though 21:55:53 wait 21:56:02 it does, nevermind 22:10:46 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-386-g9c9d49f623 (34) 23:42:53 New branch created: pull/880 (10 commits) 13https://github.com/crawl/crawl/pull/880 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-387-gd5772b4: An arrival vault (Beargit, 11400) 10(23 hours ago, 1 file, 20+ 0-) 13https://github.com/crawl/crawl/commit/d5772b4db03e 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-388-gbc26032: New arrival vaults (WanderingBlade, 11132) 10(23 hours ago, 3 files, 166+ 0-) 13https://github.com/crawl/crawl/commit/bc2603225d9c 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-389-g1df7947c: A decorative Xom vault for Snake (Skrybe, 11133) 10(23 hours ago, 1 file, 15+ 0-) 13https://github.com/crawl/crawl/commit/1df7947cee66 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-390-g764062c: Multi-coloured glass columns for Zot (Skrybe, 11232) 10(22 hours ago, 1 file, 96+ 0-) 13https://github.com/crawl/crawl/commit/764062c911f0 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-391-g5775ad6: Branch entry vaults (skrybe, 11232) 10(8 hours ago, 2 files, 52+ 0-) 13https://github.com/crawl/crawl/commit/5775ad670edc 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-392-g8d6e7e1: KennySheep inspired adjustments to a sewer (10035) 10(8 hours ago, 1 file, 48+ 42-) 13https://github.com/crawl/crawl/commit/8d6e7e10d4b9 23:42:53 03palyth02 {ebering} 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-393-g44d37d2: A winding forest swamp entry vault (11061) 10(1 year, 4 months ago, 1 file, 31+ 0-) 13https://github.com/crawl/crawl/commit/44d37d2dc20d 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-394-gb882742: A shower themed Vaults entry (ximxim, 10658) 10(6 hours ago, 1 file, 21+ 0-) 13https://github.com/crawl/crawl/commit/b882742a2f77 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-395-gd745df8: Some variable vaults (WanderingBlade, 11140) 10(16 minutes ago, 2 files, 124+ 0-) 13https://github.com/crawl/crawl/commit/d745df859905 23:42:53 03ebering02 07https://github.com/crawl/crawl/pull/880 * 0.23-a0-396-g83076e8: Update CREDITS 10(8 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/83076e8fdc26 23:46:12 %git 23:46:12 07ebering02 * 0.23-a0-386-g9c9d49f: Prevent unwielding by transforming 10(2 hours ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/9c9d49f62369