00:00:08 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-375-g66a18ee (34)
00:03:50 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-g9810350: Berserk 10(4 minutes ago, 2 files, 10+ 9-) 13https://github.com/crawl/crawl/commit/981035093cc5
00:09:07 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-ge7d8fe6: Berserk 10(9 minutes ago, 3 files, 13+ 9-) 13https://github.com/crawl/crawl/commit/e7d8fe659403
00:10:01 <switch__> thanks gamma :D
00:24:03 <ebering> !csdclive
00:24:11 <Sequell> 2 minutes, 52 seconds ago on [cao](http://crawl.akrasiac.org:8080/#watch-WJ69): WJ69 the DgSk^ killed Urug.
00:24:11 <ebering> oops sorry
00:25:18 <alexjurkiewicz> it looks like your indentation setup is a bit off switch__, seems like you might be using 8 spaces rather than 4?
00:25:54 <alexjurkiewicz> oh, you are using hard tabs
00:27:42 <switch__> hellllll yeah
00:27:55 <switch__> and i'm loving going back and removing them
00:28:54 <ebering> switch__: util/checkwhite in the source directory will fix up your whitespace to crawl conventions
00:32:43 <switch__> sweet
00:32:45 <switch__> thanks
00:35:33 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-gfc1e15e: Berserk 10(36 minutes ago, 3 files, 13+ 12-) 13https://github.com/crawl/crawl/commit/fc1e15e4ffb3
01:02:18 <alexjurkiewicz> how can I (in C++ code) perform a delay action (taking off armour) and then do more things after it finishes? It seems when I start a delay action control returns immediately to the code
01:04:16 <geekosaur> it has to, because other things can happen during including monsters taking a whack at you
01:05:26 <switch__> (spoiler: lots of things happen in the meantime)
01:07:19 <alexjurkiewicz> sure, but there are actions which are two delays, like replacing your body armour, so there is some way to run a delay in code and "wait for it to return"
01:11:45 <switch__> looking at the code for swapping body armour, i don't think so
01:12:37 <switch__> which line are you talking about in the body armour swap code?
01:14:17 <switch__> better question, what are you trying to do?
01:15:10 <alexjurkiewicz> I want to unequip the player's armour, modify it, then return
01:21:23 <Gretell> Unstable branch on crawl.develz.org updated to: 0.23-a0-375-g66a18ee (34)
01:33:41 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-ge99dea8: Berserk 10(2 hours ago, 6 files, 18+ 17-) 13https://github.com/crawl/crawl/commit/e99dea8be0cb
01:38:59 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-g5ca03a4: Berserk 10(2 hours ago, 6 files, 19+ 18-) 13https://github.com/crawl/crawl/commit/5ca03a41439b
01:44:16 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-gdd39fc3: MSVC 2017 Compatability 10(4 hours ago, 32 files, 2587+ 795-) 13https://github.com/crawl/crawl/commit/dd39fc367f63
01:49:34 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-g9dd6b70: MSVC 2017 Compatability 10(4 hours ago, 32 files, 2574+ 779-) 13https://github.com/crawl/crawl/commit/9dd6b7066832
01:55:53 -!- masterinire is now known as inire
01:58:59 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.23-a0-375-g66a18ee
02:59:23 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.23-a0-375-g66a18ee
03:11:53 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.23-a0-375-g66a18ee (34)
03:26:38 -!- amalloy is now known as amalloy_
05:54:54 <Stairdancer_> Urgh, my internet dropped as I was in the middle of typing a message. Sorry if something accidentally gets sent twice
05:55:11 <Stairdancer_> Anyways, I wanted to report a couple of things from my last playthrough
05:55:23 <Stairdancer_> Sorry if those were brought up already
05:56:06 <Stairdancer_> I happened to get my hands on the new Singing Sword and using it with any sort of allies is pure pain, since you get prompted for every swing
05:56:37 <Stairdancer_> Not only that, but I also just got promted for a riposte attack and was able to manually cancel it
05:58:26 <Stairdancer_> The latter certainly doesn't seem like the intended behaviour for me
06:00:39 <Stairdancer_> Also, the enchantment value of a weapon still isn't visible if the weapon belongs to a summoned demon
09:19:01 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-378-g154c6ee: Berserk 10(9 hours ago, 6 files, 32+ 31-) 13https://github.com/crawl/crawl/commit/154c6ee68c6d
09:30:34 <switch__> look at me, fixed all my whitespace
09:30:44 <switch__> wow, good job
09:34:54 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-g8b36907: MSVC 2017 Compatability 10(12 hours ago, 32 files, 2573+ 778-) 13https://github.com/crawl/crawl/commit/8b369072ad6a
09:54:59 -!- ebering_ is now known as ebering
12:00:55 -!- Tiobot is now known as Guest51497
12:26:56 <switch__> *whistles*
12:27:29 <switch__> when do you think the hitpoints PR will be merged?
13:05:50 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-375-g66a18ee (34)
13:47:17 -!- amalloy_ is now known as amalloy
13:59:21 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-379-g949ea3b: Death's Door 10(3 minutes ago, 8 files, 26+ 33-) 13https://github.com/crawl/crawl/commit/949ea3bb5c29
14:09:55 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-379-g71fba1e: Death's Door 10(13 minutes ago, 8 files, 28+ 36-) 13https://github.com/crawl/crawl/commit/71fba1ee18d6
14:15:12 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-379-gc165bcf: Death's Door 10(19 minutes ago, 8 files, 28+ 36-) 13https://github.com/crawl/crawl/commit/c165bcf3d427
15:23:01 <espais> here is perhaps a softball/easy build question, specific for webtiles
15:23:32 <espais> on ubuntu 18 lua's default package in aptitude is 5.2, and my webtiles.log is showing a missing liblua5.1
15:24:22 <espais> anybody know the best way to resolve this?  i guess, should i compile liblua5.1 from source?
15:24:45 <espais> i'm guessing each nightly git build is going to point at 5.1 specifically, unless if i'm missing a >= 5.1...
15:26:36 <geekosaur> 5.2 and up are missing some hooks used to prevent malicious lua from running servers out fo memory, iirc
15:27:16 <geekosaur> ths probably matters less to you, but you'd have to remove the relevant calls from the crawl surce
15:27:52 <espais> so then for me, just install lua5.1 i guess
15:32:05 <geekosaur> yes
15:33:29 <geekosaur> liblua5.1-0-dev on my mint system; but ubuntu 18 may have renamed it
15:36:33 <espais> odd, i have it too, perhaps i forgot the -dev
15:36:34 <espais> dammit
15:36:40 <espais> oh well, there's something else going on
15:37:16 <espais> ohh
15:37:17 <espais> so
15:37:23 <espais> my chroot can't find it in aptitude
15:37:28 <espais> but the normal system can
15:38:58 <|amethys1> maybe you have a difference in the sources.list or the ubuntu version?  In 17.10 and up (at least) it's in universe
15:39:11 <espais> i was *just* checking that, and yep, there is a difference
15:39:28 <|amethys1> hm
15:39:51 <espais> yea
15:39:51 <|amethys1> but in the chroot you shouldn't need the -dev package, just liblua5.1-0
15:39:53 <espais> that couldn't even be found
15:40:16 <espais> the only repo in the chroot was archive.ubuntu.com/ubuntu bionic main
15:40:45 <|amethys1> ah, yeah, that would do it, since it's been moved out of main because it's old
15:40:49 <espais> yea
15:40:56 <espais> update/upgrade running now, will let you know if it works out
15:41:09 <|amethys1> Feel free to add a note on the server install guide
15:41:12 <espais> i had to nuke my server after upgrading to 18, i was dinking around with too much and just destroyed the folder structure
15:41:13 <|amethys1> ?/setting_up
15:41:14 <Sequell> Matching entries (1): dgl[2]: https://crawl.develz.org/wiki/doku.php?id=dcss:server:setting_up_dgamelaunch_and_webtiles
15:49:59 <switch__> amalloy, what exactly did you mean in your comment on  "you.hp_max_adj_temp = max(-(get_real_hp(false, false, false) - 1)" ?
15:50:26 <amalloy> switch__: -(x - y)  is just a weird way of writing (y - x)
15:50:29 <switch__> not in this case
15:50:36 <switch__> it's not a percent, it's actually a negative number
15:51:36 <amalloy> i don't follow. it is true by algebra
15:53:01 <switch__> oh, nevermind
15:53:32 <switch__> what i meant to convey is that the output is always negative
15:53:37 <switch__> so by doing it that way you make the negative implicit
15:54:51 <amalloy> what's always negative? get_real_hp(false, false, false) - 1?
15:55:13 <switch__> no, that result is always positive, but hp_max_adj_temp is meant to be a negative value
15:55:23 <switch__> that's why there's a negative before (get_real_hp()-1)
15:58:47 <geekosaur> it still simplifies to 1-get_real_hp()
15:59:03 <|amethys1> I agree with switch__ here that it is clearer will the - on the outside
15:59:06 <geekosaur> granting that it doesn't read qite as easily for people
15:59:07 -!- |amethys1 is now known as |amethyst
15:59:15 <amalloy> yes, looking over what it's supposed to mean i agree the current way is better
15:59:20 <|amethyst> s/will/with/
16:00:06 <switch__> regarding the booleans that are checked in get_real_hp(), the death's door check can use either trans or equip, it sort of doesn't matter
16:00:11 <switch__> but why would equip make more sense than trans?
16:02:31 <switch__> regarding the positioning, you're totally right, and i fixed it, but the reason it was wrong in the first place is that
16:02:32 <switch__> #if TAG_MAJOR_VERSION == 34 tag on the torment sceptor. is that necessary?
16:03:46 <ebering> switch__: yes, that is a part of our save compatibility system
16:04:07 <switch__> gotcha
16:04:17 <switch__> last thing is the name validate_hp(), i guess
16:04:23 <switch__> i can change it to recalc() if you want
16:04:25 <espais> yay, it worked
16:04:33 <switch__> it's just meant to be an all-encompassing function, and serves as that
16:04:48 <switch__> doesn't really matter to me
16:05:00 <amalloy> ebering: it is part of save compat but i don't totally see what the purpose of it is in this instance. are we removing |torment in 35?
16:05:36 <amalloy> %git dd419b1c084
16:05:36 <Cheibriados> 07MarvinPA02 * 0.17-a0-1567-gdd419b1: Remove some Eternal Torment handling on major version bump 10(3 years, 3 months ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/dd419b1c084d
16:06:18 <ebering> crown of eternal torment is different from scepter of torment
16:06:18 <amalloy> oh
16:06:27 <amalloy> okay, so the crown is gone, right?
16:06:41 <ebering> in new games yes
16:06:45 <amalloy> right
16:06:45 <amalloy> then yes, this #ifdef is necessary
16:06:55 <espais> side question, to update the wiki do i make a bug report in mantis?
16:07:27 <ebering> espais: which wiki
16:07:48 <|amethyst> espais:  if you have a mantis account, you should be able to log to the wiki in using that and edit the page directly
16:07:52 <ebering> switch__: I would prefer that you call the function calc_hp for consistency with calc_mp, since that function does hp updates
16:08:01 <ebering> |amethyst: not the chaosforge wiki
16:08:04 <ebering> nor the github wik
16:08:05 <espais> ok, thanks.  i do have a mantis acct
16:09:41 <switch__> so, the added parameter to get_real_hp() isn't actually used in this rework
16:09:56 <switch__> it was originally meant to be a special case to fix the transformation unequip bug
16:10:04 <switch__> but it doesn't actually serve a purpose in this commit
16:10:20 <switch__> i left it in because i figured it was functionality that could be used and wasn't obviously in the way
16:11:36 <gammafun1> we tend to remove arguments that are outright unused since it just makes reading stuff more confusing
16:12:00 <gammafun1> i lost my k
16:12:03 -!- gammafun1 is now known as gammafunk
16:12:38 <switch__> should i remove it?
16:12:46 <switch__> i'll just take that as a yes
16:12:55 <gammafunk> that would be my recommendation but n.b. I haven't read the actual code
16:13:06 <gammafunk> maybe someone who has will have a different opinion
16:13:39 <gammafunk> but yeah, we typically just removed unused code unless it's clear that it's going to get used soon
16:17:24 <espais> ok, i updated the wiki.  also added in some info to update/upgrade aptitude when entering chroot since that wasn't there before
16:24:17 <espais> thanks all
16:27:24 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/877 * 0.23-a0-379-g737e7e4: Death's Door 10(3 hours ago, 22 files, 68+ 78-) 13https://github.com/crawl/crawl/commit/737e7e44913a
16:27:57 <switch__> amalloy: that should cover everything you brought up
16:31:41 <amalloy> switch__: suggestion: while a PR is being reviewed, try not to rebase over comments that were made, instead creating a new commit so it's easy to compare your current version to the version that was commented on. once review is done and it's ready to merge, those excess commits can be rolled up
16:31:47 <switch__> credit to np7, as he mentioned in his own PR. we did talk about this together while working through how we wanted it to look
16:32:00 <switch__> noted, will do
16:32:11 <switch__> sorry about that
16:32:23 <amalloy> no worries
16:38:05 <switch__> the number of files changed went from 22 to 12 because 10 of those files already referenced "calc_hp()"
16:41:03 <switch__> can someone take a look at https://github.com/crawl/crawl/pull/878/files#diff-d45d77d0d4ce3f9045aae33abe2d061b please? i don't know what this thing does and can't debug it so i don't really want to try to fix it myself
16:41:27 <switch__> would like to get the msvc changes merged asap so i can pull properly
16:41:42 <switch__> especially since there shouldn't be much to consider there other than that file
16:42:36 <amalloy> the problem is that MSVC doesn't support variable-size stack allocations like that?
16:42:53 <switch__> right, VLAs aren't supported no matter what
16:43:18 <switch__> i just can't rewrite it because it never hits my debugger for some reason and i have no idea what this even does
16:43:41 <amalloy> switch__: could just replace it with a tightly-scoped new array
16:43:49 <switch__> i mean, i know it generates the png files, but does the size of that array even change from whatever set value it hits every time?
16:44:01 <switch__> what would that look like?
16:44:19 <amalloy> i think it loads png files from disk, and h is determined by the size of the png, so it's not the same every time
16:45:48 <amalloy> {png_bytep row_pointers[] = new png_bytep[h]; for (...) {...} png_read_image(png_ptr, row_pointers); delete[] row_pointers;} // roughly
16:46:33 <amalloy> i guess it's png_bytep row_pointers*
16:47:55 <amalloy> sucks to heap-allocate but what can you do. i'm not a C++ genius
16:48:38 <amalloy> switch__: similar to how m_pixels is allocated
16:49:18 <amalloy> oh no, i take it back, m_pixels is weird
16:51:08 <switch__> doesn't seem to work
16:51:29 <amalloy> what happens?
16:52:09 <switch__> you're talking about replacing png_bytep row_pointers[3000] with "png_bytep row_points* = new png_bytep[h]", right?
16:52:34 <switch__> pretend i spelled that right
16:52:43 <amalloy> yes, and adding a matching delete[]
16:53:53 <switch__> https://i.imgur.com/F9huBEh.png
16:54:23 <amalloy> ;
16:55:17 <amalloy> (that is, you are missing a ;)
16:55:28 <switch__> huh?
16:55:35 <switch__> oh
16:55:36 <switch__> i am
16:55:40 <switch__> but that's not the ; it's talking about
16:56:05 <amalloy> indeed, but i don't put a lot of trust in compiler's type errors while the file has syntax errors
16:56:13 <|amethyst> switch__:  *row_points
16:56:23 <switch__> i actually *just* did that on my own
16:56:24 <switch__> thanks
16:56:24 <switch__> lol
16:57:06 <switch__> i think that works
17:00:58 <switch__> pushed
17:03:05 <switch__> thanks for the help amalloy |amethyst :D
17:04:25 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-g6bad9d4: MSVC 2017 Compatability 10(19 hours ago, 32 files, 2576+ 778-) 13https://github.com/crawl/crawl/commit/6bad9d45d414
17:14:59 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-376-g0c44b4f: MSVC 2017 Compatability 10(20 hours ago, 33 files, 2624+ 784-) 13https://github.com/crawl/crawl/commit/0c44b4f25c8a
17:15:34 <switch__> should be pull-able
17:17:25 <ebering> amalloy: have you tested or is that just a style sign-off
17:17:34 <amalloy> i haven't tested
17:18:02 <amalloy> i'll edit the comment to clarify
17:19:10 <switch__> i tested it, but not extensively, and not since the newest commit (though it didn't change anything structurally)
17:19:42 <gammafunk> can any dev compile under msvc right now?
17:19:46 <ebering> switch__: you'd be amazed at how brittle crawlcode is
17:19:59 <gammafunk> probably could try under a VM
17:20:00 <switch__> gammafunk if you download it on a windows machine, sure
17:20:19 <switch__> the community edition is free
17:20:19 <gammafunk> right, wondering if anyone has tried based on PR yet
17:20:33 <switch__> i did, on a fresh machine, fwiw
17:20:42 <switch__> you'll need the PRs to the submodules as well
17:20:53 <gammafunk> dracoomega was our last dev to use msvc iirc
17:20:58 <gammafunk> actually maybe mumra did as well
17:21:15 <switch__> sounds like you need a new dev or two
17:21:21 <switch__> winky face
17:21:50 <gammafunk> he have more than two new ones! they just don't use msvc
17:21:59 <gammafunk> it will be a problem where it becomes out of date again is what I'm saying
17:22:03 <gammafunk> would be cool if we could like
17:22:06 <gammafunk> wine test compilation
17:22:10 <switch__> i'm down to maintain it
17:22:50 <switch__> and finish fixing it, for what that's worth
17:23:08 <switch__> since it does only compile release/win32 as of right now ._.
17:23:32 <gammafunk> yeah, no problem at all to have someone in the community maintaining
17:23:49 <gammafunk> I think it just happened that there were a bunch of viable alternatives for compilation now, and dedicated windows people have been using those
17:23:58 <gammafunk> this method of compilation is probably among the fastest though
17:24:25 <switch__> i haven't tested its speed vs cygwin or mysys2
17:24:38 <switch__> it's definitely simpler to make install and leave it alone
17:24:45 <switch__> but then you don't get to use MSVC's debugger
17:24:53 <gammafunk> it would have to be way faster than msys2 and cygwin (I hope)
17:25:05 <switch__> it's pretty damn fast in MSVC
17:29:31 <switch__> https://i.imgur.com/aAOML3V.png amalloy
17:29:44 <switch__> are you sure those are actually doing anything?
17:30:17 <amalloy> that's a funny error message. MSVC guessing what you might mean and then telling you you're wrong
17:30:53 <amalloy> yes, PURE is a macro defined to expand to a compiler hint that gcc and clang understand
17:31:11 <amalloy> !source PURE
17:31:12 <Sequell> Can't find PURE.
17:31:26 <geekosaur> AppHdr.h
17:31:53 <|amethyst> and if it's not one of those two (if not defined(__GNUC__)), it should expand to nothing
17:31:57 <amalloy> oh, interesting. it's already defined to only apply in gnu
17:32:22 <amalloy> maybe MSVC thinks it's illegal to define a macro that shares a name with a keyword, even though the names differ in case?
17:32:52 <amalloy> oh, probably the relevant files just need to #include AppHdr
17:33:42 <amalloy> yeah, there are lots of other files using PURE that you didn't have to change
17:34:00 <amalloy> these two files just complain because they need to include the macro
17:34:31 <switch__> doesn't every file have to include AppHdr?
17:35:05 <geekosaur> no. back in the day, it was mostly for precompiled headers
17:35:22 <geekosaur> whcih cause their own problems, so files that didn't need them didn't include it
17:35:25 <|amethyst> package.cc does
17:35:36 <|amethyst> which is the relevant file here, according to the error message
17:37:15 <|amethyst> unless somehow geom2d.h is being indirectly included from AppHdr.h
17:37:23 <|amethyst> (and before PURE is defined)
17:39:07 <amalloy> it doesn't seem to be
17:41:05 <amalloy> switch__: other than the PURE change everything in the msvc PR looks fine to me, though of course i didn't test it or read the giant project files
17:41:37 <switch__> i dunno what to do about the PURE change
17:43:15 <switch__> i can wrap the entire thing in an ifdef if you want amalloy
17:43:20 <switch__> it'd be like 4 of them
17:44:53 <amalloy> i'd rather we figure out why it's not working, since it's supposed to work already
17:55:48 <switch__> from what i'm reading it seems MSVC just doesn't like it
17:57:17 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-377-gf23e929: Maintain PURE-ity 10(2 minutes ago, 2 files, 21+ 0-) 13https://github.com/crawl/crawl/commit/f23e929fadce
18:03:24 <rastwork> FYI devs DS spines mutation is still busted in the early game
18:03:43 <switch__> what makes you say that
18:03:52 <rastwork> should probably be nerfed, maybe slightly increase late game spines to make up for it
18:04:07 <rastwork> because it kills monsters better than the player can
18:04:32 <switch__> i distinctly remember it wasn't enough to carry a game where i had a cursed crossbow and no ammo
18:04:48 <switch__> even though i held <.> for 3-4 floors
18:04:53 <rastwork> i mean at some point yeah its not going to kill every monster for you
18:04:54 <switch__> if anything it needs a buff
18:05:06 <switch__> true story btw
18:05:22 <rastwork> its doing quite a lot of damage IME
18:22:50 <rastwork> d:7 death knight, totally fair
18:22:55 <switch__> amalloy, is that change sufficient?
18:25:02 <amalloy> switch__: it's fine i guess, but put in a TODO comment about figuring out why these specific usages of PURE need these kid gloves but other usages work as expected
18:25:14 <switch__> sure thing
18:25:27 <switch__> i can add it to things i'll try to figure out after i get x64/debug working as well
18:27:54 <switch__> pushed
18:28:25 <switch__> would be nice to get this merged before i start screwing with project files again to get the rest of it working
18:29:00 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/878 * 0.23-a0-378-g7c1d5b7: FixMe! 10(81 seconds ago, 2 files, 6+ 0-) 13https://github.com/crawl/crawl/commit/7c1d5b7eb18f
18:36:25 <amalloy> weird, i had to make clean after pulling that PR - an ordinary build failed to link tool/tilegen.elf for some reason
18:47:13 <amalloy> i'm happy to merge the MSVC PR if nobody else objects - the one person who uses MSVC alleges that it works, and it also works for me on linux
18:55:58 <Cheibriados> 03Stenella02 {amalloy} 07* 0.23-a0-376-ge56fa01: MSVC 2017 Compatibility (#878) 10(6 seconds ago, 33 files, 2645+ 778-) 13https://github.com/crawl/crawl/commit/e56fa010db5c
18:56:29 <amalloy> wait, did i merge the right one? you have two PRs about MSVC
18:57:05 <amalloy> oh, the other one is an issue, not a PR
18:59:07 <switch__> technically there are 3 PRs :P
18:59:17 <switch__> but yeah, that's the right one
18:59:21 <switch__> could you merge the submodule PRs as well?
19:09:51 <switch__> https://github.com/crawl/crawl-zlib/pull/1 https://github.com/crawl/crawl-freetype/pull/1 https://github.com/crawl/crawl-libpng/pull/1 https://github.com/crawl/crawl-lua/pull/1 https://github.com/crawl/crawl-pcre/pull/1  https://github.com/crawl/crawl-sdl2/pull/2  https://github.com/crawl/crawl-sdl2-image/pull/1  https://github.com/crawl/crawl-sqlite/pull/1 amalloy
19:10:41 <switch__> for future commits i'll probably migrate the project files to a single directory within the main repo
19:10:43 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-376-ge56fa010db (34)
19:10:45 <switch__> so you shouldn't ever have to do that again
19:10:52 <amalloy> well, one more time
19:11:18 <amalloy> when you move the project files that'll be a change to each repo, right?
19:11:29 <switch__> not necessarily, you could just leave the dead files in there
19:11:33 <amalloy> fair
19:11:36 <switch__> there's plenty of them as it is
19:13:20 <amalloy> done
19:13:46 <switch__> i think you missed the sqlite one
19:14:10 <switch__> poggers
19:14:18 <switch__> we did it
19:30:15 <amalloy> rastwork's spines comment made me think: (a) what if spines scaled with XL as well as with mutation level; (b) why don't most mutations do that?
19:31:31 <ebering> I don't think there's a blanket answer to (b)
19:31:42 <ebering> some don't because they're discrete (rC+) e.g.
19:31:51 <amalloy> i guess it's hard to find a scaling amount where they're neither insignificant at XL1 nor insane at XL27
19:32:09 <ebering> some do (blink fail %, frail (in a sense)) I guess I can't list the whole set of them off the top of my head so
19:32:32 <ebering> I've got a squash+rebase of 877 in progress which I'll merge when I finish testing it
19:33:20 <switch__> sweet
19:34:24 <gammafunk> yeah, I also think mutations are not all meant to have the same relevance at the same parts of the game
19:34:50 <gammafunk> if you make all mutations scale up you're probably going to have a harder time keeping combinations of them balanced
19:35:42 <gammafunk> that's very general as a statement, but each mutation is not meant to "carry" a character or whatnot
19:43:17 <switch__> would putting the main project file into contrib\MSVC and the subproject files into contrib\MSVC\contrib be fine?
19:44:04 <switch__> or would you prefer the main project file as is (in contrib\) and the subproject files in a subdirectory (e.g. contrib\MSVC\)
19:45:51 <switch__> i think the second way is better
19:57:09 -!- amalloy is now known as amalloy_
20:17:32 -!- amalloy_ is now known as amalloy
21:29:17 <ebering> switch__: how would you like to be listed in CREDITS.txt
21:29:34 <switch__> sure
21:29:34 <switch__> "Stenella" is fine
21:29:38 <ebering> ok
21:29:41 <switch__> i can add it myself in my cast commit, if you want
21:29:50 <switch__> which is... right about now, actually
21:30:01 <ebering> no I'm about to push
21:30:10 <switch__> okay, that works
21:30:40 <switch__> i'm not sure if it was due to internal lag or whatever but the project files didn't load perfectly from the submodules
21:30:48 <switch__> i've finished porting it to a single folder, outside of the submodules
21:30:58 <switch__> no harm done, the old broken project files remain broken ._.
21:32:59 <Cheibriados> 03stenella02 {ebering} 07* 0.23-a0-377-g1406302: Simplify HP calculations (11728) 10(25 hours ago, 12 files, 67+ 92-) 13https://github.com/crawl/crawl/commit/1406302debe1
21:32:59 <Cheibriados> 03ebering02 07* 0.23-a0-378-gd7a6ca6: Add Stenella to CREDITS 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/d7a6ca628010
21:34:21 <switch__> Thanks
21:38:26 <Cheibriados> New branch created: pull/879 (3 commits) 13https://github.com/crawl/crawl/pull/879
21:38:26 <Cheibriados> 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-377-gfa867a1: Merge pull request #5 from crawl/master 10(12 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/fa867a13e25b
21:38:26 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-378-g576885d: Migrate MSVC Project files into the main repository 10(7 minutes ago, 41 files, 3260+ 434-) 13https://github.com/crawl/crawl/commit/576885dd23ff
21:38:26 <Cheibriados> 03Stenella02 {GitHub} 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-379-g7b4b629: Don't need this file 10(2 minutes ago, 1 file, 0+ 13-) 13https://github.com/crawl/crawl/commit/7b4b629a50b0
21:43:18 <ebering> hm. it's not in any of our develop docs
21:43:26 <ebering> but we have a standard for commit messages
21:44:38 <gammafunk> I think that's covered actually
21:44:47 <switch__> time to go look at that, I suppose
21:45:04 <switch__> or I could just squash all of those shitty commits :^)
21:45:42 <ebering> oh it's in the new one
21:46:25 <gammafunk> yeah, in the contribution guide
21:46:31 <gammafunk> there's also a patch guide
21:46:39 <gammafunk> that might need updating, talks about uploading the patch to mantis
21:46:50 <ebering> that does need updating
21:46:55 <gammafunk> maybe the useful parts of that could be made into markdown
21:47:03 <gammafunk> with the contrib guide linking to it
21:49:00 <Cheibriados> 03stenella02 07https://github.com/crawl/crawl/pull/879 * 0.23-a0-377-g6d02017: Migrate MSVC Project files into the main repository 10(17 minutes ago, 39 files, 3247+ 384-) 13https://github.com/crawl/crawl/commit/6d02017e506b
21:49:16 <switch__> sorry, that should be the last one for that PR
21:49:40 <switch__> i read the coding conventions file a few days ago when i first started working on stuff
21:49:47 <switch__> are there other docs you're referring to?
21:50:44 <gammafunk> !source contribution-process.md
21:50:45 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/contribution-process.md
21:51:11 <ebering> there are also some out of date ones we're talking about revising to bring up to date with current practice
21:53:31 <gammafunk> !learn set patch[1] Too get details about how to discuss and submit a patch or pull request, see: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/contribution-process.md
21:53:32 <Sequell> patch[1/2]: Too get details about how to discuss and submit a patch or pull request, see: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/contribution-process.md
21:53:36 <gammafunk> ??patch[2
21:53:37 <Sequell> patch[2/2]: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/patch_guide.txt
21:54:02 <gammafunk> nice thing is that got masked by patch[1] being a reference to ??mantis
21:54:30 <switch__> i'll read through these. those extraneous commits definitely should have been rebased; I left an extra file in and deleted your makefile ._. no reason for other people to see that
21:54:36 <gammafunk> !learn edit patch[2] s/^/Somewhat out of date patch guide: /
21:54:37 <Sequell> patch[2/2]: Somewhat out of date patch guide: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/patch_guide.txt
21:55:18 <gammafunk> !learn add pull_request see {patch}
21:55:19 <Sequell> pull request[1/1]: see {patch}
22:01:25 <switch__> triple-tested that PR btw
22:10:51 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-378-gd7a6ca6280 (34)
22:18:19 <gammafunk> pro tip: don't rebase your branch to clean up commits while you're compiling the branch
22:19:19 <switch__> is that from experience or did I do that
22:19:21 <gammafunk> thankfully I didn't spend 15 minutes going crazy figuring out what happened like I did the last time I did this
22:19:23 <switch__> because I can totally see myself doing that
22:19:32 <switch__> rofl
23:02:21 <switch__> what's a quick way to know i'm on the debug build?
23:03:24 <switch__> nevermind, it's super obvious
23:19:52 <ebering> !seen regret-index
23:19:52 <Sequell> I last saw regret-index at Thu Nov 17 00:56:03 2016 UTC (about 1y 49w 2d 2h 23m 49s ago) quitting, saying 'Quit: leaving'.
23:20:09 <ebering> have they appeared under a different name in recent times?
23:20:38 <ebering> looking at reviewing some of these old mantis vault submissions
23:27:31 <gammafunk> that's they're preferred name, although they were submitting vaults "anonymously" for a while
23:27:46 <gammafunk> *their
23:48:37 <switch__> debug works
23:48:46 <switch__> have to fix libpng and x64 should be good to go