00:28:12 -!- babuloseo_afk is now known as babuloseo 02:18:52 ebering: i had to admit total inability to understand your comment on 842 02:19:09 have 02:19:52 are you saying that species difficulty ignoring background can be ranked but background difficulty ignoring species cannot? 02:26:46 alexjurkiewicz: i'm fairly sure that's one thing that comment is saying: that you can't divide up "the difficulty of the character XxYy" into "the difficulty of Xx times the difficulty of Yy" 02:46:38 that makes sense to me 03:11:59 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-359-g9beedce (34) 03:41:56 TZer0: is there some trouble with CDO? I'm a bit worried since I have a game going on CDO/trunk with 30+ hours into it, and when I try to continue with it I get the "start a new game" screen. I'm probably doing something wrong, but I can't figure out what.. 03:42:00 !gameinfo 03:42:02 TAS2012 the L27 MuNe^Gozag in Pan (cdo console), 2d+5:40:04, T:495638, runes: 15 (fiery, dark, magical...), defenses: 34/30/35, stats: 26/47/15, >15 skills: Fighting,Long Blades,Polearms,Armour,Dodging,Stealth,Shields,Spellcasting,Conjurations,Charms,Necromancy,Translocations,Fire Magic,Earth Magic,Evocations, Max skills: Fighting,Long Blades,Polearms,Armour,Dodging,Stealth,Shields,Spellcasting,Co... 03:43:41 options file is also not how I left it, but an earlier version 03:43:50 this dump still there though, http://crawl.develz.org/morgues/trunk/TAS2012/TAS2012.txt 03:53:07 If there is any chance of recovering this, or if you can advice me on what I'm doing wrong, please give me a shout 04:01:35 at least what seems like the proper/latest options file is found at http://crawl.develz.org/configs/trunk/TAS2012.rc - now I have hope :) 04:43:59 -!- amalloy is now known as amalloy_ 04:52:20 03NormalPerson702 07https://github.com/crawl/crawl/pull/868 * 0.23-a0-353-ge1fcb26: Make the immune_to_hex function available to clua 10(4 minutes ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/e1fcb266c80f 05:18:32 Sarcophagus blocking access to staircase on Tomb:1 13https://crawl.develz.org/mantis/view.php?id=11733 by NormalPerson7 05:21:35 hi guys, what is your preferred way of suggestions on various aspects of game mechanics or flavour? 05:25:27 hmm, sorry to bother TZer0, him not even being the admin of CDO 05:25:41 this might be a clue to my troubles though 05:26:45 I am quite sure I saw him listed in dgamelaunch as maintainer 05:27:16 and I've rechecked that the host name in putty is cawl.develz.org 05:27:54 now I tried again, and get the CDO dgamelaunch, and it recognized me having a savegame, but after asking if it should bre aupdated to latest trunk it just quits back out to dgamelaunch again 05:29:22 So I guess it is Napkin I should kindly ask to bother 05:33:28 Napkin: I've recently encountered some troubles on CDO/console/trunk. Please see above. Currently, as soon as I choose Play on trunk, I momentarily see "Starting [...] 98c7a59" and then get bounced back to the main Trunk screen in dgamelaunch. Is there anything I can do? 05:34:01 looking at it 05:34:05 <3 05:35:54 i added a "any key to continue" to the start script 05:36:12 PM 05:36:12 could you please try loading your save again and check if there is any error message shown 06:00:48 crash on game start after updating to latest (98c7a59) trunk 13https://crawl.develz.org/mantis/view.php?id=11734 by TAS2012 07:09:43 03NormalPerson702 07https://github.com/crawl/crawl/pull/868 * 0.23-a0-353-g8aca982: Make the immune_to_hex function available to clua 10(2 hours ago, 1 file, 12+ 0-) 13https://github.com/crawl/crawl/commit/8aca9829f37b 08:05:01 I've encountered a strange case of distribution of exp from !exp 08:07:36 it's minor, but when you change the focus of the skills the distribution changes if you just change the focus 08:09:46 you can just drink an exp pot with a few(like 4) skills chosen and change the focus on one of them a few times to see what I'm talking about 08:26:13 alexjurkiewicz: yes, I'm saying that difficulty of Xx Yy isn't the product of difficulty of Xx and difficulty of Yy. Since we already display difficulty of Xx and the species screen is first by default, the background screen should indicate difficulty of Yy for the selected species, which it does currently, just with two possible leves 08:26:25 "recommended" and "not recommended" 08:51:32 %git 08:51:32 07gammafunk02 * 0.23-a0-359-g9beedce: Refactor and update comments. 10(14 hours ago, 1 file, 6+ 7-) 13https://github.com/crawl/crawl/commit/9beedcea5eaa 08:57:41 %git 6e662b0731bd80 08:57:41 07ebering02 * 0.23-a0-330-g6e662b0: Add Harm as an artefact property 10(3 months ago, 6 files, 15+ 2-) 13https://github.com/crawl/crawl/commit/6e662b0731bd 08:58:37 I can't replicate the TAS_2012v crash locally, so it may be compiler dependent, but it crashed during a fixup resulting from that commit (resizing the artifact props vector to allow for the harm) 08:59:10 if that's so, and there's not an extra random factor, it may happen again; any save from before that commit should do the fixup 09:11:57 I wonder if this problem might be specific to unlinked items 09:19:37 oh, they're probably showing as unlinked because of the recursive crash, load_level_items didn't finish 09:28:20 hm. not sure what's going on there 09:29:14 I don't think it's anything you did 09:29:32 ok 09:30:01 artefact_fixup_items is already designed to cope with exactly the kind of change you made 09:30:13 er, artefact_fixup_props 09:30:33 yeah I remember looking at that to be sure 09:33:22 it seems to have crashed on CrawlVector::reserve, which is just inherited from std::vector 09:34:27 oh I phrased that wrong -- it crashed on the reserve call to the internal store, which is just a vector 09:35:37 albeit a vector, one of crawl's more annoying types 09:44:39 I'm currently working on 11725, in case anyone else starts work on it / already has done 09:56:19 looking at some old dev logs, it appears that ng-wanderer tries to memorise the l1 spell from a book if it's given but that is not currently working 10:02:49 ah, so what you're saying is that I should leave any code for spells that are initially memorised in, rather than remove it? 10:03:34 *any of my new code 10:21:37 yes 10:21:49 (and, if you're mucking around in there, maybe fix that bug too :) ) 10:23:18 sure I'll have a look 10:24:04 03NormalPerson702 {ebering} 07* 0.23-a0-360-gb5b85be: Display (immune) in monster description when a player is immune to a hex 10(2 days ago, 3 files, 56+ 5-) 13https://github.com/crawl/crawl/commit/b5b85be88df4 10:24:04 03NormalPerson702 {ebering} 07* 0.23-a0-361-gd59976b: Include info about intrinsic immunity in monster spell description 10(18 hours ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/d59976b5a02a 10:24:04 03NormalPerson702 {ebering} 07* 0.23-a0-362-g084b3f8: Make the immune_to_hex function available to clua 10(6 hours ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/084b3f85fe80 10:24:14 New branch created: pull/869 (1 commit) 13https://github.com/crawl/crawl/pull/869 10:24:14 03NormalPerson702 07https://github.com/crawl/crawl/pull/869 * 0.23-a0-351-gd5b4220: Announce the starting items and spells for wanderers (11725) 10(9 minutes ago, 1 file, 41+ 4-) 13https://github.com/crawl/crawl/commit/d5b42209ba54 10:24:16 advil: I dunno if your lua doc hosting updates automatically 10:24:35 ebering nope 10:24:57 it could be done, just haven't set it up 10:25:51 probably not needed, but after those commits it needs an update 10:28:28 !source newgame_make_item 10:28:29 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/ng-setup.cc#L95 10:29:33 looks like wanderers are currently vetoed from memorising level 1 spells in their book, because they might have multiple level 1 spells 10:29:43 I guess it makes sense for players to be able to choose which level 1 spell they want 10:30:50 I suppose if they only have one level 1 spell it should probably be automatically memorised 10:31:21 would you like me to add that last bit to create_wanderer? 10:31:57 yes, I think that's reasonable behavior 10:32:06 someone else might disagree 10:32:30 well I'll make it a separate commit and you can always just not merge that commit 10:35:32 sounds good 10:43:55 -!- Euph0ria is now known as TabMasher 11:10:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-362-g084b3f85fe (34) 11:29:00 03advil02 07* 0.23-a0-363-gceb43e6: unbrace 10(33 minutes ago, 2 files, 0+ 4-) 13https://github.com/crawl/crawl/commit/ceb43e64b4f6 11:29:00 03advil02 07* 0.23-a0-364-gbf5fdde: Try to avoid recursive crashes when loading level/save data 10(8 minutes ago, 4 files, 14+ 3-) 13https://github.com/crawl/crawl/commit/bf5fdde8f9ee 11:41:42 gammafunk: do you know if the CDO crawl login (crawl:crawl) can write to save folders (dgl:crawl, 0644) somehow? I feel like I've seen you do that to fix a save, but maybe I'm misremembering 11:43:05 I've never fixed a CDO save, no, but I've downloaded some data like bones files or maybe a save 11:43:31 you'd porbably have to ask Napkin about that 11:43:52 ok 11:44:02 what's up? 11:44:02 it's probably just impossible, which is reasonable 11:44:20 i think it's a separate user 11:44:33 advil: btw, re: that server documentation we were talking about the other day (based on your initial one), when I complete that, should we put it in a place that only devs have access to? 11:44:37 what would you like me to move from where to where? 11:45:30 I'm just trying to figure out how to replicate TAS_2012v's crash, and one idea I had was to try to load his save on a test account on CDO...I think the idea is too nebulous to bug you with though Napkin :) 11:45:53 no problem, logged in already 11:46:28 but crawl on cdo is still on crawl-svn-98c7a59 11:46:40 need latest, correct? 11:47:04 ah, good point 11:47:16 that you would install as user crawl just running update-cdo-trunk.sh 11:47:32 "update-cdo-trunk.sh quiet" if you don't want to be forced to press enter all the time ;-) 11:47:52 could you copy ~crawl/adviltest.cs into the save directory for the current trunk? that'll be a proof of concept and then I can see if it's worth following up on 11:48:29 I'm still not sure if the mantis save even has the bug 11:49:04 you want to see the error message as well? 11:49:29 try now then 11:49:58 ok, yep, definitely replicates the crash! 11:50:25 will you install fresh trunk then? 11:50:28 thanks!...I think now that that save is copied I can work from here 11:50:39 I've got to go to a meeting but I will sooner or later :) 11:50:40 ah, true :) 11:50:52 meeting with Feierabend soon :D 11:52:02 let me know when you're finished, i'll remove the "DEBUG Mode" then 11:52:47 https://yourdailygerman.com/german-word-of-the-day-feierabend/? 11:53:04 \o/ 11:53:33 had to look that one up 11:53:36 heh 11:55:35 03NormalPerson702 07https://github.com/crawl/crawl/pull/869 * 0.23-a0-352-ged8802c: Start Wn with a spell memorised if they have only one level 1 spell 10(7 minutes ago, 3 files, 25+ 0-) 13https://github.com/crawl/crawl/commit/ed8802ccf75e 11:55:35 03NormalPerson702 07https://github.com/crawl/crawl/pull/869 * 0.23-a0-353-g8de23d1: Update a comment and make the opening clause of a list better 10(2 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/8de23d1c94a2 12:10:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-364-gbf5fdde8f9 (34) 12:28:27 !lm cdo crash 12:28:28 No milestones for cdo (crash). 12:28:33 !lm * cdo crash 12:29:12 2646. [2018-10-01 15:34:47] hayenne the Geomancer (L10 DDNe of Sif Muna) ASSERT(in non diamond int(r.start)) in 'ray.cc' at line 217 failed on turn 11680. (D:9) 13:20:34 Unstable branch on crawl.develz.org updated to: 0.23-a0-364-gbf5fdde (34) 13:20:45 heh that script does make you hit enter a lot 13:26:19 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-364-gbf5fdde (34) 13:36:01 -!- amalloy_ is now known as amalloy 13:52:06 advil: how did you find out details of the TAS_2012v crash? i don't see a mention of it in the log 14:08:54 so wait, granite statues are not disintegrable, and digging doesn't exist anymore, right? is there any way for a player to destroy one? 14:09:06 digging still exists 14:09:15 and they can be dug 14:15:27 amalloy: digging still exists, we're not planning to remove the wand, just reduce the charges (which hasn't been done yet) 14:21:31 03amalloy02 07* 0.23-a0-365-gd27e9dc: Fix a Tomb vault that was impassable (NormalPerson7, #11733) 10(9 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d27e9dc1eedf 14:21:31 03amalloy02 07* 0.23-a0-366-gf86452d: Turn some pointers into refs, resolving a TODO 10(8 minutes ago, 1 file, 15+ 18-) 13https://github.com/crawl/crawl/commit/f86452d001a6 14:26:03 03amalloy02 07* 0.23-a0-367-gf2e588f: Remove some now-unneeded sarcophagus labelling from a Tomb vault 10(24 seconds ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/f2e588f4e5f4 14:28:01 nice, rip pointers 14:29:49 i have a little elisp function and bash script to do pointer-to-ref conversion that works in simple cases despite just being a little perl hackery 14:30:10 !tell advil still having issues with webtiles and the ubuntu18 upgrade :/ 14:30:10 espais: OK, I'll let advil know. 14:30:19 advil: though, I have a new/interesting wrinkle here 14:30:30 so i waited for the nightly, still no luck 14:30:37 i added in the most recent stable build for 0.22 14:31:05 also fails with the swap from #play-dcss-0.22 to #lobby 14:31:12 but, 0.20 works just fine 14:31:58 this is the specific error in webtiles.log 14:32:00 ERR: /usr/games/crawl-0.22: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /usr/games/crawl-0.22) 14:32:35 result of apt-cache policy libc-bin: Installed: 2.27-3ubuntu1 14:34:23 thumbs up to amalloy 14:36:59 espais, do you have a chroot for crawl? you may need to upgrade it to match the host 14:37:13 hm, i do 14:37:26 otherwise a crawl built outside the chroot will fail when run inside it 14:37:39 interesting, hadn't considered that 14:37:54 would that just be re-running the debootstrap command or do i have to go through the whole dgamelaunch process? 14:38:17 possily just apt-get upgrade inside the chroot 14:42:03 New branch created: pull/870 (1 commit) 13https://github.com/crawl/crawl/pull/870 14:42:03 03NormalPerson702 07https://github.com/crawl/crawl/pull/870 * 0.23-a0-351-gfd25baa: Fix transformation HP scaling with HP+ artefacts (11728) 10(31 minutes ago, 1 file, 20+ 20-) 13https://github.com/crawl/crawl/commit/fd25baa0c09a 14:47:26 -!- Euph0ria is now known as TabMasher 14:48:11 ah, good point about the chroot, that's very similar to what recently bit johnstein on CBRO so sounds very plausible to me 14:48:12 advil: You have 1 message. Use !messages to read it. 14:51:25 i re-ran the debootstrap before geekosaur responded 14:51:45 interesting apt-get update/upgrade (inside chroot) didn't do anything, so perhaps the debootstrap took care of it 14:51:58 the git build is taking way longer than before, so i'm cautiously optimistic 14:52:01 iirc johnstein had to do something a bit complicated, apt-get update didn't work for him either 14:54:52 i suppose worst case i can nuke everything and start fresh 14:55:02 i'm the only one really using my server so it wouldn't really hurt anybody 14:58:04 huh, i see logic in the untransform code to kill you if HP scaling somehow gets you to 0 hp after losing your form, but i can't see how that would ever happen 15:00:04 yea I was wondering that too 15:00:34 there's lingering code for ways you used to be able to die still lurking around 15:00:52 can I just remove it then? 15:01:23 i wouldn't do it in this PR 15:01:28 ok 15:04:28 03NormalPerson702 {amalloy} 07* 0.23-a0-368-g82e9058: Fix transformation HP scaling with HP+ artefacts (11728) 10(54 minutes ago, 1 file, 20+ 20-) 13https://github.com/crawl/crawl/commit/82e90586b2dc 15:10:52 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-367-gf2e588f4e5 (34) 15:40:24 advil, Napkin: do you think I should try updating to latest trunk again with my problem game, to see if the problem is still there, or is there no point in that? 15:40:42 TAS_2012v, probably not a good idea 15:41:11 :) I'll keep on the old one then, but if you want me to try just write a note on the mantis issue 15:41:38 I have a save parked on cdo under another username where I was able to replicate the crash, so that's probably enough to take it from there 15:41:38 ah 15:41:38 good 15:41:52 (hopefully I won't accidentally give you any milestones from it, I forgot to change the username in the save file :D) 15:41:58 :D 15:42:51 I'll keep trudging on with this game forever, planning on visiting multiple Zigs... we'll see how that goes... 15:43:35 now I just got this: 15:43:38 You are not playing in the latest version (bf5fdde) available! 15:43:39 [T]ransfer your save to the latest version? 15:43:39 Starting Dungeon Crawl Stone Soup 440b721... 15:43:39 --- DEBUG Mode to see console output - any key to continue ---Failed starting: /bin/crawl-svn-440b721 not found! 15:43:39 --- any key to continue --- 15:43:48 (answered N to the question of course) 15:43:55 hm 15:43:56 and bounced back out 15:44:04 I think my last session had a timeout 15:44:13 if that is of importance 15:44:21 did you play it since the save got moved to the old version? 15:44:33 I played last less than an hour ago 15:44:44 no problems then, and did some exiting and resuming 15:45:59 I guess this is not my save problem, but 440b721 bins that are the problem 15:47:05 huh, that binary is present 15:47:34 I'm afraid I don't know enough about the CDO setup to diagnose this, it'll have to be Napkin 15:48:59 I'll get some sleep now, Napkin please see above if you can tell what is the issue here, thanks! 15:49:49 did you run an update, advil? 15:49:58 I did update trunk 15:50:05 hope I did it right :D 15:50:33 amalloy: sorry, missed your question -- TAS_2012v reported it on mantis, yeah it didn't show up here 15:53:57 ah, TAS_2012v - that error comes after the game already ran 15:56:11 your game from 18:18 today is still running 15:56:25 svalbard (L13 DEFE) Crash caused by signal #15: Terminated (Lair:3) 15:56:25 (not really asleep yet) 15:56:37 TAS2012 (L27 MuNe) Crash caused by signal #15: Terminated (Pan) 15:57:29 ah, so it should (normally) have asked me if it was to kill the earlier (abandoned) process? 15:57:55 retrying 15:58:16 looks fine now 15:58:19 Napkin btw if you'd rather not leave debug mode on, I'm going to be only able to look at this crash kind of sporadically over the next few days, so I can probably manually find the crashlogs without too much trouble 15:58:55 removed 15:59:16 did a proper exit&save now, so I can sleep without worries :) 16:00:23 :) 16:00:33 !crashlog svalbard 16:00:35 2. svalbard, XL13 DEFE, T:16282 (milestone): http://crawl.develz.org/morgues/trunk/svalbard/crash-svalbard-20181023-195624.txt 16:01:31 I wonder if there was an infinite lua loop 16:04:10 definitely it was running for 4 hours with 100% cpu 16:10:47 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-368-g82e90586b2 (34) 16:27:11 advil: it works 16:27:22 wow 16:27:24 congrats1 16:27:25 er 16:27:27 congrats! 16:27:57 it was both way easier and way harder than it should have been 16:28:20 very interested to know what you had to do overall (I have some sense of it from the questions that have come up of course) 16:29:11 in my current build, i am building libpng externally, and undefined "use_zlib" in package.cc 16:29:34 but that last bit was a hack that i did because i thought i was still in "try everything" mode; it just happened to be the last problem 16:29:45 heh 16:29:53 so i have to fix the libpng shit 16:30:00 which is just project file stuff 16:30:39 other than that there aren't any hacks 16:31:16 I guess a big chunk of it was just getting file lists correct? 16:31:37 yep 16:32:06 which is why i was so annoyed when that guy wanted to remove the instructions from the install.txt. there's no way i'd have been able to do this from scratch 16:33:19 I uh have to admit I did remove those, because your experience convinced me they were super obsolete (I did include a reference to the last version where they worked, since it's all in version control) 16:33:30 but I would definitely merge an update 16:34:28 i saw; your change was definitely better than the current instructions, but i will say i wouldn't have tried if it's what i'd read in the first place (meaning, it'd probably discourage a patch from ever happening) 16:34:28 "current" = the ones i read at first 16:34:28 that's fair 16:35:48 I guess I was mostly thinking of people who would try them more casually 16:36:10 and get frustrated 16:37:34 Yeah, I don't think it's a problem to make the instructions reflect current realties 16:38:06 Not that there's any harm in throwing in a quick pointer to relevant info if someone wants to improve things 16:38:10 I was also wondering when the last time anyone tried the linux for windows instructions, maybe more recently? 16:38:30 yeah, I haven't tried myself but I think I've heard reports of people using it successfully 16:38:42 was meaning to test in a VM some time ago but never got around to that 16:39:45 I feel like wheals or someone did it 16:41:10 potentially you could try cross-compiling with mingw32 from that subsystem 16:41:17 to make a windows-native binary 16:41:18 heh 16:41:33 https://github.com/crawl/crawl/blob/0b27b35b31d15d2eadbad8042adf154c3dba3e22/crawl-ref/source/rltiles/tool/tile.cc#L461 16:41:49 only other hack was changing this from "h" to 3000 16:41:57 because VLAs aren't supported 16:42:00 and i didn't want to rewrite it 16:42:08 heh makes sense 16:42:14 so that needs to be rewritten 16:42:23 it's probably bad that we're using any 16:42:30 is that really the only one? 16:42:40 the only VLA? yeah 16:45:02 in fact c++11 says that array size needs to be constexpr, so we're explicitly violating that 16:46:12 there's quite a few things, honestly 16:46:23 e.g. disjunction() is a function 16:46:26 off the top of my head 16:46:49 but i think i'll upload all the changes at once and we can look at them all at once 16:47:12 <|amethyst> yeah, that probably should be a vector 16:47:43 <|amethyst> (and then .data() when passing it to png_read_image) 16:51:37 shouldn't disjunction be a function? or are you pointing out that it shadows std::disjunction? 16:51:46 the latter 16:52:52 yes, if you look at the changes I'll look at them when I have a chance (other people probably will too) 16:53:13 yep, i did the linux for windows build a little while back and wrote up the instructions 16:53:27 it doesn't *feel* like that long ago but that's no guarantee it still works well 16:53:34 a PR would be fine (we can iterate as needed), or just some diffs if there's stuff you think will need further changes (like the VLA one), or a github issue that links to some diffs, any of these would work 16:54:05 wheals I think it was since I was a dev, which maybe is getting to be not that recent? but doesn't feel so long ago 16:55:06 well i know it's the system i've used since, so it at least worked as late as april which is when my last commit was 16:55:38 i added the instructions in december 2017, apparently 16:57:42 https://github.com/crawl/crawl/blob/b306ea240a012dd66efd0c049ce1f1577385bee0/crawl-ref/source/dungeon.cc#L6020 16:57:47 i thought that was pretty funny 17:00:32 bt2! 17:02:28 !blame gamma 17:02:29 I pronounce gamma... Guilty! 17:03:00 haha I'm originally more of a python programmer so that actually took me a while to see 17:03:59 if you don't ever want to write code that's wrong, the only solution is to never write code! 17:04:15 probably just because I had also been writing so much lua at the same time for the same project 17:05:43 https://en.cppreference.com/w/cpp/language/operator_alternative 17:05:47 til 17:06:11 wheals, this release is still waiting for your one commit 17:06:11 what's it going to be, I want a spoiler 17:06:23 i've had #11517 open in a tab in my browser for a few months 17:06:46 !bug 11517 17:06:46 https://crawl.develz.org/mantis/view.php?id=11517 17:07:05 nice 17:07:21 and yeah, that is really weird how and is an alternative token for && 17:07:57 just verified that the linux windows build thing still works, that's nice 17:08:12 wheals: would you be able to try cross-compiling with mingw under that? 17:08:39 if you want the compilation command it's in docs/develop/release/guide.txt 17:08:50 the make argument I mean 17:09:06 although maybe it is not trivial to install mingw in that subsystem, now that I think about it 17:09:14 not sure how installing packages works there, or if you really can 17:09:55 wow, C++17 removed support for trigraphs 17:09:57 it seems to have apt as usual 17:10:26 oh, so it's debian-based, interesting 17:11:05 i think in the latest versions you can actually choose what kind of distro it mimics even 17:11:09 it's mroe or less ubuntu 17:11:28 or at least early releases were 17:11:28 i'm not certain what packages i need for mingw cross compilation though 17:11:51 that may be in the install guide 17:12:03 no worries if it's a hassle, I was mostly just curious 17:12:29 amalloy: Trigraphs were proposed for deprecation in C++0x, which was released as C++11.[7] This was opposed by IBM, speaking on behalf of itself and other users of C++,[8] and as a result trigraphs were retained in C++0x. Trigraphs were then proposed again for removal (not only deprecation) in C++17.[9] This passed a committee vote, and trigraphs (but not the additional tokens) are removed from 17:12:35 C++17 despite the opposition from IBM 17:13:11 apparently they've been on the chopping block a while 17:13:23 of course, who else would have systems and codebases so old they predate ASCII and want to keep running them on modern C++ 17:14:59 i guess g++-mingw-w64-i686 is the package i want in order to install i686-w64-mingw32-g++? 17:15:02 it's very palindromic 17:15:17 yes, but you might need the toolchain package, let me see 17:16:45 wheals: mingw-w64 is the base package I have that pulls in the dev environment needed 17:16:45 perhaps mingw-w64-x86-64-dev 17:17:39 you'll also need the binutils package and possibly mingw-w64-common 17:17:49 if you want to install the packages individually, I guess 17:18:00 binutils-mingw-w64-x86-64 I mean 17:18:24 might try to look more into this tomorrow 17:18:54 calling it a day for now, already did more work than in the past 6 months :) 17:19:04 a vacation well earned 18:21:51 Unstable branch on underhound.eu updated to: 0.23-a0-368-g82e90586b2 (34) 18:31:21 ebering: I think that difficulty of recommended and not recommended would remain 20:28:31 -!- amalloy is now known as amalloy_ 20:29:57 03ebering02 07* 0.23-a0-369-g357f654: Update CREDITS.txt 10(41 seconds ago, 1 file, 21+ 1-) 13https://github.com/crawl/crawl/commit/357f65462955 21:02:28 -!- amalloy_ is now known as amalloy 21:04:36 -!- pblur_ is now known as pblur 21:10:48 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-369-g357f654629 (34) 21:14:11 how are experimentals handled? I'd like to put up known-traps as one to see what the experience of the shaft rate is like for players 21:14:48 should I push the branch to the main repo or set it up as a pr? what's the preferred workflow I guess 21:33:32 New branch created: pull/871 (1 commit) 13https://github.com/crawl/crawl/pull/871 21:33:32 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-370-gf5a67bd: MSVC2017 Changes 10(22 minutes ago, 33 files, 2688+ 920-) 13https://github.com/crawl/crawl/commit/f5a67bd2bd45 21:36:48 ebering: it just needs to be a branch, and one where you preferably don't force push 21:36:56 then you need an admin like johnstein to host it 21:37:15 I think alexjurkiewicz has hosted them in the past on cpo, but that limits the playerbase 21:37:21 so a server like cbro is pretty ideal 21:37:52 nothing wrong with also having a PR on said branch, of course 21:38:04 not sure if zibudo could set one up on cjr, he's not done that before 21:38:11 but if johnstein doesn't have time, he might be willing 21:39:08 I'll PR-ify it then and ask johnstein 21:44:41 if you were to pull that PR right now (and had my submodule files) it'd only build the win32 version 21:45:18 i ran into a problem with the crawl version of freetype's project file and didn't fix it (opting for trying to use the 32-bit version) 21:45:54 i guess i should leave that info in the PR 21:46:59 the problem i ran into with zlib solved itself 21:53:10 ebering: yeah, if it seems johnstein doesn't have time, maybe we can find another server for it 21:53:44 johnstein: if you have time, I'd appreciate an experimental of pull 872 (known-traps) 21:53:50 alexjurkiewicz: ^ 21:54:39 New branch created: pull/872 (7 commits) 13https://github.com/crawl/crawl/pull/872 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-370-gd3951a5: Reveal all traps 10(4 months ago, 27 files, 62+ 224-) 13https://github.com/crawl/crawl/commit/d3951a53874a 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-371-ga0b6011: Remove trap detection from wizmode 10(4 months ago, 5 files, 0+ 31-) 13https://github.com/crawl/crawl/commit/a0b6011a43c7 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-372-g0b11513: Exploration based trap effects. 10(4 months ago, 6 files, 60+ 7-) 13https://github.com/crawl/crawl/commit/0b11513cd37b 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-373-g7e4741a: Zot-ify alarm traps 10(4 months ago, 2 files, 14+ 49-) 13https://github.com/crawl/crawl/commit/7e4741a684ee 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-374-gfbda904: Add dispersal traps 10(4 months ago, 6 files, 31+ 5-) 13https://github.com/crawl/crawl/commit/fbda90477d88 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-375-g81f6d33: Keep friendlies out of traps that affect the player 10(4 months ago, 3 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/81f6d33e8524 21:54:40 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-376-g0b3fdcb: Don't make alarm traps permanent (MarvinPA) 10(49 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/0b3fdcbffd25 22:05:17 exciting!! 22:05:29 who is rawlins 22:05:37 that's advil, right? 22:06:35 yeah 22:06:43 I just took a quick pass through 22:06:50 I think you might have some different indent settings 22:07:11 did you read what i wrote in the pR? 22:07:14 PR* 22:07:19 and yeah I do, it's all screwed up 22:07:55 those files do actually have changes though 22:12:57 ebering: should be up in an hour or two 22:13:04 yeah, I see the utf stuff 22:17:19 alexjurkiewicz: cool! thanks! 22:18:24 in AppHdr.cc I changed SDL.lib to SDL2.lib because the folders are named SDL2 and MSVC defaults its output to the folder's name. 22:18:29 is this file used in other builds? 22:18:44 i.e. should I change the output of the project files rather than the filename inside the files 22:19:08 i'd probably have to write it explicitly, but that's fine 22:19:22 ebering: what happens if you reveal two shaft traps in the same move? 22:19:23 I'm not sure, I saw that change but will need to try it out 22:19:54 travis does build tiles so if you fix the make_unique thing that's currently causing it problems, it'll test for you 22:19:59 oh, there's a comment in the file itself that it's an MSVC file 22:22:20 the binaries off of their website use SDL2 as a name 22:22:25 so i guess it's fine 22:23:24 alexjurkiewicz: the explore based effects aren't actually linked to revealing traps 22:23:27 probably 22:23:35 just each tile revealed gives you a flat chance of getting shafted 22:23:58 ebering: oh, so you can't get shafted and alarmed in the same move? shame 22:24:10 you can 22:27:23 do_trap_effects gets called for each tile that comes into los so if one tile rolls mark and one rolls shaft then have fun 22:28:14 but I imagine if two shafts went off, the second ....well can the second ever even go off? 22:28:22 it just doesn't get to trigger I guess 22:28:42 that not working is also a shame 22:30:42 ebering: 2018-10-24 02:30:27,524 INFO: #2947 P1364 ERR: ERROR in 'traps.cc' at line 1384: placeholder trap type 103 used 22:31:42 ebering: https://crawl.project357.org/morgue/chequers/crash--20181024-023027.txt 22:32:34 oh my 22:32:39 I must have broken something with a rebase 22:36:40 needs a 0.01% chance of being shafted straight to zot 22:36:55 03stenella02 07https://github.com/crawl/crawl/pull/871 * 0.23-a0-371-gf4b2429: Update crawl-ref/source/libutil.h 10(4 minutes ago, 1 file, 7+ 6-) 13https://github.com/crawl/crawl/commit/f4b242999176 22:36:59 i guess i should build experimentals with full debugging huh 22:37:01 when every revealed tile gets you a shaft 22:37:17 ebering: do you want the crash again with full crashlog or is this one ok? 22:38:05 STRIP=true EXTERNAL_FLAGS_L="-g" 22:38:44 that STRIP=true is so unintuitive 22:39:32 you often see STRIP=: instead just to avoid it being misleading 22:41:11 (and because it's very slightly faster / lower load if "true" hasn't been built into the shell; ":" is almost always a builtin for historical reasons) 22:41:39 advil: error C2440: 'static_cast': cannot convert from 'Pred' to 'bool' 22:42:14 alexjurkiewicz: this one is ok, I've got it replicating locally 22:42:14 hm, apparently you cannot force msvc to use just c++11, c++14 is the lowest it goes 22:43:28 switch__: odd. It must be something about how function arguments work in msvc, or conceivably c++14 22:43:40 all code must be written within the last 4 years or we don't want it 22:43:58 yeah i'm not sure. i looked at it a bit but not too much 22:44:01 have you considered becoming a front-end developer? 22:44:05 i tried all the obvious hacky shit 22:44:11 looking at the way this function is used, I'm not sure why the `filter` check is even there 22:45:25 beats me 22:46:56 though the logic does change if you have just the right-hand-side of that conditional 22:47:31 I'm honestly not even sure what is happening when a lambda is cast to bool 22:47:32 which is what the current code does 22:47:39 I also don't know why it's a template parameter instead of auto 22:48:20 quite a lot of these are "why is this even here/not here" 22:48:37 the randomly missing ASSERT_LESS was pretty confusing 22:50:31 I saw that...but it's really rare to build without ASSERTS defined, and that's the case that instantiates the missing #define 22:51:15 aye 22:51:21 since its there in the if block 22:51:43 (I wouldn't recommend building without ASSERTS actually, if that's how you found this) 22:52:51 i think they're only defined if it's the debug configuration 22:53:28 no, they should be always defined, we don't release without them 22:53:42 oh 22:53:42 it's not the traditional debugging notion of asserts 22:53:52 then yeah, that's totally how i found this 22:55:03 they're used to check all sorts of error cases and validate program state 22:56:29 advil, switch__: https://stackoverflow.com/q/41720989/625403 22:56:43 yeah, I just saw that one 22:57:12 it can get cast to a pointer if there's no capture, which casts to bool 22:58:05 just not in msvc 22:59:29 this reminds me, even though it's not really related 22:59:37 is PURE next to a function a GCC optimization thing? 23:00:17 not talking a virtual method or even any kind of method at all, but just a function 23:00:35 it declares that the function has no side effects and its return value only depends on its inputs 23:00:46 AppHdr.h:# define PURE __attribute__ ((pure)) 23:01:14 and yes, it's basically an optimization 23:02:12 doh! 23:02:15 thanks for that, geekosaur 23:02:27 I was getting confused since the GCC docs were using pure only 23:02:32 didn't realize it was a macro 23:02:44 well they were using lower-case pure 23:03:22 yeh, this is so it can be conditionalized to be empty for non-gcc 23:03:34 when looking around i saw a commit where some memelord added PURE and VERYPURE to a bunch of stuff 23:03:35 yeah, i think macros like PURE are a holdover from before the __attribute__ stuff was formalized/standardized 23:03:58 i think these were explicitly illegal 23:04:00 let me try to find why 23:08:00 https://i.imgur.com/aAOML3V.png 23:09:05 along with https://i.imgur.com/pt0m1x7.png 23:27:54 03advil02 07* 0.23-a0-370-gf497b7c: Improve (?) filtered_vector_select 10(4 minutes ago, 1 file, 8+ 7-) 13https://github.com/crawl/crawl/commit/f497b7cc9947 23:29:25 works for me 23:30:21 it's just a bit annoying that it won't deduce M 23:32:20 alexjurkiewicz: ok I've fixed the crash 23:33:20 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-377-g4eaae10: fixup! Reveal all traps 10(12 minutes ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/4eaae107713d 23:33:20 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-378-g006f29a: fixup! Exploration based trap effects. 10(11 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/006f29a9818b 23:33:20 03ebering02 07https://github.com/crawl/crawl/pull/872 * 0.23-a0-379-gb89b1dd: Lowercase a trap name in a des 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b89b1ddd7799 23:39:40 switch__: I'll look more at this tomorrow but aside from the indentation and the VLA this looks pretty straightforward to merge soon 23:40:09 neat 23:41:26 you could also revise INSTALL.txt 23:42:27 and record whatever caveats about contribs there are 23:43:21 sure, i can do that 23:43:27 i still have to finish getting x64 to work 23:43:33 but after that i'll tidy it all up 23:51:19 ebering: does fixup! have special meaning, or just a reminder for you to sqash on merge 23:53:49 alexjurkiewicz: if you pass --autosquash to rebase it will set it up for your 23:55:55 :O more secret git features