00:10:40 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-275-g0cf4261408 (34) 00:43:29 The build passed. (master - 0cf4261 #10334 : Edgar A. Bering IV): https://travis-ci.org/crawl/crawl/builds/435948282 01:01:24 someone opened a bug with static analysis output. Seems like a few small code smell things and a lot of things which are just how crawl code style is 01:01:40 but maybe a good excuse to re-open discussions around clang-format ;) 01:03:02 Guardian Golem clouds don't dissipate when leaving LOS 13https://crawl.develz.org/mantis/view.php?id=11701 by CanOfWorms 02:05:57 here's a google sheet of it https://docs.google.com/spreadsheets/d/1NZ3bLtFAO-wUapF8WgWn7QbgAeB_a1h6-4q0IiYf5qE 03:12:05 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-275-g0cf4261 (34) 04:29:09 New branch created: pull/855 (1 commit) 13https://github.com/crawl/crawl/pull/855 04:29:09 03ImmatureCunningCoon02 07https://github.com/crawl/crawl/pull/855 * 0.23-a0-276-g63bf6a9: Changed some dead links to relative 10(11 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/63bf6a94db24 04:55:33 03ICC02 07https://github.com/crawl/crawl/pull/855 * 0.23-a0-276-g3a5a518: Changed some dead links to relative 10(7 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/3a5a518b642f 05:44:02 -!- amalloy is now known as amalloy_ 06:53:37 hey guys, I don't know if this was discussed yet, but does it seem interesting to you to display potential spell damage in spell description (scaled to caster's spellpower)? Seems logical after the excellent to-dam display in trunk 07:07:34 -!- amalloy_ is now known as amalloy 09:03:56 -!- amalloy is now known as amalloy_ 09:10:47 "The expression is excessive or contains a misprint." 09:11:12 the fact that there's only one of these makes me worried about the analyzer, tbh 09:12:56 crawlcode vs static analyzers 10:24:01 %git 3a5a518b 10:24:01 07ICC02 * 0.23-a0-276-g3a5a518: Changed some dead links to relative 10(6 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/3a5a518b642f 10:24:43 I *think* the username is cleaned up there; it seems to be someone who is not a native speaker of English based on their new github username 11:08:39 yeah, likely a misunderstanding as that phrase shows up in contexts that aren't attempting to be racist, but it's good to not have a username like that in the commit history; thanks advil 11:09:55 advil: did you happen to see that contributer's guide branch I made, by the way 11:10:17 I should just merge it probably, need to make some final edits 11:32:51 yes, the username is cleaned up there in all fields (it's not just github display) 11:41:31 gammafunk yeah, sorry, I just haven't had a chance to look at it 11:42:22 no problem, I'll make my edits and merge if I have time today, then anyone can modify from there 11:51:25 03advil02 07* 0.23-a0-276-gb44a8d1: Fix disaster area adjacency check 10(9 minutes ago, 1 file, 8+ 7-) 13https://github.com/crawl/crawl/commit/b44a8d19cf35 12:10:00 03advil02 {GitHub} 07[contribguide] * 0.23-a0-210-ga67b3ec: Various wording tweaks, typo fixes 10(7 seconds ago, 1 file, 24+ 16-) 13https://github.com/crawl/crawl/commit/a67b3ec2554f 12:10:28 gammafunk: don't forget to delete the .txt version from the repo when you merge 12:10:36 will do 12:10:41 well, I guess I could do it ;-) 12:10:42 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-276-gb44a8d19cf (34) 12:13:19 the "My contribution made it into the game! What can I expect?" could be incorporated 12:13:26 seems useful 12:13:50 look like you got everything else from the .txt version? 12:18:50 03advil02 07* 0.23-a0-277-ga4718cd: Exclude bones from checkwhite and run it 10(2 minutes ago, 8 files, 17+ 16-) 13https://github.com/crawl/crawl/commit/a4718cdc7d3a 12:19:10 I'll have to check honestly, those edits were made months ago 12:22:06 that section does seem useful, yeah 12:22:49 looks like we can also linkify and inline that url to the ##crawl-dev web archives 13:09:21 03ICC02 {ebering} 07* 0.23-a0-278-g5ee874d: Change some dead links to relative links in new_dev_guidelines.md 10(8 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/5ee874de492e 13:10:42 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-277-ga4718cdc7d (34) 13:28:48 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-277-ga4718cd (34) 13:33:14 03advil02 07* 0.23-a0-279-g95cc579: Fix a bad bitwise calculation for ban_glyph in arena 10(4 minutes ago, 1 file, 7+ 9-) 13https://github.com/crawl/crawl/commit/95cc57954e75 13:33:28 this static code checker actually seems to have found stuff, last time someone ran one of these it was utterly useless 13:33:47 !source caction_compound 13:33:47 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/chardump.cc#L1143 13:36:06 the bitwise math there is kind of weird, but I'm not really sure what it's even doing 13:37:43 why is it shifting an explicitly signed value? 13:45:38 anybody here? 13:45:38 lobf: You have 1 message. Use !messages to read it. 13:45:44 !messages 13:45:44 (1/1) alexjurkiewicz said (14h 37m 38s ago): try `make TILE=y` without the other stuff 14:10:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-279-g95cc57954e (34) 14:21:44 -!- amalloy_ is now known as amalloy 14:22:44 The build has errored. (contribguide - a67b3ec #10338 : Kyle Rawlins): https://travis-ci.org/crawl/crawl/builds/436221634 14:54:07 broke crawl compilation by editing the contrib guide, shame 15:14:48 The build passed. (master - 95cc579 #10341 : advil): https://travis-ci.org/crawl/crawl/builds/436259466 15:26:06 lobf: alexjurkiewicz presumably meant `TILES=y` not `TILE=y` 15:39:32 -!- ProzacElf_ is now known as ProzacElf 15:45:36 03advil02 07* 0.23-a0-280-g91074bd: Fix two iterators becoming invalidated during iteration 10(3 minutes ago, 1 file, 7+ 4-) 13https://github.com/crawl/crawl/commit/91074bd14959 15:48:28 03advil02 07* 0.23-a0-281-gfe727ee: Fix an uninitialized variable 10(41 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fe727ee8d20f 15:49:00 advil tearin up the static analysis report 15:49:16 yeah, there's plenty of stuff in here 15:59:46 03advil02 07* 0.23-a0-282-g643b770: Ensure fsim file always gets closed 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/643b770f2874 16:10:41 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-282-g643b770f28 (34) 16:51:55 03advil02 07* 0.23-a0-283-g9a040af: Remove some vacuous ASSERTs 10(42 minutes ago, 2 files, 0+ 4-) 13https://github.com/crawl/crawl/commit/9a040af8fa0f 16:51:55 03advil02 07* 0.23-a0-284-gdacbca0: Change a + to a += 10(13 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/dacbca085580 16:51:55 03advil02 07* 0.23-a0-285-g51c88b6: Some extra pointer checks 10(7 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/51c88b696837 16:51:55 03advil02 07* 0.23-a0-286-gcae3914: Add a pointer check 10(2 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/cae391489210 17:10:41 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-286-gcae3914892 (34) 18:03:37 -!- KurzedMetal__ is now known as KurzedMetal 18:22:25 Unstable branch on underhound.eu updated to: 0.23-a0-286-gcae3914892 (34) 18:45:37 nice stuff 18:48:59 The build passed. (master - cae3914 #10345 : advil): https://travis-ci.org/crawl/crawl/builds/436346300 19:17:51 biggest annoying part of github UI: commmit messages wrap slightly before 78 chars, so they wrap poorly 19:18:00 i think the UI actually wraps them at 72 or something 20:25:44 72 is the recommended width 20:28:33 that is, anyway, a common recommendation from places like https://chris.beams.io/posts/git-commit/ - i don't know whether crawl has any specific style guide for commit messages that differ from the norm 20:34:18 oh heh, I have a minimum font size override in chrome. That explains it! 21:00:58 I thought we required 72 21:01:10 that is what people made me do before I was a dev, at least 21:05:11 technically git doesn't care. in practice, various display-related things behave poorly if you exceed 72 for the body and something shorter for the first line. 22:11:11 03advil02 07* 0.23-a0-287-g55accd5: Fix a redundant feature on Sonja 10(59 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/55accd554fc1 22:11:11 03advil02 07* 0.23-a0-288-gc497677: Fix several minor pointer issues 10(49 minutes ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/c497677b45f7 22:11:11 03advil02 07* 0.23-a0-289-g0b44af7: Comment a few weird things 10(35 minutes ago, 2 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/0b44af716b83 22:11:11 03advil02 07* 0.23-a0-290-g290e36d: Various beam.cc cleanups 10(58 seconds ago, 1 file, 7+ 11-) 13https://github.com/crawl/crawl/commit/290e36dc6fa1 23:10:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-290-g290e36dc6f (34)