00:16:34 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.23-a0-4-g8f018a2 (34) 01:11:17 The build passed. (stone_soup-0.22 - 27d7cf4 #10046 : advil): https://travis-ci.org/crawl/crawl/builds/410134212 02:33:16 <+gammafunk> stone_soup-0.22 branch is ready with a 0.22-b1 tag, and trunk is now tagged as 0.23-a0 <-- woo! 02:35:14 Sphara (L19 MiBe) ERROR in 'mon-util.cc' at line 1956: bogus mc (no monster data): invalid monster_type 1000 (1000) (Snake:2) 02:36:18 my make command includes `EXTERNAL_FLAGS_L="-g" STRIP="true"` -- does this make sense? 02:36:34 oh yes it does, STRIP=true means "don't strip", doesn't it 02:38:16 right, it means run true instead of strip 03:02:46 every time players find the bug with death channel (where a spectre gets created in the middle of resolving a fireball and then the fireball hits it), they find it via ignition, and think it's a bug with ignition and blame it on me :( 03:04:10 0.22-b1 is on CPO 03:17:48 Unstable branch on crawl.beRotato.org updated to: 0.23-a0-4-g8f018a2 (34) 04:32:08 -!- amalloy is now known as amalloy_ 05:29:07 aidanh: is it a known bug that Wu Jian abilities have no icon? 06:17:19 known to me, at least 06:18:14 I thought it was just wall jump that's missing an icon though 06:19:22 I might cobble together a frankentile from the hop tile and whatever else I can find 07:29:28 advil: hm. can that crash happen if a monster is cleaving with an axe and dies mid cleave? 08:35:00 ebering probably, that was more or less amalloy's theory too. I noticed that the cleave function didn't previously assume it was called with a live monster. the is_player() check is safe in that case 08:44:39 !lm Sphara x=src 08:44:47 32134. [2018-07-31 09:29:38] [src=cue] Sphara the Executioner (L27 MiBe of Trog) found the Orb of Zot! (Zot:5) 09:19:03 advil: doing several tests it seems like it does not 09:19:39 since the cleave loop checks if the attacker issstill alive after each cleaved attack 09:20:40 the crash that I looked at was a headbutt death on the monster's turn 09:20:44 the crash was on the weapon() call 09:20:58 not during that while loop 09:22:28 yes. I mean that, if a cleaving monster dies while attacking the player with an axe and subsequent cleave attacaks still to be processed, the game does not crash because of the test in the while loop. I agree that the weapon() call is the problem 09:22:52 Just that it seems likcalling weapon on a dead monster should return nullptr, not crash 09:57:45 yeah, possibly, or the cleave call should be prevented earlier 09:58:16 though in general many things aren't safe on non-valid monsters 09:59:14 in handle_phase_end 10:00:04 *in handle_phase_end would be a potential place to check attacker validity 10:18:58 should we do another 0.21 stable release? I guess we don't really bother at this point? 10:25:57 advil: in the past we have done those when releasing the new stable 10:26:11 but not consistently 10:26:30 if there are enough fixes since last 0.21 it could be worth 10:26:32 might be nice to do something with fixes for a few nasty bugs at least 10:26:36 %git stone_soup-0.21 10:26:36 07advil02 * 0.21.1-1-g345015f: Don't crash if Duvessa dies when Dowan is polymorphed 10(6 months ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/345015fe6438 10:26:36 like the beogh thing 10:26:52 hrm, well we have only one commit in the branch since 0.21.1 10:27:07 yeah someone would need to do some cherry-picking 10:27:15 I can take a look in the next few days 10:27:31 there's extra work in building a release, but that's fairly well automated for me now 10:27:38 and I can just sort of do it as I have time during tourney 10:27:44 you would also need to do the os x build, of course 10:27:49 yeah that's fine 10:28:07 oh, and how will the timing be fore you for 0.22 itself, in terms of os x build? 10:28:24 probably I'd try for release on the 9th, maybe the 8th if timing worked for me 10:28:36 that works for me 10:28:50 ok, great, I'll let you know of course when 0.22.0 is tagged 10:29:14 I'm a bit busy that weekend with some visiting family but it doesn't take much time to do the release build 10:30:35 I should test out your fixes for sdl2 at some point soon 10:30:43 when I did a windows cross-compile build with mingw 10:30:51 it failed in sdl2 like it had been under msys2 10:30:59 oh interesting 10:31:01 I've had a few people test them on windows, but yeah it should be tested for cross-compile 10:31:17 so I had to tweak the GCC defines like how you had said back when I asked and it compiled fine 10:31:23 but hopefully now it just works without that 10:31:52 neunon was emailing me about this stuff actually, was trying to help a coworker build on windows 10:32:09 he said that the fix worked for him 10:35:56 I should go just try in my 0.22 beta branch right now 10:40:15 idea: for ghouls maybe modify the HUD to display how many chunks are in inventory 10:40:29 someone just asked me if there's a way to autoquiver chunks so they don't have to check 10:40:40 good idea 10:42:23 I don't see how to do it without adding a line though 10:43:57 There's some free space to the right of AC/EV/SH, ugly but practical? 10:44:53 that's a bit complicated because some of that space (for AC specifically) is used in wizmode 10:45:32 to the right of piety might be possible, one or two god names might need to be slightly chopped 10:46:09 iirc kiku is the longest one as written there? 10:46:34 or nem, but we could cut one of his names 10:47:05 at some point when working on the hud I'd calculated the longest species/god combo but I can't remember it now 10:48:16 oh, it's mottled draconian of TSO 10:48:32 but most of that length is in the species name 10:49:00 Ha, thought I _was_ in wizmode. The EV/SH space isn't occupied, or (not to be Capt Obvious) to the right of stats? 11:06:38 Windows Trunk downloads 1 week old on http://crawl.develz.org/trunk/ [^] 13https://crawl.develz.org/mantis/view.php?id=11574 by RoGGa 11:14:47 advil: hrm, I got a permission denied for your test script 11:14:58 does it not have execute permission set? 11:15:04 huh, that's odd 11:15:22 well, I guess it makes sense since windows doesn't have permissions in the same way 11:15:36 but it should have been run by travis etc 11:15:43 well the file doesn't have execute permissions set 11:15:55 yeah I guess this might not happen somehow in msys2 11:16:05 it shouldn't be run directly I thought 11:16:20 appears to have been when I did cross-compile 11:16:37 make CROSSHOST=i686-w64-mingw32 package-windows-zips 11:16:37 shoudl I cherry pick the shock serpent relec fix? 11:16:42 yes 11:18:19 anything that fixes unintended gameplay is generally ok to cherry pick, but I guess by unintended I mean and actual bug or omission 11:18:45 just in terms of how we've handled point releases in the past 11:18:55 maybe I can just set the permission bit and then push that to the submodule 11:18:58 hmm 11:19:29 yeah the makefile is definitely using $(shell ./text_xinput.sh) 11:19:41 so that would need execute permissions to work as it's going through a shell 11:25:21 03Aidan Holm02 07* 0.23-a0-5-gbf19839: Add wall jump tile 10(2 hours ago, 3 files, 3+ 0-) 13https://github.com/crawl/crawl/commit/bf19839e8a81 11:25:21 03Aidan Holm02 07* 0.23-a0-6-g5b5cf6b: Improve default menu more text (fakechuck, #11563) 10(2 hours ago, 2 files, 43+ 16-) 13https://github.com/crawl/crawl/commit/5b5cf6b3f367 11:26:55 I've pushed a fix to the submodule now I need to remind myself about updating the submodule 11:26:58 don't tell me, I'll figure it out 11:27:04 heh 11:27:05 thanks 11:32:56 03gammafunk02 07* 0.23-a0-7-g557ef7e: Fix sdl2 contrib compilation for Linux cross-compiling to Windows. 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/557ef7ec2e4a 11:35:48 yay, looks like it got through contribs and is compiling 11:35:59 great, thanks for testing 11:39:46 I'm about to push some stuff to 0.21, but not done yet -- only up to jun 1 11:39:52 I'll work on it more later 11:40:15 I've probably missed things, anything UI-related in this cycle gets hard to figure out quickly 11:43:47 I had to do something like git --pretty="%an: %s" ..HEAD | grep -v Aidan 11:43:58 just to be able to read the list of changes from last changelog update 11:45:07 his commit storm too strong and I was afraid I'd miss some significant gameplay thing nestled in all his UI commits 11:45:33 s/git --pretty/git log --pretty/ 11:46:32 03advil02 07[stone_soup-0.21] * 0.21.1-2-g20f1ec3: If there's no assert message on crash, put signal into the noun 10(6 months ago, 3 files, 17+ 11-) 13https://github.com/crawl/crawl/commit/20f1ec344e20 11:46:32 03advil02 07[stone_soup-0.21] * 0.21.1-3-g24a485b: Show >0 skill message (if needed) when entering skill menu (dds1) 10(6 months ago, 2 files, 26+ 15-) 13https://github.com/crawl/crawl/commit/24a485bbd44a 11:46:32 03advil02 07[stone_soup-0.21] * 0.21.1-4-g53e4fd6: Have shock serpent retaliation check rElec 10(6 months ago, 1 file, 8+ 5-) 13https://github.com/crawl/crawl/commit/53e4fd664e05 11:46:32 03amalloy02 {advil} 07[stone_soup-0.21] * 0.21.1-5-gab5db52: Make Duvessa and Dowan react the same to killing each other 10(7 months ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ab5db520c840 11:46:32 03amalloy02 {advil} 07[stone_soup-0.21] * 0.21.1-6-gd9ae509: Fix Dowan's reaction to Duvessa dying far away (minmay) 10(6 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d9ae50934656 11:46:32 03MarvinPA02 {advil} 07[stone_soup-0.21] * 0.21.1-7-g900f829: Fix bloodless Vampires having their accuracy penalised 10(5 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/900f8294dd10 11:46:32 03MarvinPA02 {advil} 07[stone_soup-0.21] * 0.21.1-8-gc72a899: Note the effect of Invo skill in Nemelex description (#11393) 10(5 months ago, 1 file, 5+ 4-) 13https://github.com/crawl/crawl/commit/c72a8991ac1d 11:46:32 03MarvinPA02 {advil} 07[stone_soup-0.21] * 0.21.1-9-g7fc3f39: Don't mark cloud spells as permanently useless under Still Winds 10(5 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7fc3f399ea1a 11:46:32 03MarvinPA02 {advil} 07[stone_soup-0.21] * 0.21.1-10-g86db44f: Mark PoG only temporarily useless when in Zot but without the orb (|amethyst) 10(5 months ago, 3 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/86db44f4b3af 11:46:32 03gammafunk02 {advil} 07[stone_soup-0.21] * 0.21.1-11-g0895a4c: Prevent monsters from picking up a loot item in a vault 10(5 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0895a4c8dcf0 11:46:32 ... and 24 more commits 11:46:38 ok, commit storm on its way 11:48:51 advil: if you feel like it after you're done cherry-picking, feel free to write the 0.21.2 changelog entry (we usually emphasize bugfixes in those, you can see previous examples) 11:48:58 if not I can do at some point 11:49:13 there are usually only a few very significant ones from a player perspective 12:09:54 Stable (0.21) branch on crawl.jorgrun.rocks updated to: 0.21.1-35-gfefc1aa2bb 12:20:01 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-7-g557ef7ec2e (34) 12:21:59 Stable (0.21) branch on underhound.eu updated to: 0.21.1-35-gfefc1aa2bb 12:28:57 "your damage is reflected back at you" after monster has died (with BVC) 13https://crawl.develz.org/mantis/view.php?id=11575 by TAS2012 13:07:01 -!- amalloy_ is now known as amalloy 13:30:39 Unstable branch on crawl.akrasiac.org updated to: 0.23-a0-7-g557ef7e (34) 14:20:19 -!- Fixer_ is now known as Fixer 15:37:36 -!- Bammboobies is now known as Bammboo 16:19:20 -!- turin is now known as thurin 17:01:28 03Nikolai Lavsky02 {advil} 07[stone_soup-0.21] * 0.21.1-36-gf199cdc: Fix Injury Bond description 10(8 weeks ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/f199cdc39728 17:01:28 03advil02 07[stone_soup-0.21] * 0.21.1-37-g10e4ace: Fix (un)woken_rest.rc 10(8 weeks ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/10e4ace1482d 17:01:28 03Nikolai Lavsky02 {advil} 07[stone_soup-0.21] * 0.21.1-38-g3eddebe: Make Iron Giants and other Throw Ally users obey Sanctuary 10(8 weeks ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3eddebe8979e 17:01:28 03advil02 07[stone_soup-0.21] * 0.21.1-39-gb2f560a: Let ArmourOffDelay be invalidated for undefined items (11494) 10(7 weeks ago, 2 files, 7+ 0-) 13https://github.com/crawl/crawl/commit/b2f560a357c9 17:01:28 03advil02 07[stone_soup-0.21] * 0.21.1-40-gb5911f1: Don't assume elemental force placement doesn't change clouds 10(7 weeks ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/b5911f15acd0 17:01:28 03advil02 07[stone_soup-0.21] * 0.21.1-41-g99ad7da: Don't overwrite opaque clouds with non-opaque clouds 10(7 weeks ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/99ad7daf1aa6 17:01:28 03advil02 07[stone_soup-0.21] * 0.21.1-42-g51be1da: Set player as summoner for elemental force 10(7 weeks ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/51be1dacfc3b 17:01:28 03Alcon02 {advil} 07[stone_soup-0.21] * 0.21.1-43-g104816b: Fix a crash when blinking away a cleaving attacker (amalloy, #718) 10(5 weeks ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/104816b462ba 17:01:28 03ebering02 {advil} 07[stone_soup-0.21] * 0.21.1-44-gc8722a8: Fix bug 11478: Movement-key actions and Wu Jian 10(8 weeks ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/c8722a8b1439 17:01:28 03MarvinPA02 {advil} 07[stone_soup-0.21] * 0.21.1-45-g5a665bb: Don't make ancient zymes sicken friendlies (#10769) 10(5 weeks ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/5a665bbca426 17:01:28 ... and 22 more commits 17:05:30 03advil02 07[stone_soup-0.21] * 0.21.1-68-g103a7af: Update changelog for 0.21.2 10(53 seconds ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/103a7afc0ae4 17:06:31 03advil02 07* 0.23-a0-8-gb809bb7: Update changelog for 0.21.2 10(24 seconds ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/b809bb70e428 17:09:38 I'm done cherry-picking, though if anyone spots something I missed, let me know (and I'll be impressed at your patience) 18:09:56 Stable (0.21) branch on crawl.jorgrun.rocks updated to: 0.21.1-68-g103a7afc0a 18:20:09 Unstable branch on crawl.jorgrun.rocks updated to: 0.23-a0-8-gb809bb70e4 (34) 18:21:31 Unstable branch on underhound.eu updated to: 0.23-a0-8-gb809bb70e4 (34) 19:38:22 aidanh: top art re: wall jump 20:38:14 -!- amalloy is now known as amalloy_ 20:45:00 alexjurkiewicz: thanks! it turned out surprisingly ok 21:18:22 -!- amalloy_ is now known as amalloy 22:09:55 -!- flappity_ is now known as flappity 23:28:12 Spacebar press is registered twice on aptitude table screen 13https://crawl.develz.org/mantis/view.php?id=11576 by thmsdrew