00:00:28 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-757-gdba82d8 (34) 01:27:42 Unstable branch on crawl.develz.org updated to: 0.22-a0-757-gdba82d8 (34) 01:46:13 Crash when all skill targets met 13https://crawl.develz.org/mantis/view.php?id=11527 by kitchen_ace 01:58:30 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-757-gdba82d8 02:58:27 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-757-gdba82d8 03:14:07 gammafunk: I have a DES question. I want to create a guarded unrand vault that can place any of the robe unrands. How do I write lua to randomly pick from only non-generated robes? https://gist.github.com/alexjurkiewicz/f29403849204d8b8501bab90fdb45301 03:18:03 alexjurkiewicz: just put them into a lua array, iterate testing using someting like for _,name in ipairs(robe_unrads) do if not you.unrands(name) then avail_unrands[#avail_unrands + 1] = name end 03:18:43 then final iteration over avail_unrands to assemble an item string joined by " / " to pass to item() as you've done there in DES 03:22:29 the comma syntax, does that work for items? 03:22:52 if it does, that'd be a much simpler way 03:23:02 ah, no 03:23:12 that's used for multiple items on the same square 03:23:29 so you'd really have to use lua and develop an array of viable ones 05:15:41 -!- amalloy is now known as amalloy_ 06:36:55 After leaving Overview screen, game screen is not redrawn 13https://crawl.develz.org/mantis/view.php?id=11528 by TAS2012 06:42:12 Version screen displays markup tags 13https://crawl.develz.org/mantis/view.php?id=11529 by TAS2012 07:03:21 Player has to guess how to interact with the Altar screen 13https://crawl.develz.org/mantis/view.php?id=11530 by TAS2012 07:30:38 -!- HoloIRCUser2 is now known as tminei 09:07:17 03Aidan Holm02 07* 0.22-a0-758-g2141c5b: Redraw screen when closing last popup 10(11 hours ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/2141c5b775c9 09:07:17 03Aidan Holm02 07* 0.22-a0-759-gca69a669: Revert "Add item/spell/ability menu adjust mode" 10(2 hours ago, 10 files, 116+ 189-) 13https://github.com/crawl/crawl/commit/ca69a669c744 09:07:17 03Aidan Holm02 07* 0.22-a0-760-g7e4a324: Fix version UI printing formatting tags (TAS2012, #11529) 10(52 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7e4a32469d28 09:07:17 03Aidan Holm02 07* 0.22-a0-761-g6240e6a: Make altar UI more user-friendly (TAS2012, #11530) 10(23 minutes ago, 3 files, 25+ 6-) 13https://github.com/crawl/crawl/commit/6240e6a4ab1f 09:09:07 !tell gammafunk I don't think in the end that johnstein had to do anything much to merge webtiles chat changes. scroller.js is from the ui patch, I think 09:09:08 advil: OK, I'll let gammafunk know. 09:09:26 not really sure how there could be a merge message on that file 09:09:50 maybe it somehow relates to cbro having an experimental version of the ui overhaul branch? 09:10:10 but I would've thought that anything in game_data would be fine 09:46:35 03advil02 07* 0.22-a0-762-gf02a501: Fix potions of experience 10(4 minutes ago, 3 files, 20+ 1-) 13https://github.com/crawl/crawl/commit/f02a5016e20a 09:52:09 ohh, nice 09:57:22 aidanh: 1015d742ccf4e seems to have dropped `.hidden` from static style.css, which is why the text input div is showing in the lobby 09:57:25 can I just add it back? 09:57:29 %git 1015d742ccf4e 09:57:29 07Aidan Holm02 * 0.22-a0-620-g1015d74: Revert "Add static files for CBRO ui-overhaul experimental" 10(4 weeks ago, 7 files, 2+ 319-) 13https://github.com/crawl/crawl/commit/1015d742ccf4 09:57:53 ah, drat; yeah sure 09:58:22 I'll just add the exact definition, haven't looked carefully at anything else in there besides .hidden 10:01:52 03advil02 07* 0.22-a0-763-g783f74d: Add back in .hidden to static style.css 10(59 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/783f74d721d6 10:02:04 that's the only unintentional deletion in that commit; the rest is all stuff that was moved into game_data 10:02:04 ah ok 10:02:11 not really sure if .templates is used for anything 10:02:55 or why it's !important 10:05:48 it's used for html UI templates that are cloned and then modified before being shown 10:06:06 !source webserver/game_data/templates/game.html:156 10:06:07 https://github.com/crawl/crawl/blob/master/crawl-ref/source/webserver/game_data/templates/game.html#L156 10:07:22 To drop specific quantity, Ctrl-Shift + left-click no longer works 13https://crawl.develz.org/mantis/view.php?id=11531 by RoGGa 10:07:22 .templates is !important presumably because it was added onto .hidden, and that's important because by itself .hidden is not very specific 10:09:27 who knew that existed 10:10:17 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-762-gf02a5016e2 (34) 11:10:15 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-763-g783f74d721 (34) 11:40:28 eyesofgods1 (L22 DsGl) Crash caused by signal #15: Terminated (Crypt:2) 11:44:49 eyesofgods1 (L22 DsGl) Crash caused by signal #15: Terminated (Crypt:2) 12:11:52 03Aidan Holm02 07* 0.22-a0-764-g8b9a6d0: Align webtiles UI popups to centre-top 10(2 minutes ago, 1 file, 8+ 3-) 13https://github.com/crawl/crawl/commit/8b9a6d00eb26 12:11:52 03Aidan Holm02 07* 0.22-a0-765-g5224685: Adjust webtiles mutations UI popup 10(34 seconds ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/5224685f51f0 12:13:42 !tell gammafunk moved webtiles menus to the top in 8b9a6d0; if you have any other design feedback let me know, I'm all ears 12:13:43 aidanh: OK, I'll let gammafunk know. 12:29:40 !crashlog eyesofgods1 12:29:41 2. eyesofgods1, XL22 DsGl, T:51300 (milestone): https://crawl.xtahua.com/crawl/morgue/eyesofgods1/crash-eyesofgods1-20180716-154449.txt 12:48:31 -!- amalloy_ is now known as amalloy 12:48:38 !source hash.cc:40 12:48:38 https://github.com/crawl/crawl/blob/master/crawl-ref/source/hash.cc#L40 12:49:31 this switch seems dodgy, right? doesn't it guarantee memory access outside data? 12:50:05 well, unless len % 4 is 0, which it is in this case I think, but still 12:51:16 oh, nm, I think it's ok 12:51:30 I'd missed that d is casted to uint8_t* 13:10:22 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-765-g5224685f51 (34) 13:19:00 advil: i think if d were void* it would still be correct, since void* behaves like char* in terms of indexing/size stuff 13:19:15 although i guess d[2] is just an error in that case 13:19:50 it wouldn't read beyond the end of the buffer, anyway 13:26:05 New branch created: pull/819 (9 commits) 13https://github.com/crawl/crawl/pull/819 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1803-ga5271e9: AF_STICKY_FLAME deals fire damage in addition to sticky flame. 10(3 years, 8 months ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/a5271e945180 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1804-g4f72cf5: Add anti-magic effect to dispelling bolts. 10(3 years, 8 months ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/4f72cf5b6837 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1805-g2960584: Don't let hostile dispels remove contam from the player. 10(3 years, 8 months ago, 3 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/296058425288 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1806-gcdc8e28: Purple ugly things are antimagic ugly things. 10(3 years, 8 months ago, 8 files, 37+ 2-) 13https://github.com/crawl/crawl/commit/cdc8e282f9cb 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1807-g614b67e: Blue ugly things (theTower). 10(3 years, 8 months ago, 3 files, 44+ 32-) 13https://github.com/crawl/crawl/commit/614b67ea3cf5 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1808-gf90ee38: M_GLOWS_RADIATION blocks contam dissipation for nearby players. 10(3 years, 8 months ago, 14 files, 70+ 3-) 13https://github.com/crawl/crawl/commit/f90ee38895f9 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1809-gdcc6f0c: Let monsters cast Irradiate. 10(3 years, 8 months ago, 2 files, 82+ 17-) 13https://github.com/crawl/crawl/commit/dcc6f0c4e20c 13:26:05 03Grunt02 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1810-g6609cd9: Extremely ugly things! 10(3 years, 8 months ago, 18 files, 100+ 55-) 13https://github.com/crawl/crawl/commit/6609cd94d0ea 13:26:05 03Pekkekke02 {GitHub} 07https://github.com/crawl/crawl/pull/819 * 0.16-a0-1811-g5a7dabb: Update religion.cc 10(11 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5a7dabb17373 13:26:08 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-765-g5224685 (34) 13:29:06 personally i'm a little more annoyed there's no explicit default case in that switch 13:37:22 ah I see 13:43:33 !source level_id 13:43:33 1/3. https://github.com/crawl/crawl/blob/master/crawl-ref/source/externs.h#L411 13:43:44 oh, right. github is having a bad day 13:44:21 yeah 13:44:36 annoying because I was just looking to see if we should update that hash algorithm 13:44:43 I wish I had a save for this crash 13:45:19 cpp standard guarantees that sizeof(uint32_t) = sizeof(int32_t), right? 13:47:44 https://en.cppreference.com/w/cpp/types/integer 13:48:17 and we are indeed using the ones from cstdint, rather than some weird homebrew, so that should indeed be guaranteed 13:49:43 these crashlogs do make it look like it's crashing in hash_rand 13:50:57 this religion.cc PR about jiyva is a funny one 13:51:14 it fixes the documentation without noticing that the documentation correctly describes the current incorrect behaviour 13:53:41 advil: that is weird. the obvious error case is x=0, but that should be handled 13:54:08 the first thing i'd fix is to just use sizeof(data) instead of 2 * sizeof(int32_t) 13:54:28 then you're not only safe against different sizes but also don't have this dangling 2 lying around 13:54:35 yeah, and I would've thought that wouldn't happen in that function 13:54:38 or...er...that doesn't work for arrays 13:54:43 does it? i forget 13:54:48 I think it does? 13:54:54 yes, this sizeof thing is dumb 13:55:03 yes, it does. i was getting confused about ARRAYSZ 13:55:15 apparently that hash algorithm has a big bug under some circumstances, https://github.com/aappleby/smhasher/wiki/MurmurHash2Flaw 13:56:54 advil: does that bug matter to us? a hash collision is not a big deal in our uses, i'd think 13:57:08 no, it probably doesn't 13:57:18 I don't think this is ever used for hashing anything very complicated 13:57:23 or persistant for that matter 13:58:16 well, tile appearances I think 14:01:32 03advil02 07* 0.22-a0-766-g08e7145: Clean up some messy but harmless code (amalloy) 10(85 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/08e7145bed06 14:06:24 oh hm maybe this problem is simpler than I was thinking 14:08:52 the reporter already figured it out 14:09:20 advil: i didn't see the report. what's the answer? 14:09:52 %git 0f6634 14:09:52 07Aidan Holm02 * 0.22-a0-738-g0f66341: Only give ghosts pumpkin heads on Halloween 10(2 days ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/0f663418af6b 14:10:09 hash_rand in that loop is deterministic, so the loop never terminates 14:10:42 that's why it's signal 15 I guess 14:10:49 the fact that it was in hash_rand at the time is incidental 14:11:44 that's what we get for calling it rand 14:13:18 i wonder how this thing in religion.cc was supposed to work 14:13:45 it fires the DET_ENTERED_LEVEL event, hoping this will lower the walls in Slime:$, but as far as i can tell this does nothing 14:16:30 indeed there is nothing listening to DET_ENTERED_LEVEL 14:17:39 so if you get to ****** Jiyva piety while on slime:6, this will claim it has lowered the slime walls but actually won't, meaning it will never try again to lower the walls. but, good news: it's impossible to get to slime:6, so this never happens 14:20:15 unless you're running that infinite depth grunt patch >.> 14:22:11 maybe it's a trap for forks 14:22:29 didn't one of the forks just make abyss 27 levels deep or something? 14:23:46 what is the right way to look up the depth of a branch, or more specifically to tell whether the player is currently on the last floor of a branch 14:24:38 well, actually i have to go for a couple hours. i'll fix this when i have time 14:25:19 -!- amalloy is now known as amalloy_ 14:26:07 !lm place=slime:6 max=cv 14:26:08 No milestones for geekosaur (place=slime:6). 14:26:12 !lm * place=slime:6 max=cv 14:26:13 derp 14:27:12 130685. [2018-05-18 05:41:57] riowarren the Ninja (L24 SpAs of Gozag) reached level 6 of the Pits of Slime on turn 122661. (Slime:6) 14:27:41 right, suspect that's a leftover 14:28:12 right, suspect that's a leftover (and that game was a transferred save) 14:28:12 erl 14:28:26 * geekosaur perhaps should go back to bed; not making sense... 14:34:19 03advil02 07* 0.22-a0-767-gac240df: Fix pumpkin heads in a different way (11524 / Gorice) 10(15 minutes ago, 1 file, 7+ 4-) 13https://github.com/crawl/crawl/commit/ac240df97d60 14:34:19 03advil02 07* 0.22-a0-768-geab2209: Rename `hash_rand` 10(70 seconds ago, 7 files, 16+ 16-) 13https://github.com/crawl/crawl/commit/eab220982e44 15:07:39 I've confirmed that other people are also getting this spazzing out effect with the Crawl console client on the latest version of Crawl when manually compiled 15:08:30 as in this gif https://imgur.com/a/aJEcOny 15:09:09 this is on Windows 15:10:21 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-768-geab220982e (34) 15:10:37 I'm going to report it as a bug on Mantis so there is an easy place to track it 15:10:53 -!- pantaril_ is now known as pantaril 15:32:40 Console client flickers and does not load at all when manually compiled. 13https://crawl.develz.org/mantis/view.php?id=11532 by NormalPerson7 15:50:10 the abyss was actually 27 levels in the original iteration of the multi-level abyss 15:50:19 thankfully it was toned down a bit since 15:50:47 I gather Gooncrawl's going back to 27 15:51:08 ... oh, I've just made this conversation go full circle, sorry 16:27:13 Gorice (L20 DsWn) Crash caused by signal #15: Terminated (Shoals:2) 16:51:01 !crashlog 16:51:15 19776. Gorice, XL20 DsWn, T:39422 (milestone): https://crawl.xtahua.com/crawl/morgue/Gorice/crash-Gorice-20180716-202711.txt 16:51:36 ??rebuild 16:51:37 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug |amethyst or Nap.Kin for CDO. Use your powers wisely. 17:01:50 -!- amalloy_ is now known as amalloy 17:29:29 03amalloy02 07* 0.22-a0-769-g178e555: Make sure Jiyva opens Slime:$ for you if you reach ****** while there (Pekkekke) 10(9 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/178e55541d7c 17:56:42 Anyone know where the new level_id actually gets created when a new level is built? 17:58:17 level_id is purely a data class; you can create one representing any level at any time with no global state implications 17:58:42 what do you mean? in general level_ids are ephemeral afaict. they're basically just glorified tuples 17:59:09 Gah. So where _is_ permanent state about a level kept? (I see, for example, corruption leaves a thingy behind...) 18:00:06 that's also a pretty broad question. at a fairly coarse scope, the answer is "it is kept on disk when the player is not on the level" 18:00:12 do you have a more specific usage in mind? 18:00:40 there's you.depth and you.where_you_are 18:01:04 which is player tracking of the current level, but yeah like amalloy is saying what data you'd want would depend on the context 18:02:31 I'm trying to think how to express this. A property like Corruption, which changes infrequently (corruption is irrevocable, but it wouldn't have to be) 18:05:43 Would the easy way to do that be to use env.markers like Corruption does? 18:05:46 Pinkbeast: env.markers is the best place, yeah 18:05:57 Thanks. 18:06:43 env is a global that represents the currently loaded level 18:07:07 but corruption uses its own marker type, which if we were adding some kind of permanent level effect 18:07:11 we'd probably not introduce a new one 18:07:44 but if you wanted to follow that model, it would be the most natural way, to extend map_marker_type 18:10:08 That seems clear now, thanks both. 18:10:16 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-769-g178e55541d (34) 18:21:40 Unstable branch on underhound.eu updated to: 0.22-a0-769-g178e55541d (34) 19:07:50 Mgcat (L19 BaBe) Crash caused by signal #15: Terminated (D:8) 19:08:12 Mgcat (L19 BaBe) Crash caused by signal #15: Terminated (D:8) 19:08:45 Mgcat (L19 BaBe) Crash caused by signal #15: Terminated (D:8) 19:45:52 <+advil> didn't one of the forks just make abyss 27 levels deep or something? <-- x-crawl is about to, afaik 19:46:10 with one-way portals to zot as well, so an AK could theoretically win with zero runes 19:46:32 alexjurkiewicz: That's two forks, then 20:01:34 Cakaith (L17 HOMo) ERROR in 'dbg-scan.cc' at line 472: mid cache bogosity: no monster for 308 (Swamp:1) 20:01:54 Cakaith (L17 HOMo) ERROR in 'dbg-scan.cc' at line 472: mid cache bogosity: no monster for 308 (Swamp:1) 20:04:19 Cakaith (L17 HOMo) ERROR in 'dbg-scan.cc' at line 472: mid cache bogosity: no monster for 308 (Swamp:1) 20:16:14 -!- svendre_ is now known as svendre 20:18:05 TuffENuff (L27 FoFi) ASSERT(charge_iter == charges.end()) in 'evoke.cc' at line 559 failed. (Depths:4) 20:19:33 TuffENuff (L27 FoFi) ASSERT(charge_iter == charges.end()) in 'evoke.cc' at line 559 failed. (Depths:4) 20:52:23 Cakaith (L17 HOMo) ERROR in 'dbg-scan.cc' at line 472: mid cache bogosity: no monster for 308 (Swamp:1) 20:56:21 !lm Cakaith x=src 20:56:21 591. [2018-07-17 00:52:11] [src=cbro] Cakaith the Warrior (L17 HOMo of Beogh) ERROR in 'dbg-scan.cc' at line 472: mid cache bogosity: no monster for 308 (Swamp:1) 21:05:25 -!- amalloy is now known as amalloy_ 21:17:27 man 21:17:32 !crashlog 21:17:33 19786. Cakaith, XL17 HOMo, T:47599 (milestone): http://crawl.berotato.org/crawl/morgue/Cakaith/crash-Cakaith-20180717-005211.txt 21:17:55 !crashlog Mgcat 21:17:56 3. Mgcat, XL19 BaBe, T:34378 (milestone): https://crawl.xtahua.com/crawl/morgue/Mgcat/crash-Mgcat-20180716-230844.txt 21:18:54 !lm mgcat x=src 21:18:55 6469. [2018-07-17 00:32:48] [src=cxc] Mgcat the Executioner (L24 BaBe of Trog) reached level 5 of the Depths on turn 47317. (Depths:5) 21:22:02 !crashlog TuffENuff 21:22:03 2. TuffENuff, XL27 FoFi, T:44814 (milestone): http://crawl.akrasiac.org/rawdata/TuffENuff/crash-TuffENuff-20180717-001932.txt 21:23:14 huh, that stack trace seems unrelated to the printed assert 21:25:16 yeah that's a strange one 21:25:33 ah, I bet it's manual related though 21:25:51 that's before my fix for the skill menu bug so it might be an interaction of that bug and manuals 21:31:46 hm, good thing I looked at this, I think xp potions are still buggy 21:47:22 -!- amalloy_ is now known as amalloy 22:46:02 PKrockin (L13 DsFE) ERROR in 'menu.cc' at line 197: ASSERT failed: index of 4 out of range 0 (0) .. (int)m_menu->items.size() (0) (Lair:2) 23:25:57 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:34:32 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:35:03 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:37:09 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:37:30 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:37:52 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:38:43 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:38:51 !crashlog 23:38:52 19794. atomicknyte, XL14 GnWz, T:30160 (milestone): http://crawl.akrasiac.org/rawdata/atomicknyte/crash-atomicknyte-20180717-033841.txt 23:39:53 that same loop from the other day? 23:40:27 looks like the same stack trace, maybe cao doesn't have that fix yet? 23:40:30 we could rebuild if not 23:40:32 &versions 23:40:35 I'm rebuilding 23:40:39 oh, great 23:40:53 CAO: 0.22-a0-765-g5224685, CBRO: 0.22-a0-614-g34fbaa0, CDO: 0.22-a0-757-gdba82d8, CJR: 0.22-a0-769-g178e55541d, CPO: 0.22-a0-769-g178e555, CUE: 0.22-a0-769-g178e55541d, CWZ: 0.22-a0-422-g9628fc8, CXC: 0.22-a0-757-gdba82d8, LLD: 0.22-a0-618-gd6a3efe1fc 23:42:00 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:42:31 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:45:36 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:45:51 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:46:03 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:46:38 very persistent, this one 23:49:22 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:50:31 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:52:27 maybe he's rerolling D:15 for better loot 23:53:01 I guess d:15 would be marshalled, but hey can still reroll for better combat results 23:53:20 atomicknyte (L14 GnWz) Crash caused by signal #15: Terminated (D:15) 23:53:21 advil: oh he's in ##crawl right now asking a question 23:53:44 03advil02 07* 0.22-a0-770-g06a55de: Fix behavior of multiple xp potions in the same session 10(2 hours ago, 2 files, 46+ 24-) 13https://github.com/crawl/crawl/commit/06a55de886e3 23:53:44 03advil02 07* 0.22-a0-771-g52540ca: Don't crash if a manual would be used up by an xp potion 10(28 minutes ago, 4 files, 8+ 2-) 13https://github.com/crawl/crawl/commit/52540cafeb25 23:53:44 03advil02 07* 0.22-a0-772-gac08f70: Fix xp potions for real this time 10(85 seconds ago, 2 files, 12+ 12-) 13https://github.com/crawl/crawl/commit/ac08f70f71dc 23:54:08 jfc this skill menu stuff 23:54:19 I just mentioned to them that they can wait for a rebuild 23:54:44 ok 23:54:48 yeah it's still going 23:56:18 of course now everything should probably have another rebuild with those xp potion fixes, since they were still pretty broken 23:56:33 change_xp_for_real 23:56:51 really_almost_entirely_change_most_xp 23:56:55 indeed 23:59:39 :) 23:59:50 no good refactor goes unpunished