00:00:04 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-571-g4a923d4 (34)
00:42:42 <buppy> heyo
00:42:54 <buppy> gammafunk buddy are you there
01:01:52 <buppy> I don't think he's there
01:02:28 <buppy> are any other devs around? I was really hoping my ogre magic thing could get in soon
01:03:27 <buppy> !tell gammafunk check this out its dcss on the nes https://i.imgur.com/sGqSBZw.png
01:03:28 <Sequell> buppy: OK, I'll let gammafunk know.
01:03:43 <ProzacElf> i too suspect he is not there
01:04:25 <buppy> probably eating a bag of cheetos with his cheeto wife
01:04:33 <buppy> again
01:26:26 <Gretell> Unstable branch on crawl.develz.org updated to: 0.22-a0-571-g4a923d4 (34)
01:59:04 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-571-g4a923d4
02:07:53 <gammafunk> buppy: 1) get rekt and 2) yeah I haven't talked with MPA about what to do with ogre magic stuff, it's pretty late in this cycle so fairly unlikely that it gets used for 0.22, but certainly could see some action in 0.23-a
02:07:54 <Sequell> gammafunk: You have 1 message. Use !messages to read it.
02:08:24 <gammafunk> and what nes game is that?
02:38:41 <Cheibriados> 03ebering02 {gammafunk} 07* 0.22-a0-572-g2af43bd: Gozag themed ghost vault 10(9 days ago, 1 file, 57+ 0-) 13https://github.com/crawl/crawl/commit/2af43bd06444
02:38:41 <Cheibriados> 03ebering02 {gammafunk} 07* 0.22-a0-573-gbb431e2: Disaster themed lone ghost vault 10(7 days ago, 1 file, 24+ 0-) 13https://github.com/crawl/crawl/commit/bb431e278f74
02:38:41 <Cheibriados> 03ebering02 {gammafunk} 07* 0.22-a0-574-g0289154: Davey Jones' / Kraken themed ghost vault for Shoals 10(6 days ago, 1 file, 32+ 0-) 13https://github.com/crawl/crawl/commit/028915408b82
02:38:41 <Cheibriados> 03ebering02 {gammafunk} 07* 0.22-a0-575-ga6a7277: Port several ghost vaults to the Vaults branch 10(6 days ago, 1 file, 64+ 0-) 13https://github.com/crawl/crawl/commit/a6a7277fff6f
02:38:41 <Cheibriados> 03gammafunk02 07* 0.22-a0-576-ga172949: Updates to ebering_ghost_gozag 10(12 hours ago, 3 files, 95+ 38-) 13https://github.com/crawl/crawl/commit/a1729497a02c
02:38:41 <Cheibriados> 03gammafunk02 07* 0.22-a0-577-g5148d60: Updates to ebering_ghost_davey_jones 10(7 hours ago, 1 file, 23+ 20-) 13https://github.com/crawl/crawl/commit/5148d607e1eb
02:38:41 <Cheibriados> 03gammafunk02 07* 0.22-a0-578-gafc7989: Some ghost vault DES and code cleanups and refactoring 10(7 hours ago, 3 files, 153+ 156-) 13https://github.com/crawl/crawl/commit/afc7989ea5db
02:38:41 <Cheibriados> 03gammafunk02 07* 0.22-a0-579-gb62a27e: Port some ghost vaults to the Vaults branch 10(2 hours ago, 3 files, 181+ 97-) 13https://github.com/crawl/crawl/commit/b62a27e40211
02:56:52 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.22-a0-579-gb62a27e
03:09:53 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-579-gb62a27e402 (34)
03:11:21 <buppy> gammafunk: any estimate of when 0.22 is coming out?
03:11:55 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.22-a0-579-gb62a27e (34)
03:13:47 <gammafunk> august
03:18:57 <buppy> it doesn't take 3 months to review my PR :P
03:21:08 <gammafunk> I believe we have other things we're up to and there are more than a few PRs we have open
03:25:21 <buppy> well do you want help reviewing any of those PRs
03:26:28 <buppy> I'd be willing to test them and review the code if it means someone could look at my PRs
03:34:40 <gammafunk> We're just going to be pretty busy with polishing up release stuff for the next month or so rather than trying to merge a new species or god
03:52:50 <buppy> I'll message you when 0.22 comes around then
03:52:54 <buppy> good night old boy
04:00:21 <gammafunk> nite nite
04:03:36 <buppy> don't let the boring beetles bite
04:26:23 <ProzacElf> lol
04:26:26 <ProzacElf> cheeto wife?
05:13:23 -!- amalloy is now known as amalloy_
08:27:24 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/757 * 0.22-a0-580-gc81a2bd: Draw higher XL players deeper into the abyss 10(7 weeks ago, 1 file, 21+ 0-) 13https://github.com/crawl/crawl/commit/c81a2bde6720
08:27:24 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/757 * 0.22-a0-581-g4167adc: Describe new abyss behavior 10(7 weeks ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/4167adc746f1
08:43:15 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/802 * 0.22-a0-580-g7999cd4: Remove self-harm from chain of chaos (gammafunk) 10(6 days ago, 3 files, 32+ 30-) 13https://github.com/crawl/crawl/commit/7999cd48333a
08:43:15 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/802 * 0.22-a0-581-g6ff6bc7: Add the mace of Variability to ebering_ghost_xom 10(6 days ago, 5 files, 20+ 12-) 13https://github.com/crawl/crawl/commit/6ff6bc7bb461
08:47:31 <ebering> I oops'd the commit history on that rebase, try again
08:48:32 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/802 * 0.22-a0-581-gb0ced52: Revise the mace of Variability 10(6 days ago, 4 files, 16+ 11-) 13https://github.com/crawl/crawl/commit/b0ced52add5c
08:48:32 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/802 * 0.22-a0-582-gdb3a25a: Add the mace of Variability to ebering_ghost_xom 10(6 days ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/db3a25a6481c
08:51:53 <ebering> !tell gammafunk I dunno which of my non ghost-vault prs you're considering but I went through and made sure they all apply cleanly
08:51:53 <Sequell> ebering: OK, I'll let gammafunk know.
12:15:56 <muffindrake> Am I seeing correctly that the start of _generate_armour_item in makeitem.cc tries to reroll 1000 times?
12:16:06 <muffindrake> up to*
12:19:02 <|amethyst> muffindrake:  yes, until it finds a subtype that works for the brand
12:19:35 <muffindrake> Is that not an excessive amount of attempts?
12:20:12 <|amethyst> the chances of needing that many attempts are extremely low, yes
12:21:00 <|amethyst> in general I don't like these "reroll until it works" things... would be nicer to have a way to select a random subtype that is acceptible for the brand
12:21:32 <|amethyst> which would involve data-ifying the logic in is_armour_brand_ok
12:23:08 <muffindrake> I'll see to changing this then
12:23:10 <muffindrake> this is awful
12:48:12 <Cheibriados> 03MarvinPA02 07* 0.22-a0-580-gd5db89c: Add Alexandra Shields to credits 10(25 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/d5db89c09a90
12:50:20 * geekosaur wonders if that means mpa's around
12:50:34 <MarvinPA> hi, briefly yeah
12:50:38 <geekosaur> someone in ##crawl noted that everyone on comcast in michigan is currently banned
12:50:50 <geekosaur> because of an overwide spam ban from last christmas
12:51:40 <muffindrake> oh dear
12:51:50 <geekosaur> hm. not everyoine in ,mi but a lot
12:51:52 <geekosaur> 2017 Dec 25 21:04:53 *	MarvinPA sets ban on *!*@*.hsd1.mi.comcast.net
12:53:17 <muffindrake> oh dear
12:53:43 <muffindrake> MarvinPA: What did Michigan do to you?
12:54:04 <geekosaur> it was a spammer
12:54:12 <MarvinPA> had a spammer from there presumably, yeah
12:54:32 * geekosaur checked logs, there was some reason to do it then but it's been a few months since (and that spammer was hitting ~all of freenode)
12:54:58 <muffindrake> Perhaps it's a better idea to report that to #freenode rather than banning them yourself
12:55:13 <MarvinPA> thanks, will take a quick look in my logs too but yeah i guess it's safe to just unban that
12:55:16 <geekosaur> no, at the time freenode was doing what it could
12:55:31 <muffindrake> spammers hitting all channels is usually something #freenode care about
12:55:36 <geekosaur> that should probably have been a temporary ban but someone forgot to remove it
12:55:43 <muffindrake> I realize that
12:56:53 <geekosaur> but you don;t realize that freenode already knew it was happening and staff were already doing what they could. or maybe you just haven't seen that kind of spam attack; it's deliberately overwhelming
12:57:07 <muffindrake> Oh, I sure have seen spam like that
12:57:10 <geekosaur> i.e. you don;t need to edumacate everyone on the "porper" way to deal
12:57:11 <muffindrake> enough times
12:57:26 <muffindrake> Perhaps it was the correct action at the time
12:57:29 <muffindrake> It's difficult to tell now
12:57:36 <geekosaur> for you
12:57:55 <geekosaur> for those of us who were there at the time, could you consider crediting us with a few functional neurons?
12:58:32 <muffindrake> There is no need to get condescending
12:58:58 <geekosaur> correct. and you're being condescending to mpa (and to me and to others)
13:05:10 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-580-gd5db89c (34)
13:10:01 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-580-gd5db89c09a (34)
13:13:55 <muffindrake> geekosaur: It's just that usually during such spam waves, there's a timely reponse from an admin who klines the offending hosts
13:14:24 <muffindrake> in any case, this is simply forgetting to remove a hostmask, which is a mistake that I could make just as easily
13:14:48 <geekosaur> yes, which works really well when it's 200 different hosts at the same time as those spam waves had and have been doing
13:14:48 <geekosaur> yes, I am serious
13:15:43 <Pinkbeast> Also, since in practice it doesn't try 1000 times or anything like it, "awful" is the usual ridiculous hyperbole.
13:16:25 <geekosaur> well, it's awful from a "who comes up with this kind of reasoning?" sense
13:16:58 <geekosaur> that said, for crawlcode it's about par >.>
13:17:24 <Pinkbeast> I think of "try a lot and complain if it turns out to be unexpectedly impossible" as perfectly normal really
13:21:45 <muffindrake> Sure, if the behaviour of a program makes something difficult/impossible to determine trivially ahead of time, that's definitely the right approach
13:22:04 <muffindrake> I'm not sure that's the right way to do that for armor generation, however
13:22:05 <Pinkbeast> It's a perfectly fine approach here
13:24:33 <geekosaur> approach is fine, 1000 is a bit excessive
13:25:45 <muffindrake> perhaps there should be a macro called REASONABLE_NUMBER_OF_REROLL_ATTEMPTS
13:25:57 <muffindrake> put a number on sanity
13:26:00 <Pinkbeast> Maybe although in this sort of case where you expect to take maybe 3 or 4 goes the value of $bignum is largely academic. Pity it doesn't complain if it doesn't work at all.
13:27:59 <Pinkbeast> Maybe 1000 is a bit excessive, that is
13:39:07 <travis-ci> The build has errored. (master - d5db89c #9871 : Chris Campbell): https://travis-ci.org/crawl/crawl/builds/398847116
13:41:30 <muffindrake> random failure, packages failed to install
13:48:33 <muffindrake> Is that a common thing on travis?
13:49:16 <ebering> yeah travis is cranky these days
13:49:52 <geekosaur> not just these days, even
14:07:00 -!- amalloy_ is now known as amalloy
15:32:45 -!- Krakhan|2 is now known as Krakhan
15:57:51 <ebering> there's an interesting bug wrt gozag bribe branch and orb run spawns
15:58:15 <ebering> namely, an orb run monster can spawn in los of the player and be bribed when the dactions catch up
15:58:42 <ebering> they don't actually display as bribed until the player takes a turn with them in los, because that gets set in seen_monsters_react
15:59:19 <ebering> so if the player uses that turn to attack, it counts as attacking a bribed monster
15:59:25 <ebering> and cancels the bribe of everything in los
15:59:38 <gammafunk> I think that may be a problem in general with bribe not even specific to orb spawns
16:00:09 <gammafunk> I've noticed that monsters come into los and don't appear to get bribed but then do so after I act
16:00:09 <ebering> I guess now that wandering monsters don't spawn the only other edge case is if the monster teleports into view of the player
16:00:15 <ebering> hm
16:02:32 <ebering> yeah that seems consistent. If the monster moves into view on its turn it doesn't get to react to you in seen_monsters_react
16:06:12 <MarvinPA> iirc the way gozag triggers on things coming into view is handled in a place where stuff like that really shouldn't be handled
16:06:34 <ebering> its in seen_monsters_react which does stealth checks et. al.
16:06:35 <MarvinPA> (and a bunch of other things use a similar codepath too)
16:06:48 <ebering> not in _monster_warning where Zin and ash warnings (and gozag wrath!) are processed
16:07:06 <ebering> Beogh and Jiyva also use this codepath for pacification/conversion
16:07:14 <ebering> this being the seen_monsters_react codepath
16:08:42 <muffindrake> So, in what range is item_level passed to items() and its subroutines usually?
16:09:08 <muffindrake> (makeitem.cc)
16:12:01 <MarvinPA> oh ok, i think that's kinda closer to being the right codepath since it's actually like, about monsters acting
16:12:14 <MarvinPA> whereas the wrath codepath is otherwise just doing a view update
16:13:38 <ebering> I guess the problem is then that the monster gets its 'bribed' status at generation
16:13:45 <ebering> but it's not revealed to the player until the monster reacts
16:17:11 <gammafunk> yeah, I want to say that the codepath for bribe was changed to that from something else?
16:17:16 <gammafunk> it went through some iterations
16:18:20 <MarvinPA> it's worked in a few different ways too, yeah
16:18:36 <ebering> well, one way to resolve this current bug without moving the codepath is to edit gozag_break_bribe
16:18:49 <ebering> !source attitude-change.cc 470
16:18:50 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/attitude-change.cc#L470
16:19:42 <ebering> and only trigger a bribe break if the monster has the ENCH and not the KEY
16:20:01 <ebering> since the KEY gets turned into the ENCH by check_bribe in the seen_monsters_react codepath
16:20:39 <ebering> this would have the bizzare property that occasionally an attacked monster would take a bribe after you attacked it
16:20:55 <gammafunk> yeah, it would be nicer if the monster just showed the status before that was possible
16:21:31 <gammafunk> I suppose it wouldn't be all that weird if the monster just transitioned afterwards though
16:21:39 <gammafunk> they had to "decide" to accept the bribe
16:22:16 <ebering> players would be encouraged to not attack a monster without letting it react though, to avoid damaging a possible permanent ally
16:22:18 <gammafunk> but ideally for gameplay purposes that minigame of "I might not want to hit this monster since I'm damaging a potential ally"
16:22:21 <gammafunk> lol
16:22:26 <gammafunk> I *thought* it before you did
16:24:14 <gammafunk> oh, and I didn't finish that sentence, but yeah ideally said minigame wouldn't exist
16:30:15 <Cheibriados> Polymorphing a frenzied shapeshifter causes it to become "indifferent" 13https://crawl.develz.org/mantis/view.php?id=11504 by Muffindrake
16:31:33 <ebering> another fix would be to move the guaranteed conversions (gozag bribes and jiyva slimes) to the codepath of when they come into view and leave beogh conversions (which can proc after taking damage and are random chance) where they are
16:33:04 <ebering> hm no, each orc only gets attempted to convert once
16:33:34 <ebering> I guess it's just not pre-ordained like it is with gozag
17:32:28 <muffindrake> 101 + item_level * 3
17:32:36 <muffindrake> What should I expect the value of this expression to be?
17:32:42 <muffindrake> It's used in a few places in makeitem.cc
17:34:34 <muffindrake> ISPEC_GOOD_ITEM = 351
17:35:43 <neofelis> item_level mostly seems to be a function parameter, so I guess look at what calls the functions?
17:38:16 <neofelis> from a grep, at least one thing sets it to a function of absdepth, for instance, and something in xom.cc sets it to something else
17:42:22 <muffindrake> Oh, I see what its value would usually be
17:43:01 <muffindrake> It's value is actually capped to 50 unless it's ISPEC_GOOD_ITEM or more
17:43:32 <muffindrake> now the code makes somewhat more sense
18:20:43 <Lantell> Unstable branch on underhound.eu updated to: 0.22-a0-580-gd5db89c09a (34)
19:31:41 <Cheibriados> New branch created: dithrevamp (2 commits) 13https://github.com/crawl/crawl/tree/dithrevamp
19:31:41 <Cheibriados> 03gammafunk02 07[dithrevamp] * 0.22-a0-581-g8ea7af7: Rework Dithmenos' Shadow Step restrictions and costs (mikee) 10(60 minutes ago, 4 files, 8+ 17-) 13https://github.com/crawl/crawl/commit/8ea7af78d681
19:31:41 <Cheibriados> 03gammafunk02 07[dithrevamp] * 0.22-a0-582-g010b403: Make Dithmenos an evil god (mikee) 10(11 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/010b403db860
19:42:26 <Cheibriados> New branch created: pull/808 (1 commit) 13https://github.com/crawl/crawl/pull/808
19:42:26 <Cheibriados> 03ebering02 07https://github.com/crawl/crawl/pull/808 * 0.22-a0-580-gda5e4c5: Attempt God conversions on sight. 10(32 minutes ago, 4 files, 20+ 4-) 13https://github.com/crawl/crawl/commit/da5e4c5fea8f
20:00:07 <hellmonk> can someone please update hellcrawl on cbro
20:00:20 <hellmonk> alexjurkiewicz: please update hellcrawl on cpo
20:11:03 <aidanh> hellmonk: rebuilding
20:11:12 <hellmonk> thank you
20:11:33 <aidanh> no problemo
20:13:40 <muffindrake> hellmonk: please remove hell
20:24:26 <Rotatell> Experimental (hellcrawl-cbro) branch on crawl.beRotato.org updated to: 5.1-511-g153722e
21:16:36 <gammafunk> hrm, is ccache tied to directory? I'd have thought that the cache was shared across directories, but it seems that my builds in different repos don't use cache when I've compiled the same things in a different dir
21:23:57 <Pinkbeast> It should be independent of directory.
21:24:26 <Pinkbeast> I mean, "that is the design of ccache", not "that is how the design of ccache should be"
21:25:16 <Pinkbeast> Crawl seems in general to do less well out of ccache than I'd hope for reasons I don't understand... are the object files you're getting identical?
21:30:03 <gammafunk> hrm, they do seem to differ
22:27:49 <Cheibriados> when player is CONFused, still able to command allies where to go (with  't' key) 13https://crawl.develz.org/mantis/view.php?id=11505 by RoGGa
22:37:01 -!- Suika is now known as erkin
23:59:44 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-580-gd5db89c (34)