00:38:34 aidanh: cool, I'll try to merge soon 00:38:34 alexjurkiewicz: You have 2 messages. Use !messages to read them. 00:39:02 my local webtiles-changes running copy is a horrible mess of unmerged local changes, so might take a bit 00:39:10 what sort of timeframe do you have for merging to master? 01:27:10 Unstable branch on crawl.develz.org updated to: 0.22-a0-458-gb446440 (34) 01:42:11 alexjurkiewicz: it'd be nice to get it in before the next release, with a week or two to spare for bug fixing, but I'm not sure what the release time frame is 01:43:45 a merge to master will also require manual merges on all servers 01:47:00 I'd also prefer to have it running as an experimental for a bit first, for testing and to gather any feedback 01:56:30 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-458-gb446440 02:57:36 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-456-g11ed031 03:11:39 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-458-gb446440 (34) 04:40:04 -!- amalloy is now known as amalloy_ 07:09:59 New branch created: pull/777 (1 commit) 13https://github.com/crawl/crawl/pull/777 07:09:59 03Nikolai Lavsky02 07https://github.com/crawl/crawl/pull/777 * 0.22-a0-459-gc254099: Make Iron Giants and other Throw Ally users obey Sanctuary 10(24 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c254099d7c5f 09:25:35 dgl question - is there a way to use the dgl command to update a user's email address and, if not, is it safe to go just munge that in the db manually? i have a user request 09:29:13 rax_: looks like it's safe to just issue the sqlite commands yourself, I don't see a script to update email 09:30:18 word 09:30:42 would be good to write that script I guess, we could base it on the dgl script in bin/passwd.sh 09:34:29 hm, mantis spammer under username "Okdnffkjhd35" 09:34:49 I don't seem to have permissions to delete a user, can someone who does do that? 09:35:40 I just deleted the one spam that I saw 09:37:11 looks like it was just one 09:37:30 thanks gammafunk, i made the change manually. it's possible letting logged-in users change their email would be good too 09:38:14 yeah rax_, it would be nice if dgl had support for that; probably wouldn't bee too hard to implement either 09:38:32 advil: for tavern? are you a mod, you can ban them if so 09:38:35 if not, I can ban them 09:38:46 Changing email address> how often does it come up? 09:38:50 I am not a mod, it was actually spam on mantis 09:38:52 ah, mantis spam 09:38:58 not sure I can do anything about that 09:41:14 Napkin: Apparently we have a mantis spam Okdnffkjhd35 ; can any of us do anything to delete them? 09:41:24 I guess advil already deleted their spam reports 09:41:44 advil: they actually made a mantis report containing spam? 09:41:49 don't think I've seen that before 09:41:59 yeah, it was just one in https://crawl.develz.org/mantis/view.php?id=11493 09:42:36 you might be able to see it if you have the right permissions, I do have it saved in email, links about cheap shoes 09:43:06 it was a note on an existing report 09:43:17 Pinkbeast: this is the second time i can think of i wouldn't call it a high-priority request 09:43:20 hm, I'm not sure if I actually did the search right to see if they added notes elsewhere 09:43:36 -!- rax_ is now known as rax 09:55:25 yeah, I think it was just that one thing, which we might never have noticed if an active dev wasn't on the email list for it 09:58:23 seems like not the most effective way to get ones spam out there 09:58:45 I'm somewhat impressed that a spammer went to the hassle of making their spam bot post on mantis 10:06:20 re ghosts, here's an assumption I've been making that I hope is true: trunk versions on a server all share a single bones folder 10:06:47 it seemed likely to me since they share a save folder 10:16:43 advil: I can examine cdo a bit 10:20:05 03advil02 07https://github.com/crawl/crawl/pull/726 * 0.22-a0-459-g549b3ee: Proof of concept implementation of server-side tileschat mute 10(4 months ago, 2 files, 118+ 11-) 13https://github.com/crawl/crawl/commit/549b3ee64d2e 10:20:05 03advil02 07https://github.com/crawl/crawl/pull/726 * 0.22-a0-460-g8269026: Implement mutelist saving with a server-side sqlite db 10(4 months ago, 7 files, 135+ 16-) 13https://github.com/crawl/crawl/commit/82690266415d 10:20:05 03advil02 07https://github.com/crawl/crawl/pull/726 * 0.22-a0-461-gf53d933: Add an `/unmute *` command, /help, misc cleanups 10(6 weeks ago, 1 file, 42+ 4-) 13https://github.com/crawl/crawl/commit/f53d933a0fe7 10:20:05 03advil02 07https://github.com/crawl/crawl/pull/726 * 0.22-a0-462-g2caebd6: Add a way of minimizing and hiding the chat window 10(6 weeks ago, 6 files, 121+ 9-) 13https://github.com/crawl/crawl/commit/2caebd6e16b6 10:20:05 03advil02 07https://github.com/crawl/crawl/pull/726 * 0.22-a0-463-g1dbd2df: Show mute status in spectator list 10(2 days ago, 1 file, 8+ 4-) 13https://github.com/crawl/crawl/commit/1dbd2df96d00 10:20:07 03advil02 07[tileschat-mute] * 0.22-a0-459-g549b3ee: Proof of concept implementation of server-side tileschat mute 10(4 months ago, 2 files, 118+ 11-) 13https://github.com/crawl/crawl/commit/549b3ee64d2e 10:20:07 03advil02 07[tileschat-mute] * 0.22-a0-460-g8269026: Implement mutelist saving with a server-side sqlite db 10(4 months ago, 7 files, 135+ 16-) 13https://github.com/crawl/crawl/commit/82690266415d 10:20:07 03advil02 07[tileschat-mute] * 0.22-a0-461-gf53d933: Add an `/unmute *` command, /help, misc cleanups 10(6 weeks ago, 1 file, 42+ 4-) 13https://github.com/crawl/crawl/commit/f53d933a0fe7 10:20:07 03advil02 07[tileschat-mute] * 0.22-a0-462-g2caebd6: Add a way of minimizing and hiding the chat window 10(6 weeks ago, 6 files, 121+ 9-) 13https://github.com/crawl/crawl/commit/2caebd6e16b6 10:20:07 03advil02 07[tileschat-mute] * 0.22-a0-463-g1dbd2df: Show mute status in spectator list 10(2 days ago, 1 file, 8+ 4-) 13https://github.com/crawl/crawl/commit/1dbd2df96d00 10:22:52 %git 10:22:52 07advil02 * 0.22-a0-458-gb446440: Fix (un)woken_rest.rc 10(17 hours ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/b446440d2e2b 10:24:16 not merged yet, but that was a rebase in prep for merging 10:24:22 advil: hmm...this looks troubling 10:24:53 what does? 10:25:07 one sec, I'll dpaste 10:26:40 advil: http://dpaste.com/3GB7ZTB 10:26:48 it looks like each trunk build has its own bones dir 10:26:58 ugh ok 10:27:06 but what you said earlier about their sharing saves dir 10:27:10 this doesn't seem to be true either 10:27:18 huh 10:27:23 seems like they all have their own save dir 10:27:27 which bones is a subdir of 10:27:37 I see e.g. one save in that later version 10:27:41 oh, I guess that makes sense given that one has the option to not update the save 10:27:41 and a bunch in the earlier one 10:27:47 right 10:27:53 <|amethyst> hm 10:27:59 <|amethyst> wonder when that changed 10:28:22 this is just cdo, not sure about other servers 10:28:26 <|amethyst> oh, probably related to CDO having a different setup from most servers 10:28:49 <|amethyst> on CAO there is one bones dir for all trunk versions, but separate save dirs 10:29:02 sigh 10:30:39 the CDO setup actually seems "wrong" in the sense that it would reduce ghost generation, probably by a noticeable amount 10:30:48 and make it dependent on how often we update trunk 10:31:17 cdo also doesn't have a lot of users 10:31:24 well, compared to other servers 10:31:30 maybe it doesn't end up mattering too much 10:32:06 |amethyst: bones files are versioned like other files, right? does having older versions try to load a bones file that's been modified by a later version actually work? 10:32:23 maybe I don't understand how save compat works with those files 10:32:29 interesting question 10:32:51 but what happens if a later trunk marshalls a ghost in a way an earlier trunk doesn't know how to read? 10:33:37 it should just fail to load it with an error (that probably isn't visible to the player in a non-debug build) 10:33:40 <|amethyst> dprf("Ghost version mismatch: ghost was %d.%d; wanted %d.%d", 10:33:57 <|amethyst> see _ghost_version_compatible in files.cc 10:34:35 <|amethyst> hm 10:34:44 <|amethyst> but I do notice that it doesn't try to repeat 10:35:32 <|amethyst> but I guess it wouldn't help much to repeat 10:36:05 <|amethyst> so that means, if you don't like ghosts, you should avoid transferring your save, and hope for a new minor tag 10:36:22 I guess that version numbering will use the same minor tags as everything else? 10:36:36 to be fair, the same is true if each version does have its own folder 10:36:49 you should avoid transferring your save so you're the only one playing your version 10:36:56 <|amethyst> yeah 10:37:08 <|amethyst> advil: yeah 10:37:38 really we ought to be using an sqlite db for ghosts, or something like that, but I didn't have the willpower to go down that path 10:40:10 advil: so that permastore in trunk will have an issue where, when a new trunk is installed, for servers with a common bones dir, said new trunk version will make the store no longer usable by untransferred games? 10:40:36 yes, though I think only with a new minor tag 10:40:41 and then I guess for CDO the permastore is just for each trunk version 10:40:42 ah, true 10:41:10 for CDO one could get the same behavior as on other servers by copying the bones folders on installation, I guess 10:41:10 I guess CDO has a bit more of a problem since new trunk build makes a new directory, so you're always starting over 10:41:18 yeah 10:41:33 if CDO is a bit wonky wrt ghosts for a while, it's not the end of the world anyhow 10:41:47 for the busy servers we certainly want things to work normally upon merge 10:41:58 in terms of being able to have play-tests and the like 10:42:22 if we moved to sqlite, does that actually solve the problem? 10:42:39 the ghost format could change, so doesn't it too have to record minor version 10:42:58 well I have in mind a completely different solution, not using tags at all 10:43:04 *tags.cc at all 10:43:06 ok 10:43:50 there would still be a versioning problem, but many other problems would be better (mainly that the save format isn't something designed to be treated as a db) 10:44:26 btw for the initial seeding of the permastore, I had a simple idea, which was to suppress ghosts altogether on a per-level basis until the permastore for that level has some stuff in it 10:45:26 advil: you want to avoid making "too many" of those direct player-clone ghosts? 10:45:58 yeah, I was a bit worried about that being very weird from the player's perspective 10:46:04 maybe it's ok though? 10:46:25 it's seems alright to me, although I'm sure players will be a bit confused initially 10:46:48 but it probably is better to get them going through these vaults in terms of balancing; not that balancing is too difficult though 10:47:07 I'm sort of going for some common levels of loot distribution in these vaults 10:47:50 with loot count/quality increasing with depth, but nothing is set in stone, and some vaults can be exceptions 10:48:19 that sounds good, my initial pass was very unbalanced w.r.t. loot 11:02:07 New branch created: pull/778 (1 commit) 13https://github.com/crawl/crawl/pull/778 11:02:07 03ebering02 07https://github.com/crawl/crawl/pull/778 * 0.22-a0-459-g980b2be: Fix bug 11478: Movement-key actions and Wu Jian 10(13 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/980b2be620b4 11:14:49 !bug 11402 11:14:49 https://crawl.develz.org/mantis/view.php?id=11402 11:15:39 The build has errored. (tileschat-mute - 1dbd2df #9726 : advil): https://travis-ci.org/crawl/crawl/builds/389748451 11:16:09 The cause of this bug is that G&G set up the double attack using the cleaving code, and WJ martial attacks do not cleave 11:17:36 I guess G&G is a special case 11:42:24 hey 11:42:27 is any bigshot online 11:45:00 what is a bigshot 11:45:58 a big cheese 11:46:01 a head honcho 11:46:17 a big wheel 11:49:04 I wanted to wrap up my magic system thingy on github this weekend and have it be done 11:49:24 New branch created: pull/779 (1 commit) 13https://github.com/crawl/crawl/pull/779 11:49:24 03ebering02 07https://github.com/crawl/crawl/pull/779 * 0.22-a0-459-gf0ae1a8: Kung Fu with swordchucks (11402) 10(8 minutes ago, 1 file, 9+ 4-) 13https://github.com/crawl/crawl/commit/f0ae1a85e9fd 11:49:27 could I get dev opinion on it 11:49:51 I saw it, the intial version, I thought the idea might fit in somewhere, possibly as part of a god (CanofWorms was thinking about it as part of a pakellas rework) 11:50:13 I think you've changed it a bit subsequently and I don't know the details about those changes 11:50:35 basically its on hill orc now instead of ogre and its balanced slightly better 11:52:28 god idea is fine but it misses out on the early XL2/XL4 spells which is disappointing and it needs several more abilities which have yet to exist 11:54:04 yeah, I think worms had some plans for other pakellas aspects, but I don't know if he has much finalized there 11:54:23 you could have a convo with him when he's around (he usually shows up every few days, is also on the roguelikes discord) 11:54:53 hellmonk mentioned how it might even work for sif but I haven't thought about that much 11:55:28 I think I saw another sif remake on github 11:56:02 yeah that's something completely different 11:56:41 The build has errored. (tileschat-mute - 1dbd2df #9726 : advil): https://travis-ci.org/crawl/crawl/builds/389748451 11:57:26 I thought the travis people had fixed this problem, it seems to be back with a vengeance 11:57:50 it's a bit like being a gnoll and just worshiping a non-book-gifting god, but it is probably different enough that it could be ok on a species, but I'm not sure where a good fit would be 11:58:17 HO are very similar to Mi in a lot of ways, so they might even actually be a good candidate, but that would be a fairly radical departure as well 11:58:37 finally, the noob spellcasting species we need, I guess 11:58:46 that was my thinking as well 11:59:58 HO mages are fairly fun and easy to do, and this wouldn't really prevent that, just make it somewhat different, and Og would remain similar to the old HO mages 12:00:17 but I'd like to hear some other opinions from devs who like to think about design stuff, maybe MPA and/or elliptic 12:00:39 maybe I can chat about it with MarvinPA at some point in the near term, but I have to finish this ghost stuff right now 12:01:03 buppy: were you at all inspired by e.g. ogre mage and other monsters that have those "spell sets" for this? 12:01:08 I noticed the sort of connection there 12:01:38 is this more monster-player symmetry??? 12:01:51 im not gonna reveal my secrets 12:02:05 were you involved in the ihop -> ihob scandal be honest 12:02:39 advil: did you have lingering reservations about adding unbrace/checkwhite to travis? 12:02:53 I've already told everyone about your secret fascination with xbow users of zin and how that's why you made dwants 12:02:54 or anyone else, for that matter 12:02:56 you have nothing left to hide 12:03:22 that certainly sounds cool, aidanh, but you probably care more about whether it causes technical issues I guess 12:03:25 well it feels very different than the other stuff that ci does 12:03:25 and I'm not sure about that 12:03:54 hrm, travis doesn't error on compiler warnings, does it? 12:03:56 or maybe it does 12:04:05 it doesn't 12:04:06 it doesn't 12:04:33 I gotta go 12:04:40 I guess checkwhite/unbrace would be a bit strange then and might mask other actual errors 12:04:41 it's already a PR from chequers, and they're starting to stack up 12:04:55 ping me on github gammafunk when you get other dev opinion 12:05:12 will do pubby 12:05:12 thanks buddy I'm counting on you 12:05:12 also the world is too don't screw it up 12:05:27 from one perspective the solution is for people to add those scripts as a commit hook 12:05:35 I defeated him in Golden Axe for Sega Genesis, so the least I can do is give his PR a fair shake 12:06:45 I guess my basic preference would be to keep CI for actual testing 12:08:26 I can see how style errors could mask compilation failures; I assume there'd be a way to only do style checks after everything else? 12:09:09 one idea I had would be to use a difference ci (e.g. CircleCI) for code style checks (when looking into this before that was a solution I found in some other large project, can't remember which one) 12:10:03 personally I don't really mind having the extra commits 12:10:28 well, this wouldn't even prevent the extra commits 12:11:12 it'd work for work done on branches, but not for commits pushed straight to master, yeah 12:13:53 a pre-receive hook would work, but I'm not sure if those are enterprise only 12:14:10 I meant a pre-commit hook 12:15:43 yep, I know; the downside there is that it's a per-developer step 12:16:01 The build has errored. (ui-overhaul-wtc - 624d4f3 #9721 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/389370654 12:17:49 his change to unbrace itself is good 12:20:08 yup; I might at least cherry-pick that bit 12:36:52 03alexjurkiewicz02 {Aidan Holm} 07* 0.22-a0-459-gfc9006d: Add error output to unbrace 10(5 weeks ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/fc9006d011c7 12:40:31 hm, another thing to consider is that this is intended to mostly help out contributors 12:41:27 so not catching pushes to master isn't really a problem, and it removes a tedious and easy-to-forget step from the contribution process 13:05:26 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-459-gfc9006d (34) 13:08:32 New branch created: pull/780 (1 commit) 13https://github.com/crawl/crawl/pull/780 13:08:32 03ebering02 07https://github.com/crawl/crawl/pull/780 * 0.22-a0-459-geff77c4: Don't re-check forgotten map squares (10461) 10(7 minutes ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/eff77c4b119c 13:09:50 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-459-gfc9006d011 (34) 13:33:15 <|amethyst> hm 13:33:32 <|amethyst> advil: just got this when tabbing: 13:33:53 <|amethyst> Lua error: ...-master/crawl-git-fc9006d011/data/dat/dlua/macro.lua:27:...ter/crawl-git-fc9006d011/data/dat/clua/autofight.lua:293: Cannot currently process new keys (there is pending input) 13:34:51 <|amethyst> advil: I guess this is probably related to the thing minmay noticed a long time back where tabbing could sometimes do keypresses in the wrong order, resulting in actions one didn't intend to take 13:35:39 |amethyst: do you remember 13:35:40 %git 900b867fb7dce 13:35:41 07|amethyst02 * 0.16-a0-4021-g900b867: Disallow elemental status_caption_colour and background_colour. 10(3 years, 4 months ago, 3 files, 11+ 9-) 13https://github.com/crawl/crawl/commit/900b867fb7dc 13:35:54 in particular why you decided to default allow_elemental to true? 13:36:06 !bug 11468 13:36:06 https://crawl.develz.org/mantis/view.php?id=11468 13:36:34 is related, and diggin in to it it seems that, except in l-colour and l-dgn str_to_colour uses *dont* expect an elemental colour 13:36:51 <|amethyst> ebering: probably because I knew of a couple of places that caused a crash with elemental colours, but did not know every location that would want to use elemental colours 13:37:07 <|amethyst> so preferred to keep it closer to status quo ante 13:39:47 ok 13:41:37 |amethyst: yes, I added that error message yesterday 13:41:51 <|amethyst> advil: I know, that's why I mentioned it to you specifically :) 13:41:54 I may change the behavior again 13:42:14 <|amethyst> advil: I don't know, I mean, that does seem like a bug 13:42:37 <|amethyst> that autofight would be able to do that 13:43:07 well, I think I know how to ensure that all the commands in the sequence are grouped together 13:43:15 <|amethyst> ah, cool 13:43:35 I didn't do it before because I wasn't really sure what the conditions were, but now I think it's triggered by network randomness or lag that leads to two tabs arriving very close to each other, and the way commands are pulled from the macro buffer means that new keystrokes take priority over stuff in the buffer 13:43:59 it doesn't replicate locally because the timing needs to be extremely close, I think 13:44:42 <|amethyst> hm, I guess it should be possible to introduce an artificial delay so that it can be tested locally 13:47:00 it should be pretty simple: basically if there's pending input I'll push all commands in the sequence to the back of the buffer, otherwise I'll push everything but the first and trigger the first right away (the current behavior) 13:48:22 I even tested out something like that before going with the current behavior 13:54:23 hm, I suppose there is still the potential for weirdness if e.g. a movement key shows up before the autofight sequence gets processed 14:01:06 New branch created: pull/781 (1 commit) 13https://github.com/crawl/crawl/pull/781 14:01:06 03ebering02 07https://github.com/crawl/crawl/pull/781 * 0.22-a0-460-g7c5d4fa: Don't accept elemental colours by default (11468) 10(9 minutes ago, 6 files, 13+ 13-) 13https://github.com/crawl/crawl/commit/7c5d4fa5cf32 14:04:22 <|amethyst> advil: I was at first going to say that I don't understand why input and macro handling shouldn't be completely synchronous 14:04:34 <|amethyst> advil: but I guess that would prevent things like pressing a key to abort travel 14:05:04 yeah, I think my solution idea is non-ideal 14:05:32 really what we want for autofight is to be able to push an unbreakable sequence of commands to the front of the buffer 14:06:21 03ebering02 07https://github.com/crawl/crawl/pull/780 * 0.22-a0-460-gbffbd0e: C++ better (aidanh) 10(3 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/bffbd0e1dd37 14:07:05 -!- amalloy_ is now known as amalloy 14:07:26 ebering: in-progress fixup commits are fine, but that should probably be fixup-ed onto the original commit before merging 14:07:52 well here's a ridiculously hacky idea: unwind the key buffers while processing a command sequence like that 14:10:21 would only work for cases like autofight where the remainder of the sequence is consumed in a menu or targeter 14:12:25 aidanh: so it's cool to rebase and force-push to PRs as a part of crawl workflow? 14:12:59 <|amethyst> ebering: unless other people are working on the same PR, at least 14:13:22 <|amethyst> ebering: and even then, IMO it's fine as long as you synchronize with them 14:14:00 ok 14:17:43 I've already force-pushed once today! 14:18:54 hm, there's some code already that tries to prioritize command macro sequences, but it looks to me like it'd potentially go wrong if there is more than one macro sequence 14:19:16 !source macro_buf_apply_command_macro 14:19:16 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/macro.cc#L589 14:20:20 oh this is not going to apply to the autofight case anyways 14:56:42 aidanh: there are a lot of bizarre uses of .get() on unique_ptrs in the codebase 14:56:45 e.g. 14:56:55 !source mapdef.cc 1678 14:56:56 https://github.com/crawl/crawl/blob/master/crawl-ref/source/mapdef.cc#L1678 14:57:18 (also why is that assert there before the if?) 15:00:34 also would it be useful for me to chase all these down or? 15:01:08 ebering: that looks like some kind of attempt to "fail gracefully" when asserts are not enabled 15:04:13 ah 15:04:46 still pretty weird, in any case 15:06:11 yes 15:06:12 <|amethyst> yeah, no need for .get() there 15:06:21 <|amethyst> operator bool exists 15:07:02 The build has errored. (master - fc9006d #9730 : Alex Jurkiewicz): https://travis-ci.org/crawl/crawl/builds/389808339 15:09:31 trees are destructible, right? 15:09:50 any objections to switching the swamp border to open sea? 15:10:25 <|amethyst> Only of the geographical sort :) 15:10:41 <|amethyst> I suppose "Endless forest" might be a bit much 15:22:39 open sea isn't a perfect fit either, but it's not a huge deal 15:22:57 <|amethyst> that's what I meant by "of the geographical sort" :) 15:23:16 <|amethyst> but I guess the southern tip of Florida is in fact swamp surrounded by open sea 15:24:59 ohh gotcha :) 15:25:45 what is the border right now? 15:30:28 New branch created: pull/782 (1 commit) 13https://github.com/crawl/crawl/pull/782 15:30:28 03ebering02 07https://github.com/crawl/crawl/pull/782 * 0.22-a0-460-g42fda74: Clean up uses of unique_ptrs 10(11 minutes ago, 28 files, 97+ 109-) 13https://github.com/crawl/crawl/commit/42fda7466fdb 15:31:12 trees, most of the time, but sometimes it's rock wall 15:35:17 seems like (SysEnv.map_gen_range && !SysEnv.map_gen_range->is_usable_in(foo)) could be extracted into a new function, since apparently it's used a lot 15:35:43 03ebering02 07https://github.com/crawl/crawl/pull/780 * 0.22-a0-460-ge7add2d: Don't re-check forgotten map squares (10461) 10(3 hours ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/e7add2da2b9b 15:49:08 haha I figured out how to replicate the "wrong for desired context" messages on at least some versions: but a macro to \{9}\{27} 15:49:15 *bind 15:50:25 beautiful 15:51:02 vault syntax question: does border_fill_type only work with whole-floor vaults? 15:52:17 aidanh: https://github.com/crawl/crawl/blob/eeb374903f99a40a4aae14b8164b8c3fa0160985/crawl-ref/source/dungeon.cc#L4164 15:54:59 thanks 15:55:51 hm, I'd expect dgn_replace_area to potentially replace tiles in the middle of the map 15:58:44 i think it does. it just does that first, and then the map overwrites the stuff in the middle 16:01:42 yeah, makes sense 16:02:26 hm, perhaps a new "endless swamplands" feature is in order after all; the shallow water -> open sea transition looks very abrupt 16:05:12 "impossibly thick marsh" 16:07:22 "if you blundered out there you'd get chomped up by lernie in no time!" 16:07:27 03advil02 07* 0.22-a0-460-g49b1da7: Add command sequences to the front of the buffer for crawl.do_commands 10(17 minutes ago, 1 file, 22+ 14-) 13https://github.com/crawl/crawl/commit/49b1da7e92bd 16:09:35 I think that should finally fix autofight for good, unless it causes new and unexpected crashes 17:09:53 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-460-g49b1da7e92 (34) 18:20:59 Unstable branch on underhound.eu updated to: 0.22-a0-460-g49b1da7e92 (34) 18:23:11 The build passed. (master - 49b1da7 #9736 : advil): https://travis-ci.org/crawl/crawl/builds/389892040 18:42:48 -!- Fixer_ is now known as Fixer 20:37:48 advil: aidanh: if you look at a travis build of the repo there are currently like 15 jobs that run independently. A style error would be a separate job from all of those. If any job fails Travis marks the build as failed, but you can see compilation errors separately from unbrace/checkwhite errors 20:42:44 -!- eb__ is now known as eb_ 21:17:39 New branch created: pull/783 (1 commit) 13https://github.com/crawl/crawl/pull/783 21:17:39 03shieldal02 07https://github.com/crawl/crawl/pull/783 * 0.22-a0-457-gd5b95ce: Fix grammar in Zin's laws description (0011491) 10(31 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/d5b95ce6b1e9 23:59:44 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-460-g49b1da7 (34)