01:56:34 gammafunk: sweet. is there anything to do pre-merge except contacting all server admins? 01:58:28 well I never heard from |amethyst about the script, but yeah I think advil is happy with things 01:58:38 so I have a couple of quick commits I'm pushing tonight, and I can contact them after that 01:59:24 oh, does that branch update the reqs in terms of the needed packages 01:59:36 iirc pyyaml is in debian as an actualy package? 01:59:58 hrm 02:02:09 ok, so python-yaml 02:02:59 chequers: ^ 02:47:03 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-433-gd2a9cce 02:55:07 -!- MadCoyote is now known as FunkyBomb 03:53:09 Large graphical error 13https://crawl.develz.org/mantis/view.php?id=11483 by Jarrodb 06:11:56 gammafunk: it updates INSTALL.txt if that's what you mean? 06:12:02 gammafunk: is there a debian build script I missed? 06:12:16 just was wondering about INSTALL.txt 06:12:40 so if that's updated with the right info, that's fine 06:14:09 https://github.com/crawl/crawl/blob/master/crawl-ref/source/debian/control <-- hmm what about this? 06:15:27 yes, the debian package does need updating, now that you mention it, but this does not influence servers 06:15:49 nor users compiling from source 07:06:39 I have to admit to serious confusion with the dual-"a" devs of advil and aidanh 07:07:16 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-305-g16e8bcd: Add python deps to debian build dependencies 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/16e8bcde2967 07:07:20 I need some way to tell you apart 07:08:44 you don't want to add python to the build deps like that 07:08:59 because I think that's a base system requirement already; webtiles even requires it 07:09:06 just python-yaml is all that's need 07:09:07 ed 07:09:14 but I can edit that later if you don't 07:09:26 note that it does not list perl in its requirements either 07:09:47 but yeah python-yaml is one that needs adding 09:12:18 Nib (L17 FeCj) Crash caused by signal #11: Segmentation fault (Orc:2) 09:41:40 is 11483 really a bug, or just players doing something silly 09:41:43 !crashlog Nib 09:41:44 1. Nib, XL17 FeCj, T:73338 (milestone): https://crawl.xtahua.com/crawl/morgue/Nib/crash-Nib-20180528-131158.txt 10:16:54 -!- Nomi is now known as NomiAtWork 10:19:54 stl find should be perfectly safe on an empty iterator, right? 10:46:57 chequers, that's what the letters after 'a' are for ;) it's easy once you know the trick 10:47:13 advil, depends on what you mean by an empty iterator 10:47:44 in iterator where begin() == end() 10:50:21 yeah; find won't do anything in that case, because it's an empty range; it'll just return end() 10:54:44 11483 sounds like a bug to me; stale state is sticking around 11:19:29 hm yeah that crash is unusual; the menu entry being corrupt/stale is the obvious candidate 11:20:39 no chance of getting a core dump, I suppose 11:22:34 I have so far not found a direct way that the menu entry could be corrupted or stale, but yeah, it seems likely to be some kind of memory corruption issue 11:25:28 man, the memorize menu is painfully slow in webtiles, hopefully that's just because it's a debug build 11:26:02 I might even have frozen it 11:30:08 yeah, I've noticed huge slowness on local tiles as well; it's due to a slow comparison function comparing artefacts 11:32:55 it's mostly it being a debug build though 11:47:14 !pr 764 11:47:14 https://github.com/crawl/crawl/pull/764 11:47:40 Would it make sense to make these dynamic colours configurable as an rcfile option 12:01:12 Radius 2 LRD targeter is inaccurate when there are interfering walls. 13https://crawl.develz.org/mantis/view.php?id=11484 by NormalPerson7 12:26:35 If a monster drops a corpse and I cast animate skeleton I get a skeleton + chunks 12:26:51 If I butcher and then remember I have animate skeleton sometimes I don't get a skeleton anymore 12:27:26 IMO it's an interface screw to have these two operations not commute 12:27:55 Is there a balance reason I'm missing as to why butchering should sometimes destroy skeletons? 12:29:32 I think that;s just an ancient behavior (not always getting skeleton) whereas animate skeleton working on a corpse is iirc relatively recent? so nobody thought about it 12:35:39 <|amethyst> hm 12:35:43 <|amethyst> ??goblin zombie 12:35:44 I don't have a page labeled goblin_zombie in my learndb. 12:35:48 <|amethyst> @?goblin zombie 12:35:48 goblin zombie (07Z) | Spd: 8 | HD: 1 | HP: 6-10 | AC/EV: 0/7 | Dam: 3 | 07undead, evil, unbreathing | Res: 06magic(1), 02cold++, 09poison+++, 12drown, 04rot, 13neg+++, 13torm | Vul: 08holy | XP: 1 | Sz: small | Int: brainless. 12:35:51 <|amethyst> @?goblin skeleton 12:35:51 goblin skeleton (15Z) | Spd: 8 | HD: 1 | HP: 6-8 | AC/EV: 0/5 | Dam: 3 | 07undead, evil, unbreathing | Res: 06magic(1), 02cold++, 09poison+++, 12drown, 04rot+++, 13neg+++, 13torm | Vul: 08holy | XP: 1 | Sz: small | Int: brainless. 12:39:03 <|amethyst> It does greatly reduce the tradeoff between animate dead/remains and nutrition, though that probably only matters for trolls 12:45:12 maybe ghouls too 13:42:31 -!- Nomi is now known as NomiAtWork 14:35:28 |amethyst: the only GhNe|TrNe that have starved to death did so before they had animate dead castable 14:38:40 only one is recentish 14:58:40 |amethyst: with the current behaviour a player who really cared could walk to each corpse and cast animate skeleton instead of butchering all of them and casting animate dead 14:59:04 which is a functionally identical result 15:20:31 New branch created: pull/768 (2 commits) 13https://github.com/crawl/crawl/pull/768 15:20:32 03ebering02 07https://github.com/crawl/crawl/pull/768 * 0.22-a0-434-gfa2536f: Remove an unused include 10(6 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/fa2536fbcb57 15:20:32 03ebering02 07https://github.com/crawl/crawl/pull/768 * 0.22-a0-435-g8f96055: Have butchering always leave a skeleton. 10(39 minutes ago, 3 files, 11+ 21-) 13https://github.com/crawl/crawl/commit/8f960559dde1 16:07:51 <|amethyst> ebering: yeah... that is the reason I keep animate skeleton even when I have learned animate dead, but that is the tedious way 16:14:08 well, submitted pr that changes the behavior 18:18:58 New branch created: pull/769 (1 commit) 13https://github.com/crawl/crawl/pull/769 18:18:58 03ebering02 07https://github.com/crawl/crawl/pull/769 * 0.22-a0-434-g20ad6ec: Correct Usk stomp description 10(7 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/20ad6ec90110 18:23:31 03ebering02 {gammafunk} 07* 0.22-a0-434-gb72857b: Update options_guide.txt for teleporter->transporter 10(4 days ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/b72857b65bb6 18:23:31 03ebering02 {gammafunk} 07* 0.22-a0-435-g04dac39: Update old glyph sets for teleporter->transporter 10(4 days ago, 3 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/04dac39c4187 18:23:31 03gammafunk02 07* 0.22-a0-436-g04e6133: Move some unused lua code to the save compat DES file 10(61 minutes ago, 4 files, 38+ 41-) 13https://github.com/crawl/crawl/commit/04e6133e909f 18:23:31 03gammafunk02 07* 0.22-a0-437-g7c5a50c: Reindent a lua function 10(25 minutes ago, 1 file, 12+ 15-) 13https://github.com/crawl/crawl/commit/7c5a50ce01df 18:23:31 03gammafunk02 07* 0.22-a0-438-g90f0736: Mark an unused feature tile for removal after major version change 10(59 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/90f0736f4df6 18:23:31 03gammafunk02 07* 0.22-a0-439-gac93bac: Update an ice cave transporter vault 10(21 hours ago, 1 file, 18+ 20-) 13https://github.com/crawl/crawl/commit/ac93bacefe6c 19:09:54 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-439-gac93bacefe (34) 19:38:07 gammafunk: will update now 19:38:47 gammafunk: seems weird that there are base packages though, what about a minimal system? 19:39:01 or is there some contract for for the "minimal debian build system package list" 19:42:18 03alexjurkiewicz02 {GitHub} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-306-geadea55: Update control 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/eadea55e0825 19:46:37 ha ha: https://packages.debian.org/stretch/build-essential "This package is NOT the definition of what packages are build-essential; the real definition is in the Debian Policy Manual. This package contains merely an informational list, which is all most people need. However, if this package and the manual disagree, the manual is correct." 19:46:49 https://www.debian.org/doc/debian-policy/ "It is not necessary to explicitly specify build-time relationships on a minimal set of packages that are always needed to compile, link and put in a Debian package a standard “Hello World!” program written in C or C++. The required packages are called build-essential, and an informational list can be found in /usr/share/doc/build-essential/list (which is 19:46:55 contained in the build-essential package). [2]" 19:47:04 fwiw, perl is in that list, but Python is not 19:51:03 chequers: yeah, but that's also just build-essential, python is a system requirement for debian I think? 19:51:15 but yeah, it's moot since like you said in your commit, python is a dependency of python-yaml 19:52:21 could be an issue for minimal systems, I guess; like the chroot we have people install with debootstrap or w/e it's called itself is minimal, but that does require python I think? 19:52:52 I'm not knowledgeable about debian packaging guidelines in general 19:52:55 ok, so let me go contact people 19:53:15 first thing I need is a branch, which I think we have 19:53:59 hrm 19:54:05 advil made commits, so this must be a branch? 19:54:33 ah, I see 19:55:35 he made his own branch 19:55:46 but then is making commits to chequers' repo? 19:56:31 maybe I should just make advil's branch into an up-to-date version of chequers' repo 19:56:45 I want to give the admins a branch they can pull from, and it's bad to give them chequers' repo 19:57:40 advil: do you mind if I make your datafiles branch current with chequer's repo? I want to have a branch to give to admins so they can check things out 19:57:44 and test if they like 19:57:48 I believe the branch in the official repo is out of date, and all commits in the official branch are in the PR 19:58:06 yes, so I would simply make our branch up to date 19:58:11 and we can merge your commits if there are any more 19:58:22 fine wiht me 19:58:30 and we can use this branch as the basis for the eventual merge as well 19:59:15 I guess I could also go ahead and merge master, might as well do so and verify there are no further conflicts 19:59:23 which I don't think there will be 20:00:09 github didn't think so, but I haven't tried myself lately. I did rebase it a few weeks ago but didn't push that to keep the PR intact 20:00:23 let me try locally then 20:02:13 yeah it merged with no conflicts 20:02:25 and yeah this would be a merge and not a rebase just for branch purposes 20:02:42 it can be rebased before the final merge to avoid merge commits if we like 20:03:22 am compiling webtiles now, so if that works and if advil is ok with this, I'll push the updated branch 20:04:16 I wonder if github has a "merge this into a different branch" thing for PRs 20:05:51 i can change the base branch of the PR 20:08:36 it's fine I think; good to keep your PR intact since it has all the discussion 20:10:12 I think I'll just go ahead and push this to datafiles 20:11:20 👍 20:12:43 03advil02 07[datafiles] * 0.22-a0-299-ge70dca4: Doc updates 10(3 weeks ago, 2 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/e70dca4d4ebf 20:12:43 03Alex Jurkiewicz02 07[datafiles] * 0.22-a0-300-gb89db72: Add PyYAML install instructions for MSYS2 10(11 days ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/b89db7205859 20:12:43 03alexjurkiewicz02 07[datafiles] * 0.22-a0-301-g75dc4dd: Simplify MSYS2 pyyaml instructions (gammafunk) 10(10 days ago, 1 file, 3+ 8-) 13https://github.com/crawl/crawl/commit/75dc4dd4fd9a 20:12:43 03advil02 07[datafiles] * 0.22-a0-302-g6aeebbb: Handle levelup stats in a cleaner way 10(33 hours ago, 4 files, 31+ 12-) 13https://github.com/crawl/crawl/commit/6aeebbb03d07 20:12:43 03advil02 07[datafiles] * 0.22-a0-303-g3feafc1: Relax python version requirements 10(33 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3feafc1c6079 20:12:43 03advil02 07[datafiles] * 0.22-a0-304-ga3e79da: Fix up an error message I missed 10(33 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a3e79da47c91 20:12:43 03alexjurkiewicz02 07[datafiles] * 0.22-a0-305-g16e8bcd: Add python deps to debian build dependencies 10(13 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/16e8bcde2967 20:12:43 03alexjurkiewicz02 {GitHub} 07[datafiles] * 0.22-a0-306-geadea55: Update control 10(33 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/eadea55e0825 20:12:43 03gammafunk02 07[datafiles] * 0.22-a0-468-g5cec6a2: Merge remote-tracking branch 'origin/master' into datafiles 10(11 minutes ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/5cec6a27f4fa 20:20:53 hm, do some of my commits have bad email 20:21:25 yep. let me rewrite a few of them 20:25:57 your mailmap is also apparently bad! 20:26:08 since you're not even using alexjurkiewicz suddenly 20:26:30 oh, that's just laziness 20:26:35 -!- chequers is now known as alexjurkiewicz 20:31:47 I pushed my branch again with one commit author replaced 20:31:48 alexjurkiewicz: You have 3 messages. Use !messages to read them. 20:33:51 03alexjurkiewicz02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-300-g90794a2: Add PyYAML install instructions for MSYS2 10(4 minutes ago, 1 file, 14+ 0-) 13https://github.com/crawl/crawl/commit/90794a2312a8 20:33:51 03alexjurkiewicz02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-301-gabf904c: Simplify MSYS2 pyyaml instructions (gammafunk) 10(10 days ago, 1 file, 3+ 8-) 13https://github.com/crawl/crawl/commit/abf904c9dc8d 20:33:51 03advil02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-302-g687ba8e: Handle levelup stats in a cleaner way 10(33 hours ago, 4 files, 31+ 12-) 13https://github.com/crawl/crawl/commit/687ba8ee7b91 20:33:51 03advil02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-303-g7e3103e: Relax python version requirements 10(33 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7e3103e7fdfe 20:33:51 03advil02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-304-g7d80f83: Fix up an error message I missed 10(33 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7d80f8334451 20:33:51 03alexjurkiewicz02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-305-gfe1fab5: Add python deps to debian build dependencies 10(13 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fe1fab59aac1 20:33:51 03alexjurkiewicz02 {Alex Jurkiewicz} 07https://github.com/crawl/crawl/pull/721 * 0.22-a0-306-gd10e663: Update control 10(54 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d10e663fda48 20:59:12 yes, I started working in a master branch but then put the changes in the PR branch, they were in sync when I did that 20:59:20 not sure what that rebase will have done then 21:13:19 I just pushed a version to datafiles with a merge of master 21:13:42 we can remember to get alexjurkiewicz's rewritten commits when we do the final rebase before merge 21:15:11 maybe I can just do that now before I contact people since the rebase wouldn't affect much 21:27:00 !seen |amethyst 21:27:00 I last saw |amethyst at Mon May 28 20:07:51 2018 UTC (5h 19m 8s ago) saying 'ebering: yeah... that is the reason I keep animate skeleton even when I have learned animate dead, but that is the tedious way' on ##crawl-dev. 21:27:49 |amethyst: greensnark: I also wanted to talk to you about ttyrec storage. I'd like to push ttyrecs to S3, but everything currently depends on reading directory indexes of ttyrec files 21:29:34 <|amethyst> well, it doesn't specifically have to be an apache directory listing; if there's some S3 api to get the list, you could write a CGI wrapper or such around that 22:09:36 -!- Jozrael is now known as SkeggAtHeart 23:59:35 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-439-gac93bac (34)