00:00:15 03ebering02 07* 0.22-a0-410-gad65372: Code cleanup 10(13 days ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/ad653724b05d 00:00:15 03gammafunk02 {GitHub} 07* 0.22-a0-425-g89d60a1: Merge pull request #758 from ebering/banished-cleanup 10(13 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/89d60a11d804 00:09:50 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-425-g89d60a11d8 (34) 01:24:41 Unstable branch on crawl.develz.org updated to: 0.22-a0-425-g89d60a1 (34) 01:57:50 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-425-g89d60a1 02:53:20 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-425-g89d60a1 03:11:45 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-425-g89d60a1 (34) 10:20:05 this is an odd one https://travis-ci.org/crawl/crawl/jobs/381772221 10:20:11 I don't think it's related to the PR 10:25:45 I guess it's just a random level builder failure, digging a bit deeper 11:09:57 -!- bh is now known as Guest30616 11:34:09 I think this one might have made @crawlcode before, but I always enjoy `return true; //TODO: false` 11:42:55 haha 12:32:35 -!- amalloy_ is now known as amalloy 13:05:20 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-425-g89d60a1 (34) 15:08:18 Hello! I'm working with item-name.cc file right now, is_useless_item portion. Looking at useless types of armor, I see that the scarf with spirit shield ego is useless for a dude with spirit shield. I get why, but it brings another question. Why there is no function that maps pain weapons as useless for dudes without necromancy, or another one for troglodytes and archmagi egos? 15:10:03 I have my no spellcasting mutation and I'm thinking about mapping robes with archmagi egos as useless, but I still don't know if I should. Will it also brand randart robes with multiple properties, archmagi included, as useless? 15:20:32 Scarves are a special case because (correct me if I'm wrong) they don't offer anything except the one special mod. You hit the nail on the head that when other mods can come into play you have to be careful what you filter. 15:39:11 a +2 robe of archmagi is not entirely useless to a trog char; even less so for a +9 bardiche of pain 15:40:15 even a +0 archmagi robe is in principle not entirely useless because it could be enchanted (though there's going to be something better 99% of the time, sure) 15:41:50 Yeah, I thought about that. But staves of Wiz\Conj\Sum got me confused (they are marked as useless for Trog, but you can still smash with them!) 16:08:06 I think strictly staves should not be marked useless, but they are less useful than any of the other non-useless items listed 16:31:53 yeah there's been some discussion about staves before 16:32:50 but basically the thing is without spell schools almost any weapon is better 16:33:11 whereas any possible ego weapon is at the least, not less useful than a plain unbranded weapon 16:34:18 After I add new invalid conditions of handing out sacrifices in sacrifice-data.h - I get "error: too many initializers for 'const sacrifice_def'" in god-abil 16:34:49 I tried to look at god-abil, maybe there are some places where you should block sacrifices also - but it seems there is none 16:36:45 Deformed dudes don't get to sacrifice armor because of the restrictions in sacrifice-data and nothing points to something like that in god-abil file 16:36:58 I am at loss - what exactly do I miss? 16:37:45 Sergeek: Can we see a diff? 16:40:46 I'm sorry, I don't know what that means. You want to see the things I put in sacrifice-data? 16:41:08 Do "git diff", pastebin the results 16:46:14 probably whatever you added has the wrong number of fields (should be 8), or maybe there's a missing comma somewhere 16:47:34 now this is embarrassing - it happened because I used "you.get_mutation" instead of "you.has_mutation" 16:48:54 I really have no clue what is the difference between those, I always simply copied the one that was already present in the same block 16:49:33 get_mutation gets the mutation level, has_mutation returns a bool, but that wouldn't really cause the error you pasted 16:58:03 Ah, yeah, just bad syntax - couple of more tests and now I got it all right 17:00:59 But now I want to know for sure about "has" vs "get_level" - if I don't care for the level of my mutation (like in this case with sacrifices) - it is better to use has, right? 17:08:33 either is fine, has_ just calls get_ internall iirc 17:44:30 !messages 17:44:30 No messages for TZer0. 17:56:29 TZer0: Hi! 17:57:21 I just got linked https://bitbucket.org/TZer0/crawl-docker yesterday, do you have any plans with that in the future ;o? 18:11:11 elliptic: gammafunk suggested I get your opinion on pr 757. The mechanic it adds is to give abyss teleports a (XL dependent, only nonzero for sufficiently high) chance to move the player deeper 18:11:58 The idea is to increase the lethality of the abyss against high XL players but also speed them through it 18:17:50 Oh whoa 18:17:59 (I love it :p) 18:18:18 (My opinion carries no weight I started playing last week, just noting.) 18:19:57 Unstable branch on underhound.eu updated to: 0.22-a0-425-g89d60a11d8 (34) 18:41:43 ebering: it looks reasonable to me 18:42:14 ebering: I'm a little confused by the numbers though - what is "depth" for abyss:4 vs abyss:1? 18:44:30 I guess probably 4 vs 1 and your ~1/4 and ~1/10 are approximating in opposite directions (and the 1/10 is not actually that close to 100/729)? 18:48:06 oh oops 18:49:19 yeah the comment is imprecise 18:51:25 precisely an xl27 char has a 169/729 ~ .23 chance of A:1->A:2 and a 100/729 ~ .13 chance of A:4->A:5 18:51:38 your guess about what "depth" is is correct 19:02:22 -!- amalloy is now known as amalloy_ 19:03:08 03ebering02 07https://github.com/crawl/crawl/pull/757 * 0.22-a0-412-g28ed870: Clarify a comment and checkwhite 10(3 minutes ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/28ed870aff90 19:13:19 ebering: regarding that PR you made about patrolling, I think it's generally ok if those monsters wander away from their vaults, and swamp worms really aren't special in this regard 19:13:39 but if you think that some specific vaults especially benefit from patrolling, that's fine 19:13:41 but it should not be only swamp worms that patrol 19:13:51 probably the vault should just have that tag 19:14:30 we don't have the other lair branch entry vaults use patrolling 19:15:48 gammafunk: ok. the vault in particular that it seems to break is the nicolae one, that really relied on the hide and pop up mechanism of swamp worms 19:16:59 yeah, you could have the worms patrol in that vault 19:17:31 I think that only places swamp worms, but if there are any other types of monsters they should all just patroll 19:17:55 an electric eel sometimes 19:17:58 if the swamp worms are a bit too much they could be thinned out with other appropriate amphibious mosters 19:18:06 hrm, doesn't that one actualy place just eels and swamp worms? 19:18:07 let me go look 19:18:10 yes 19:18:29 nicolae_swamp_entry_splash_gauntlet 19:18:33 that's the one, right? 19:18:56 right, I simplified this one a bit 19:19:00 yes 19:19:00 looks like it always places an eel 19:21:08 I wouldn't even say this vault particularly depends on having the worms in the vault; obviously that makes it worse but this is true of the other vaults 19:22:33 patrolling is basically just trying to make the vault harder, which it can do, but this vault does place 4 swamp worms on average and that's a reasonble threat even if you fight some of them individually 19:23:05 but I would not object to it having patrolling; might be nice to randomize the monsters a bit more anyhow 20:19:22 -!- Guest6901 is now known as Basil 20:26:04 I guess I was thinking more about the flavor loss from the spirit of the vault. That one was memorable with oldstyle worms (one of the few places they actually mattered!) and something has been lost when they can wander off. 20:29:39 yeah, that is certainly thing; feel free to update that PR to make that vault patrolling; it's going to be a little aggravating trying to lure out those worms one at a time 20:30:00 so you might also consider replacing a couple of them with some amphibious thing that doesn't have the harpoon 20:30:42 patrolling generally means you have to do more luring so it's nice if you're a bit judicious about what monsters are in a patrolling vault 21:48:45 -!- ProzacElf_ is now known as ProzacElf 22:10:06 gammafunk: will do after I think it over a bit more 22:11:04 thanks; I'll try to get to your arrival vaults after I finish up this batch of ghost vaults 22:11:24 neato 22:11:50 I've not tried my hand at vaulting before so I have no idea what I'm doing 22:13:06 that's the secret of vault making, no one knows what they're doing 22:13:31 probably the secret to crawl itself, really 22:14:42 shhhh 23:51:40 -!- Basil is now known as Guest51387 23:59:31 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-425-g89d60a1 (34)