00:00:34 well I'll put in a stub for now and sleep on it 00:00:38 i am not good at magic functions 03:03:37 So, what is the raison d'etre for CK and AK? 03:03:53 They just seem like bad fighters compared to Fi, Gl and Be 03:13:45 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-409-gb855193 (34) 03:41:21 muffindrake, AK is seven years old, and CK is even older 03:43:53 the game was pretty different back then, but noone has time to do a comprehensive makeover of every decade old aspect 03:54:37 well, to address comparisons to Fi, Gl, and Be, classes are not balanced in crawl to be of the same difficulty 03:55:04 they're made to be distinct from each other and provide different ways to enjoy the game 03:55:19 CK is now a challenge class that lets you try the Xom conduct all game 03:57:14 and AK has some distinct early game feel depending on what you do in starting abyss and is also a melee-oriented class that's a little more difficult early on in practice 04:00:07 not to say that we would never change something like AK, but it does not need to be as strong as those other classes for it to feel distinct and fun 08:23:27 sometimes i cast orb of destruction and it doesn't appear, there is no sign that it hit a wall (no smoke or anything), no message like 'your ood hits a wall' 08:23:29 but it uses mana 08:23:34 what is happening there? 08:31:42 sounds like a bug 08:36:57 aidanh: what should i do about it? 08:37:38 this has happened multiple times in the game 08:38:18 hm, not every time you cast iood? 08:38:19 always when i've tried to cast diagonally near walls i think. like around the corner of a wall. 08:38:22 I can't reproduce it 08:38:42 oh, I'll try that 08:38:42 aidanh: i could give you the save file 08:38:45 i'm playing offline 08:39:25 Currency: yeah, the move() call is there to remove an unnecessary refcount ++ and -- on the shared_ptr, but if the callback takes a reference to it, it's going to be zeroed out by the move 08:39:46 dds1: I'll try to reproduce first; it's unlikely to be save-specific 08:39:55 aidanh: okay 08:42:29 aidanh: try doing it from a spot near the walls where you are unlikely to hit the enemy anyway 08:42:43 you have to stand adjacent to a wall 08:43:41 yeah, I can reproduce it 08:44:30 could you open a bug report on mantis please? 08:45:58 -!- Euph0ria is now known as TabMasher 08:47:10 aidanh: okay. i'm not good with descriptions though. 08:48:44 you can always upload screenshots to mantis as well 08:49:11 i can't see the link to create an account. i'm on this page - https://crawl.develz.org/mantis/main_page.php 08:49:41 dds1: https://crawl.develz.org/mantis/signup_page.php 08:49:47 top-left 08:51:50 aidanh: sorry about that 08:59:39 When standing adjacent to a wall, orb of destruction fails to appear without any signs of having hit the wall 13https://crawl.develz.org/mantis/view.php?id=11469 by dds 09:01:53 aidanh: created a bug report, does it look okay? also added a note about you reproducing it - https://crawl.develz.org/mantis/view.php?id=11469 09:04:26 yeah, no worries, and that looks fine, but I'll add a screenshot 09:06:08 aidanh: i can't reproduce it in my current game because i want to win :-) 09:13:13 :) 09:15:20 New branch created: pull/757 (1 commit) 13https://github.com/crawl/crawl/pull/757 09:15:20 03ebering02 07https://github.com/crawl/crawl/pull/757 * 0.22-a0-410-gc64a72f: Draw higher XL players deeper into the abyss 10(12 minutes ago, 1 file, 21+ 0-) 13https://github.com/crawl/crawl/commit/c64a72fb0908 09:15:23 Currency: you had a bug with macro save prompts not showing? 09:41:34 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-505-gfaf701d: fixup! Spruce up the god UI 10(29 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/faf701d711e1 09:41:51 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-505-gfaf701d: fixup! Spruce up the god UI 10(29 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/faf701d711e1 09:48:52 the description for pot of brill reads ' potion which greatly increases the intelligence and magical power of one who drinks it.' i almost died just now because i thought it gives mp. however it didn't make any change to my mp, or 'magical power'. i suggest the description be changed to something else. 09:51:44 it increases spellpower 09:52:27 ebering: so it should say something like increases the powers of the spells cast by the one who drinks it 09:53:16 dds1: I agree. I'm not good at words so I don't know exactly what to put there 09:54:15 but! this is an excellent opportunity for you to get into crawl development; you can edit text-files and create a pull request directly in github 09:54:18 the file you want is 09:54:44 would love to if it doesn't involve learning too much git 09:54:47 !source dat/descript/items.txt:#673 09:54:47 Can't find dat/descript/items.txt:#673. 09:54:55 !source crawl-ref/dat/descript/items.txt:#673 09:54:55 Can't find crawl-ref/dat/descript/items.txt:#673. 09:55:02 well I dunno how that works 09:55:19 dds1: there was a tavern thread about how to use the github web interface give me a sec to find it 09:57:00 !source dat/descript/items.txt:673 09:57:01 https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/descript/items.txt#L673 09:57:12 no # for line numbers; it's just file:line 09:57:37 oh thanks 09:58:13 i don't want to have to clone the whole repo to make very small changes of my level. so i hope there's an online way. 10:00:22 so you don't have to clone it to your home computer 10:00:29 I can't find the thread, but 10:00:57 if you have a github account, you can fork the repo (just on github), and use the github web interface to create a branch, edit the file and commit, then submit a pull request 10:01:07 ebering: okay that's fine i'll google in a few hours. ingame now. but thanks for inviting me to participate. i'll be sure to learn it and make the changes. 10:01:12 ebering: okay will remember 10:01:33 dds1: the beauty is I'm not even a dev either, just a community participant 10:01:39 everyone's got to bring a thing to make stone soup 10:01:52 ebering: oh cool! what do you usually do? 10:02:02 which part of the game do you help with? 10:03:16 dds1: I haven't contributed in a few years. when I was sending in patches regularly I did a mix of things. some bug fixing, a big refactor of the potion code, little things here and there as it strikes my fancy 10:04:34 potions of ambrosia and pieces from xoms chessboard are two items I wrote 10:04:38 ebering: that's cool. i'm going to be learning c++ too, maybe i'll do something like you too. 10:04:42 nice! 10:08:40 the devteam is friendly and patient and generous with their time when it comes to giving feedback on your ideas and code, it's a fun project to contribute to 10:09:11 i can tell, the few times i've brought up an issue it's been handled so well 10:16:46 oh ya, I co-wrote this post with PleasingFungus when I was contributing a lot in .16 about community contributions: http://crawl.develz.org/wordpress/community-contributions 10:17:02 I should do another one of those for .22 or something 10:23:23 if I noticed a small code cleanup issue while writing this PR should I just add another commit to it or make a separate PR with the cleanup issue? 10:23:50 (specifically banished() calls push_features_to_abyss() twice even though at that point in the execution each call does the same thing) 10:24:46 generally better to keep them separate 10:25:31 things like the abyss change you mentioned tend to take a lot of review time; quick fixes can go in "immediately" 10:33:22 the days of rash push and find out are over I see 10:35:06 well, devs need to playtest it 10:45:48 I'm not sure pleasing fungus did that for the first ambrosia patch, which made it to trunk before the bug that the regen lasted forever was noticed 10:46:11 :) 10:49:58 New branch created: pull/758 (1 commit) 13https://github.com/crawl/crawl/pull/758 10:49:58 03ebering02 07https://github.com/crawl/crawl/pull/758 * 0.22-a0-410-gad65372: Code cleanup 10(10 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/ad653724b05d 10:50:13 aidanh: Yes. Does that yesno show correctly for you? 10:50:35 To clarify it was the prompt that comes up after death to save the macros 10:57:20 oh ok, yeah, that'd make a difference 11:19:54 so uh, if I merge https://crawl.develz.org/mantis/view.php?id=10855 is there going to be rioting in the streets? 11:20:19 that white dream sheep shadow has been bugging me for a while 11:21:08 I think the flayed ghost here https://crawl.develz.org/mantis/view.php?id=9864 is definitely an improvement 11:21:33 and is it finally time for a cockroach unique? https://crawl.develz.org/mantis/view.php?id=8287 11:24:45 that new flayed ghost could be redder? 11:34:05 more saturated? perhaps 12:22:53 Diggin up the OG mantis posts. 12:34:11 flavor bug: borg's clutch says vile hands spring forth from the earth when cast over water 12:35:33 well they're springing forth from the earth that's under the water 12:38:21 -!- PsyMar2 is now known as PsyMar 12:51:57 -!- amalloy_ is now known as amalloy 13:04:57 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-409-gb855193 (34) 13:06:18 Offered same spell twice by Vehumet. 13https://crawl.develz.org/mantis/view.php?id=11470 by NormalPerson7 13:31:08 weird 13:33:41 does vehumet not just add all those spells to your library, now that we have a spell library? you actually get the spell *removed* from your library when vehumet offers a new gift? 13:34:31 i guess so 13:40:20 haha, good bug 13:41:32 you'd better be thankful veh gives you the privelege of remembering it! 13:49:41 there was a bit of discussion on the PR about whether veh should be changed to add to the library but i guess it never got done 13:50:54 Is spell hunger here to stay? 14:16:41 -!- PsyMar2 is now known as PsyMar 14:18:29 -!- Bammboobies is now known as Bammboo 14:40:41 gammafunk: in principle it's not a "bug", i think, but could be WAI. if vehumet can't find any spells to offer you that are within the desired power level that you haven't seen before, the fallback is to re-offer a spell you've been offered before 14:41:28 so if you find a lot of spellbooks you might be offered a spell twice that's not in any of those books 15:33:27 -!- TabMasher is now known as OICU812 17:25:19 -!- gresshopper is now known as gressup 18:20:12 Unstable branch on underhound.eu updated to: 0.22-a0-409-gb855193d78 (34) 20:30:11 -!- amalloy is now known as amalloy_ 21:15:07 omg test status is so useful 21:16:50 `goto move_again;` :-( 21:33:42 test status? 21:36:00 heh, I notice some iood code related to interacting with submerged monsters 21:40:41 *statue 21:53:51 oh, haha 21:53:58 I was pretty confused 21:55:36 03advil02 07* 0.22-a0-410-g97be04f: Fix messaging for oods that have just been created (11469) 10(6 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/97be04f903ed 22:05:48 is (0,0) ever visible in normal play to a monster? I feel some step from time bugs have happened due to something like that 22:09:54 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-410-g97be04f903 (34) 22:11:40 iirc (0,0) is used as a not-place a lot 22:12:00 both by step from time, and for some monster related things. which causes problems when step from time places you there 22:15:52 New branch created: gcc_cxx_assert (1 commit) 13https://github.com/crawl/crawl/tree/gcc_cxx_assert 22:15:52 03advil02 07[gcc_cxx_assert] * 0.22-a0-409-g7b63a65: Try an extra check for gcc 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7b63a6544251 22:19:26 yeah, I think 0,0 is being used as a fake place here because there might be no actual first position (in exactly the case that was causing a messaging error) 22:20:16 that iood could use some cleanup but it's rather alarming 22:20:24 *iood code 22:20:42 floats *and* gotos 22:21:18 just poping in to thank you guys for not stealing any ideas from me in the past year 22:29:18 we're just figuring out which stolen idea would hurt you the most if we implemented it 22:32:40 hah yall thought it would be hurtful, probably, to remove piza and who pissed a bit? not me 23:31:04 -!- muffindrake1 is now known as muffindrake 23:59:35 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-410-g97be04f (34)