01:24:19 Unstable branch on crawl.develz.org updated to: 0.22-a0-402-ga933591 (34) 01:57:52 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-402-ga933591 02:53:16 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-402-ga933591 03:11:44 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-402-ga933591 (34) 03:28:31 -!- TabMasher is now known as OICU812 05:59:05 -!- pikaro_ is now known as pikaro 08:44:30 -!- svendre_ is now known as svendre 09:10:43 -!- XXX is now known as Guest98243 09:17:14 for some reason my instinct is not to put code formatting tests in CI 09:19:51 any reason why? they could eliminate the regular unbrace commits, and they aren't exactly taxing on the CPU 09:21:16 advil: separately, I don't see any remaining issues with chequers' datify PR, but I've held off on merging in case you (or others) spot something I missed 09:25:05 I think part of my instinct is that the problem that chequers is trying to solve specifically with that commit (new committers) isn't a technical problem 09:25:28 aidanh: that does probably need some testing to verify that it doesn't break servers 09:25:47 or it not testing some verification that it wouldn't 09:25:50 since I think it adds executing a python script to the makefile? 09:26:31 yes, with some specific version requirements 09:26:43 right, that was the only concern I had 09:26:56 yeah, that makes sense 09:28:39 s/it not/if not/ 09:29:06 also, except in branches it won't actually stop the checkwhite/unbrace commits, and there only if people actually bother to rebase them 09:29:19 does it require python3? 09:29:42 iirc it does, I didn't spot any hard dependencies on python 3 though some it might be ok with some import from future stuff 09:29:53 yeah, so that's a problem for cdo 09:30:03 which I see only has python2.7 09:30:24 I think webtiles depends on python2 minimally, unless I'm just misremembering 09:30:29 yes 09:30:35 it won't actually run on python 3 09:30:44 yeah, ok, so that's probably the main issue 09:31:02 I'm sure the script can be ported to run on 2 09:31:12 but as long as webtiles depends on python2 we probably shouldn't force python3 for this one script 09:31:34 porting webtiles to python3 is probably a nice thing to do, but someone has to work on that 09:31:56 maybe |amethyst has some thoughts about all of that, since there are probably admin issues I'm not aware of 09:32:13 cao might be another server without python3, but maybe it's only cdo 09:33:22 probably updating the tornado dependency needs to come first (that's something I want to do, but it's logistically annoying) 09:34:03 <|amethyst> This script is needed for all builds, not just webtiles, right? 09:34:12 yes 09:34:29 aidanh: I'm not hard opposed to adding that as a test, it would definitely automate a common comment that we have to make on first PRs 09:34:41 <|amethyst> How complicated is the Python stuff? I haven't looked at the branch 09:34:48 it's not complicated 09:34:53 <|amethyst> my first thought would be rewrite it in Perl 09:34:57 haha 09:35:00 <|amethyst> since we already depend on Perl for the build process 09:35:14 I would ... not prefer that option 09:35:18 :-P 09:36:47 |amethyst: https://github.com/alexjurkiewicz/crawl-ref/blob/383b4fed98c33140618616973fc558a8b822f477/crawl-ref/source/util/species-gen.py 09:37:32 absolutely something that could be rewritten in perl in terms of complexity, but yeah perl is less popular as a choice :) 09:43:26 I will get the datify PR and play around with it, I haven't done that yet 09:58:39 !seen johnstein 09:58:39 I last saw johnstein at Sun May 6 03:58:47 2018 UTC (9h 59m 52s ago) joining the channel. 10:04:54 the yaml dependency might also be something that servers will need to update for 10:07:42 oh, I'm not sure str.format exists in python 2 10:10:55 ugh my python 2 install doesn't have pip installed on this computer 10:11:11 that recent xkcd about python is very apropos right now 10:16:12 ok nm about str.format 10:16:29 this script seems to run just fine under python 2.7 10:17:08 same version I run webtiles with 10:50:42 -!- EuphOria is now known as OICU812 10:51:54 I'm going to be unable to not impose my python preferences on this 10:56:29 like don't inherit from dict 10:56:40 which is funny because I barely even noticed that when reviewing 10:57:21 New branch created: datafiles (11 commits) 13https://github.com/crawl/crawl/tree/datafiles 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-279-g23013df: Simplify XL7 draconian randomisation 10(7 weeks ago, 3 files, 21+ 16-) 13https://github.com/crawl/crawl/commit/23013dfe8911 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-280-ga90d2a0: Generate species data from YAML files 10(7 weeks ago, 62 files, 2846+ 2679-) 13https://github.com/crawl/crawl/commit/a90d2a06c175 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-281-gcbef7eb: Clean up random/viable character selection 10(13 days ago, 6 files, 77+ 84-) 13https://github.com/crawl/crawl/commit/cbef7ebc52f4 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-282-gf2d15f2: Document species/jobs missing recommendations 10(13 days ago, 2 files, 6+ 2-) 13https://github.com/crawl/crawl/commit/f2d15f24e00c 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-283-g3e56be5: species: Make difficulty mandatory 10(10 days ago, 12 files, 13+ 3-) 13https://github.com/crawl/crawl/commit/3e56be5e93d7 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-284-g7dbdc1e: Use filter_enum instead of do-while loops. 10(2 days ago, 3 files, 42+ 24-) 13https://github.com/crawl/crawl/commit/7dbdc1e0af04 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-285-ga0e895c: De-duplicate VIABLE/RANDOM newgame species/job logic 10(2 days ago, 1 file, 42+ 50-) 13https://github.com/crawl/crawl/commit/a0e895c0a4e8 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-286-gfbbd00b: various bug fixes to newgame species/job selection 10(14 hours ago, 2 files, 29+ 12-) 13https://github.com/crawl/crawl/commit/fbbd00b06608 10:57:24 03alexjurkiewicz02 07[datafiles] * 0.22-a0-287-g383b4fe: more fixes 10(13 hours ago, 10 files, 31+ 29-) 13https://github.com/crawl/crawl/commit/383b4fed98c3 10:57:24 03advil02 07[datafiles] * 0.22-a0-288-gbf7c31b: Change species generation to python 2.7 10(30 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/bf7c31b779ee 10:57:24 03advil02 07[datafiles] * 0.22-a0-289-g9201aa5: Format/refactor for 80 columns 10(8 minutes ago, 1 file, 79+ 40-) 13https://github.com/crawl/crawl/commit/9201aa59e481 10:58:21 I'm not sure this is very practical logistically but I'm definitely not going to be able to go over this in one setting (or even necessarily a few days) so I wanted to push to somewhere 10:58:33 *one sitting 11:01:08 I'll be interested to see if the change to 2.7 passes travis, I couldn't spot anywhere that pyyaml is explicitly installed, and I doubt it will be installed by default 11:01:14 but we'll see 11:02:59 wasn't there some kind of setting where people with commit access to the target repo could push to a PR branch? maybe that would make sense here, if chequers is willing 11:07:21 wouldn't that'd require write access to their repo? or do you mean switching the ref the PR tracks? 11:07:50 it was a github thing specifically, I don't think it required full write access 11:09:10 oh ok, that sounds convenient yeah 11:10:11 https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ 11:11:57 thanks 11:54:29 The build passed. (datafiles - 9201aa5 #9597 : advil): https://travis-ci.org/crawl/crawl/builds/375555898 11:59:21 huh, ok 12:14:32 03advil02 07[datafiles] * 0.22-a0-290-g9ef5112: Don't inherit from dict, use constructor instead of factory function 10(3 minutes ago, 1 file, 56+ 40-) 13https://github.com/crawl/crawl/commit/9ef5112fbdfa 13:01:59 03advil02 07[datafiles] * 0.22-a0-291-ge24a7fb: Make build dependencies more specific 10(30 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e24a7fb3aca0 13:01:59 03advil02 07[datafiles] * 0.22-a0-292-geca3f6f: Handle empty mutation lists a bit better 10(36 seconds ago, 2 files, 17+ 15-) 13https://github.com/crawl/crawl/commit/eca3f6f3564f 13:06:43 03advil02 07[datafiles] * 0.22-a0-293-g08ee2c8: Add entry format description to header for species-data.h 10(51 seconds ago, 1 file, 19+ 0-) 13https://github.com/crawl/crawl/commit/08ee2c857f5f 13:25:30 -!- GiantOwl is now known as Kalir 14:08:24 03advil02 07[datafiles] * 0.22-a0-294-g648d254: Don't set recommended weapons for non-starting species 10(29 minutes ago, 1 file, 16+ 14-) 13https://github.com/crawl/crawl/commit/648d2540c07b 14:08:24 03advil02 07[datafiles] * 0.22-a0-295-gd0c7f61: Fix undead type 10(13 minutes ago, 3 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/d0c7f61ef533 14:08:24 03advil02 07[datafiles] * 0.22-a0-296-g2fc61c5: Add walk/pray verbs to SP_UNKNOWN 10(58 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/2fc61c518aed 14:11:52 03advil02 07[datafiles] * 0.22-a0-296-g2525d87: Add walk/pray verbs to SP_UNKNOWN and deprecated species 10(4 minutes ago, 2 files, 10+ 0-) 13https://github.com/crawl/crawl/commit/2525d8704819 14:27:21 -!- MadCoyote is now known as FunkyBomb 14:31:54 03advil02 07[datafiles] * 0.22-a0-297-gd4cb019: Handle demigod stats properly 10(2 minutes ago, 3 files, 15+ 6-) 13https://github.com/crawl/crawl/commit/d4cb019f9d34 14:32:54 so far the only actual errors I've found are undead type, and demigod stats (which might well have been ignored, I didn't check the code that uses those values) 14:53:42 Does anyone know if a monster's turn of creation is already tracked, please? 15:01:34 03advil02 07[datafiles] * 0.22-a0-298-gb142bda: Warn on unknown fields in the main list of species properties 10(88 seconds ago, 1 file, 18+ 0-) 13https://github.com/crawl/crawl/commit/b142bdad310e 15:01:56 I don't believe so 15:02:32 some of that would be indirectly available if you could determine that the monster was a level spawn from normal placement or a vault 15:02:45 then you just need the turn the player first entered said level 15:07:48 Bother. Thanks anyway. 15:30:50 The build passed. (datafiles - d4cb019 #9603 : advil): https://travis-ci.org/crawl/crawl/builds/375608863 16:15:48 The build passed. (datafiles - b142bda #9604 : advil): https://travis-ci.org/crawl/crawl/builds/375616391 18:21:42 -!- yesno_ is now known as yesno 19:09:22 hello. how do i find the offline dump for characters won? i could do it with # for ingame characters but where are the txt files for those who have won? 19:10:07 i'm on linux, ubuntu 19:11:07 i have looked in ~/.crawl/morgue but it only shows the last dump taken. where is the data for the ingame highscores read from? that shows my winning character's dump but i can't find its file 19:11:45 <|amethyst> hm, it should be in ~/.crawl/morgue/morgue-charname-date-time.txt 19:12:53 |amethyst: got it, looking, thanks. i was confused because there were also just charname.txt dumps 19:13:14 <|amethyst> ah 19:13:34 <|amethyst> yeah, the morgue files for dead and won characters are names such that they won't be overwritten by future games 19:13:53 <|amethyst> while charname.txt from # will be the next time you do # on a char of the same name 19:14:20 <|amethyst> s/are names/are named/ 20:52:43 New branch created: pull/755 (1 commit) 13https://github.com/crawl/crawl/pull/755 20:52:43 03Doesnty02 07https://github.com/crawl/crawl/pull/755 * 0.22-a0-403-ga598997: Fix Stomp description 10(19 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a5989978b151 22:41:49 Hello! Is someone in here? I want to ask a question about creating player species. 22:42:50 Mainly I don't know what "corresponding monster" is supposed to be in species-data 22:43:05 I can put any MONS there and it seems to work just fine 22:45:43 <|amethyst> it's not used for much 22:46:21 So I don't really need to make an actual monster for my species to work properly? 22:47:34 <|amethyst> it's used for tile_show_player_species, for same-genus checks (cannibalism mostly), and maybe one or two other things I can't think of at the moment 22:48:02 <|amethyst> it would be kind of nice to have something to put in the species gallary arrival vaults 22:49:25 <|amethyst> the monster doesn't have to actually appear anywhere in game, just in mon-data.h 22:50:00 <|amethyst> but at least for testing purposes it's fine to just pick a monster and use it