01:05:07 Draconian Berserker of Trog can end up with spellcasting aptitudes 13https://crawl.develz.org/mantis/view.php?id=11452 by josh 02:07:22 amalloy: hm, I guess I didn't look closely enough at the actual implementation of the LineReader types 02:08:07 although, the contents of the options file will be included in the dump, so utf stuff has to be handled on that end as well 02:10:55 well. producing a malformed dump file is something we already do somewhat regularly, and a nuisance but not a big deal. failing to read in a correct config file is a bigger deal 02:12:54 !tell chequers i don't think `git diffbase a..b` will tell you if you rebased correctly. `git diff a..b` probably would 02:12:55 amalloy: OK, I'll let chequers know. 03:11:43 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-369-gc73351f (34) 08:50:17 emperorscorpion (L16 GnSk) ASSERT(in_non_diamond_int(r.start)) in 'ray.cc' at line 217 failed. (D (Sprint)) 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-369-g864ee37: Allow ghosts built from bones files to be placed in vaults 10(4 months ago, 7 files, 119+ 5-) 13https://github.com/crawl/crawl/commit/864ee3737e19 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-370-gc5ebc23: Add some ghost mini-vaults that will place in Vaults 10(4 months ago, 1 file, 36+ 1-) 13https://github.com/crawl/crawl/commit/c5ebc234aa5c 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-371-g9494f11: Add a description line for mirrored player ghosts 10(4 months ago, 5 files, 9+ 3-) 13https://github.com/crawl/crawl/commit/9494f11c4b11 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-372-ge1cfe05: Add a permanent store for some fallback ghosts 10(4 months ago, 3 files, 197+ 99-) 13https://github.com/crawl/crawl/commit/e1cfe058fe32 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-373-gf8544e0: Don't use permastore when rewriting on level veto 10(4 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f8544e074de5 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-374-g2cd10e7: Tweak ghost vault generation rates 10(4 months ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/2cd10e7afc61 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-375-gff08da7: Don't spawn randomly-placed ghosts on level generation 10(4 months ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/ff08da74b210 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-376-g958d761: Let ghosts use stairs 10(4 months ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/958d7619febf 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-377-g3395f5e: Use CHANCE rather than WEIGHT for non-Vaults ghost vaults 10(4 months ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/3395f5e703be 10:56:27 03advil02 07https://github.com/crawl/crawl/pull/700 * 0.22-a0-378-g30acc4a: Various vault adjustments based on feedback 10(8 weeks ago, 1 file, 35+ 26-) 13https://github.com/crawl/crawl/commit/30acc4a4f3b3 10:56:27 ... and 6 more commits 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-369-g864ee37: Allow ghosts built from bones files to be placed in vaults 10(4 months ago, 7 files, 119+ 5-) 13https://github.com/crawl/crawl/commit/864ee3737e19 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-370-gc5ebc23: Add some ghost mini-vaults that will place in Vaults 10(4 months ago, 1 file, 36+ 1-) 13https://github.com/crawl/crawl/commit/c5ebc234aa5c 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-371-g9494f11: Add a description line for mirrored player ghosts 10(4 months ago, 5 files, 9+ 3-) 13https://github.com/crawl/crawl/commit/9494f11c4b11 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-372-ge1cfe05: Add a permanent store for some fallback ghosts 10(4 months ago, 3 files, 197+ 99-) 13https://github.com/crawl/crawl/commit/e1cfe058fe32 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-373-gf8544e0: Don't use permastore when rewriting on level veto 10(4 months ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f8544e074de5 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-374-g2cd10e7: Tweak ghost vault generation rates 10(4 months ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/2cd10e7afc61 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-375-gff08da7: Don't spawn randomly-placed ghosts on level generation 10(4 months ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/ff08da74b210 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-376-g958d761: Let ghosts use stairs 10(4 months ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/958d7619febf 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-377-g3395f5e: Use CHANCE rather than WEIGHT for non-Vaults ghost vaults 10(4 months ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/3395f5e703be 10:56:30 03advil02 07[spooky_vaults] * 0.22-a0-378-g30acc4a: Various vault adjustments based on feedback 10(8 weeks ago, 1 file, 35+ 26-) 13https://github.com/crawl/crawl/commit/30acc4a4f3b3 10:56:30 ... and 6 more commits 11:17:48 03NormalPerson702 07https://github.com/crawl/crawl/pull/740 * 0.22-a0-356-g372cf42: Revert "Read in options file manually rather than using FileLineInput (aidanh)" 10(4 minutes ago, 2 files, 12+ 14-) 13https://github.com/crawl/crawl/commit/372cf424fd19 11:49:54 No Wizlab timing announcements 13https://crawl.develz.org/mantis/view.php?id=11453 by Le_Nerd 12:21:57 Swamp worm harpoon shot correction 13https://crawl.develz.org/mantis/view.php?id=11454 by Angani 13:05:19 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-369-gc73351f (34) 14:01:27 johnstein: Report from Angani that user BigieCheese is spamming copypasta in tiles chat, if you have time to take a look 14:02:05 johnstein: angani says he can provide logs if need be 15:06:20 I have a vague memory of hearing about that username before 15:06:22 I will merge the muting stuff soon (TM) 17:45:59 ヽ(´▽｀*)ノ 17:46:01 dammit 18:24:30 Dithmenos still suppresses Ds ignite blood 13https://crawl.develz.org/mantis/view.php?id=11455 by gameguard 18:26:12 MummyMadness (L23 OpAr) ASSERT(!invalid_monster(&mons)) in 'mon-death.cc' at line 1904 failed. (Depths:1) 19:24:12 Can someone help me understand the value of get_item_info() in item.cc. Looks like its essentially a partial copy constructor. It's called frequently in the tiles code. What is the value in using this rather than the original item_def in these cases? 19:27:01 the idea is to not copy things the player doesn't know about, to avoid info leaks 19:28:31 I'm going to push some commits, one of which fixes 11455 reported up there, in case anyone was working on that 19:28:38 or thinking about it 19:33:50 Duvessa misspelling 13https://crawl.develz.org/mantis/view.php?id=11456 by UsaSatsui 19:58:05 I guess my qualm was specifically with the graphics/tiles/dolls code. The original intent is clear. 19:58:35 In tiledolls.cc for example: item = new item_def(get_item_info(*you.slot_item(EQ_WEAPON))); 20:00:31 well, same thing -- the appearance of the doll shouldn't reflect any information that the player doesn't have 20:00:42 though these days i don't think it's possible to be wielding anything and not have full ID of it 20:01:00 if it's a weapon, at least 20:03:40 Yeah I'm having a hard time imagining what use case the ui would have to care. That particular case seems to me like 2 copy constructors are being called when the original item would do. 20:06:07 At least in terms of drawing tiles, dolls, etc. It's fairly consistent though so I thought I could be missing something. 20:30:07 Currency: Perhaps it's a relic of an idea that there might be a trust boundary 20:33:21 I think it's probably the case that the tiledoll code should be using the item info class rather than wanting an item def 20:34:09 it could be the case that the item info class somehow isn't robust enough to get the info the tiledoll code wants, but then the item info class would just need to be expanded a bit 20:38:36 item_info and item_def are the same. It's a typedef. 20:40:04 yeah, that's probably not a great design, we have a distinct class for monsters 20:40:12 but maybe that's sufficient for items 20:40:50 but I assume it's simply doing the "item_info" recreation specifically to avoid that information leak that was mentioned 20:42:01 so if there's no distinct class, that's fine, but your question was basically "why is the tiledoll code recreating the item_def in this way?" 20:42:11 and as far as I understand, the answer is just to avoid the information leak 20:42:21 the get_item_info function does some information stripping 20:42:45 there's a comment to that effect where the function is defined 20:53:45 New branch created: pull/743 (1 commit) 13https://github.com/crawl/crawl/pull/743 20:53:45 03Jacob Meigs02 07https://github.com/crawl/crawl/pull/743 * 0.22-a0-370-gdbcc06b: Updated get_item_info() specifically for decks. Added note for decks used_count which can be negative. Bugfix for issue #11435 10(4 minutes ago, 2 files, 7+ 31-) 13https://github.com/crawl/crawl/commit/dbcc06b7a348 20:56:37 Currency: is that PR yours? 20:57:06 Yes 20:57:22 ok, thanks for submitting that, but one pointer about commit messages 20:58:17 ..weird 20:58:28 ? 20:58:46 oh, just the way it was printed in irc 20:59:09 but our commit message style 20:59:09 72 chars max on first line as the commit title 20:59:19 then blank line, then 74-max (or 72 if you prefer, just less than 74) for the commit body lines 20:59:59 it allows the commit message to format properly when displayed in irc and from shell without wrapping 21:00:39 and generally just make the title a simple summary of what the commit is instead of trying to string together sentences 21:00:45 can put more detail in the commit body 21:01:05 Ah ok. I see other's now too. I agree, much more readable. Should I re-submit then? 21:01:19 you can simply force push a commit with the updated message 21:01:29 the PR just tracks your branch so will get updated accordingly 21:01:37 as long as it goes to the same branch 21:01:41 no need to recreate the PR 21:02:04 Oh that's convenient. 21:02:19 This is my second one. I'll get them both. 21:02:28 thanks! 21:05:20 also, good commit messages are in imperative tense: "Make things better" rather than "Made things better" 21:17:24 03gammafunk02 07* 0.22-a0-370-g6ec6d78: Mark some Pakellas code for removal when the major version changes 10(2 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/6ec6d7893a42 21:17:24 03gammafunk02 07* 0.22-a0-371-g609ae0a: Allow the ignite blood demonspawn mutation under Dith (gameguard) 10(2 hours ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/609ae0a0b197 21:17:24 03gammafunk02 07* 0.22-a0-372-g01d5f99: Allow fire facet mutant beasts under Dith and remove unused code 10(85 minutes ago, 5 files, 8+ 30-) 13https://github.com/crawl/crawl/commit/01d5f99b3441 21:17:24 03gammafunk02 07* 0.22-a0-373-gab1296c: Allow brand weapon scrolls to give flaming and chaos brands under Dith 10(62 minutes ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/ab1296cafb1c 21:17:34 03Jacob Meigs02 07https://github.com/crawl/crawl/pull/743 * 0.22-a0-370-g5aab7cc: Update to get_item_info() specifically for decks. 10(28 minutes ago, 2 files, 7+ 31-) 13https://github.com/crawl/crawl/commit/5aab7cc3d9c0 21:18:43 *cough* imperative isn't a tense 21:18:48 yes, yes 21:19:11 english doesn't have moods, though 21:19:22 i had a mood once 21:19:28 if english doesn't have moods, then what's the imperative? :-P 21:19:30 or so i recall hearing from people who know linguistics better than i do 21:19:47 okay, so i am wrong 21:19:51 it's just a mood. rip 21:22:59 well, in fairness it's not entirely obvious that mood is the best term for it 21:23:03 some people just use clause type 21:23:40 anyways, does anyone know why crawl doesn't generate bones when Options.seed is set? 21:24:44 I've been tearing my hair out over why qw doesn't generate ghosts and it turns out it's just because this expect script sets a seed 21:28:14 03Jacob Meigs02 07https://github.com/crawl/crawl/pull/742 * 0.22-a0-364-g99b43ba: Decoupled hi-score logic from ouch. 10(31 hours ago, 5 files, 84+ 50-) 13https://github.com/crawl/crawl/commit/99b43ba0bbd5 21:28:38 seeds are probably just supposed to be for testing 21:28:52 you don't want to generate a bunch of garbage bones files every time you run tests 21:38:54 03Jacob Meigs02 07https://github.com/crawl/crawl/pull/742 * 0.22-a0-364-g25ecaec: Decouple hi-score logic from ouch. 10(31 hours ago, 5 files, 84+ 50-) 13https://github.com/crawl/crawl/commit/25ecaec2c295 21:39:19 I suppose that makes sense 21:44:13 03Jacob Meigs02 07https://github.com/crawl/crawl/pull/743 * 0.22-a0-370-gf763617: Update to get_item_info() specifically for decks. 10(54 minutes ago, 2 files, 7+ 31-) 13https://github.com/crawl/crawl/commit/f7636178565a 21:49:37 Weapon brand messages print after fragile weapon crumbles to dust 13https://crawl.develz.org/mantis/view.php?id=11457 by josh 21:54:15 huh, a qw sp just died of hunger 21:59:18 oh no, now the devs will keep food in crawl for the next 3 versions 22:05:10 Whats the new race/class? 22:09:53 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-373-gab1296cafb (34)