00:00:04 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-352-gc608dd7 (34) 00:13:01 -!- ProzacElf_ is now known as ProzacElf 00:32:13 -!- amalloy_ is now known as amalloy 01:24:33 Unstable branch on crawl.develz.org updated to: 0.22-a0-352-gc608dd7 (34) 01:57:04 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-352-gc608dd7 02:52:41 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-352-gc608dd7 03:11:51 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-352-gc608dd7 (34) 03:30:01 03NormalPerson702 {Aidan Holm} 07* 0.22-a0-353-g2d6336e: Fix an extra "the" in "It would be a sin to butcher..." (Reeces) 10(10 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2d6336e71891 04:09:48 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-353-g2d6336e718 (34) 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-354-gbfbebb0: Add CK_RESIZE to console input handling 10(6 months ago, 4 files, 57+ 15-) 13https://github.com/crawl/crawl/commit/bfbebb01c90a 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-355-gcda64d0: Add tile_def_info() helper 10(5 months ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/cda64d05ff43 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-356-ga330d78: Add hierarchical UI system 10(5 months ago, 4 files, 801+ 1-) 13https://github.com/crawl/crawl/commit/a330d786a2c6 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-357-gd6c5fb7: Add widget preferred size caching 10(5 months ago, 2 files, 16+ 1-) 13https://github.com/crawl/crawl/commit/d6c5fb7e3679 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-358-g15a5c96: Add crt/sdl-specific widget margin helpers 10(5 months ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/15a5c9606754 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-359-gf92532b: Add rowspan, colspan, and flex_grow to grid 10(5 months ago, 2 files, 84+ 56-) 13https://github.com/crawl/crawl/commit/f92532be3df1 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-360-g2770ddf: Add UI scissor stack 10(5 months ago, 2 files, 50+ 2-) 13https://github.com/crawl/crawl/commit/2770ddf4f612 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-361-ga5e2028: Add text widget 10(4 months ago, 2 files, 188+ 0-) 13https://github.com/crawl/crawl/commit/a5e20284a65c 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-362-g73e6b4e: Only render visible grid rows 10(5 months ago, 2 files, 41+ 10-) 13https://github.com/crawl/crawl/commit/73e6b4e13ad5 04:11:52 03Aidan Holm02 07https://github.com/crawl/crawl/pull/728 * 0.22-a0-363-g1e9d56e: Add UI widget event observer API 10(4 months ago, 4 files, 307+ 50-) 13https://github.com/crawl/crawl/commit/1e9d56e211c0 04:11:52 ... and 82 more commits 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-354-gbfbebb0: Add CK_RESIZE to console input handling 10(6 months ago, 4 files, 57+ 15-) 13https://github.com/crawl/crawl/commit/bfbebb01c90a 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-355-gcda64d0: Add tile_def_info() helper 10(5 months ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/cda64d05ff43 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-356-ga330d78: Add hierarchical UI system 10(5 months ago, 4 files, 801+ 1-) 13https://github.com/crawl/crawl/commit/a330d786a2c6 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-357-gd6c5fb7: Add widget preferred size caching 10(5 months ago, 2 files, 16+ 1-) 13https://github.com/crawl/crawl/commit/d6c5fb7e3679 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-358-g15a5c96: Add crt/sdl-specific widget margin helpers 10(5 months ago, 1 file, 13+ 0-) 13https://github.com/crawl/crawl/commit/15a5c9606754 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-359-gf92532b: Add rowspan, colspan, and flex_grow to grid 10(5 months ago, 2 files, 84+ 56-) 13https://github.com/crawl/crawl/commit/f92532be3df1 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-360-g2770ddf: Add UI scissor stack 10(5 months ago, 2 files, 50+ 2-) 13https://github.com/crawl/crawl/commit/2770ddf4f612 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-361-ga5e2028: Add text widget 10(4 months ago, 2 files, 188+ 0-) 13https://github.com/crawl/crawl/commit/a5e20284a65c 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-362-g73e6b4e: Only render visible grid rows 10(5 months ago, 2 files, 41+ 10-) 13https://github.com/crawl/crawl/commit/73e6b4e13ad5 04:11:59 03Aidan Holm02 07[ui-overhaul] * 0.22-a0-363-g1e9d56e: Add UI widget event observer API 10(4 months ago, 4 files, 307+ 50-) 13https://github.com/crawl/crawl/commit/1e9d56e211c0 04:11:59 ... and 82 more commits 04:15:37 lovely 04:16:19 i see those entries have been duplicated by cheibriados too 04:17:29 thankfully chei stops short at ten entries 04:18:11 probably not worth fixing the duplication; having a large branch with its own PR isn't all that common 04:18:25 yea 04:22:43 realistically, there's just not much point in PRs for branches that size; people rarely have the time to do more than glance at them 04:23:24 right 04:40:30 have you had a chance to look at my two other bugfix prs yet? 04:53:20 -!- amalloy is now known as amalloy_ 05:12:59 The build was fixed. (ui-overhaul - b258633 #9489 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/366430419 05:47:39 New branch created: pull/738 (6 commits) 13https://github.com/crawl/crawl/pull/738 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-260-g98a31b2: All commits up to 9th April 10(5 days ago, 261 files, 1333+ 1142-) 13https://github.com/crawl/crawl/commit/98a31b2f0f5a 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-261-g1ff23eb: gammafunk's Hellbinder wizlab nerf 10(5 days ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/1ff23eb071b2 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-351-gc641d5d: Merge the two branches, to try to start again 10(4 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/c641d5d7817c 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-349-ga347eca: gammafunk's Hellbinder wizlab nerf 10(5 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a347ecad815f 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-353-g0caed0c: Merge branch 'master' of https://github.com/NormalPerson7/crawl 10(13 hours ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/0caed0ccebf1 05:47:40 03NormalPerson702 07https://github.com/crawl/crawl/pull/738 * 0.22-a0-354-g1d74110: Add reference to * direction as alternative to ctrl+direction (#11401) 10(13 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/1d74110626e8 10:10:44 I'm having some trouble compiling 10:11:34 Error: https://pastebin.com/B88sXBsx 10:11:53 I'm on ubuntu, gcc 5.4.0 10:44:12 foxor: unusual that you're getting an internal compiler error 10:45:19 what's your build command? 11:06:07 "Although the central place for this kind of discussion is on the CDO wiki, some may find it helpful to discuss potential requests and suggestions here first." 11:06:16 I wonder who is able to edit that 11:06:31 advil: where is this? 11:06:44 tavern, it's the short description for GDD 11:06:56 mpa and I are mods, so we can edit 11:06:59 I'll go update it 11:07:01 I had never even noticed it, but there's a reddit question about it 11:07:48 it's a fair question of where such discussion should be 11:07:58 we should probably refer people to ##crawl-dev 11:08:16 yeah, these days that seems right 11:08:16 do we have a guide doc for contributions? 11:08:53 https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/contribution-process.txt ? 11:09:11 that could probably use editing too though 11:09:18 yeah 11:09:26 wonder if that doc might be better as a github wiki page? 11:09:34 yeah probably 11:09:45 doc features crd way too prominently 11:10:04 yeah 11:10:17 I guess no one currently active is an email person (I'm def not) 11:10:32 it hadn't been used too much for some years 11:12:17 advil: wasn't there a doc that went into a bit more detail for outside constributions? 11:12:21 maybe I can just link to that 11:12:34 I drafted something on the wiki, it might still need some editing -- it is more about setting expectations 11:12:42 could be merged with that doc I just linked 11:13:08 probably should be in fact 11:13:13 this is the thing I drafted: https://github.com/crawl/crawl/wiki/Guide-and-FAQ-for-contributing-to-crawl 11:13:23 it also probably needs to link into the docs/develop folder better 11:13:55 oh yeah, that's pretty good 11:14:14 hrm, sort of raises a question over whether things like this should be in the repo or in the wiki 11:14:24 I guess repo by default, since that works outside of github 11:14:41 yeah, maybe, I just like the wiki interface for working on a doc like that a bit better 11:14:58 yeah, good place to get the doc into place at least 11:15:06 but we could move this doc into the repo now you think? 11:15:27 what about merging some of the content with contribution-process.txt? 11:15:46 yeah, I'm just worried about duplication 11:16:12 one place gets update and the other gets out ot date 11:16:30 yeah, to be clear, I mean merge and have one doc, that could go in the repo. There's things I see I didn't cover that are in there (like art) 11:16:39 yeah, sounds good 11:17:23 let me start by merging the page markdown into the repo 11:17:29 gammafunk: I just ran make 11:17:36 any preference for the filename? contribution-process.md ? 11:18:20 foxor: yeah, that should give you a working console build. Are you sure that the development environment is correctly installed and that the system doesn't have anything like disk space issues or whatnot? 11:18:39 that filename sounds good 11:21:08 Yeah, the system has 10gb free, and the apt-get commands completed sucessfully 11:21:37 It compiles a bunch of the object files, and then consistently crashes on dungeon.o 11:22:02 this can be a good time to have checkwhite fix advils *egregious* *french* *spacing* 11:22:25 oh 11:22:33 I guess it's english spacing that we're fixing 11:22:38 and making it french spacing 11:25:13 Looks like it might be running out of memory while compiling 11:25:24 it's a little 512MB instance 11:25:41 oh, that would make sense yeah 11:26:21 normally swap would cover this but you may not have enough swap 11:34:30 heh 11:34:51 I'm definitely English spacing by habit, but working on crawl has put my habits somewhat in flux 11:35:36 checkwhite should do french spacing though 11:35:44 did you remember to do -a? 11:35:54 iirc it won't do doc by default 11:36:31 oh you just meant that you were going to run it on that doc 11:40:44 wrt the wiki vs repo question, it's always nice to have those things version controlled, but the github wiki is also a git repo 11:44:37 there may be some background concern about having our docs tied too closely to a github-specific thing 12:03:00 yeah, it's nice that the wiki version-controlled, but it's nice to have infrastructure docs like that in the repo 12:39:00 that's true; github wikis being a repo does mean that they're easily exportable, should it come to that 13:02:23 gammafunk: yep! That was it! 13:02:40 resized the VM and compiled 13:04:55 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-353-g2d6336e (34) 14:35:08 -!- Fixer_ is now known as Fixer 14:49:39 -!- amalloy_ is now known as amalloy 16:28:32 Lua error running hook 'post_place' on map 'shoals_end_grunt_ice': /crawl-master/crawl-0.20/data/dat/dlua/dungeon.lua:583: Failed to place map 'shoals_ilsuiw_ice' # bother 17:16:40 Ok you devs will be pleased to know, I'm sure, that this kind of mass commit idiocy will never happen again. I finally figured out how to use git rebase, thanks for the help aidanholm and gammafunk. 17:17:11 *never happen again from me, that is 17:18:03 I doubt it --- but we've all been through it :) git is, erm, well named 17:18:51 haha thx for reassuring me :) 17:18:59 and rebase has "fun" all its own 17:19:19 indeed it's almost like they picked the name "git" just to let you know what you were letting yourself in for 17:20:08 https://ohshitgit.com :) 17:20:21 you kinda know what you're in for just because such sites exist 17:22:27 erm ye my browser freaks out about the encryption on that website 17:23:31 oh, looks like it's http only not https 17:23:47 the https site may be a hosting glitch 17:24:03 Is this supposed to happen: https://imgur.com/a/LanIG 17:27:37 it's probably that the site is supposed to be https but the website is running http atm and so my browser says it's not private 17:28:20 foxor that's just unlucky, yes 18:19:30 Unstable branch on underhound.eu updated to: 0.22-a0-353-g2d6336e718 (34) 21:46:54 Shafted into a vault's freezing cloud, stuck 13https://crawl.develz.org/mantis/view.php?id=11449 by MainiacJoe 21:48:10 should remove that vault tbh 23:59:33 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-353-g2d6336e (34)