00:59:51 !tell advil you still want a ghost vault experimental sometime? 00:59:52 johnstein: OK, I'll let advil know. 01:15:05 -!- Rast- is now known as rast 01:24:57 Unstable branch on crawl.develz.org updated to: 0.22-a0-248-gc8378ba (34) 01:58:26 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-248-gc8378ba 02:53:40 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-248-gc8378ba 03:11:41 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-248-gc8378ba (34) 06:54:24 -!- amalloy is now known as amalloy_ 07:26:09 twalesijr (L10 MiFi) ERROR in 'libutil.cc' at line 367: screen write out of bounds: (1,-1) into (80,24) (D:9) 07:27:29 !crashlog 07:27:36 18929. twalesijr, XL10 MiFi, T:6892 (milestone): http://crawl.berotato.org/crawl/morgue/twalesijr/crash-twalesijr-20180228-122601.txt 09:32:17 we seem to be getting those lately 09:32:17 advil: You have 4 messages. Use !messages to read them. 09:34:49 !tell johnstein sorry, haven't had much time to think about it yet, I still haven't figured out how to seed the semi-permanent ghost db that the branch uses. I may need to partially merge some of the db code to master so I can seed it that way. 09:34:50 advil: OK, I'll let johnstein know. 10:16:21 haha I think I finally replicated that shop thing 10:16:27 ERROR in 'libutil.cc' at line 367: screen write out of bounds: (1,-1611268094) into (80,24) 10:31:07 I think my rewrite probably took care of it already (and probably introduced new and exciting bugs) 10:31:40 not that it's merged yet, of course 10:31:44 ah 10:32:21 I can check if you want 10:32:35 the bug is if you repeat some actions in a shop menu 10:34:14 if you have time, that'd be appreciated; what sort of repeated actions? 10:37:04 the following key sequence does it for any shop (ignore spaces): > ! a ESC ESC ` 10:37:39 it's because the shop code abuses more to show the gold amount, and manually triggers draw_more in a bunch of places 10:38:26 in current master, there's a bunch of member variables that are not guaranteed to be initialized unless draw_menu is called, but on repeats, the menu isn't drawn 10:38:50 specifically m_offset and m_pagesize 10:39:05 so basically for shops, draw_more can be called with those set to 0 10:39:28 in fact those aren't even initialized to 0 in a constructor so the bad value depends on what the compiler does in that case 10:40:04 ah, nice, well done tracking that one down 10:40:14 yeah, I get a segfault here as well 10:40:19 the fix in master would be to (i) check crawl_state.doing_prev_cmd_again more consistently in any draw code in MenuDisply subclasses, and (ii) probably more consistently initialize those variables 10:40:27 also the shop code shouldn't use more for that 10:41:21 also, I noticed that if a shop should scroll, some stuff isn't displayed properly (though maybe that never happens in practice, I had to modify shop gen code to get shops big enough) 10:41:57 I think I noticed the shop scrolling issue too; it's fixed in my branch 10:42:01 ah nice 10:42:22 I'm not sure what the alternative for shops is 10:42:42 that is, what the alternative for using more like that is 10:44:03 I was thinking something like have a three line footer and change one of those lines for gold messaging (patterning after the skill menu) 10:44:43 one possibility is to refactor the interface a bit to allow attaching supplementary widgets around the main menu widget 10:45:17 patterning after the skill menu? 10:46:21 the skill menu has a bunch of text lines that change depending on the circumstances, as well as the [?] line...it's not done in a very generalizable way 10:47:55 but it's not done with a more either 10:48:26 maybe it's easiest if you fix the shop crash in your branch? I was going to do it in master but that'll just make conflicts 10:48:57 though since it is a crash on demand if someone knows it, if you aren't planning on merging soon, it maybe should be fixed in master 10:50:01 The skill menu uses a totally separate PrecisionMenu class; I was planning on just reimplementing the menus that use that, as it seems easier than porting the PrecisionMenu class itself 10:50:11 ah right, yeah, I forgot that was so separate 10:52:16 if you'd prefer to have this fixed ASAP, it might be better to fix it in master first 10:53:06 ok, a quick fix isn't too bad 10:53:34 yeah, we generally like to fix easily triggerable crashes when we know about them, since there can be some scummy ways to use them 10:54:07 yeah, fair enough 10:59:22 I wonder if repeating a shop purchase just shouldn't work 11:00:05 I kind of suspect these crashes are miskeys, which could be accidentally kind of expensive when it actually works 11:00:48 it'd certainly be a simpler fix 11:04:48 and there's not much of a reasonable use-case for something like that 11:13:25 03advil02 07* 0.22-a0-249-gc6edcda: More consistently check for repeats in menu code 10(13 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/c6edcda9ae58 11:13:25 03advil02 07* 0.22-a0-250-g848dc5c: Don't allow repeating shop actions with ` 10(2 minutes ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/848dc5cce043 11:13:43 I did both, since the quick fix for the more thing is pretty simple, and might impact somewhere else 11:52:31 03wheals02 07* 0.22-a0-251-g072727e: Identify the starting book (Dynast). 10(17 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/072727ec5a92 11:52:31 03wheals02 07* 0.22-a0-252-gcace5d2: Clarify Lugonu disto protection (Fingolfin). 10(22 seconds ago, 2 files, 10+ 5-) 13https://github.com/crawl/crawl/commit/cace5d2d354e 12:02:30 The build has errored. (master - 848dc5c #9365 : advil): https://travis-ci.org/crawl/crawl/builds/347343145 12:05:24 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-252-gcace5d2 (34) 12:09:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-252-gcace5d2d35 (34) 15:15:50 -!- amalloy_ is now known as amalloy 15:47:23 -!- giantbatt is now known as giantbat 16:16:11 -!- ZanniqlcKzxkq is now known as Zannick 18:07:00 -!- Bammboobies is now known as Bammboo 18:14:13 -!- Bammboobies is now known as Bammboo 18:17:36 Unstable branch on underhound.eu updated to: 0.22-a0-252-gcace5d2d35 (34) 21:06:28 -!- amalloy is now known as amalloy_ 22:27:41 -!- giantbatt is now known as giantbat 23:57:35 -!- Guest12858 is now known as myp