00:02:20 perhaps the colour dr entries could remain the same, and the job entries could be more a list of modifications? 00:02:51 -!- amalloy_ is now known as amalloy 00:07:32 could work, though that'd be pretty different to all the other outputs from ?/m 00:08:46 if it should change, i still think the best of the remaining options is to show all combinations 00:09:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-126-g307c7c3803 (34) 00:10:02 well, I'm also not too sure how colour and job attributes combine 00:10:28 like a menu? select the colour on job screens, and vice versa? 00:11:03 i was thinking just have all the combinations appear as entries in the list 00:11:18 oh as in the main list? 00:11:20 so if you search for "draconian monk," for example, you get the normal choice 00:11:37 if you search "red draconian" you get red draconian as usual 00:11:45 but if you search "red draconia" you can see all the possible red draconians 00:12:20 and if you search "draconia" you probably end up with more than 52 entries which will be a problem pending one of your upcoming fixes :P 00:13:26 I think that's in the menu-refactor PR actually 00:13:30 "the normal choice" -> a list of all monsters with "draconian monk" in their name, such as red draconian monk, green draconian monk, etc. 00:13:34 yeah, thats what i meant 00:14:03 i couldn't remember whether it was in menu-refactor or ui-overhaul 00:14:49 I see, so there are "$COL draconian" pages and "$COL draconian $JOB" pages 00:15:13 ideally, yeah 00:15:31 that'd work, and it'd work for zombies as well, but it's not going to work for other problem entries 00:15:34 ghosts and pan lords 00:16:12 maybe others.. 00:16:25 those seem pretty unfixable 00:16:53 though ugly things, despite also using ghost_demon, would probably be easier to fix 00:17:06 (currently all ghost_demon-using monsters only show the description from the DB and nothing else) 00:20:56 can't show stats of course, but it'd be nice to add a bit more than the description 00:21:32 e.g. ghosts can always fly, are always intelligent, always incapable of using stairs, etc 00:27:37 -!- amalloy is now known as amalloy_ 00:28:10 -!- amalloy_ is now known as amalloy 00:28:32 might also be nice to have gretell's info available in ?/M and/or xv 00:28:35 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-126-g307c7c3 (34) 00:28:43 although I realize that you fancy webtiles players have beem and whatnot 00:29:45 Monsters wielding staves don't identify them 13https://crawl.develz.org/mantis/view.php?id=11375 by CanOfWorms 00:30:56 Stable (0.21) branch on CRAWL.XTAHUA.COM updated to: 0.21.0-37-g46506fa 00:40:22 -!- forgottenwizard is now known as ZombieChicken 00:56:59 The build passed. (master - 307c7c3 #9277 : Matthew Boeh): https://travis-ci.org/crawl/crawl/builds/335009210 00:57:34 aidanh: it's not that simple, we don't give all of that info in-game on purpose 00:58:55 we try to avoid some direct use of numbers when players don't have a way of using that info without reading a bunch of formulas 01:10:15 Stable branch on crawl.develz.org updated to: 0.21.0-37-g46506fa (34) 01:54:40 whatever happened to ranged combat reform 02:00:08 -!- wHATEver is now known as Guest36161 03:10:39 Stable (0.21) branch on crawl.beRotato.org updated to: 0.21.0-37-g46506fa 03:22:29 Unstable branch on crawl.beRotato.org updated to: 0.22-a0-126-g307c7c3 (34) 04:47:45 !messages 04:47:45 No messages for TZer0. 05:23:21 -!- amalloy is now known as amalloy_ 06:27:03 -!- amalloy_ is now known as amalloy 07:45:53 <|amethyst> !tell wheals in ea6f5a2d "Treat wands like other stackables for autopickup", shouldn't the lambda be checking item's base type as well? 07:45:53 |amethyst: OK, I'll let wheals know. 07:47:51 <|amethyst> !tell wheals maybe return item.is_type(OBJ_WANDS, first->sub_type); 07:47:52 |amethyst: OK, I'll let wheals know. 07:48:27 -!- amalloy is now known as amalloy_ 07:49:24 <|amethyst> !tell wheals also, since there's only one capture, I'd usually prefer to list it; and since it's a pointer that isn't being re-seated, there's no need to capture by reference 07:49:24 |amethyst: OK, I'll let wheals know. 07:50:12 <|amethyst> !tell wheals (that also applies to the lambda that was already there, which I'm pretty sure was my fault; hobgoblin of small minds and all that) 07:50:12 |amethyst: OK, I'll let wheals know. 08:37:38 !messages 08:37:38 (1/5) Ge0ff said (1h 50m 27s ago): This new explore horizon thing is amazing! 08:39:41 !messages 08:39:42 (1/4) |amethyst said (53m 49s ago): in ea6f5a2d "Treat wands like other stackables for autopickup", shouldn't the lambda be checking item's base type as well? 08:39:43 !messages 08:39:43 (1/3) |amethyst said (51m 52s ago): maybe return item.is_type(OBJ_WANDS, first->sub_type); 08:39:45 !messages 08:39:45 (1/2) |amethyst said (50m 37s ago): also, since there's only one capture, I'd usually prefer to list it; and since it's a pointer that isn't being re-seated, there's no need to capture by reference 08:39:46 !messages 08:39:47 (1/1) |amethyst said (49m 35s ago): (that also applies to the lambda that was already there, which I'm pretty sure was my fault; hobgoblin of small minds and all that) 08:40:18 03wheals02 07* 0.22-a0-127-g50b93cf: Refactor lambdas in l_item_do_stacks (|amethyst). 10(3 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/50b93cfed0b0 08:40:44 that should fix it 09:09:41 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-127-g50b93cfed0 (34) 09:31:39 The build has errored. (master - 50b93cf #9278 : wheals): https://travis-ci.org/crawl/crawl/builds/335155703 10:46:10 i was wondering why TSO wasn't marking venom weapons as evil for some reason, turns out i totally missed that conduct being removed 10:46:38 03wheals02 07* 0.22-a0-128-gfbf05e5: Correctly mark partially-ided weapons evil or useless (#9545, #10724). 10(7 minutes ago, 2 files, 18+ 9-) 13https://github.com/crawl/crawl/commit/fbf05e55dfdd 10:51:00 !tell aidanh i saw your comment on #691 now; it could be done in is_holy_item, but you would have to add a calc_unid parameter or something similar to it and also every other function that handles a weapon being useless or evil 10:51:00 wheals: OK, I'll let aidanh know. 11:09:45 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-128-gfbf05e55df (34) 11:38:14 The build has errored. (master - fbf05e5 #9279 : wheals): https://travis-ci.org/crawl/crawl/builds/335211797 12:01:48 Stable (0.21) branch on crawl.akrasiac.org updated to: 0.21.0-37-g46506fa 12:18:22 Stable (0.21) branch on underhound.eu updated to: 0.21.0-37-g46506fa5f3 12:26:03 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-128-gfbf05e5 (34) 14:24:00 "Viewing" dungeon features through ctrl-f ! does not work. 13https://crawl.develz.org/mantis/view.php?id=11376 by NormalPerson7 14:41:14 add a dildo bat 14:47:28 wat 14:54:51 gammafunk, yeah, that's fair enough 14:54:51 aidanh: You have 2 messages. Use !messages to read them. 14:55:16 !messages 14:55:17 (1/2) wheals said (6d 17h 36m 17s ago): how far is ui-overhaul from merging, do you think? adding search might involve more digging around in the guts of Menu and i don't want to make even more conflicts 14:56:41 !messages 14:56:42 (1/1) wheals said (4h 5m 41s ago): i saw your comment on #691 now; it could be done in is_holy_item, but you would have to add a calc_unid parameter or something similar to it and also every other function that handles a weapon being useless or evil 15:02:38 wheals, lots of the call sites for those items don't handle unIDed items correctly without that 15:03:30 yeah 15:03:50 so adding those parameters might be a good idea anyway 15:07:53 that area of code could use other refactoring as well 15:49:28 -!- somebody_ is now known as somebody 16:30:05 quick question: where in the game's code is AC gain for species like draconians, naga, and gargoyles kept track of 16:30:40 !source player::racial_ac 16:30:41 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L5829 16:31:05 thanks 16:31:13 trying to code up a simple no-equipment slot species 16:39:36 how do you print the AC you're getting from racial AC into the mutations screen 16:41:21 check out the if block it on line 633 of mutation.cc 16:41:41 s@ it@@ 16:47:52 ok last thing I need to do is ban the species from worshipping Ash (since no equipment slots means there's nothing to curse) 16:51:13 !source player_can_join_god 16:51:13 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/religion.cc#L3082 16:51:18 thanks 17:57:33 ok how do I wipe all changes I've made clean so I can update my branch cleanly 17:59:29 <|amethyst> git stash save broken-race-changes # just in case you want to get back to it later 18:07:04 I already made the patch by the way 18:07:18 just editing the commit message if anyone wants to mock it 18:18:25 Unstable branch on underhound.eu updated to: 0.22-a0-128-gfbf05e55df (34) 18:22:24 https://pastebin.com/QPZ4pPpp 18:22:35 here is my broken-race-changes for anyone who wants a good laugh 18:27:15 good message i ran into in testing: "No God disapproves of the use of such an item." 18:28:05 what a good bug 18:28:55 anyways I'm going to take a nap 18:29:03 notify me how terrible of an idea blobs are when I wake up 19:54:16 johnstein: any chance of getting hellcrawl back up this week? 19:57:30 hellmonk, pretty good chance. sorry for the delay. I've barely been at my computer 19:57:43 no worries 19:57:49 thanks for continuing to host it 19:57:55 ^status 19:57:55 61 Crawlers. CBRO disk usage=99% (135GB) | RAM usage=56% (4GB)| uptime/CPU= 19:57:54 up 24 days, 33 min, 5 users, load average: 0.50, 0.81, 1.08 (4 Cores) http://status.berotato.org 19:58:01 ruh roh 19:58:56 |amethyst, sometime I need to talk to you about Operation Upgrade Old Saves to Latest Build for Each Version (OUOStLBfEV) 20:04:29 |amethyst, the basic issue is, I need to consolidate a lot of old saves. I want to update each save to the appropriate version. determining that version seemed less than simple (based on a discussion with gammafunk), but once it was determined, I could do the upgrade one time and remove all the old unused versions 20:05:47 03wheals02 07* 0.22-a0-129-g68cc883: Require uppercase letters for SID prompt (Sprucery, minmay). 10(9 hours ago, 1 file, 6+ 3-) 13https://github.com/crawl/crawl/commit/68cc883211ac 20:05:47 03wheals02 07* 0.22-a0-130-g78804fe: Remove some leftover purple chunk handling code. 10(3 hours ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/78804fe2cf77 20:05:47 03wheals02 07* 0.22-a0-131-g47a4871: Refactor testing whether items are forbidden. 10(2 hours ago, 4 files, 131+ 128-) 13https://github.com/crawl/crawl/commit/47a4871b1b09 20:05:47 03wheals02 07* 0.22-a0-132-g21b7597: Refactor god_hates_item_handling. 10(26 seconds ago, 5 files, 43+ 64-) 13https://github.com/crawl/crawl/commit/21b75971b6b7 20:22:14 ^status 20:22:14 61 Crawlers. CBRO disk usage=90% (135GB) | RAM usage=44% (4GB)| uptime/CPU= 20:22:13 up 24 days, 58 min, 6 users, load average: 0.68, 1.06, 1.17 (4 Cores) http://status.berotato.org 20:26:20 gammafunk, advil, aidanh, I think these 4 PR are complete enough for consideration. I need to get experimentals working again on cbro, but after that, I'll have time to react to any comments/questions/suggestions. https://github.com/crawl/crawl/pulls/jmbjr 20:26:48 k, yeah I recall you have some ones waiting a look 20:27:10 wheals too. oops. not sure who else is active 20:27:10 I need to get back to finishing some crawl dev stuff 20:27:32 yea, there's no rush on these at all. but I know I'm planning on setting aside time for game dev stuff that way I can react 20:28:05 I was pretty stoked to see the spell failure chance merged in 20:28:19 the only way I know how to react is !flip 20:29:08 !flip out 20:29:09 (╯°□°)╯︵ʇn° 20:29:28 !flip ʇn° 20:29:29 (╯°□°)╯︵ouʇ 20:29:38 !flip ouʇ 20:29:39 (╯°□°)╯︵ʇn° 20:30:01 !flip (╯°□°)╯︵ʇn° 20:30:02 (╯°□°)╯︵ouʇ︶╭(o□o╭) 20:31:35 hmm 20:31:45 !recur !flip 3 wheals 20:31:46 (╯°□°)╯︵(╯°□°)╯︵slɐǝɥʍ︶╭(o□o╭) 20:32:28 !recur !flip 8 gammafunk 20:32:28 (╯°□°)╯︵(╯°□°)╯︵(╯°□°)╯︵(╯°□°)╯︵ƃɐɯɯɐɟunʞ︶╭(o□o╭)︶╭(o□o╭)︶╭(o□o╭)︶╭(o□o╭) 20:32:29 works perfectly imo 20:32:53 i agree with past PF that #536 looks better than #594 as a solution, so i'll go ahead and merge the former, close the latter and you can reopen a new one with the refactoring that it had, does that sound good? 20:36:47 03johnstein02 {wheals} 07* 0.22-a0-133-g090d9d4: Discourage summoned creatures from Bolting their summoners (jwoodward48ss) (#613) 10(9 seconds ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/090d9d40b667 20:39:07 oops 20:40:02 wheals, I didn't have a strong opinion on that. your suggestion sounds good. I'll work on a new PR with the other fixes 20:40:12 thanks 20:45:12 03wheals02 07* 0.22-a0-134-g8af8940: Fix a crash when targetting near a friendly monster. 10(29 seconds ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/8af8940e327e 20:45:34 03Doesnty02 {wheals} 07* 0.22-a0-135-g6f012ad: Allow Fulminant Prism and Lightning Spire to be cast on traps. (#536) 10(20 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/6f012ad52b13 20:46:59 finally, my new meta 20:47:21 and as a vault maker this will justify more extensive use of traps 20:48:32 the real meta was detecting traps by trying to cast them on their squares and failing 20:52:01 don't worry, you can still detect invisible monsters 20:58:49 The build passed. (master - 21b7597 #9280 : wheals): https://travis-ci.org/crawl/crawl/builds/335424329 21:09:50 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-135-g6f012ad52b (34) 21:43:34 The build has errored. (master - 6f012ad #9283 : Doesnty): https://travis-ci.org/crawl/crawl/builds/335434542 21:48:59 -!- Krakhan|2 is now known as Krakhan 22:00:43 woke back up