00:10:01 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.22-a0-113-gdd6f4a9 (34)
00:11:57 <Eksell> Stable (0.21) branch on CRAWL.XTAHUA.COM updated to: 0.21.0-30-g47ce8e4
00:15:26 -!- n1k is now known as n1
01:10:32 <Gretell> Stable branch on crawl.develz.org updated to: 0.21.0-30-g47ce8e4 (34)
01:24:57 <Gretell> Unstable branch on crawl.develz.org updated to: 0.22-a0-113-gdd6f4a9 (34)
01:59:10 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-113-gdd6f4a9
02:10:51 <Lightli> !won . Gh
02:10:52 <Sequell> Lightli (Gh) has won once in 57 games (1.75%): 1xGhMo
02:13:56 <Lightli> !lg . won god=makhleb
02:13:57 <Sequell> 7. Lightli the Sharpshooter (L27 HaGl of Makhleb), escaped with the Orb and 3 runes on 2016-11-08 06:57:12, with 1775119 points after 60757 turns and 3:56:10.
02:14:33 <Lightli> !lg . won god=yred
02:14:34 <Sequell> 2. darkli the Invulnerable (L25 MiDK of Yredelemnul), escaped with the Orb and 3 runes on 2012-12-11 21:58:25, with 1644277 points after 63984 turns and 4:05:22.
02:15:04 <Lightli> ok it's been over half a decade
02:15:07 <Lightli> time to try for a yred win
02:34:58 <Lightli> rip
02:54:57 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.22-a0-113-gdd6f4a9
03:10:45 <Rotatell> Stable (0.21) branch on crawl.beRotato.org updated to: 0.21.0-30-g47ce8e4
03:16:04 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.22-a0-113-gdd6f4a9 (34)
03:46:06 -!- amalloy is now known as amalloy_
03:47:28 -!- amalloy_ is now known as amalloy
04:37:44 -!- Dracunos_ is now known as Dracunos
05:43:23 -!- CoolGuy is now known as Stevenson777
06:08:56 -!- amalloy is now known as amalloy_
08:29:43 -!- EuphOria is now known as BrainBug
09:27:09 -!- Euph0ria is now known as BrainBug
10:06:28 <advil> hmm I guess something needs to be updated on https://crawl.develz.org/trunk/ and http://crawl.develz.org/trunk/archive.html so that it includes 0.22? Gretell seemed to say that there were 0.22 trunk builds being generated
10:51:41 <geekosaur> in the past that's required manual action from the Kin iirc
11:08:45 <|amethyst> updated
11:13:49 <Cheibriados> New branch created: pull/707 (1 commit) 13https://github.com/crawl/crawl/pull/707
11:13:49 <Cheibriados> 03EMTedronai02 07https://github.com/crawl/crawl/pull/707 * 0.22-a0-114-gc1a2779: Do not force more prompts for (most) of desolation of salt messages. 10(24 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c1a2779847b6
11:16:27 <Cheibriados> 03EMTedronai02 {wheals} 07* 0.22-a0-114-g70bfd0b: Do not force more prompts for (most) of desolation of salt messages. (#707) 10(7 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/70bfd0b6028c
11:24:28 <wheals> about https://github.com/crawl/crawl/issues/706
11:24:34 <wheals> i've literally never seen anyone at all use this
11:24:38 <wheals> i had no idea this feature existed
11:24:42 <wheals> is it worth keeping?
11:38:24 <advil> thanks |amethyst
11:38:33 <advil> hm, what's the feature in that issue?
11:38:50 <advil> oh, i for inventory?
11:39:42 <wheals> yeah, in the f menu
11:41:09 <advil> my experience with stuff like this is that like 10% of the player base turns out to deeply rely on the feature and they're very vocal about it
11:41:38 <advil> it seems like a bug that it can't be remapped though?
11:43:26 <wheals> perhaps
11:43:53 <wheals> it's not that the mapping gets overwritten, it just has a switch directly on the input key
11:43:57 <wheals> not ideal for sure
11:46:14 <advil> ah
11:57:39 <advil> where is the switch?
12:00:00 <advil> " * - Not changing Qv; nobody knows about internals"
12:02:14 <Henzell> Stable (0.21) branch on crawl.akrasiac.org updated to: 0.21.0-30-g47ce8e4
12:02:28 <wheals> just search for 'i' in throw.cc
12:02:43 <advil> yeah, I found it
12:04:40 <advil> it seems like the basic problem is that that function isn't using key_to_command
12:05:08 <wheals> not so surprising with how old it is, though
12:05:12 <advil> !source fire_target_behaviour::get_command
12:05:13 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/throw.cc#L235
12:05:55 <advil> "It really needs to be ripped out and rewritten"
12:06:51 <advil> also wait what
12:06:56 <advil> I just actually read the code in the switch
12:07:12 <advil> "case '(': case CONTROL('N'): cycle_fire_item(true);  return CMD_NO_CMD;"
12:08:11 <advil> someone got lazy :D
12:09:45 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-114-g70bfd0b602 (34)
12:10:23 <advil> granted it's not entirely obvious how you're supposed to subclass direction_chooser in a way that allows adding commands
12:10:49 <advil> s/direction_chooser/targeting_behaviour
12:12:00 <advil> though maybe if you just have a new context for the fire targeter, and add those commands to the direction chooser switch, it'd work
12:13:35 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-114-g70bfd0b (34)
12:17:42 <Lantell> Stable (0.21) branch on underhound.eu updated to: 0.21.0-30-g47ce8e4cbb
12:18:32 <travis-ci> The build has errored. (master - 70bfd0b #9267 : Elan Morin Tedronai): https://travis-ci.org/crawl/crawl/builds/334402711
12:21:17 <advil> omg
12:22:09 <advil> I am really tired of that error
12:25:31 <Cheibriados> Petrify should show on death messages in the same way as paralysis. 13https://crawl.develz.org/mantis/view.php?id=11374 by NormalPerson7
13:46:13 -!- amalloy_ is now known as amalloy
14:09:37 <Lasty> In terms of quick, not-refactoring-all-of-beam.cc solutions to the Dithmenos shadow launcher bug, how about 1) add an optional actor field to the beam object, and 2) set it to the shadow monster during shadow launching only, then 3) return it from bolt::agent when it's set.
14:09:38 <Sequell> Lasty: You have 4 messages. Use !messages to read them.
14:13:05 <Lasty> !tell advil Oh, that's a simpler solution. Probably at least equally effective. If reflection happens after the monster stops existing, it would reflect towards you, which is good, right? I guess it would increase the reflection damage tho...
14:13:06 <Sequell> Lasty: OK, I'll let advil know.
14:13:14 <Lasty> !tell advil still seems like a step better
14:13:15 <Sequell> Lasty: OK, I'll let advil know.
14:51:42 <Lasty> !tell advil actually, looks like it's working great
14:51:43 <Sequell> Lasty: OK, I'll let advil know.
14:56:35 <Cheibriados> 03Lasty02 07* 0.22-a0-115-g1c85753: Make Dith Shadow Mimic launchers normal (Valarioth, ebering, advil, Snack) 10(2 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/1c85753056f3
15:00:11 <wheals> oh
15:00:44 <wheals> Lasty: there's a problem with that code actually, it's going to cause problems for players on top of fedhas plants
15:01:36 <wheals> that said it might not be so hard to fix it
15:05:02 <hellmonk_> if (you_worship(GOD_DITHMENOS))
15:05:03 <hellmonk_> ez
15:08:05 <wheals> changed it to check whether it's MONS_PLAYER_SHADOW but basically same thing
15:08:19 <wheals> just need to make sure this works
15:09:41 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-115-g1c85753056 (34)
15:19:08 <Cheibriados> 03wheals02 07* 0.22-a0-116-g8341686: Restrict the "treat monster under you as the source" code to Dith shadows. 10(12 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/8341686a52cb
15:19:08 <Cheibriados> 03wheals02 07* 0.22-a0-117-g314b907: Fix an uninitialized variable warning. 10(15 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/314b90714a31
15:21:05 -!- amalloy is now known as amalloy_
15:37:00 <advil> looks like things worked out
15:37:00 <Sequell> advil: You have 3 messages. Use !messages to read them.
15:37:22 <advil> what happens with reflection? I never actually tested that
15:42:47 <Lasty> advil: it looks like it works correctly
15:42:54 <Lasty> you get shot but there's no launcher bonus
15:43:14 <Lasty> wheals: thank you1
15:43:43 <wheals> no problem
15:45:31 -!- Bammboobies is now known as Bammboo
15:48:16 <travis-ci> The build failed. (master - 1c85753 #9268 : Corin Buchanan-Howland): https://travis-ci.org/crawl/crawl/builds/334454302
16:00:24 <advil> uh oh
16:00:51 <wheals> hm?
16:00:57 <advil> possibly wheals' version is safer
16:01:15 <advil> but apparently that can be called when you.pos() isn't valid
16:01:33 <advil> hopefully the way you did it will just return a nullptr in that case
16:01:43 <wheals> ah
16:03:02 <advil> looks like the fireworks stress test will trigger the relevant case
16:03:11 -!- amalloy_ is now known as amalloy
16:06:56 -!- russ0r is now known as russ0r`OFF
16:09:45 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-117-g314b90714a (34)
16:36:15 <travis-ci> The build passed. (master - 314b907 #9269 : wheals): https://travis-ci.org/crawl/crawl/builds/334460472
16:46:17 -!- amalloy is now known as amalloy_
18:17:32 <Lantell> Unstable branch on underhound.eu updated to: 0.22-a0-117-g314b90714a (34)
19:30:23 <advil> hmm, either no one's looked at https://github.com/crawl/crawl/pull/705 or no one's thought of any problems with it
19:34:19 <geekosaur> I am not sure I'd want to trust <string> to be sane after a segfault
19:34:56 <advil> oh hm
19:35:02 <advil> well, it's used a lot already after a segfault
19:35:11 <advil> or at least, some
19:35:18 <geekosaur> which probably explains double crashes
19:35:44 <advil> _assert_msg itself is a string
19:37:26 <advil> it's even used in the double crash code :D
19:38:51 <wheals> yeah i was going to say the same thing the other day, and then i noticed that it's used already
19:40:19 <advil> there's a comment that indicates someone decided not to care about string
19:40:30 <advil> well, I guess if this is an actual problem someone should do a pass through all of this
19:51:32 -!- hellmonk_ is now known as hellmonk
20:19:55 <Lasty> hellmonk: Gonna pull the Dith bug fix into hellcrawl?
20:20:09 <hellmonk> I see it more as a dith feature tbh
20:20:22 <hellmonk> might try to enable brand on melee weapon for dith shadow
20:20:25 <hellmonk> instead
20:21:03 <Lasty> A solid power boost for Dith
20:31:14 <gammafunk> I saw advil did some cherry-picks for 0.21
20:31:24 <gammafunk> anyone else have anything they know of that should go in?
20:31:40 <gammafunk> I can look over the list, would be nice to get a release made tomorrow maybe
20:33:28 <Lasty> gammafunk: definitely the dith fixes, but I'm guessing advil already got it
20:33:42 <gammafunk> ok, I'll double-check those
20:34:02 <Lasty> and wheals's fix for the dith fix
20:34:03 <Lasty> haha
21:17:23 <Lightli> ok quick question
21:17:29 <Lightli> how do I make a patch in git
21:18:53 <geekosaur> commit your change(s), use git format-patch
21:19:11 <Lightli> I made the commit but it won't make any patches
21:19:12 <geekosaur> or, if your changes are all in the working tree and not committed, git diff
21:20:06 <geekosaur> uh, what command did you try?
21:20:10 <Lightli> git format-patch
21:20:28 <Lightli> git status reports the commit as existing
21:20:48 <geekosaur> you have to specify a commit
21:21:15 <geekosaur> you literally asked it to format all the changes between the current HEAD and the current HEAD... which is always empty
21:21:52 <Lightli> how do I specify the commit
21:22:16 <geekosaur> by its hash
21:22:28 <geekosaur> or, to get the most recent commit, HEAD^
21:22:39 <Lightli> thanks
21:22:50 <Lightli> now to figure out how to make a test build and see how many crashes happen
21:23:11 <geekosaur> (the ^ means "back up one commit". to back up some number of commits, use ~ instead, i.e. HEAD~3 means the most recent 3 commits)
21:23:22 <Lightli> thanks
21:23:27 <geekosaur> you've probably seen this used with chei's %git
21:23:51 <Lightli> ok how do I make the test build
21:24:06 -!- amalloy_ is now known as amalloy
21:25:19 <geekosaur> on linux I generally 'make debug-lite'
21:25:39 <geekosaur> if you want tiles, add 'TILES=y' to the end of that
21:26:05 <Lightli> it says the make command doesn't exist
21:26:05 <geekosaur> (actually I do something more complex, because I can :p )
21:26:05 <geekosaur> you dont have a build system set up?
21:26:33 <Lightli> ...duh
21:26:36 <Lightli> how do I set that up
21:26:44 <geekosaur> there's instrructions in the INSTALL.txt document
21:26:54 <geekosaur> which should be one directory up from the source directory
21:27:02 <geekosaur> for windows, os x, and linux
21:27:11 <geekosaur> (linux instructions assume a debian-like system iirc)
21:27:15 <Lightli> thanks
21:35:17 <Lightli> ok this doesn't want to work at all;
21:35:43 <Lightli> I did the git submodule update
21:35:49 <Lightli> it still doesn't think make is a command
21:36:41 <Lightli> oh is it that I'm using regular git
21:36:57 <Lightli> oh wait no not that
21:39:35 <geekosaur> make is not part of git, nor is it part of a submodule
21:39:41 <Lightli> oh
21:39:56 <geekosaur> on debian-derived systems, it would come from the build-essential package that INSTALL.txt tells you to install
21:40:01 <Lightli> I'm windows
21:40:14 <geekosaur> you probably need to install msys2
21:40:24 <geekosaur> and run its shell so you have access to its commands
21:40:48 <geekosaur> but someone else will probably have to help you from there
21:40:55 <Lightli> once I install it I can make it from there
21:40:57 <Lightli> thanks
22:21:45 <advil> that dith fix was after I cherry-picked, so I haven't done it
22:23:09 <advil> "git status reports the commit as existing" git status doesn't tell you about commits
22:23:35 <advil> if you've committed, git status should say Your branch is up-to-date with 'origin/master'.
22:23:35 <advil> nothing to commit, working directory clean
22:24:39 <geekosaur> it will tell you if you have commits that aren't in the upstream repo
22:24:49 <advil> ah right
22:24:54 <advil> nm
22:31:34 <Cheibriados> 03Lasty02 {advil} 07[stone_soup-0.21] * 0.21.0-31-gbbeae45: Make Dith Shadow Mimic launchers normal (Valarioth, ebering, advil, Snack) 10(8 hours ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/bbeae457d20f
22:31:34 <Cheibriados> 03wheals02 {advil} 07[stone_soup-0.21] * 0.21.0-32-ga63daae: Restrict the "treat monster under you as the source" code to Dith shadows. 10(7 hours ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/a63daae70775
22:31:34 <Cheibriados> 03EMTedronai02 {advil} 07[stone_soup-0.21] * 0.21.0-33-gf8bfb2f: Do not force more prompts for (most) of desolation of salt messages. (#707) 10(11 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f8bfb2fadafb
22:31:45 <gammafunk> oh, thanks
22:31:46 <advil> there's a few more
22:32:17 <advil> there might be a few aidanh commits that are bugfix-y but I was a little wary of trying to apply them myself since there might be dependencies
22:33:44 <advil> I did try to apply 5b255cfda4cd2a581 and got a conflict, so I just aborted
22:33:49 <advil> %git 5b255cfda4cd2a581
22:33:49 <Cheibriados> 07Aidan Holm02 * 0.22-a0-110-g5b255cf: Fix spurious spell failure warning for wands (Le_Nerd, #11370) 10(2 days ago, 1 file, 4+ 5-) 13https://github.com/crawl/crawl/commit/5b255cfda4cd
22:34:34 <aidanh> that one was a fix for the spell danger warnings, which is only in master
22:34:39 <advil> ah ok
22:35:07 <advil> I was mostly just going by commit titles :D
22:35:08 <aidanh> I think I've cherry-picked everything important
22:35:46 <aidanh> can't trust those commit titles
22:36:53 <gammafunk> I should probably prepare 0.21 tonight then
22:36:53 <gammafunk> since we're caught up now
22:37:14 <gammafunk> anyone have recommendations for the highlight bugfixes?
22:37:25 <advil> numpad, obviously
22:37:53 <advil> I did get one response back in travis confirming it's fixed for them in the most recent unstable build
22:37:57 <advil> so hopefully that's true
22:38:17 <advil> er, in mantis
22:38:52 <gammafunk> oh that's finally fixed? nice
22:39:39 <gammafunk> do you have a changelog-style summary of that fix? * Numlock enabled no longer causes some commands to repeat?
22:40:05 <advil> * Numlock on windows no longer causes unpredictable repeating movement
22:40:09 <gammafunk> ty
22:40:58 <advil> also alt-f4 on windows should no longer freeze crawl, that may be more niche
22:41:38 <gammafunk> nice to mention
22:41:41 <gammafunk> %git bbeae457d20f
22:41:41 <Cheibriados> 07Lasty02 {advil} * 0.21.0-31-gbbeae45: Make Dith Shadow Mimic launchers normal (Valarioth, ebering, advil, Snack) 10(8 hours ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/bbeae457d20f
22:42:11 <gammafunk> what was it doesn't before, retaining ego/enchant?
22:42:11 <aidanh> local tiles stability improvements (aka can resize without crashing now)?
22:42:11 <advil> yeah, getting the weapon brand + enchant
22:42:14 <gammafunk> sure, I can add that
22:42:41 <Cheibriados> 03Aidan Holm02 07[stone_soup-0.21] * 0.21.0-34-g9234887: Fix crash when resizing window while targeting (#11356) 10(32 hours ago, 3 files, 12+ 5-) 13https://github.com/crawl/crawl/commit/9234887e0f10
22:43:12 <advil> dith with a bow character would've been pretty amazing before that fix
22:50:00 <Lightli> https://pastebin.com/tAAsLhv4
22:50:03 <Lightli> can someone find the bug in this for me
22:50:12 <Lightli> make breaks here
22:51:46 <aidanh> your ternary expressions are missing the third part
22:51:52 <Lightli> what's the third part
22:52:08 <aidanh> should be something like a ? b : c; but yours are just a ? b;
22:53:33 <aidanh> so I'd guess you'd want to add  : MB_TRUE; to the end
22:55:47 <Lightli> still not working
22:56:18 <Lightli> https://pastebin.com/vCm4xdgh
22:56:59 <geekosaur> I am not sure what you are trying to do there
22:57:19 <Lightli> I'm trying to tell the game "this species can't wear these"
22:57:25 <aidanh> oh, should be == not =
22:57:28 <geekosaur> firsty off, you wanted ==
22:57:33 <geekosaur> = means assignment
22:57:35 <geekosaur> ??epic_bugs
22:57:36 <Sequell> epic bugs[1/28]: if (you.religion = GOD_XOM)
22:57:42 <Lightli> lol
22:57:51 <advil> Lightli: `return you.species == SP_BLOB ? MB_FALSE : MB_TRUE` for the current return MB_TRUE line
22:57:54 <aidanh> epic indeed
22:57:58 <advil> is what I'm guessing you want
22:58:36 <Lightli> no ;?
22:58:36 <geekosaur> that can be shorter: return you.species != SP_BLOB;
22:58:36 <advil> oh, yes a ; too
22:58:36 <geekosaur> hm, maybe not
22:58:40 <advil> that's not safe with maybe_bool iirc
22:58:41 <geekosaur> MB_TRUE is not TRUE
22:59:40 <advil> you could do `return frombool(you.species != SP_BLOB);` I think
23:00:12 <advil> I'm not sure it's clearer though
23:01:16 <geekosaur> suppose it depends on your tastes. I don't consider C's ternary operator clear, in general
23:01:33 <geekosaur> this might even be an example thereof
23:02:09 <Lightli> ok
23:02:10 <Lightli> one last bug
23:02:18 <Lightli> player.cc:5421:1: error: expected ',' or ';' before 'string'  string player::shout_verb(bool directed) const
23:03:10 <geekosaur> suspect the error is actually on the previous line
23:03:10 <Lightli> any idea why that broke
23:03:54 <geekosaur> since what it is saying is that it did not expect a declaration there
23:03:55 <Lightli> ok
23:03:56 <Lightli> fixed it
23:09:40 <Jorgrell> Stable (0.21) branch on crawl.jorgrun.rocks updated to: 0.21.0-34-g9234887e0f
23:21:57 <Lightli> ok just to check how long is it supposed to be on "LINK crawl.exe" before finishing
23:22:24 <advil> that is very slow on msys2
23:22:46 <advil> so, a while
23:24:13 <Lightli> and is it supposed to take up all the ram
23:29:13 <advil> sounds plausible
23:29:33 <Lightli> well it's done
23:30:24 <Lightli> it mechanically works except I forgot to tell the game to not let blobs wield anything
23:31:28 <Lightli> where is it in the code where felids are prevented to use weapons
23:36:09 <advil> !source player::could_wield
23:36:09 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/player-act.cc#L374
23:36:14 <advil> but I think there's a bunch of places
23:36:35 <advil> for example in aptitudes.h a bunch of skills are set to unusable
23:37:03 <advil> I'd go through the results of `git grep SP_FELID` to figure it out in detail