01:25:16 Unstable branch on crawl.develz.org updated to: 0.22-a0-93-g6b88ebb (34) 01:51:26 -!- ProzacElf_ is now known as ProzacElf 02:00:03 Windows builds of master branch on crawl.develz.org updated to: 0.22-a0-93-g6b88ebb 02:54:38 Monster database of master branch on crawl.develz.org updated to: 0.22-a0-93-g6b88ebb 03:15:56 -!- amalloy is now known as amalloy_ 03:17:47 -!- amalloy_ is now known as amalloy 04:52:41 -!- amalloy is now known as amalloy_ 06:29:58 !messages 06:29:58 No messages for TZer0. 08:58:08 -!- nino_ is now known as nino 09:04:12 Vile Clutch Not Displaying Icon on Constricted Monsters 13https://crawl.develz.org/mantis/view.php?id=11364 by MainiacJoe 09:39:53 The build has errored. (master - e6eb3b7 #1 : Jeremy Gurr): https://travis-ci.org/jeremygurr/dcss_spicy/builds/332812392 09:45:26 03Aidan Holm02 07* 0.22-a0-94-g7da2295: Don't list removed books in ?/s spell descriptions (rchandra, #11287) 10(6 weeks ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/7da22956461f 09:47:34 hm, I guess jeremygurr is the ca dev 09:49:06 doh 09:49:29 really wish there was a way to not have that happen 09:49:48 yeah, the github vs travis config setup is really inelegant 09:51:57 advil: last time this happened I made a PR with a commit to comment out the lines in the travis config 09:52:05 yeah I'm doing that 09:52:10 right on, thanks 09:57:47 there's a travis issue from 2011 about this 10:09:43 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-94-g7da2295646 (34) 10:13:51 advil: I recall there was some kind of crazy workaround people where doing where they encrypted the name of the channel in the config and it called out to a script to decrypt the channel name... 10:14:09 yeah, I saw that...it looks like it might disable travis on PRs though 10:14:13 lol I think he clicked the wrong PR button now 10:14:26 closed it? 10:15:13 I haven't 10:16:19 !tell Huene` here are some screenshots of the new UI stuff: https://a.pomf.space/qtmadcvohouf.png https://a.pomf.space/wiglkrffftrf.png https://a.pomf.space/cspbhqtjsqax.png 10:16:20 I wonder if you could simply do a conditional ban on messages from travid where you looked at that url 10:16:20 aidanh: OK, I'll let huene` know. 10:16:43 in the channel settings, I mean 10:16:49 I have now closed it 10:16:55 The build has errored. (health_potions - e8a672a #3 : Jeremy Gurr): https://travis-ci.org/jeremygurr/dcss_spicy/builds/332829048 10:17:21 New branch created: pull/701 (11 commits) 13https://github.com/crawl/crawl/pull/701 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-94-g624da49: initial difficulty level implementation 10(23 hours ago, 22 files, 504+ 96-) 13https://github.com/crawl/crawl/commit/624da49a43ea 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-95-g7ba2d1d: bug fixes 10(22 hours ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/7ba2d1d4f778 10:17:22 03Jeremy Gurr02 {GitHub} 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-96-gf6975bc: Merge pull request #1 from jeremygurr/difficulty 10(22 hours ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/f6975bc56cf5 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-96-ge589426: minor 10(22 hours ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/e589426351db 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-98-gbb2e717: Merge branch 'difficulty' 10(22 hours ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/bb2e717aa2bb 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-99-g2fef5d2: different experience sources added 10(11 hours ago, 14 files, 150+ 26-) 13https://github.com/crawl/crawl/commit/2fef5d21dfd8 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-100-gf3da0a7: make debug_exp option 10(11 hours ago, 3 files, 32+ 24-) 13https://github.com/crawl/crawl/commit/f3da0a72ffeb 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-101-gb75337a: bug fixes 10(11 hours ago, 2 files, 7+ 3-) 13https://github.com/crawl/crawl/commit/b75337a3d1ff 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-102-g7233d8d: Fix some exp balancing issues 10(7 hours ago, 5 files, 22+ 11-) 13https://github.com/crawl/crawl/commit/7233d8da5d8a 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-103-ge6eb3b7: doc improvement 10(43 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/e6eb3b758457 10:17:22 03Jeremy Gurr02 07https://github.com/crawl/crawl/pull/701 * 0.22-a0-104-ge8a672a: health potions heal 100% 10(6 minutes ago, 7 files, 47+ 1-) 13https://github.com/crawl/crawl/commit/e8a672ae8c3f 10:17:29 if travis posts a message with a travis-ci.org url and it doesn't have a url path with crawl/ 10:17:32 sigh 10:17:56 what is going on here 10:18:27 I think he intended to click a PR button in his own repo 10:18:33 and clicked it in crawl 10:18:40 gotcha 10:18:48 this clearly isn't intended to be merged (it has a readme describing the fork) 10:19:05 !tell Huene` the new UI is local tiles only for now, although I'll probably do some webtiles UI improvements at some point, once I understand the code a little better 10:19:06 aidanh: OK, I'll let huene` know. 10:19:12 sorry, this is what I meant by "clicked the wrong PR button" 10:20:44 I get all the github emails and they tend to come about 30-60 seconds before IRC notifications 10:21:28 I see 10:21:50 another funny thing is when I make commits, they pop up in discord almost instantaneously 10:22:09 takes 30-60 seconds to see in freenode as well 10:24:31 maybe Cheibriados is just lazy 10:24:41 or ... slow 10:26:30 actually it looks like chei just has a minimum update frequency of 60 ticks, which are probably seconds 10:29:04 !tell wheals I'll pull the menu-related commits out of ui-overhaul and open a PR for those first, as they're basically good to go 10:29:04 aidanh: OK, I'll let wheals know. 10:30:37 !tell wheals having searchable/filterable menus could improve ?/ screens, especially ?/M, since my refactor supports showing the full list with ?/m .* 10:30:38 aidanh: OK, I'll let wheals know. 10:31:46 !tell wheals the drop menu already has ctrl-f for selecting items to drop with a regex, so that could possibly be used as a starting point 10:31:46 aidanh: OK, I'll let wheals know. 10:34:28 the ctrl-f menu is a bit idiosyncratic 10:35:39 there's an outer loop that repeatedly calls the menu 10:35:40 in what sense? 10:36:14 oh nm 10:36:18 I don't know how the drop menu works 10:36:21 I misread 10:38:48 so I guess PRs default to the parent repository, for a forked repo 10:38:56 does anyone know how to change that default permanently? 10:39:15 afaik the drop menu just sets MF_ALLOW_FILTER, which doesn't actually filter, just allows selecting an item by search term 10:39:16 you can change it when you do a PR but it seems to keep defaulting like that 10:40:23 this seems to be a newish feature, which is also probably going to result in more irc spam for us 10:41:26 as far as I can tell the only workaround is to permanently reset your repository by making a bare clone?? 10:42:53 New branch created: menu-refactor (12 commits) 13https://github.com/crawl/crawl/tree/menu-refactor 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-95-g8ce6b90: Remove menu.set_maxpagesize interface 10(3 months ago, 7 files, 3+ 38-) 13https://github.com/crawl/crawl/commit/8ce6b903e68d 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-96-g679f7fe: Assert that menus have a valid selection flag 10(3 months ago, 2 files, 19+ 4-) 13https://github.com/crawl/crawl/commit/679f7fea6545 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-97-g7002a6f: Explicitly set MF_SINGLESELECT on describe menu 10(3 months ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/7002a6f8fab4 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-98-ga1b64af: Remove unused menu.f_drawitem hook 10(3 months ago, 2 files, 2+ 7-) 13https://github.com/crawl/crawl/commit/a1b64af2758a 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-99-g751972d: Remove column_compoer set_pagesize() 10(3 months ago, 4 files, 2+ 20-) 13https://github.com/crawl/crawl/commit/751972d0bb1b 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-100-ga800dec: Refactor Menu scrolling into MenuDisplay 10(3 months ago, 7 files, 407+ 317-) 13https://github.com/crawl/crawl/commit/a800dec30724 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-101-g8f229af: Remove limit on lookup-help results length 10(3 months ago, 1 file, 8+ 17-) 13https://github.com/crawl/crawl/commit/8f229af26492 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-102-gcd94562: 2-col tile menus: wrap horizontally and support line scrolling 10(6 weeks ago, 4 files, 259+ 176-) 13https://github.com/crawl/crawl/commit/cd945628a220 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-103-g890d972: Remove Menu text-only option 10(5 weeks ago, 10 files, 46+ 89-) 13https://github.com/crawl/crawl/commit/890d97297729 10:42:54 03Aidan Holm02 07[menu-refactor] * 0.22-a0-104-gd822c3e: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 147+ 188-) 13https://github.com/crawl/crawl/commit/d822c3ec2f0e 10:42:54 ... and 2 more commits 10:47:41 !messages 10:47:42 (1/3) aidanh said (18m 38s ago): I'll pull the menu-related commits out of ui-overhaul and open a PR for those first, as they're basically good to go 10:48:26 yeah it looks good 10:48:28 !messages 10:48:28 (1/2) aidanh said (17m 50s ago): having searchable/filterable menus could improve ?/ screens, especially ?/M, since my refactor supports showing the full list with ?/m .* 10:48:32 !messages 10:48:33 (1/1) aidanh said (16m 47s ago): the drop menu already has ctrl-f for selecting items to drop with a regex, so that could possibly be used as a starting point 10:49:36 main difference is that searching requires hiding some of the entries, whereas the d and \ menus just select them, but the actual input code can be reused at least 10:51:03 the regular ctrl-f menu works by having an outer loop around the menu that rebuilds the list each time depending on what you do in the menu interface 10:51:12 yeah 10:51:59 ShopMenu (and the new MemoriseMenu) avoids that, but it requires a few hacks to keep the UI updated all the time, especially on webtiles 10:53:57 another nice thing would be to generalize the whole ACT_EXECUTE/EXAMINE/MISC, since both of the menus i mentioned duplicate that manually 10:54:06 that lets you have two states, or three, but not more 11:04:14 New branch created: pull/702 (12 commits) 13https://github.com/crawl/crawl/pull/702 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-95-g8ce6b90: Remove menu.set_maxpagesize interface 10(3 months ago, 7 files, 3+ 38-) 13https://github.com/crawl/crawl/commit/8ce6b903e68d 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-96-g679f7fe: Assert that menus have a valid selection flag 10(3 months ago, 2 files, 19+ 4-) 13https://github.com/crawl/crawl/commit/679f7fea6545 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-97-g7002a6f: Explicitly set MF_SINGLESELECT on describe menu 10(3 months ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/7002a6f8fab4 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-98-ga1b64af: Remove unused menu.f_drawitem hook 10(3 months ago, 2 files, 2+ 7-) 13https://github.com/crawl/crawl/commit/a1b64af2758a 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-99-g751972d: Remove column_compoer set_pagesize() 10(3 months ago, 4 files, 2+ 20-) 13https://github.com/crawl/crawl/commit/751972d0bb1b 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-100-ga800dec: Refactor Menu scrolling into MenuDisplay 10(3 months ago, 7 files, 407+ 317-) 13https://github.com/crawl/crawl/commit/a800dec30724 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-101-g8f229af: Remove limit on lookup-help results length 10(3 months ago, 1 file, 8+ 17-) 13https://github.com/crawl/crawl/commit/8f229af26492 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-102-gcd94562: 2-col tile menus: wrap horizontally and support line scrolling 10(6 weeks ago, 4 files, 259+ 176-) 13https://github.com/crawl/crawl/commit/cd945628a220 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-103-g890d972: Remove Menu text-only option 10(5 weeks ago, 10 files, 46+ 89-) 13https://github.com/crawl/crawl/commit/890d97297729 11:04:15 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-104-gd822c3e: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 147+ 188-) 13https://github.com/crawl/crawl/commit/d822c3ec2f0e 11:04:15 ... and 2 more commits 11:04:19 Ghost damage is displayed inconsistently. 13https://crawl.develz.org/mantis/view.php?id=11365 by NormalPerson7 11:04:19 I like the changes, minor but impactful 11:04:19 Huene`: You have 2 messages. Use !messages to read them. 11:04:19 !messages 11:04:19 (1/2) aidanh said (47m 54s ago): here are some screenshots of the new UI stuff: https://a.pomf.space/qtmadcvohouf.png https://a.pomf.space/wiglkrffftrf.png https://a.pomf.space/cspbhqtjsqax.png 11:04:28 !messages 11:04:28 (1/1) aidanh said (45m 23s ago): the new UI is local tiles only for now, although I'll probably do some webtiles UI improvements at some point, once I understand the code a little better 11:08:43 is there any documentation on getting go-sequell setup? all the readme.md says is "A database loader for Crawl xlogfiles in the Sequell schema." 11:09:03 oh, goldifying books will also fix the clash between spell letters and (d)rop in the spellbook item screen 11:11:00 The build has errored. (health_potions - 6772a74 #5 : Jeremy Gurr): https://travis-ci.org/jeremygurr/dcss_spicy/builds/332851840 11:18:45 yeah, that's a nice outcome there 11:21:33 The build has errored. (health_potions - dc3791e #6 : Jeremy Gurr): https://travis-ci.org/jeremygurr/dcss_spicy/builds/332859955 11:33:00 @rc qw 11:33:05 http://crawl.develz.org/configs/trunk/qw.rc 11:51:54 New branch created: pull/703 (1 commit) 13https://github.com/crawl/crawl/pull/703 11:51:54 03cut1less02 07https://github.com/crawl/crawl/pull/703 * 0.22-a0-82-gba367bc: Display zombie hands icon for offline tiles users 10(29 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/ba367bc92ff5 11:52:47 oh 11:52:56 not my fault 12:03:51 The build passed. (menu-refactor - acf8590 #9234 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/332843406 12:04:04 wheals: calc_title uses a ref for output mostly because it simplifies the ShoppingList and Stash menu implementations when title is false 12:04:52 and I didn't think it was unclear; but if just returning a formatted_string is preferred, I can do that 12:04:53 Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-94-g7da2295 (34) 13:15:42 it doesn't seem like those conditionals are even necessary, since if title is false draw_title will exit before calling calc_title anyway 13:27:16 Engulfed by a dead water elemental. 13https://crawl.develz.org/mantis/view.php?id=11366 by NormalPerson7 13:28:57 oh, good catch 13:44:22 -!- amalloy_ is now known as amalloy 13:51:02 03Aidan Holm02 07[menu-refactor] * 0.22-a0-104-gceb0724: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 183+ 230-) 13https://github.com/crawl/crawl/commit/ceb0724d57f3 13:51:02 03Aidan Holm02 07[menu-refactor] * 0.22-a0-105-g16ef442: Add section dividing line (advil) 10(2 days ago, 2 files, 9+ 2-) 13https://github.com/crawl/crawl/commit/16ef442775f0 13:51:02 03Aidan Holm02 07[menu-refactor] * 0.22-a0-106-g3c26f4d: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/3c26f4d1f1ca 13:51:02 03Aidan Holm02 07[menu-refactor] * 0.22-a0-107-g4323303: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/4323303362e4 13:51:11 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-104-gceb0724: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 183+ 230-) 13https://github.com/crawl/crawl/commit/ceb0724d57f3 13:51:11 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-105-g16ef442: Add section dividing line (advil) 10(2 days ago, 2 files, 9+ 2-) 13https://github.com/crawl/crawl/commit/16ef442775f0 13:51:11 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-106-g3c26f4d: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/3c26f4d1f1ca 13:51:11 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-107-g4323303: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/4323303362e4 14:21:13 03Aidan Holm02 07[menu-refactor] * 0.22-a0-104-ga5717b5: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 188+ 232-) 13https://github.com/crawl/crawl/commit/a5717b50de4a 14:21:13 03Aidan Holm02 07[menu-refactor] * 0.22-a0-105-g798f5cb: Add section dividing line (advil) 10(2 days ago, 2 files, 9+ 2-) 13https://github.com/crawl/crawl/commit/798f5cb377ca 14:21:13 03Aidan Holm02 07[menu-refactor] * 0.22-a0-106-g20fbb6f: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/20fbb6fe3e21 14:21:13 03Aidan Holm02 07[menu-refactor] * 0.22-a0-107-g74fac97: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/74fac97eef82 14:21:22 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-104-ga5717b5: Move menu title rendering to mdisplay 10(5 weeks ago, 8 files, 188+ 232-) 13https://github.com/crawl/crawl/commit/a5717b50de4a 14:21:22 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-105-g798f5cb: Add section dividing line (advil) 10(2 days ago, 2 files, 9+ 2-) 13https://github.com/crawl/crawl/commit/798f5cb377ca 14:21:22 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-106-g20fbb6f: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/20fbb6fe3e21 14:21:22 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-107-g74fac97: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/74fac97eef82 14:29:43 03cut1less02 {Aidan Holm} 07* 0.22-a0-95-ga32820b: Display zombie hands icon for offline tiles users 10(3 hours ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/a32820bc895e 14:36:42 The build has errored. (menu-refactor - 4323303 #9237 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/332926928 14:47:21 The build has errored. (menu-refactor - 4323303 #9237 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/332926928 15:09:42 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-95-ga32820bc89 (34) 15:40:56 New branch created: pr-610 (5 commits) 13https://github.com/crawl/crawl/tree/pr-610 15:40:56 03Aidan Holm02 07[pr-610] * 0.22-a0-96-gb305a02: Add spell_failure_rate_string() 10(13 minutes ago, 2 files, 13+ 5-) 13https://github.com/crawl/crawl/commit/b305a02e1ad1 15:40:56 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-97-gcab039c: Display spell fail % for "dangerous to cast" warning (aidanh, tedric, Zenthirum) 10(5 months ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/cab039c26dca 15:40:56 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-98-gefe041f: Prevent casting a spell with 100% failure chance (aidanh) 10(5 months ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/efe041f533e3 15:40:56 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-99-g7a23d02: Colourize risk of spell failure for last casted spell (aidanh) 10(5 months ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/7a23d02d0529 15:40:56 03Aidan Holm02 07[pr-610] * 0.22-a0-100-g03cd9f6: Omit very-dangerous message on 100% spell failure 10(48 minutes ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/03cd9f617fd5 15:43:29 that's https://github.com/crawl/crawl/pull/610, rebased and cleaned up; any objections to me merging? 16:00:43 aidanh: it overall looks fine to me, as it did when johnstein originally created the pr. the only thing i'm a little worried about it is, are we taking information the player could previously get from words, and encoding it only via colour now? 16:02:49 ie, has the game just gotten more difficult for someone colourblind to play 16:05:48 I don't think so; this pr doesn't remove any information that was there previously 16:09:33 The build has errored. (menu-refactor - 74fac97 #9239 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/332938343 16:11:19 aidanh: okay, i agree with that. from looking at the screenshots in the discussion i couldn't really tell what was going on for sure, but the diff pretty clearly does not remove existing messaging 16:12:07 it looks like it doesn't add as much information as it could in cast_a_spell 16:12:25 ie, if you can see colours you know how large a miscast you risk when pressing z., but if you can't then you only know the fail% 16:15:03 is that information presented anywhere at all besides in colours? 16:15:36 well, it's also presented in the numbers that are being coloured 16:16:27 wheals: when it says "very dangerous" or "somewhat dangerous" to cast 16:17:06 aidanh: is it? i think a level 9 spell with 5% fail chance is yellow (for example), and bad stuff can happen to you, whereas a level 2 spell needs a fail rate of like 80% to be yellow 16:18:11 oh, duh 16:19:50 but i suppose you only ever get into the state i'm talking about (danger encoded in colour only) after you've acknowledge the danger presented to you for the same spell in words 16:20:03 because it appears in the re-cast menu 16:22:04 well, high-danger spells will ask for confirmation and describe the danger in words, but a yellow spell doesn't seem to do that 16:25:11 interesting, you're right. only dark-red spells do that now, not yellow or light-red 16:39:37 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-98-gdce0555: Prevent casting a spell with 100% failure chance (aidanh) 10(5 months ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/dce055514ae4 16:39:37 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-99-g3f9b9d2: Colourize risk of spell failure for last casted spell (aidanh) 10(5 months ago, 1 file, 10+ 6-) 13https://github.com/crawl/crawl/commit/3f9b9d24d5c4 16:39:37 03Aidan Holm02 07[pr-610] * 0.22-a0-100-g74eb5cb: Omit very-dangerous message on 100% spell failure 10(2 hours ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/74eb5cb01f54 16:44:12 amalloy: I think (slightly dangerous to cast at 5%) works nicely 16:44:34 (slightly dangerous to cast at 5% risk of failure), that is 16:44:49 if that's too verbose, we can drop the "to cast" 17:01:00 used escape hatch, possible to be stuck in vault 13https://crawl.develz.org/mantis/view.php?id=11367 by Le_Nerd 17:03:45 !gameinfo svalbard 17:03:47 svalbard the L12 OpAs^Ash in Lair:3 (cdo console), T:19735, defenses: 1/20/0, stats: 11/16/17 17:04:54 cute vault 17:06:29 03Aidan Holm02 07[pr-610] * 0.22-a0-96-gf6d7045: Add spell_failure_rate_string() 10(2 hours ago, 2 files, 12+ 5-) 13https://github.com/crawl/crawl/commit/f6d7045d00d8 17:06:29 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-97-gd512a29: Display spell fail % for "dangerous to cast" warning (aidanh, tedric, Zenthirum) 10(5 months ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/d512a29c3b56 17:06:29 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-98-gef56cdc: Prevent casting a spell with 100% failure chance (aidanh) 10(5 months ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/ef56cdca2d8e 17:06:29 03johnstein02 {Aidan Holm} 07[pr-610] * 0.22-a0-99-g571472f: Colourize risk of spell failure for last casted spell (aidanh) 10(5 months ago, 1 file, 10+ 6-) 13https://github.com/crawl/crawl/commit/571472f0e0c0 17:06:29 03Aidan Holm02 07[pr-610] * 0.22-a0-100-g27e3f2d: Omit very-dangerous message on 100% spell failure 10(2 hours ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/27e3f2dabfb0 17:06:29 03Aidan Holm02 07[pr-610] * 0.22-a0-101-gff99adf: Add verbal spell failure description (amalloy) 10(4 minutes ago, 1 file, 17+ 5-) 13https://github.com/crawl/crawl/commit/ff99adf40c8c 17:08:49 yay 17:09:53 aidanh: did you incorporate advil's suggestion to fix my dumb compare to "100%"? 17:09:58 also thanks 17:10:50 johnstein: I did; and np 17:16:36 -!- Snuva is now known as surr 17:26:32 03Aidan Holm02 07* 0.22-a0-96-g7cd46d3: Allow memorising from description of book on ground (Yermak, #10799) 10(44 seconds ago, 2 files, 3+ 2-) 13https://github.com/crawl/crawl/commit/7cd46d36cfbf 17:41:44 powerful tech, save turns by keeping book autopickup off :P 17:48:34 heh 17:48:52 not even sure if that'll be relevant when book goldifying is in 17:49:16 03Aidan Holm02 07[menu-refactor] * 0.22-a0-105-g411f71e: Add section dividing line (advil) 10(2 days ago, 2 files, 10+ 2-) 13https://github.com/crawl/crawl/commit/411f71ed6cc4 17:49:16 03Aidan Holm02 07[menu-refactor] * 0.22-a0-106-gdb8bd67: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/db8bd671c968 17:49:16 03Aidan Holm02 07[menu-refactor] * 0.22-a0-107-g4ccc796: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/4ccc7961ad37 17:49:25 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-105-g411f71e: Add section dividing line (advil) 10(2 days ago, 2 files, 10+ 2-) 13https://github.com/crawl/crawl/commit/411f71ed6cc4 17:49:25 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-106-gdb8bd67: Use single column for menus if there's enough space (advil) 10(2 days ago, 1 file, 17+ 6-) 13https://github.com/crawl/crawl/commit/db8bd671c968 17:49:25 03Aidan Holm02 07https://github.com/crawl/crawl/pull/702 * 0.22-a0-107-g4ccc796: Remove list_commands() redraw parameter 10(4 weeks ago, 4 files, 9+ 14-) 13https://github.com/crawl/crawl/commit/4ccc7961ad37 17:52:43 The build has errored. (master - a32820b #9241 : cut1less): https://travis-ci.org/crawl/crawl/builds/332942163 18:09:45 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-96-g7cd46d36cf (34) 18:15:13 does memorization take time? 18:15:13 advil: You have 2 messages. Use !messages to read them. 18:15:20 in the new version 18:15:24 I didn't even think to check that 18:17:21 I suppose that could count for pathological player bahaviour? never picking up books due to lost turns? 18:18:17 Unstable branch on underhound.eu updated to: 0.22-a0-96-g7cd46d36cf (34) 18:18:22 there's probably more pathological things that turncount speedrunners do 18:24:08 oh, no doubt 18:25:09 advil: did you have any lingering reservations about the serpent of hell formatting stuff in PR 670? 18:27:09 that one looks good to me, I think it addresses all the comments I had (which I guess were just in channel or something) 18:32:55 03Aidan Holm02 07* 0.22-a0-97-g2fe0497: Show Serpent of Hell flavour in ?/M list 10(6 weeks ago, 1 file, 13+ 1-) 13https://github.com/crawl/crawl/commit/2fe0497d077c 18:32:55 03Aidan Holm02 07* 0.22-a0-98-gb4b8e1f: Make Serpent of Hell name wrangling slightly less brittle 10(6 weeks ago, 3 files, 35+ 26-) 13https://github.com/crawl/crawl/commit/b4b8e1fa1e2f 18:39:42 The build passed. (pr-610 - ff99adf #9244 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/333011700 18:55:27 -!- amalloy is now known as amalloy_ 19:06:06 Agarthian (L2 GnWn) (D:1) 19:09:34 Is there no rc option that disables vikeys? 19:09:44 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-98-gb4b8e1fa1e (34) 19:10:12 no but there is a file you can include 19:10:20 yeah, ??vikeys[2 19:11:41 ??vikeys[2 19:11:42 hjklyubn[2/2]: To disable vi-keys without side-effects, look at https://www.reddit.com/r/dcss/comments/4884je/easy_vikey_removal_for_rc_files/ 19:11:58 i mean included by default 19:12:12 just add include = no_vi_command_keys.txt to your rcfile 19:12:43 (included by default = included in the crawl installation, not included in the rcfile) 19:17:14 Hmm, sounds good. Shouldn't it be include in options_guide? 19:17:21 included 19:20:47 yeah 19:20:59 it is in the default init.txt, but that tends to get overwritten 19:35:03 -!- EuphOria is now known as WalterWhite 19:44:25 -!- Dracunos_ is now known as Dracunos 20:42:13 emikaela (L14 BaAE) (Lair:4) 20:56:45 !crashlog 20:56:54 18714. emikaela, XL14 BaAE, T:26701 (milestone): https://underhound.eu/crawl/morgue/emikaela/crash-emikaela-20180125-014212.txt 20:57:50 hm, segfault in describe_spell 20:58:52 ah, the second part of 7cd46d36cfbf441fd3bea1dff3679136940085c0 fails to check if item is non_null 21:01:23 working on a fix 21:02:47 oh, my bad 21:04:18 03wheals02 07* 0.22-a0-99-g1ac4c55: Fix crash when describing memorised spells. 10(10 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/1ac4c55b9e10 21:52:42 The build has errored. (master - b4b8e1f #9248 : Aidan Holm): https://travis-ci.org/crawl/crawl/builds/333042881 22:09:47 Unstable branch on crawl.jorgrun.rocks updated to: 0.22-a0-99-g1ac4c55b9e (34) 22:42:23 if pressing "P" to start the game closes my PuTTY, what could be causing that? 22:45:07 CJR trunk only, not cjr stable nor CAO trunk. so probably something at cjr 23:02:42 yeah 23:02:51 cjr watchmode was broken in a similar way at some point too 23:32:42 New branch created: pull/704 (7 commits) 13https://github.com/crawl/crawl/pull/704 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-99-g58444dd: Reduce number and quality of items in the Abyss 10(63 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/58444dde436c 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-100-g3d900d7: Cap banishment depth by XL 10(63 minutes ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/3d900d743721 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-101-ga66ada2: Rebalance Abyss monster numbers 10(63 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a66ada22187c 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-102-g768d803: Rebalance Abyss monster pick data 10(63 minutes ago, 1 file, 120+ 119-) 13https://github.com/crawl/crawl/commit/768d8039f739 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-103-g623f5e9: Change minimum Abyssal rune depth to 4 10(63 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/623f5e9435eb 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-104-g85f7d6e: Make exit chance constant 10(63 minutes ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/85f7d6e2f0d8 23:32:43 03alexjurkiewicz02 07https://github.com/crawl/crawl/pull/704 * 0.22-a0-105-gb27a4eb: Place Abyss exits near banished players. 10(63 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/b27a4ebc5311 23:49:09 I don't see why monster banishment should remain approximately equally dangerous at all points in the game 23:50:42 we have plenty of other monster attacks that vary in difficulty over the course of the game 23:51:03 I also don't understand why abyss exits need to be placed near banished players 23:51:12 e.g. venom vs distortion are not that different in this respect 23:51:51 I also think that abyss:5 is already pretty dangerous for some characters 23:52:00 it varies a lot based on various features of the build 23:52:23 yeah abyss:5 is pretty nasty and frequently where you land when you get banished later on 23:52:41 e.g. pure casters have a harder time than melee chars in abyss in general because resting for MP can be hard 23:52:41 although I'm not sure about actual statistics there; it feels like if I get banished late game I'm going to abyss:5 23:53:12 and slow/fast movement also makes a difference 23:53:57 also, doesn't abyss already scale such that abyss:1 vs abyss:3 is a huge difference? 23:54:01 last I checked abyss:1 was pretty boring 23:55:53 yeah it's definitely a big difference in monster rates between abyss:1 and abyss:3 23:56:00 also I sort of dislike making exit chance constant with depth since that means that there is no reason to descend in abyss unless you want the rune (or to scum items faster with these changes ...) 23:56:10 though you can argue that that's a bit spoilery 23:56:20 but it's sort of an interesting decision currently 23:57:12 oh, the other thing is that I feel like the "create exits as you kill monsters" thing did a good job already of making easy abyss less tedious to escape for strong chars 23:57:28 since you can just tab things for a while instead of having to move around a lot