00:18:16 -!- amalloy is now known as amalloy_
03:11:36 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.22-a0-93-g6b88ebb (34)
12:04:57 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.22-a0-93-g6b88ebb (34)
12:26:12 <user1> hey lads
12:26:44 <user1> Hello, I've experienced an issue with loading the game via WebTiles. I have slow internet connection here and it seems like I cannot download all the stuff fast enough, and it causes require.js error (load timeout). By default it's 7 seconds as far as I know. Could you give me a link to the webtiles repository?
12:50:52 <advil> user1: not sure what you're looking for but the source repository for webtiles is here: https://github.com/crawl/crawl/tree/master/crawl-ref/source/webserver
12:51:44 <user1> yep thanks! That's what I was looking for.
12:51:44 <advil> I'm not sure if that will help, because the information sent over websockets that can't easily be preloaded is pretty high bandwidth...maybe you could manually change the timeout with greasemonkey or something?
12:55:17 <user1> No, I'm experiencing an issue with just *loading* the game, I cannot even create a character because the interface isn't loading.
12:55:17 <user1> There's only infinite "Loading" page and that's it
13:00:01 <advil> |amethyst: I just set crawl-private to discard non-member posts, rather than hold, do you see any downside to this? I guess silent failures might make it harder to use for actual members
13:03:37 -!- amalloy_ is now known as amalloy
13:17:39 -!- nino is now known as Undaunter
13:49:11 <amalloy> so, i was surprised to cast dispersal and have a monster immediately adjacent to me neither blink nor tele. i thought it was supposed to affect everything up to maximum range
13:49:35 <amalloy> could it have tried 150 times to find a space and failed every time? that seems unlikely
13:50:46 <amalloy> also, interestingly, it turns out that dispersal is in a very rare category of spells, in that it can affect monsters that aren't in LOS: it uses a radius iterator based on your current position that doesn't care if there are walls in the way, even opaque walls
13:54:55 <advil> doesn't it check MR?
13:55:16 <geekosaur> MR resist makes it a blink, iirc
13:55:16 <elliptic> it's supposed to blink the monsters that resist
13:55:20 <advil> ah
13:55:21 <advil> right
13:55:28 <advil> hm, I wonder if they could tele to the same position they left
13:55:41 <advil> no idea whether there would be messaging for that
13:55:43 <amalloy> !source monster_blink
13:55:44 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/teleport.cc#L168
13:55:54 <elliptic> tele to the same position sounds plausible yeah
13:56:06 <amalloy> yeah, i think you're right
13:56:13 <amalloy> blink to the same position is possible and doesn't message
13:56:19 <elliptic> btw I completely missed dispersal getting a radius boost
13:56:21 <amalloy> (FR: should that really be possible?)
13:56:30 <elliptic> I assume that affecting monsters on the other side of walls is just a bug
13:56:35 <amalloy> elliptic: agree
13:56:42 <elliptic> since that picking monsters out of vaults sounds bad
13:57:13 <elliptic> I should actually try using dispersal sometime instead of just skipping to disjunction
13:58:30 <elliptic> amalloy: I thought blink tried to avoid nearby squares
13:58:35 <elliptic> unlike teleport, which doesn't
13:58:55 <elliptic> oh, monster blink is different I guess
13:58:58 <geekosaur> ??your surroundings flicker
13:58:58 <Sequell> your surroundings flicker[1/1]: You teleported to exactly the same spot.
14:00:00 <elliptic> amalloy: though it loks like _random_monster_nearby_habitable_space should avoid blink to the same position?
14:00:34 <Cheibriados> Abilities can't be used while starving, and this is not messaged anywhere 13https://crawl.develz.org/mantis/view.php?id=11363 by Stonar
14:00:34 <elliptic> unless the 150 tries fails
14:01:05 <elliptic> I guess 150 tries failing there isn't that unlikely if there are just a few allowed targets
14:01:29 <elliptic> maybe _random_monster_nearby_habitable_space should do something smarter
14:02:39 <elliptic> e.g. if there are only 5 legal squares for the monster to blink to then it has a 1% chance of failing to find any of them currently, no real reason why that needs to be a thing
14:03:29 <elliptic> (41% chance of failing to find a unique legal square)
14:08:57 <advil> heh so can you disperse stuff out of a sealed runed vault by accident?
14:09:51 <advil> that's some serious anti-tech
14:33:44 <advil> the answer to that question seems to be yes, btw
14:33:59 <advil> well, I tested it with a transporter vault, but same deal
14:37:18 -!- CaptainFruitcake is now known as CanOfWorms
14:58:08 <amalloy> elliptic: i don't see the case in _random_monster_nearby_habitable_space that prevents same-square blinks. which one is it?
14:58:48 <elliptic> at the top
14:58:48 <elliptic> if (delta.origin())
14:58:53 <elliptic> same-square blink can happen but it means the 150 tries failed
14:59:02 <amalloy> i see
14:59:04 <elliptic> which is actually plausible given how that function works
14:59:18 <amalloy> right, i was thinking that delta there was the target square, but it's not
15:02:06 <amalloy> elliptic: i wonder i would even have noticed this problem except that i happened to be a Barachi in a very enclosed area
15:02:23 <elliptic> I mean, being barachi doesn't matter, no?
15:02:29 <amalloy> LOS when playing as barachi is substantially larger, 17^2 instead of 15^2
15:02:34 <elliptic> so?
15:02:37 <amalloy> so there are more invalid spots to try
15:02:38 <amalloy> right?
15:02:42 <elliptic> it isn't iterating over LOS
15:02:50 <amalloy> oh, you're right. oh well
15:03:18 <amalloy> FR: it should be. that random2 for delta is trying to select a random area in LOS, but isn't adjusted for barachi larger LOS
15:03:28 <amalloy> or, well, it should be fixed in some other way probably
15:03:31 <elliptic> no it isn't, it is currently radius 6
15:04:05 <elliptic> it's just that blink is supposed to be 2-6 squares away
15:04:05 <amalloy> hm, also true. weird. why 2-6?
15:04:13 <elliptic> not sure but iirc player blink is something similar
15:04:26 <elliptic> obviously making it 2-7 would be a buff and blink doesn't really need that
15:05:09 <elliptic> really this should just be fixed by making it not give up after 150 tries, but instead just iterate over all the squares to choose a random destination the slow way
15:06:08 <elliptic> (e.g. by iterating over everything once to count the number of legal destinations, then choose a number randomly, then iterate again to find that number
15:06:10 <elliptic> )
15:07:32 <amalloy> elliptic: well we already have reservoir sampling to avoid the re-iteration
15:07:38 <elliptic> or that, yes
15:08:30 <amalloy> it'd be kinda nice to have that function anyway, if we could figure out some way to expose it: "show me the list of squares a random blink might take me (or a specified monster) to"
15:08:43 <amalloy> or rather than showing the player, maybe some other way to make use of that
16:15:49 <Yermak> Was double-confirmation bug for cursed jewellery fixed? I cannot find nor appropriate bug report, neither appropriate commit fixing it.
16:20:52 <amalloy> Yermak: you mean like stuff that is both cursed and *Contam?
16:20:59 <Yermak> no
16:21:20 <Yermak> When you put cursed ring game asks you twice if you want to do this.
16:21:22 <amalloy> oh, for like swapping i guess
16:22:58 <Yermak> Yes, actually when you swap.
16:25:52 <Yermak> Bug report: new splash screen with Tengu is inaccurate: Tengu can't wear helmets!
16:34:12 <elliptic> is double confirmation when there are two reasons for confirmation actually a bug?
16:34:33 <elliptic> could see it either way
16:36:33 <geekosaur> if there are two reasons, the messaging should make that clear
16:36:43 <geekosaur> last time I hit this, it was two identical prompts
16:46:07 <Yermak> We need double confirmation for attacking allies under good gods, since there are indeed two reasons.
16:47:38 <Yermak> As to cursed jewellery it's simply a prompt before you remove a ring to make spot for the cursed one and after you remove it.
17:20:44 <Lasty> !tell gammafunk I have a critical update for you: I actually won this tournament. As evidence, I submit the following: 1) my winrate was 27.27%. 2) I played for 27% of my waking hours during the tournament.
17:20:45 <Sequell> Lasty: OK, I'll let gammafunk know.
17:23:57 <elliptic> time to compute how much lasty sleeps
17:24:01 <elliptic> !gamesby lasty t
17:24:02 <Sequell> lasty (t) has played 44 games, between 2018-01-05 20:08:44 and 2018-01-21 17:48:46, won 12 (27.3%), high score 12774339, total score 41593549, total turns 1634440, play-time/day 4:44:02, total time 3d+8:28:44.
17:25:11 <elliptic> about 6.5 hours/day apparently!
17:39:25 <gammafunk> !tell Lasty Sorry, the way you actually win is by having a 100% winrate and streak in this tournament with the streak continued from the previous tournament and with the players ranked in decreasing order by cumulative time played.
17:39:26 <Sequell> gammafunk: OK, I'll let lasty know.
17:39:40 <gammafunk> !tell Lasty If you look at the numbers, you'll see that I actually won the tournament
17:39:40 <Sequell> gammafunk: OK, I'll let lasty know.
17:50:05 <hellmonk> where is the tourney post gammafunk
17:51:16 <Lasty> gammafunk: sounds like you aren't playing enough crawl
17:51:16 <Sequell> Lasty: You have 2 messages. Use !messages to read them.
17:51:41 <gammafunk> It's quality, not quantity, Lasty
17:51:55 <Lasty> is it, tho?
17:52:11 <Lasty> I thought the tourney motto was "quantity first"
17:59:04 <gammafunk> I can't believe you'd tarnish our brand by publicly saying that
18:06:16 <elliptic> _A bat comes into view.
18:06:16 <elliptic> _The bat barely misses you.
18:06:16 <elliptic> _You miss the bat. The bat completely misses you.
18:06:16 <elliptic> _You miss the bat. Your bite misses the bat. The bat misses you.
18:06:16 <elliptic> You completely miss the bat.
18:06:18 <elliptic> _You kill the bat!
18:06:24 <elliptic> very confused here
18:08:37 <Lasty> elliptic: could it have been horns, spines or another passive retribution, combined with channel mutes? Could it have been an ally? I know I usually mute ally attacks.
18:09:50 <elliptic> no passives or allies (this is a L1 felid)
18:10:21 <elliptic> maybe an aux attack hit and the message got muted for some reason
18:11:13 <elliptic> though I don't think my rcfile adds any mutes
18:12:34 <Lasty> in that case I'm stumped
18:13:32 <Lasty> The only felid aux is offhand punch, right? If so, then I wouldn't expect that to fire without an attack message to go with...
18:13:41 <elliptic> you get a bite
18:13:54 <Lasty> still, same deal. Horns would be another story.
18:14:03 <elliptic> which does produce a message when it misses as above
18:14:42 <elliptic> yeah I didn't have horns at the time unless it was somehow buggily left over from previously casting appendage
18:14:42 <Lasty> yep, that would only make sense if it was muted for some reason
18:14:49 <elliptic> horns doesn't give retribution on non-mi anyway
18:15:12 <Lasty> Oh, I didn't know that.
18:15:13 <Lasty> that reminds me: I got a report that Dith shadow mimic for ranged weapons keeps brand -- at a minimum, freezing brand. I haven't had a chance to investigate yet.
18:17:39 <wheals> i was going to say that was reported and fixed a while ago but it turns out it was only reported https://crawl.develz.org/mantis/view.php?id=9959
18:18:29 <gammafunk> elliptic: btw not sure if you have any tournament observations, let me know, since I'm getting through this writeup
18:18:34 <Lasty> ah, eah
18:18:40 <gammafunk> and I as of yet have no exciting *mystery* like last time
18:18:47 <Lasty> I'll try to look into it if i get a chance
18:19:11 <elliptic> gammafunk: there's this mystery of how someone can win 36 games in 16 days...
18:19:26 <gammafunk> is that how many he won?
18:19:29 <gammafunk> !won yermak t
18:19:30 <Sequell> yermak (t) has won 36 times in 71 games (50.70%): 4xDDFi 1xBaWz 1xCeWn 1xDDIE 1xDECj 1xDgEE 1xDrFE 1xDsMo 1xFeAE 1xFoAr 1xGhVM 1xGnAM 1xGnCK 1xGnNe 1xGrFi 1xHOBe 1xHOFi 1xHOTm 1xHaHu 1xHuAr 1xKoAs 1xMfAK 1xMiGl 1xMuSu 1xNaNe 1xOgSk 1xOpFi 1xSpEn 1xSpWr 1xTeEn 1xTrFi 1xVSCj 1xVpSu
18:19:32 <wheals> elliptic just posted a mystery!
18:20:00 <gammafunk> I will mention the mak's playtime probably, but in the paragraph where I sing the praises of 1st place player
18:20:00 <Lasty> well, he spent most of his waking hours on it
18:20:06 <gammafunk> no Lasty
18:20:21 <gammafunk> your 'waking hours played' meme is not a thing
18:20:33 <gammafunk> it's not a very dank meme
18:20:39 <Lasty> too late. It has brain sjhare.
18:20:48 <Lasty> s/j//
18:21:06 <gammafunk> fr: glowing orange brain ability called "Brain Share"
18:21:14 <gammafunk> does some kind of confusion attack like dream sheep
18:21:53 <gammafunk> maybe the mystery is how buth neil and wheals won a lot
18:21:57 <gammafunk> *both
18:22:13 <Lasty> time to nerf something
18:22:20 <gammafunk> !won neil t
18:22:21 <Sequell> neil (t) has won once in 68 games (1.47%): 1xMiBe
18:22:29 <gammafunk> 1.47% is uncomfortably high
18:22:34 <gammafunk> !won wheals t
18:22:35 <Sequell> wheals (t) has won twice in 33 games (6.06%): 1xDEWr 1xGnSu
18:22:43 <gammafunk> and that's just unacceptably high
18:22:49 <gammafunk> !won wheals t0.20
18:22:50 <Sequell> wheals (t0.20) has not won in 17 games.
18:22:53 <gammafunk> !won wheals t0.19
18:22:54 <Sequell> wheals (t0.19) has not won in 9 games.
18:22:57 <gammafunk> !won wheals t0.18
18:22:58 <Sequell> wheals (t0.18) has won once in 49 games (2.04%): 1xOpSk
18:24:14 <Lasty> y'all are threatening our plausible deniability on devs aiming the game at experts
18:24:39 <gammafunk> Lasty: time for a new amulet of harm
18:24:56 <gammafunk> maybe a ring of harm and armour egos of harm
18:25:18 <hellmonk> the shadow mimic thing is pretty great, pls dont nerferoni my ranged characters of dith
18:25:18 <Lasty> I already proposed two!!
18:25:33 <Lasty> hellmonk:  hellcrawl release tourney when??
18:25:39 <elliptic> gammafunk: how about the mystery of how I thought playing FeTm was a good idea?
18:25:50 <hellmonk> I might do a csdc style "tournament" in a few weeks
18:25:50 <gammafunk> that is a good mystery
18:26:17 <Lasty> elliptic: Normally the analysis only needs Fe--
18:26:31 <elliptic> I mean, conjuration-y Fe are less painful
18:26:55 <hellmonk> fetm of zin or riot
18:27:07 <Lasty> What about fe--^qaz?
18:27:26 <hellmonk> the joke is that zin bans forms
18:28:27 <Lasty> it's not a real joke until it gets explaiend
18:29:14 <gammafunk> I know worms is a huge proponent of the sp^qaz play
18:29:20 <gammafunk> he would probably support fe^qaz
18:29:33 <Lasty> haha
18:30:02 <hellmonk> fe^qaz sounds like a good play on the player sanity zone
18:30:04 <Lasty> You could do Fe^Hep and never engage any monster from anywhere but edge of LOS. You wouldn't even have to attack.
18:32:06 <Lasty> It's like those species proposals where the char has a head and a body on separate tiles
18:33:01 <hellmonk> arent you glad that i convinced pf to allow hep worship on cats, so you can play this very interesting build
18:33:04 <gammafunk> you need the power of the orb to reunite your head and body so you can be whole again
18:33:43 <gammafunk> Was that some kind of lore thing?
18:33:55 <gammafunk> I sort of vaguely recall this limitation....but not really
18:34:15 <Lasty> hellmonk: this is all because I forgot to put lamb's blood above my door, isn't it?
18:34:33 <hellmonk> here was my thread about it: https://crawl.develz.org/tavern/viewtopic.php?f=17&t=20025&p=270740&hilit=hep%2A+cat#p270740
18:35:16 <hellmonk> I don't remember why exactly, something about ancestors and cats having multiple lives
18:36:41 <Lasty> !source mitm
18:36:42 <Sequell> Can't find mitm.
18:37:44 <hellmonk> oh wow i didn't realize that thread spawned the flavor town post
18:37:45 <Lasty> Is mitm some sort of global monster item array?
18:38:02 <hellmonk> dang and i only got 6 thanks for the op
18:40:32 <advil> #define mitm   env.item
18:40:37 <advil> which is pretty dumb
18:40:50 <Lasty> ha
18:41:10 <advil> there's probably some history where it was something else?
18:43:25 <Lasty> !source get_mitm_slot
18:43:26 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/items.cc#L504
18:43:58 <advil> or not, it's been that way since the "Initial revision" commit
18:44:54 <advil> hm, menv, mitm, grd, mgrd, igrd are all defines for env members
18:45:14 <advil> people were sure worried about character counts back in the old days
18:45:52 <Lasty> So for the weapon we get your weapon, reserve a mitm slot with a generic item in it, and then assign the base type and sub_type to the item in that slot. Seems good so far -- no brand duplication. I wonder if this is related to branded ammo? Maybe launcher brands effectively are being passed to the ammo . . .
18:46:31 <Lasty> Back in the 1990s, when you only have a couple bits of memory to rub together, file sizes were really important
18:46:33 <Lasty> :p
18:47:08 <advil> that mantis issue that wheals linked was plain bolts with an arbalest of freezing
18:47:14 <Lasty> agreed
18:47:28 <Lasty> I'm just not seeing how that would happen . . .
18:47:41 <hellmonk> can confirm that it also happens with punk btw
18:47:45 <Lasty> interesting
18:48:02 <gammafunk> hellmonk: ho boy, that thread
18:48:09 <gammafunk> I forget if I ever read it
18:48:14 <hellmonk> yeah i kind of forgot how off the rails it went
18:48:19 <Lasty> Could ranged-attack.cc be checking your launcher brand instead of shadow's launcher brand? Seems unlikely.
18:48:20 <hellmonk> bc i made a remove felid joke
18:48:31 <Lasty> Joke?
18:48:35 <advil> there's a comment from ebering in that issue that blames beam.cc
18:48:47 <advil> "bolts only track the mid of the source, and the shadow monster has MID_PLAYER"
18:49:01 <hellmonk> imo you should just keep it and let dith mimic melee weapon brand as well
18:49:03 <advil> "when the bolt hits bolt::agent looks up the agent from the mid, finding the player as the agent, and sets up a ranged attack with attacker equal to the player. Oops."
18:49:08 <Lasty> oh, lol
18:49:10 <hellmonk> dith is already kind of weak imo
18:49:18 <Lasty> there ya go
18:50:00 <Lasty> hellmonk: Dith's a solid choice for most characters, IMO. Not top-tier, but good.
18:51:21 <hellmonk> I respectfully disagree, I think dith is bottom half for most character types
18:51:49 <Lasty> advil: that sounds harder to fix. Would have to think about how to handle MID . . .
18:52:17 <Lasty> hellmonk: there's only one perfectly objective way to settle this.
18:52:21 <Lasty> DrKe's rankings!
18:52:22 <advil> yeah, it's not an obvious fix
18:52:30 <advil> could make a fake monster too
18:52:33 <hellmonk> ??tier
18:52:33 <Sequell> tier ~ tiers[1/2]: For DrKe's Species/Gods tier lists see {drke[2]}. For Minmay's Gods/Species/Backgrounds/Other stuff tier lists see https://crawl.develz.org/tavern/viewtopic.php?f=17&t=23861
18:52:39 <hellmonk> ??drke[2
18:52:39 <Sequell> drke[2/4]: Races: http://i.imgur.com/WOgxAUN.png Gods: http://i.imgur.com/tWji7gA.png (tiles) / http://pastebin.com/UxAwrsSb (text)
18:52:46 <Lasty> I thought the whole point of the shadow was to be a fake monster
18:53:03 <advil> yeah, but there doesn't seem to actually be a fake monster?
18:53:12 <advil> I haven't really looked at dith code so maybe I'm off base
18:53:39 <Lasty> take a look at !source shadow_monster
18:53:43 <advil> but if there were a monster there would be something other than MID_PLAYER
18:53:44 <hellmonk> C early, A later. Seems about right to me.
18:53:53 <Lasty> hellmonk: yeah, that sounds right
18:54:04 <Lasty> see,objectively resolved our debate
18:54:27 <advil> ah
18:54:42 <advil> I guess there is a fake monster that has MID_PLAYER
18:55:42 <advil> it's probably for action tracking and so on
18:55:59 <advil> and blame
18:56:41 <Lasty> yeah
18:56:44 <Lasty> and XP
18:57:04 <Lasty> and piety
18:57:04 <Lasty> I assume
18:57:06 <Lasty> Gotta head out for a bit, will try to check back on this later.
19:17:00 <gammafunk> no one asked for my tier list
19:17:49 <hellmonk> where is the tournament writeup, gammafunk
19:46:53 <advil> !tell Lasty this might mostly fix the dith thing: http://dpaste.com/1YPK50P, though I'm not sure about unexpected consequences and I bet there's some cases where it doesn't work (reflections, since the shadow monster is gone by then)
19:46:54 <Sequell> advil: OK, I'll let lasty know.
19:47:09 <advil> also it's a brutal nerf damage-wise
19:48:59 <advil> ??advil_todo[2
19:48:59 <Sequell> advil todo[2/2]: what is up with the U2-U3 stairs in http://crawl.beRotato.org/crawl/saves/advil-crawl-0.21-180118-1647.tar.bz2
19:52:08 <wheals> already some good bugs with ranged weapons and non-existent agents involving ball lightning
19:52:32 <advil> I think ranged shadow attacks were also using the weapon's plusses
19:52:47 <wheals> the diff you posted probably would have very bad effects for fedhas players standing on top of plants :P
19:52:55 <advil> oh huh, good point
19:53:25 <advil> yeah, I wasn't quite sure what sort of other cases might instantiate that if
19:53:46 <hellmonk> is it finally time for the legendary fedhas reform
19:54:22 <advil> that would be an awesome bug though, if it used the plant as the agent for any beam attacks, I'm almost sorry I didn't outright commit it
20:29:14 <advil> hellmonk: hellcrawl already has goldified spells right?
20:29:24 <hellmonk> yes
20:29:28 <hellmonk> using doesnt's patch
20:29:36 <advil> did you add any other stuff on top of that patch, like searching?
20:29:41 <hellmonk> no
20:29:48 <hellmonk> I will be stealing that from you though :)
20:29:50 <advil> heh
20:30:09 <advil> wheals put up a revised version of that patch that adds some stuff, if you haven't seen it
20:30:15 <hellmonk> yeah, I saw
20:30:24 <hellmonk> search is pretty essential if you want it in real DCSS, the list gets too long otherwise
20:30:32 <advil> were there any complaints about it beyond the large spell list stuff?
20:30:39 <hellmonk> not to my knowledge
20:31:25 <hellmonk> I imagine that you will get complaints about trog losing burn book
20:31:49 <advil> probably
20:32:22 <advil> we are ruining fun
20:32:22 <advil> probably it'll make dpeg sad too
20:32:24 <advil> iirc he was a defender of burn books
20:35:51 -!- InfoWars is now known as deadbeatdad
20:36:29 <hellmonk> there is not really a good way around it though
20:37:15 <advil> yeah
20:37:39 <advil> hm, I guess you could make a trog ability that creates a flame cloud by consuming spells in your library
20:38:29 <advil> picks 3-5 randomly or something
20:38:44 <advil> that'd still create a weird dynamic with books you encounter multiple times
20:38:48 <hellmonk> yeah
20:39:05 <hellmonk> you would keep duplicate books around and go back to put spells in your library again
20:39:10 <advil> right
20:39:12 <hellmonk> so you could burn them
20:39:23 <advil> unless they became permanently unmemorizable
20:40:09 <advil> which would make thematic sense anyways, you're sacrificing your ability to ever comprehend the spell or something
20:45:32 <wheals> Trug
20:47:06 <advil> wheals: just left a note on your PR
20:48:21 <advil> thanks for working on that PR, it's been something I've wanted to do for ages
20:48:31 <advil> I can work on the search/sort ideas I had in case you're not excited to do that
20:48:58 <wheals> yeah it felt like the biggest pain point coming back to crawl
20:49:08 <wheals> which is a compliment, so many things have been improved
20:50:50 <wheals> i'm not sure how useful sorting by school really is, mostly because multi-school spells exist, and unless you show them twice, you'd have trouble finding the spell you want just based on one of its schools
20:51:05 <wheals> what i was thinking is that search would search through both the name and the school list
20:51:13 <wheals> so searching for fire would get you all fire magic spells
20:51:25 <advil> yeah, doing school via search would work
20:52:05 <advil> but I had in mind showing them multiple times
20:53:32 <wheals> might be a bit more work but that could be done too
20:54:46 <wheals> really i don't see much point in having the "N spells unmemorisable" note at all, especially now
20:54:48 -!- amalloy is now known as amalloy_
20:55:03 <wheals> though spells unmemorisable because of Ru and because of your species should be consistent at any rate
20:55:29 <advil> well, I think they should be viewable somewhere from that interface
20:56:32 <advil> I don't know if that note is very important, but before they could be viewed via the book
20:57:38 <wheals> i was thinking that if they're not memorisable, crawl might as well pretend they don't exist in that game
20:57:51 <wheals> but thinking some more it is good to have some way to let the player find out why they can't
20:58:00 <advil> yeah, that's what I had in mind
20:59:05 <wheals> showing up as special entries on the Describe tab could work
20:59:33 <advil> it's possible also that a Ru char just shouldn't be able to add banned spells after the sacrifice? but they still could have some from before
21:00:09 -!- mikee___ is now known as mikee_
21:02:37 <wheals> i just noticed the notes about ?/ being a bit inconsistent, this commit: (from the ui-overhaul branch) should make it easier to fix that
21:02:41 <wheals> %git 8f54d33cfb33d81c17972ba990bc5263756dd428
21:02:41 <Cheibriados> 07Aidan Holm02 * 0.22-a0-146-g8f54d33: Use improved spell description UI for ?/S 10(3 weeks ago, 3 files, 50+ 50-) 13https://github.com/crawl/crawl/commit/8f54d33cfb33
21:02:51 <advil> yes
21:03:03 <advil> I think there's probably a bunch of menu stuff in that branch that would make life easier for this menu
21:03:36 <wheals> yeah
21:03:36 <advil> oh he literally fixed that inconsistency I guess
21:04:07 <wheals> no he didn't i think, it's just that the inconsistency is controlled by a flag to that function
21:04:07 <advil> ah
21:04:58 <wheals> there definitely are some conflicts between the two branches, even beyond the ones that git detects: 17924d71054 is unnecessary, for one, and i'm using set_title which he removes, for another
21:05:26 <advil> hmm
21:10:17 <Huene`> is there any documentation on setting up go-sequell?
21:17:25 -!- amalloy_ is now known as amalloy
21:19:00 <wheals> !tell aidanh how far is ui-overhaul from merging, do you think? adding search might involve more digging around in the guts of Menu and i don't want to make even more conflicts
21:19:01 <Sequell> wheals: OK, I'll let aidanh know.
21:38:30 <Huene`> just out of curiosity are there any screenshots or concept art for the new ui?
21:42:21 <advil> I think it's mostly an overhaul on the code/behavior/consistency side of things, though there are places where it looks different
21:43:45 <Huene`> ahh ok sounds good
21:54:32 <aidanh> wheals: the menu.cc-related changes are relatively independent of everything else and could probably be merged soon
21:54:33 <Sequell> aidanh: You have 1 message. Use !messages to read it.
21:57:46 <wheals> yeah, i did notice there were some things that looked like they could go right into master
21:58:18 <wheals> the removed books commit as well
21:58:46 <wheals> (26c1748c)
21:59:38 <aidanh> right, that one rebases cleanly
22:01:10 <aidanh> Huene`: most of it is as advil said; getting the functionality there is most of the battle, and the only visual change I added was the popup UI stuff
22:10:06 <Huene`> okay thanks I was curious if it was more maintainence or visual, sounds good
23:38:22 <Huene`> this may be a bug or it may not be but when your hunger gets low enough to being able to eat chunks, and you get the green border around a corpse, then walk out of range of a corpse, the green border persists even if you satisfy your hunger, I figure it is probably not intended since its visibilty when in range is based on character hunger level not anything to do with the corpse