00:30:41 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-618-g6cbd37f (34) 01:19:28 Unstable branch on crawl.develz.org updated to: 0.21-a0-618-g6cbd37f (34) 01:59:40 Windows builds of master branch on crawl.develz.org updated to: 0.21-a0-618-g6cbd37f 02:52:01 Monster database of master branch on crawl.develz.org updated to: 0.21-a0-618-g6cbd37f 03:20:58 4tharraofdagon (L16 HOGl) ERROR in 'dbg-scan.cc' at line 508: mid cache bogosity: no monster for 1086 (Depths:2) 03:22:10 Unstable branch on crawl.beRotato.org updated to: 0.21-a0-618-g6cbd37f (34) 04:32:27 -!- amalloy is now known as amalloy_ 04:33:47 -!- amalloy_ is now known as amalloy 05:36:27 -!- amalloy is now known as amalloy_ 06:34:50 03gammafunk02 07* 0.21-a0-619-ged4c157: Shorten some enum names 10(3 hours ago, 13 files, 30+ 30-) 13https://github.com/crawl/crawl/commit/ed4c157c3671 06:34:50 03gammafunk02 07* 0.21-a0-620-g2783f27: A status tile for zombie hands constriction (Ultraviolent4) 10(3 hours ago, 6 files, 9+ 1-) 13https://github.com/crawl/crawl/commit/2783f2761fbf 06:34:50 03gammafunk02 07* 0.21-a0-621-gc60411f: Fix monster constriction data not getting marshalled 10(26 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c60411f26562 06:49:36 Unstable branch on crawl.beRotato.org updated to: 0.21-a0-621-gc60411f (34) 07:01:29 Unstable branch on crawl.akrasiac.org updated to: 0.21-a0-621-gc60411f (34) 07:09:35 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-621-gc60411f265 (34) 07:13:08 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-621-gc60411f (34) 08:17:26 ShadedKnight (L20 GrNe) (Elf:3) 08:19:36 ShadedKnight (L20 GrNe) (Elf:3) 08:40:53 !source ShoppingListMenu::draw_title 08:40:54 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/shopping.cc#L2173 08:49:15 !crashlog 08:49:21 !crash 08:49:30 !cmd crash 08:49:31 Command: !crash => !crashlog 08:49:32 18255. ShadedKnight, XL20 GrNe, T:41128 (milestone): http://crawl.berotato.org/crawl/morgue/ShadedKnight/crash-ShadedKnight-20171223-131929.txt 08:49:32 18255. ShadedKnight, XL20 GrNe, T:41128 (milestone): http://crawl.berotato.org/crawl/morgue/ShadedKnight/crash-ShadedKnight-20171223-131929.txt 09:06:54 ShadedKnight (L20 GrNe) (Elf:3) 09:14:00 !crash 09:14:01 18256. ShadedKnight, XL20 GrNe, T:41109 (milestone): http://crawl.berotato.org/crawl/morgue/ShadedKnight/crash-ShadedKnight-20171223-140647.txt 09:29:58 |amethyst: this crash is interesting, it seems to be happening when earth elemental summons from de elementalist die under vile clutch 09:30:51 but the crash seems to be happening when we increment the iterator over that actor.constricting map 10:07:30 -!- ProzacElf_ is now known as ProzacElf 10:41:48 -!- DarkBattle is now known as AngelaSmythe 10:45:19 Dynast (L12 GrNe) (IceCv) 10:45:51 !crash 10:45:52 18257. Dynast, XL12 GrNe, T:9775 (milestone): http://crawl.berotato.org/crawl/morgue/Dynast/crash-Dynast-20171223-154512.txt 11:23:20 lot of crashes in the last day, but they seem unrelated? 11:23:56 a bunch are constriction-related I guess 11:24:16 maybe BVC is too vile 11:25:59 advil: yeah these crashes from Dynast and ShadedKnight are the same 11:26:12 the iterator around actor.cc:890 I think is acting oddly 11:26:18 which I don't know why 11:26:49 I'll be away for some hours, but if you or anyone can see/implement a fix, by all means 11:27:03 happens when they use bvc on summons and (I think) the summoner dies 11:27:08 but I can't recreate 11:30:15 looks like defender is null, but the crash is happening before the relevant ASSERT, so it's not (just) that 11:31:04 890 seems wrong btw, not sure where that is coming from 11:31:10 well, I know it's there in the dump 11:31:57 !source actor.cc:632 11:31:58 https://github.com/crawl/crawl/blob/master/crawl-ref/source/actor.cc#L632 11:32:20 or maybe I'm looking at the wrong file 11:32:38 uh duh I didn't pull after the BVC changes 11:32:47 !source actor.cc:890 11:32:48 https://github.com/crawl/crawl/blob/master/crawl-ref/source/actor.cc#L890 11:33:34 ok, yeah, I see the problem 11:34:10 unrelated...any reason why there's no .gitignore in the root directory of the repo? 11:51:55 well, ok, I see the problem but not the cause, and I can't replicate it 11:52:50 the problem is that on 885 defender can be null, but I can't figure out why it's not taken care of by clear_invalid_constrictions 11:53:20 (side note, BVC seems fun) 12:00:31 <|amethyst> aidanh: are you around? 12:00:42 |amethyst: yep, what's up 12:14:53 actually, I'm not even sure that nullptr is the cause of the crash (though it's visible in the crashdump and shouldn't be possible) 12:16:41 hm, maybe depending on order, if constriction_damage_defender kills a summoner, which invalidates a summon later in the list 12:16:53 i haven't replicated that, though 12:18:39 well, I have to go do some errands & I won't figure this out before I leave, but that's my best guess of the problem 12:18:39 <|amethyst> aidanh: sorry, have to go for a moment, but I'll be back later today 12:18:46 sure, no worries 12:25:41 ShadedKnight (L24 GrNe) (Depths:1) 12:26:57 ShadedKnight (L24 GrNe) (Depths:1) 12:29:13 !crashlog 12:29:13 18259. ShadedKnight, XL24 GrNe, T:56130 (milestone): http://crawl.berotato.org/crawl/morgue/ShadedKnight/crash-ShadedKnight-20171223-172651.txt 13:36:37 advil: you did the fontbuf_line_reader code, right? I'm having a very weird issue where backspace edits the buffer, but the font buf seems to stay the same 13:38:40 Gorglomux (L20 FoSu) (Vaults:2) 13:41:03 -!- Bammboobies is now known as Bammboo 14:05:26 -!- amalloy_ is now known as amalloy 14:19:31 aidanh: yeah, that's me 14:19:50 are you attempting to use it for something new, or is this in the skill menu? 14:19:57 something new 14:20:14 I have to say that I didn't really test it very carefully outside that one use 14:20:39 it seems to be using the CRT emulator for rendering, even though I cannot see how that could happen from reading the code 14:22:54 it depends on what font_buf you give it 14:23:10 in the skill menu it gets the buf from the menu items 14:24:20 it's a stack allocated font buf 14:30:19 ah! found it 14:30:29 !source cio.cc:773 14:30:30 https://github.com/crawl/crawl/blob/master/crawl-ref/source/cio.cc#L773 14:32:03 hmm 14:32:41 all that cursorto stuff was overelaborate, I probably should have just reprinted the whole string when there's a change 14:33:09 well I guess the cursorto part is necessary, the print_segment stuff 14:34:09 yeah, especially since ncurses double-buffers output and minimizes the number of edits 14:34:20 at least, I think that's the case 14:34:54 probably that putwch is a noop in the skill menu 14:36:05 so I didn't notice it 14:36:13 but in principle all printing was supposed to be done with print_segment after that change 14:36:29 well yeah; the skill menu uses EDIT_MODE_OVERWRITE, which uses a different function 14:36:58 ...that also explains why, when I tried using overwrite mode, nothing appeared at all: the font buffer was never being rendered 14:37:08 it was just the CRT buffer the whole time 14:38:32 well, I'll try to get my code working with overwrite mode (should be identical with an empty initial buffer?) and then I might tackle this one next 14:47:19 03advil02 07* 0.21-a0-622-g55ff828: Attempt to fix the BVC constriction bug 10(4 minutes ago, 1 file, 10+ 11-) 13https://github.com/crawl/crawl/commit/55ff828305e0 14:47:19 03advil02 07* 0.21-a0-623-g80d1a53: A couple instances of 0 -> nullptr 10(41 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/80d1a5309b45 14:49:14 I can try to fix the insert mode issue if you aren't going to immediately 14:51:39 ok, thanks 14:56:59 gammafunk: 55ff828 tries to fix the constriction issue, but I still haven't replicated it 15:09:36 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-623-g80d1a5309b (34) 15:10:19 03advil02 07* 0.21-a0-624-g16f8e2c: Fix fontbuf_line_reader in insert mode (aidanh) 10(4 minutes ago, 1 file, 2+ 11-) 13https://github.com/crawl/crawl/commit/16f8e2cdda51 15:12:27 I noticed that the cursor in regular linebuf in tiles looks terrible 15:12:41 I wonder if it was always like that or if I broke it at some point 15:15:00 oh, that was quick 15:15:58 fairly sure it's always been like that 15:18:34 yeah, it wasn't a complicated fix (and I could test it just by changing the mode for the skill menu editing) 15:21:02 03Aidan Holm02 07https://github.com/crawl/crawl/pull/683 * 0.21-a0-616-g02f89bf: Fix crash in player doll editor (GuideCritic, #11333) 10(24 hours ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/02f89bf01d98 15:47:27 03JoelMarler02 {GitHub} 07https://github.com/crawl/crawl/pull/671 * 0.21-a0-580-g95e19d0: Update items.txt 10(49 seconds ago, 1 file, 10+ 10-) 13https://github.com/crawl/crawl/commit/95e19d0fcf19 15:48:07 TittyCrusher (L22 VpWn) (Depths:2) 16:09:34 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-624-g16f8e2cdda (34) 16:19:10 03JoelMarler02 {GitHub} 07https://github.com/crawl/crawl/pull/671 * 0.21-a0-581-g9ba9259: Update items.txt 10(4 minutes ago, 1 file, 37+ 37-) 13https://github.com/crawl/crawl/commit/9ba9259fbe87 16:26:15 <07IAB8D3I> The build has errored. (master - 16f8e2c #9090 : advil): https://travis-ci.org/crawl/crawl/builds/320756432 16:27:30 i'm not really sure what to do with that PR. a few of the suggestions are cute, a few of them are bland, and many i don't like because they suggest mechanics that don't exist (eg, would i lose HP from reading this "bitingly cold to the touch" book?) 16:38:00 03advil02 07[spooky_vaults] * 0.21-a0-594-g396020d: Add a description line for mirrored player ghosts 10(25 hours ago, 5 files, 9+ 3-) 13https://github.com/crawl/crawl/commit/396020de5c93 16:38:00 03advil02 07[spooky_vaults] * 0.21-a0-595-g438d06d: Add a permanent store for some fallback ghosts 10(18 minutes ago, 3 files, 197+ 99-) 13https://github.com/crawl/crawl/commit/438d06d6f038 16:48:37 after thinking about mutation roulette for a while, I think my current favorite is something like: new kind of mut potion that does 1-2 random mutations, and expire some reasonable # of turns after the player first notices them (a la blood) 16:49:24 basically chunks but generated as regular items, with a lower (and more even) frequency 16:59:14 Lightli (L18 GrNe) (Elf:1) 17:15:27 !crashlog 17:15:29 18263. Lightli, XL18 GrNe, T:33053 (milestone): http://crawl.berotato.org/crawl/morgue/Lightli/crash-Lightli-20171223-215906.txt 17:15:46 casting zombie hands 17:16:06 yeah 17:16:39 it may or may not be fixed in a later commit, but I wanted gammafunk to have a chance to look at the fix before I rebuild 17:21:05 also, zombie hands feels unfair against anything completely stationary 17:21:10 like oklob plants or statues 17:21:21 since you can cast it just once and then sit around and wait for them to die 17:26:54 -!- eb_ is now known as eb 17:52:12 Lightli (L20 GrNe) (Vaults:2) 17:52:22 dang 17:54:14 i thought it has a timer as well as the usual constriction-escape mechanism 18:18:30 Unstable branch on underhound.eu updated to: 0.21-a0-624-g16f8e2cdda (34) 20:23:55 Lightli (L27 GrNe) (Elf:3) 21:03:00 amalloy: there is but it's pretty long, at 60 spellpower it's 14 turns on an ice statue 21:06:42 03advil02 07* 0.21-a0-625-g1119ec1: Add constriction information to xv in wizmode 10(38 minutes ago, 4 files, 23+ 14-) 13https://github.com/crawl/crawl/commit/1119ec1544bf 21:44:54 after having won a Ne with the spell, I have come to the conclusion that zombie hands is awesome and fun 22:00:12 03advil02 07[spooky_vaults] * 0.21-a0-596-gf37da98: Don't use permastore when rewriting on level veto 10(57 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f37da98ef843 22:09:35 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-625-g1119ec1544 (34) 23:17:40 advil: yeah, that fix is similar to what I was going to do, but that comment confused me as to whether a problem could happen 23:18:04 we do need to probably ASSERT when that defender is null (I removed one when moving this code to a method)