00:11:47 -!- mibe_ is now known as mibe 00:50:57 -!- atrocityvoyeur is now known as adnol 00:51:04 -!- adnol is now known as Adnol 00:51:11 -!- Adnol is now known as Adnoll 02:17:19 New branch created: pull/668 (1 commit) 13https://github.com/crawl/crawl/pull/668 02:17:19 03dplusplus02 07https://github.com/crawl/crawl/pull/668 * 0.21-a0-539-gd5204b6: fix explore_discoveries::cleaned_feature_description() 10(15 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/d5204b6ad7a7 02:18:47 wow, a dplusplus commit! 02:47:17 Monster database of master branch on crawl.develz.org updated to: 0.21-a0-538-gd16b88a 05:25:03 -!- amalloy is now known as amalloy_ 05:26:16 -!- amalloy_ is now known as amalloy 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-539-g8cbf18b: Remove menu.set_maxpagesize interface 10(8 weeks ago, 7 files, 3+ 38-) 13https://github.com/crawl/crawl/commit/8cbf18b64e62 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-540-g34ed980: Assert that menus have a valid selection flag 10(8 weeks ago, 2 files, 19+ 4-) 13https://github.com/crawl/crawl/commit/34ed98001cfa 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-541-g4905ffb: Explicitly set MF_SINGLESELECT on describe menu 10(8 weeks ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/4905ffb89492 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-542-g2e730e8: Remove unused menu.f_drawitem hook 10(8 weeks ago, 2 files, 2+ 7-) 13https://github.com/crawl/crawl/commit/2e730e865efd 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-543-gefab3ad: Remove column_compoer set_pagesize() 10(8 weeks ago, 4 files, 2+ 20-) 13https://github.com/crawl/crawl/commit/efab3ad63136 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-544-ge85d38a: Refactor Menu scrolling into MenuDisplay 10(8 weeks ago, 7 files, 407+ 318-) 13https://github.com/crawl/crawl/commit/e85d38a80ea9 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-545-gc144eb7: Remove limit on lookup-help results length 10(8 weeks ago, 1 file, 8+ 17-) 13https://github.com/crawl/crawl/commit/c144eb7546b1 05:45:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-546-g650028e: 2-col tile menus: wrap horizontally and support line scrolling 10(3 days ago, 4 files, 259+ 180-) 13https://github.com/crawl/crawl/commit/650028e34538 05:57:28 -!- amalloy is now known as amalloy_ 06:11:41 New branch created: pull/669 (1 commit) 13https://github.com/crawl/crawl/pull/669 06:11:41 03Aidan Holm02 07https://github.com/crawl/crawl/pull/669 * 0.21-a0-539-gcb05294: Don't vary tiles for fake monsters 10(4 minutes ago, 2 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/cb05294dfbc8 06:13:51 advil: yup, two-column menus scroll quite nicely now, although I'm not too happy with the state of the code 07:50:39 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-546-g4d5786c: 2-col tile menus: wrap horizontally and support line scrolling 10(3 days ago, 4 files, 252+ 177-) 13https://github.com/crawl/crawl/commit/4d5786c1ce96 08:11:29 03Aidan Holm02 07https://github.com/crawl/crawl/pull/669 * 0.21-a0-539-gc96533f: Don't vary tiles for fake monsters 10(2 hours ago, 2 files, 5+ 4-) 13https://github.com/crawl/crawl/commit/c96533fe1151 09:40:01 03Aidan Holm02 07https://github.com/crawl/crawl/pull/669 * 0.21-a0-539-g3c92d1a: Don't vary tiles for fake monsters 10(4 hours ago, 2 files, 9+ 7-) 13https://github.com/crawl/crawl/commit/3c92d1a63c49 10:06:04 03Aidan Holm02 07https://github.com/crawl/crawl/pull/669 * 0.21-a0-540-g3e04059: Choose correct tile for headless vines/starspawn tentacles 10(5 minutes ago, 1 file, 10+ 2-) 13https://github.com/crawl/crawl/commit/3e04059cc5c1 10:42:31 New branch created: pull/670 (1 commit) 13https://github.com/crawl/crawl/pull/670 10:42:32 03Aidan Holm02 07https://github.com/crawl/crawl/pull/670 * 0.21-a0-539-gc2d77d5: Show Serpent of Hell flavour in ?/M list 10(6 minutes ago, 1 file, 13+ 1-) 13https://github.com/crawl/crawl/commit/c2d77d5f1de7 10:51:00 03advil02 07* 0.21-a0-539-gfc69bf2: Push items out of the way when a door is closed, if possible 10(12 days ago, 3 files, 140+ 14-) 13https://github.com/crawl/crawl/commit/fc69bf2b6f40 10:51:00 03advil02 07* 0.21-a0-540-ga3e6914: Refactor imprison to use new push code 10(18 hours ago, 3 files, 38+ 26-) 13https://github.com/crawl/crawl/commit/a3e691492902 10:51:00 03advil02 07* 0.21-a0-541-g7555bd9: Use new push code for abyss generation 10(18 hours ago, 1 file, 3+ 9-) 13https://github.com/crawl/crawl/commit/7555bd92a4ae 10:51:00 03advil02 07* 0.21-a0-542-g50984c1: Use refactored push code for door sealing 10(17 hours ago, 2 files, 71+ 165-) 13https://github.com/crawl/crawl/commit/50984c1eebc8 10:51:00 03advil02 07* 0.21-a0-543-gcc02c76: Docstrings, commenting, formatting 10(17 minutes ago, 2 files, 42+ 7-) 13https://github.com/crawl/crawl/commit/cc02c76d49db 10:51:00 03advil02 07* 0.21-a0-544-ga7bb147: Fix a fallthrough 10(12 days ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/a7bb1477d21e 10:51:00 03advil02 07* 0.21-a0-545-g6746751: Remove an apport special case by using visible_igrd 10(5 minutes ago, 1 file, 3+ 11-) 13https://github.com/crawl/crawl/commit/6746751bbcad 10:52:30 I'm excited to see what interesting bugs this leads to 10:52:58 03advil02 07* 0.21-a0-546-g09e1869: Unbrace 10(65 seconds ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/09e18692a932 10:54:37 !tell hellmonk I ended up going with a different approach to closing doors on items (pushes them out of the way), but if you stick with the hellcrawl version you may want to glance at the various tweaks in the (now unused) door_items branch 10:54:38 advil: OK, I'll let hellmonk know. 11:02:33 03alexjurkiewicz02 {advil} 07* 0.21-a0-547-gaa2292d: Remove Zin's capstone ability 10(8 months ago, 4 files, 2+ 23-) 13https://github.com/crawl/crawl/commit/aa2292de1b5a 11:02:33 03alexjurkiewicz02 {advil} 07* 0.21-a0-548-g7e31929: Move all god gifting logic into separate functions 10(8 months ago, 1 file, 422+ 389-) 13https://github.com/crawl/crawl/commit/7e319298a1b7 11:02:33 03alexjurkiewicz02 {advil} 07* 0.21-a0-549-gfd779ed: Rework gift messaging 10(4 months ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/fd779ed5cdf8 11:02:33 03advil02 07* 0.21-a0-550-ge0a6212: Change Zin's mutation protection to be 100% at ****** (160) piety. 10(8 weeks ago, 2 files, 2+ 3-) 13https://github.com/crawl/crawl/commit/e0a6212a90e9 11:02:33 03advil02 07* 0.21-a0-551-g3327e8e: Let !mutation for Zin at ****** (160) just delete mutations 10(8 weeks ago, 6 files, 31+ 7-) 13https://github.com/crawl/crawl/commit/3327e8e9b092 11:03:43 huh, weird, missing line in the commit message for that last one 11:07:51 03Aidan Holm02 07https://github.com/crawl/crawl/pull/632 * 0.21-a0-546-g531d82d: 2-col tile menus: wrap horizontally and support line scrolling 10(3 days ago, 4 files, 253+ 177-) 13https://github.com/crawl/crawl/commit/531d82d65b46 11:08:05 so many PRs :) 11:09:37 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-546-g09e18692a9 (34) 11:10:10 that'll keep you busy for a while :) 11:12:38 hmm for that SoH PR I'd rather do something like: change serpent_of_hell_flavour to return a branch_type, and then use the branch_type to get either the long or short string where it's needed 11:12:51 that approach would be less brittle 11:14:38 sure thing 11:16:42 also that would make it easier for serpent_of_hell_flavour to have an error return rather than using default that way (e.g. NUM_BRANCHES) 11:17:00 or it could just have an ASSERT 11:17:12 equivelant to your die call 11:17:23 *equivalent 11:19:47 I don't think there'd be any reason why it'd be called on non-soh monster_types, so I'll go with an assert 11:24:42 the capitalization isn't going to cause any issues with monster db lookups? e.g. the internal name seems to be "serpent of hell dis", but branch shortname is "Dis" 11:26:47 hm 11:27:29 lowercase it? 11:29:10 I might keep serpent_of_hell_flavour() the same, and add serpent_of_hell_branch() 11:29:24 or implement the former in terms of the latter 11:30:05 so as to avoid doing the same lowercase(branch.shortname) all over the place 11:30:45 that seems reasonable 11:38:55 heh first hot take reviews are in, "fuck zin i guess" 11:54:18 03MarvinPA02 07* 0.21-a0-552-g593960d: Fix messaging for Zin mutation potion cleansing 10(22 seconds ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/593960dda5fe 11:55:43 oh, thanks 11:56:19 i assume it was meant to be 6* not 5*, right? since that matches the full passive immunity 11:56:23 -!- MarvinPA_ is now known as MarvinPA 11:56:59 yes, you're right 11:57:18 that's what I get for not going over it carefully again before merging :-/ 11:57:27 I should make sure I didn't have an unpushed commit on my laptop 11:59:36 03Aidan Holm02 07https://github.com/crawl/crawl/pull/670 * 0.21-a0-540-gdc60f57: Make Serpent of Hell name wrangling slightly less brittle 10(5 minutes ago, 3 files, 35+ 26-) 13https://github.com/crawl/crawl/commit/dc60f5727287 12:00:17 when i first glanced at it i assumed it was just because piety breakpoint stuff is a nightmare that randomly swaps between being 0-indexed and not 12:00:37 but i think that's been substantially improved now! 12:00:42 also it might be stored in multiple places 12:01:57 !source god-passive.cc:161 12:01:58 https://github.com/crawl/crawl/blob/master/crawl-ref/source/god-passive.cc#L161 12:02:07 that might be the one that actually generates the message? 12:02:11 <|amethyst> no 12:02:21 <|amethyst> afaik god-passive messages aren't actually used 12:03:05 <|amethyst> there isn't even a function to actually do the various substitutions 12:03:52 <|amethyst> god_passive::display fortunately isn't used, because it would produce the wrong message 12:04:23 heh yeah, properly using those has been a wishlist thing for a long time 12:05:05 <|amethyst> and when it happens, the things that are there can be removed from god_powers 12:05:31 <|amethyst> with the latter listing just active abilities 12:05:40 <|amethyst> ABIL_s that is 12:06:34 <|amethyst> One problem is that there are a lot of passives that are currently unannounced 12:06:50 <|amethyst> so it could lead to a lot of piety gain message spam for some gods (e.g. Jiyva) 12:07:24 <|amethyst> well, on-join for Jiyva 12:07:34 <|amethyst> and Zin 12:07:40 <|amethyst> and Ash 12:09:36 Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-552-g593960dda5 (34) 12:12:58 yeah, no idea what I had in mind with that messaging, I guess I just didn't test it, but the current version is definitely right 12:24:41 Unstable branch on crawl.akrasiac.org updated to: 0.21-a0-552-g593960d (34) 13:08:25 -!- cojito_ is now known as cojito 14:24:48 -!- mibe_ is now known as mibe 15:19:48 At some point ghost moths gave no shadow to step onto, because they are invisible. Now it is possible. When was it changed? 15:23:32 -!- KamiKatze_ is now known as KamiKatze 15:24:18 <|amethyst> %git eeda2d7a 15:24:18 07MarvinPA02 * 0.19-a0-103-geeda2d7: Let Shadow Step target invisible monsters 10(1 year, 7 months ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/eeda2d7a93d5 15:25:30 <|amethyst> "being able to see invisible also lets you see their invisible shadows" 15:59:26 Wow, I didn't notice it for more than one year! 15:59:29 Thanks! 16:12:14 -!- Dracunos_ is now known as Dracunos 17:10:46 -!- amalloy_ is now known as amalloy 18:17:34 Unstable branch on underhound.eu updated to: 0.21-a0-552-g593960dda5 (34) 20:47:10 -!- Evablue_ is now known as Evablue