00:20:48 -!- Telnaior_ is now known as Telnaior
00:21:57 -!- Bammboobies is now known as Bammboo
00:28:50 <johnstein> how do I get rid of the #include mon-attitude-type.h in mon-clone.h here: https://github.com/jmbjr/crawl/commits/11171-fixup-new
00:34:36 <johnstein> this is probably a simple c++ question
00:35:01 <gammafunk> that link didn't seem to wrk
00:35:08 <gammafunk> top commit?
00:37:33 <geekosaur> !source SAME_ATTITUDE
00:37:35 <Sequell> Can't find SAME_ATTITUDE.
00:40:52 <geekosaur> so, you can't as long as you have that overload for clone_mons that requires mon_att
00:41:07 <johnstein> doh
00:42:46 <johnstein> so it's the overload that's the issue? i.e. that's why for mons_summon_illusion_from() that uses spell_type, I don't need to include spell-type.h?
00:42:51 <johnstein> because it's not overloaded?
00:43:59 <geekosaur> because that specific overload has a parameter whose type is defined in that header
00:44:12 <geekosaur> and that parameter is the only difference from the other implementation
00:44:52 <geekosaur> (mon_attitude_type mon_att)
00:45:41 <johnstein> I'm still not quite understanding why for mons_summon_illusion_from I don't need an #include "spell-type.h" (though I'm sure that you've probably clearly explained it above. I'm re-reading)
00:46:07 <geekosaur> if you are going to use a mon_attitude_type there, the compiler has to know what it is. since this is in both mon-clone.cc and mon-clone.h (so callers know there are two different variants, one requiring a mon_attitude_type), you need its declaration
00:46:29 <geekosaur> oh. probably because it's in AppHdr.h
00:46:47 <geekosaur> which, iirc, we are trying to move away from because it was created to support precompiled headers
00:46:51 <johnstein> ok. maybe that was the missing tech I didn't know about
00:46:58 <johnstein> !source apphdr.h
00:47:01 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/AppHdr.h
00:47:33 <geekosaur> hm, actually I don't see it in there
00:48:21 <johnstein> same with monster and actor. I couldn't figure out why those didn't have includes either.
00:49:17 <geekosaur> oh, it is in there. indirectly via externs.h
00:49:59 <johnstein> !source externs.h
00:49:59 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/externs.h
00:53:06 <geekosaur> there is a way to run the preprocessor
00:53:09 <geekosaur> er
00:53:41 <geekosaur> there is a way to run the preprocessor such that you can see the preprocessed files with the definitions in place and where they came from (via #line directives)
00:56:29 <johnstein> I'll have to do some research on that. beyond my current level
00:57:25 <geekosaur> I'm trying to verify it's still in there...
00:58:38 <geekosaur> g++ -E -dDI
00:58:47 <geekosaur> is apparently how you do it with recent gcc
01:00:25 <geekosaur> if you do that, it will not actually compile, it will instead output preprocessed source but with #include and #define markers intact so you can see where a macro's definition came from
01:00:55 <geekosaur> or where a specific include file came from when it's from multiple levels of #include
01:27:59 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/608 * 0.21-a0-245-gbe153a1: Allow setting attitude of cloned monsters 10(22 hours ago, 3 files, 10+ 2-) 13https://github.com/crawl/crawl/commit/be153a1906e2
01:27:59 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/608 * 0.21-a0-246-g208b5fa: Simplify handling a cloned monster's attitude. 10(21 hours ago, 2 files, 4+ 18-) 13https://github.com/crawl/crawl/commit/208b5fa4be5d
01:27:59 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/608 * 0.21-a0-247-g8696f9d: Remove an unused default parameter 10(21 hours ago, 2 files, 11+ 15-) 13https://github.com/crawl/crawl/commit/8696f9d1f6b3
01:27:59 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/608 * 0.21-a0-248-g3694079: Add a docstring 10(3 hours ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/3694079f030e
01:27:59 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/608 * 0.21-a0-249-g84788c9: Overload a function to handle monster_attitude_type 10(3 hours ago, 3 files, 17+ 5-) 13https://github.com/crawl/crawl/commit/84788c920bec
01:47:51 -!- amalloy_ is now known as amalloy
01:55:33 <Gretell> Unstable branch on crawl.develz.org updated to: 0.21-a0-215-g0631661 (34)
02:44:22 <alexjurkiewicz> w!vault minitemple
02:44:41 <alexjurkiewicz> !tell hellmonk please reduce the weight of minitemple
02:44:42 <Sequell> alexjurkiewicz: OK, I'll let hellmonk know.
03:00:48 <alexjurkiewicz> @??frances
03:00:49 <Gretell> Frances (08@) | Spd: 10 | HD: 14 | HP: 111-158 | AC/EV: 6/8 | Dam: 29 | natural, 10weapons, 10items, 10doors, evil, spellcaster, see invisible | Res: 06magic(100) | XP: 2251 | Sp: throw icicle (3d23), iron shot (3d26), sum.demon, haste | Sz: Medium | Int: human.
03:12:18 <Rotatell> Unstable branch on crawl.beRotato.org updated to: 0.21-a0-260-g9b2435e (34)
03:20:14 -!- amalloy is now known as amalloy_
03:25:13 -!- amalloy_ is now known as amalloy
04:16:40 -!- amalloy is now known as amalloy_
10:05:59 -!- Mayoi is now known as erkin
10:10:35 <advil> https://www.reddit.com/r/dcss/comments/6yj33i/dcss_tiles_out_of_frame/
10:10:48 <advil> tiles window size still broken on windows for some apparently :-(
10:17:05 <advil> %git b3e98cc5569973af76d871fdfdbd6a2b93bd11c3
10:17:05 <Cheibriados> 07advil02 * 0.21-a0-86-gb3e98cc: Ignore negative (relative) window sizes in fullscreen mode 10(2 months ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/b3e98cc55699
10:24:28 <|amethyst> was that in 0.20.1?
10:24:29 <Sequell> |amethyst: You have 3 messages. Use !messages to read them.
10:24:40 <|amethyst> sorry, no time to check !messages now, will do later
10:25:01 <advil> at least one of them said 0.21
10:25:17 <|amethyst> oh, I hadn't seen that comment
10:25:39 <|amethyst> !tell |amethyst check your !messages
10:25:40 <Sequell> |amethyst: OK, I'll let |amethyst know.
10:26:48 <advil> though there isn't a "0.21 release" so maybe they are confused, I just posted a followup
10:40:31 <Cheibriados> 03advil02 07* 0.21-a0-261-gbd1db8b: Give Ds extra piety for sacrificing experience 10(3 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/bd1db8bb768d
10:56:05 <Cheibriados> 03advil02 07* 0.21-a0-262-g12b8181: Fix a fallthrough that seems harmless but unintentional 10(2 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/12b8181cbade
10:59:11 <advil> not sure if I missed something about why that fallthrough was there, but intentional ones are usually commented in crawlcode so I'm assuming it wasn't
11:09:10 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-262-g12b8181 (34)
12:03:12 -!- amalloy_ is now known as amalloy
12:42:38 -!- amalloy is now known as amalloy_
13:04:45 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.21-a0-262-g12b8181 (34)
13:06:54 -!- amalloy_ is now known as amalloy
13:21:22 -!- Enthusiasm_ is now known as Enthusiasm
13:32:47 <Cheibriados> 03Bernhard M. Wiedemann02 {amalloy} 07* 0.21-a0-263-gf26e180: Sort input file list (#609) 10(20 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f26e180203db
14:09:09 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-263-gf26e180 (34)
14:17:19 <johnstein> !tell |amethyst thoughts on how to best handle the include mon-attitude-type.h in mon-clone.h for: https://github.com/crawl/crawl/pull/608 ?
14:17:20 <Sequell> johnstein: OK, I'll let |amethyst know.
14:23:07 <|amethyst> johnstein:  I think it should be included from the header
14:23:08 <Sequell> |amethyst: You have 5 messages. Use !messages to read them.
14:23:16 <|amethyst> just posted a comment saying that on GH too
14:24:40 <johnstein> good timing! I'd just refreshed the PR before pinging you here. ty
14:25:04 <|amethyst> well
14:25:13 <|amethyst> I posted the comment after seeing your question in channel :)
14:36:56 <johnstein> hah
14:52:25 <|amethyst> !tell |amethyst check your messages again, but ignore this one
14:52:26 <Sequell> |amethyst: OK, I'll let |amethyst know.
14:53:24 <gammafunk> !tell |amethyst Pay attention to this one though, it's important
14:53:25 <Sequell> gammafunk: OK, I'll let |amethyst know.
15:51:27 <amalloy> fyi johnstein i don't plan to merge that mon-clone PR myself since i don't really know enough about cloning etc
15:56:54 <johnstein> amalloy: np. I'm no expert either. I did a bunch of testing to try to cover enough cases but not sure if I got them all
15:58:10 <johnstein> same for the other one with the fixed summon checks. I think I've got it tested ok. just not sure if the part about being able to detect a hidden trap is ok or not.
16:11:14 <geekosaur> if we relied on people knowing the code, crawl would have no commits >.>
17:34:12 <johnstein> 1learn crawl-dev
17:35:12 <johnstein> ??crawl-dev
17:35:12 <Sequell> ##crawl-dev[1/1]: The IRC channel for Crawl development and design. Many but not all devs frequent the channel. To join, "/join ##crawl-dev". Logs are at http://s-z.org/crawl-dev/ .
18:04:50 <Lantell> Unstable branch on underhound.eu updated to: 0.21-a0-263-gf26e180 (34)
20:01:54 <advil> hmm, I wonder if losing levels with Ru sac xp *should* temporarily suppress mutations gained in those levels
20:02:18 <advil> right now it doesn't.  [actually, right now it crashes, which is what I'm trying to fix.]
20:03:23 -!- ProzacElf_ is now known as ProzacElf
20:04:54 <amalloy> advil: it does? when i do something like &rdemon &x &x &]inexp on a new character, i don't see a crash. what do you have to do to repro?
20:05:14 <amalloy> oh, hm
20:05:16 <advil> specifically, if you do A it crashes, because the Ds muts don't validate
20:05:23 <amalloy> &] doesn't actually decrease my XL
20:06:37 <advil> and the mutation validation code is only called there...actually it may only be called on debug builds
20:06:57 <advil> yeah ok it's only on debug builds, so not as important
20:07:24 <amalloy> okay, confirmed that it does crash as you said if i take an actual ru sac as opposed to just giving myself the mut
20:08:14 <advil> fixing the validation code is easy enough
20:08:29 <advil> I just didn't think of that case when I originally wrote it
20:10:29 <advil> well, it's easy enough except for wizmode change xl scenarios
20:20:13 -!- amalloy is now known as amalloy_
20:20:56 <alexjurkiewicz> advil: nice pickup re: ds ru sac xp
20:25:38 <Cheibriados> 03advil02 07* 0.21-a0-264-g3e31e41: Take sacrifice experience into account when validating Ds mutations 10(6 minutes ago, 1 file, 8+ 1-) 13https://github.com/crawl/crawl/commit/3e31e410cd9e
20:27:32 <advil> alexjurkiewicz: thanks, though there was not perfect agreement I think
20:45:14 <gammafunk> !lg * map~~mask
20:45:16 <Sequell> 4. tls9540 the Bringer of Light (L27 MiFi of The Shining One), slain by a golden dragon on Zot:3 (chequers_guarded_unrand_mask_of_the_dragon) on 2017-09-04 02:20:57, with 1304340 points after 74994 turns and 3:18:50.
20:45:16 <gammafunk> !lg * map~~mask -2
20:45:18 <Sequell> 3/4. acarzz the Champion of Chaos (L26 DsGl of Makhleb), mangled by a golden dragon on Zot:2 (chequers_guarded_unrand_mask_of_the_dragon) on 2017-09-02 05:10:26, with 587687 points after 55158 turns and 3:24:33.
20:45:21 <gammafunk> !lg * map~~mask s=src
20:45:23 <Sequell> 4 games for * (map~~mask): 2x cwz, cbro, cpo
20:45:34 <gammafunk> alexjurkiewicz: two cwz kills looks like
20:45:41 -!- amalloy_ is now known as amalloy
20:45:56 <gammafunk> can't footv, but I can guess how it goes down
20:49:52 <amalloy> !vault chequers_guarded_unrand_mask_of_the_dragon
20:49:53 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/des/variable/mini_monsters.des#L6409
20:52:24 <gammafunk> it's been years, but we still don't have the definitely amalloy murder vault
20:52:32 <gammafunk> *definitive
20:52:43 <gammafunk> maybe definitely amalloy also works
20:56:35 <alexjurkiewicz> nice
20:56:42 <alexjurkiewicz> cwz has no ttyrecs?
20:57:05 <alexjurkiewicz> !log * map~~mask
20:57:05 <Sequell> 4. tls9540, XL27 MiFi, T:74994: https://webzook.net/soup/morgue/trunk/tls9540/morgue-tls9540-20170904-022057.txt
20:57:05 <alexjurkiewicz> !log * map~~mask -2
20:57:05 <Sequell> 3/4. acarzz, XL26 DsGl, T:55158: https://webzook.net/soup/morgue/trunk/acarzz/morgue-acarzz-20170902-051026.txt
20:58:30 <gammafunk> they do have ttyrecs
20:58:33 <gammafunk> but they're not linked with footv
20:58:45 <gammafunk> webzook.net:82 has them
20:58:47 <alexjurkiewicz> nice. I feel good about those kills
20:59:12 <alexjurkiewicz> wish you could see how many times people get the randart
20:59:38 <gammafunk> only if someone makes a thing to parse morgues maybe
21:00:01 <alexjurkiewicz> because there's a note for unrands now, right?
21:00:17 <alexjurkiewicz> it wouldn't be perfect, because the randart might have generated earlier, but that's probably negligible
21:00:27 <gammafunk> well I was thinking the vault listing
21:00:33 <gammafunk> not sure if there is a note or not
21:09:11 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-264-g3e31e41 (34)
21:13:10 <alexjurkiewicz> good idea
22:24:35 -!- bcadren is now known as Blocadren
22:24:38 -!- Blocadren is now known as Bcadren
22:36:17 -!- Mattshark_ is now known as Mattshark
23:59:43 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-264-g3e31e41 (34)